From: "Michal Nazarewicz" <mina86@mina86.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmalloc: remove #ifdef in function body
Date: Wed, 21 Dec 2011 07:24:05 +0100 [thread overview]
Message-ID: <op.v6ttefog3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <20111221062232.GE28505@barrios-laptop.redhat.com>
On Wed, 21 Dec 2011 07:22:32 +0100, Minchan Kim <minchan@kernel.org> wrote:
> On Wed, Dec 21, 2011 at 07:13:49AM +0100, Michal Nazarewicz wrote:
>> On Wed, 21 Dec 2011 06:17:59 +0100, Minchan Kim <minchan@kernel.org> wrote:
>> >We don't like function body which include #ifdef.
>> >If we can, define null function to go out compile time.
>> >It's trivial, no functional change.
>>
>> It actually adds “flush_tlb_kenel_range()” call to the function so there
>> is functional change.
>
> Sorry. I can't understand your point.
> Why does it add flush_tlb_kernel_range in case of !CONFIG_DEBUG_PAGEALLOC?
Uh, sorry, I've totally misread the function. Never mind my comment.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-12-21 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 5:17 Minchan Kim
2011-12-21 5:31 ` Joe Perches
2011-12-21 5:45 ` Minchan Kim
2011-12-21 5:58 ` Joe Perches
2011-12-21 6:07 ` Minchan Kim
2011-12-21 6:27 ` Joe Perches
2011-12-21 6:21 ` Michal Nazarewicz
2011-12-21 6:32 ` Joe Perches
2011-12-21 6:47 ` Michal Nazarewicz
2011-12-21 15:21 ` Ted Ts'o
2011-12-21 6:13 ` Michal Nazarewicz
2011-12-21 6:22 ` Minchan Kim
2011-12-21 6:24 ` Michal Nazarewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v6ttefog3l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox