From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx195.postini.com [74.125.245.195]) by kanga.kvack.org (Postfix) with SMTP id 77ABF6B0194 for ; Mon, 12 Dec 2011 10:46:14 -0500 (EST) Received: by bkbzt12 with SMTP id zt12so7040826bkb.14 for ; Mon, 12 Dec 2011 07:46:12 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 04/11] mm: compaction: export some of the functions References: <1321634598-16859-1-git-send-email-m.szyprowski@samsung.com> <1321634598-16859-5-git-send-email-m.szyprowski@samsung.com> <20111212142906.GE3277@csn.ul.ie> <20111212154015.GI3277@csn.ul.ie> Date: Mon, 12 Dec 2011 16:46:10 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Michal Nazarewicz" Message-ID: In-Reply-To: <20111212154015.GI3277@csn.ul.ie> Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, Kyungmin Park , Russell King , Andrew Morton , KAMEZAWA Hiroyuki , Ankita Garg , Daniel Walker , Arnd Bergmann , Jesse Barker , Jonathan Corbet , Shariq Hasnain , Chunsang Jeong , Dave Hansen >> On Mon, 12 Dec 2011 15:29:07 +0100, Mel Gorman wrote:= >>> Overall, this patch implies that CMA is always compiled in. > On Mon, Dec 12, 2011 at 03:41:04PM +0100, Michal Nazarewicz wrote: >> Not really. But yes, it produces some bloat when neither CMA nor >> compaction are compiled. I assume that linker will be able to deal >> with that (since the functions are not EXPORT_SYMBOL'ed). On Mon, 12 Dec 2011 16:40:15 +0100, Mel Gorman wrote: > The bloat exists either way. I don't believe the linker strips it out = so > overall it would make more sense to depend on compaction to keep the > vmstat counters for debugging reasons if nothing else. It's not > something I feel very strongly about though. KK, I'll do that then. -- = Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz= (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org