From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D881C28B28 for ; Wed, 12 Mar 2025 04:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F8C2280002; Wed, 12 Mar 2025 00:21:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A885280001; Wed, 12 Mar 2025 00:21:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED8AB280002; Wed, 12 Mar 2025 00:20:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D1139280001 for ; Wed, 12 Mar 2025 00:20:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9DC55C0A11 for ; Wed, 12 Mar 2025 04:21:00 +0000 (UTC) X-FDA: 83211598680.30.F42A84C Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf09.hostedemail.com (Postfix) with ESMTP id C2D9C140005 for ; Wed, 12 Mar 2025 04:20:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XEwUyIMD; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741753259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDVW5paXvofauniZLpqYiGX3ZDGr6k7FCnVsxIQYmDI=; b=ZjWqZFUJt0Qntb6LOJd8NaQYM1royfl88eWyAppkUjL9VtD4ufU/jBoa3Wpm/sP7SpYMsT 5hRUCH7MA5Dp5Sdf2WfMsq2MciQBne3q1ViMtreFgxzrd0KXv7YWm80bAnUVNrukKenUQM mOnb5TAwKotn0Wd8Q1lQ/4QTB6IyybA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XEwUyIMD; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741753259; a=rsa-sha256; cv=none; b=FkPajdO/aN6IspMN2vYHlhknNffKZRX2PWNEVcvk7UIYglA1eqcGBJe9iqz8r4wno2pN11 Kk/are/U+LnvD7zvjVhj1tv/xjM/yycOD/LBpMkTM1zNgSj3hxuEg6ejSuA/Pwr/ZnA18c X2p+fLAWWEEYRWftEwVCqmfYDelaCVk= Date: Tue, 11 Mar 2025 21:20:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741753256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hDVW5paXvofauniZLpqYiGX3ZDGr6k7FCnVsxIQYmDI=; b=XEwUyIMDWawoG5pdblTStI90HquR/rc4o2V0eGwG0KkonQod7nUPqLyItShqetqdquXcQh /yNdl28wY6m6OKfmu15G0wheicZLL/xdftO1L8QhhRgbxANOz3ePyhU5QqTYAF2M9I/7F7 NOKfvHIcb5lldr/IXRtr3hANfUg4T5w= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Nico Pache Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, jerrin.shaji-george@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, mst@redhat.com, david@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, jgross@suse.com, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, nphamcs@gmail.com, yosry.ahmed@linux.dev, kanchana.p.sridhar@intel.com, alexander.atanasov@virtuozzo.com Subject: Re: [RFC 1/5] meminfo: add a per node counter for balloon drivers Message-ID: References: <20250312000700.184573-1-npache@redhat.com> <20250312000700.184573-2-npache@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312000700.184573-2-npache@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C2D9C140005 X-Stat-Signature: bqegk9hzcjma8w636brdk4c38f5bnume X-HE-Tag: 1741753258-778954 X-HE-Meta: U2FsdGVkX19HBO7TYWp2Bv0rBV+t0MPonRd5o/rvbTs3ll28ldHGjAOGJXAeM8No9EhVly/Af7u1MVZXTTVTaO70p3aVl7uECbaQD/RkWGSECLnrA8AMWrmhgz5Loyi542tgXC0g584CCu3dwgiz/pDcY71MSTLZqT35JVY8O0vPDXat/81imbZfkTi9P+/wShkxit6rjWuhHW3E2yovBTysLzp5N394kId8xlX78EKaGhiRbMBSUUG3V18P1KMj7yZr6VKGR5BhxVn1J3QNdHB9bg3bwJ9n5aXFxuIWBvEvb3tkEcfoOMTtm4RI4GotTuOZrtrS69XIJnJ8hF/PNWp5HKWGg9PW0Dz/HK/eDPFebq1LNPxIzR+aIuwl5XhGdAeSTfdzmhsZvIBFLX8ae5wHpSWx43E9n4gmzDe2Upl9FA+G5+tsn+BAsPuAR/8GEPayc6F89qA54NoEjFcNGJsM0Jsh7eaeUgVz7ZDAaYdRMSJoVR6VQpXgdkZYRQXC9mI9jmKvChetHcCtPIFySzDPoKiJpdwWRpZ4ImXOKRGl7/+JnNfQb+t9aKnWycMgF6x5lYo0vq38OygvJjWQceNsYT1WVGocbcgIzWEo5Lv4molOJCk0U2wG/KEz7u4eBHtbcEIKrE3ixyCafVZJkK7pOadccA3x7Rrx54n6r6WJB647aNqwpcQJBOQQcea5KZW+MpgS1ekhp5UaIqtd0GkNX8zpiqacSaA/sd7leIXAVObuIGs2rfkxuoEO7hfM0C1NB/dSAjvAeYLai+1qpyp7BfPzrkMKn2aEZGZv4ZhPPfIMfRGfloIIjruHlo2/UIYwmGXRn2UP2IYNVLlO0xhF2y/Ns4t9zD9UwpZ7iWCjYj4+VM11Kpf12HPSTUncVIU/LMq4kLigW88STubDPAHBodYXLMQA/x7DuwFEomguZRTIvxxfLpJcwDMBKcCE0mi5Fc3SuP+Bf+GjYXv CwcCsrbr P3ODBGDOcBNFEs0I9h2di8LLtk2dvKTfu/9+19FXZnVkiopeK9MTvDU7MFMw3MjegGo1JEnEvSIc7lL0DeNiJVq3TuFmuRGdZfaPiGDIK6iAhh8bHZC3hw8dz96+80bQiMAUQbwx/yvpRfmSw271LgfvYf47w6QQULeYFpu/2Eo2a1TgLMHwgc//hhYKuzMsjXa6qJHMJU/bWt1E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 06:06:56PM -0600, Nico Pache wrote: > Add NR_BALLOON_PAGES counter to track memory used by balloon drivers and > expose it through /proc/meminfo and other memory reporting interfaces. > > Signed-off-by: Nico Pache > --- > fs/proc/meminfo.c | 2 ++ > include/linux/mmzone.h | 1 + > mm/memcontrol.c | 1 + > mm/show_mem.c | 4 +++- > mm/vmstat.c | 1 + > 5 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 8ba9b1472390..83be312159c9 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -162,6 +162,8 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > show_val_kb(m, "Unaccepted: ", > global_zone_page_state(NR_UNACCEPTED)); > #endif > + show_val_kb(m, "Balloon: ", > + global_node_page_state(NR_BALLOON_PAGES)); > > hugetlb_report_meminfo(m); > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 9540b41894da..71d3ff19267a 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -223,6 +223,7 @@ enum node_stat_item { > #ifdef CONFIG_HUGETLB_PAGE > NR_HUGETLB, > #endif > + NR_BALLOON_PAGES, > NR_VM_NODE_STAT_ITEMS > }; > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 4de6acb9b8ec..182b44646bfa 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1377,6 +1377,7 @@ static const struct memory_stat memory_stats[] = { > #ifdef CONFIG_HUGETLB_PAGE > { "hugetlb", NR_HUGETLB }, > #endif > + { "nr_balloon_pages", NR_BALLOON_PAGES }, Please remove the above counter from memcontrol.c as I don't think this memory is accounted towards memcg.