From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3265DC021B2 for ; Sun, 23 Feb 2025 01:57:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766206B007B; Sat, 22 Feb 2025 20:57:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 716326B0082; Sat, 22 Feb 2025 20:57:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58FC76B0083; Sat, 22 Feb 2025 20:57:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3B3086B007B for ; Sat, 22 Feb 2025 20:57:44 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A517851C07 for ; Sun, 23 Feb 2025 01:57:43 +0000 (UTC) X-FDA: 83149548006.20.97DFBA1 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf04.hostedemail.com (Postfix) with ESMTP id B3A0740002 for ; Sun, 23 Feb 2025 01:57:41 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ThKotZsg; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740275861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7x8218mq/S8HeiUV2pmXqSOq4XmH8eb1lmWxoCs5iac=; b=uXk4MbzqXE1rPC/MCqGyTVXY4NuDq9beTHaz1P6Oih31/nCc20/5gFNrxHz0qApcAsnHGY EkM+ySAk/qZraKfUnbWtpiOjWJqDRtY1vp0LdYzvvhlJKFX7bP3d1+et+TLeo6LaBbCf92 COI/of0Nwj20xFmAjBAKMSDc6M5XdQs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ThKotZsg; spf=pass (imf04.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740275861; a=rsa-sha256; cv=none; b=Gs2AwpkwE07KOmMIOSSpNvbeZKZs/WBDuAOg3mkyRiohZQSAurfoDePcrL3qUOhVvDu9i+ BK1IXn/n67ahKEs20o2eyWDk/op2vRIgdQ/ISWtFMjdQpZHXFMfGplvhYzROdrMUR1VCrj 8NXeiWKGjvQwxw9SoR6aPhY6JmPelUU= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-220c8eb195aso73412235ad.0 for ; Sat, 22 Feb 2025 17:57:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740275860; x=1740880660; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7x8218mq/S8HeiUV2pmXqSOq4XmH8eb1lmWxoCs5iac=; b=ThKotZsgf0BoLa7JBTlXBqZsrZyzOQOuDXXtZtKDdueSKbVTXjFayMXZJL3BAg13J6 9UdPfXWMBOiE8zb56KhkL2Ex8kLsZthgoQB8mZ/2oNdI14OJV/P0hfZNe29FP1H6CMtp RE74dLie36JOkroN5j3xIhZYQmkiDLDqLmvUg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740275860; x=1740880660; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7x8218mq/S8HeiUV2pmXqSOq4XmH8eb1lmWxoCs5iac=; b=oLNRew5bblhl/WeXqI43zYzaN8NXDQShIO1c08mSeus3Eut/QprVjW5qKhbYfsTNru adqogmS23zRjc3vlnbRb90jABcNk2ybx3WWBFdODfL7pDBVGZJGwXOiSCvBjTL9OpDRx hYCKvH+b7sDxzBm34ju021nXsOmEGBaXzL4Z6PlX0Pdc+CzZW41AHA1/M28u6xCpfuoA iX2NoBawEbKjr7x5hdMMyzW6Wb7hoTXREhaoJ0z5qFsLMEIfAy+MDFdReEq3chmuPNZN ByI2wWxzoCHqJD3ZzZV+8VvO45AqNLIpHgMAg85kaRbFFh1q8zeW8RFIb5NO+rTdyaRD cpjQ== X-Forwarded-Encrypted: i=1; AJvYcCVGkYtdt7ABHB6T6oDbb5zA/Son56lbQxdKTbIyy6NVfAR273kNmijR1vt38tXW4o+78XWua9sD8w==@kvack.org X-Gm-Message-State: AOJu0YzGhf4evRLpQpy9amMTmG/c1WqkNIUzmeQO42RJTnkOzDk8BUuJ D9DGyaFPT3ZwUrcUUdw4WMB1THKHKSzBDARK//OVlncrHUbfX/LmQJuOGhJGeQ== X-Gm-Gg: ASbGncs7SUJM4hrh6fBcYO5FtPKaZSh24fmdFezaT2hkQ031zBzzwO46usKjBsumCc0 S1s2rpAo1sntxAzlVEJIT+2izDppdCOmuLesMRPzeSruR5nn9zCMjLmsYHnajWBELmwTSLKIQ3Y VxA0k19in6H3CF3SyQoNIZrQZfl6K6tnpq7aQ9Ss4l1WD1IikrMwFKK4GtwmdVjXTOdXcolm0yR aNkcT6ktIaXwS6Pc2JcbAv4wxxsI9NNm160KJOMBKZ9rkStyoGn3h4xNDJ1i3pEA03Vtc38GBBV zQFv+bLrFzK+hKGBFU2w7s+NmB7p X-Google-Smtp-Source: AGHT+IHLIy9S1gN9GykDrxcBionqbpTUc73s1xpGPi/v5ic7ifqBg1hoW+uEceGXFz+sq5W77XBfwQ== X-Received: by 2002:a05:6a00:4fc4:b0:730:7771:39c6 with SMTP id d2e1a72fcca58-73426cab09emr16896880b3a.8.1740275860537; Sat, 22 Feb 2025 17:57:40 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:badf:54f:bbc8:4593]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-732771a01bbsm12445699b3a.78.2025.02.22.17.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2025 17:57:40 -0800 (PST) Date: Sun, 23 Feb 2025 10:57:31 +0900 From: Sergey Senozhatsky To: Herbert Xu Cc: Sergey Senozhatsky , Barry Song <21cnbao@gmail.com>, Yosry Ahmed , Minchan Kim , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 66k3pz6gsaidos5tihxnbec3ye6zza8r X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B3A0740002 X-HE-Tag: 1740275861-888066 X-HE-Meta: U2FsdGVkX1+7HwLVniO60RhDxWBJyHsnK/LEYP0apQ5FZbfulag/6p3v265bMkIIaEPEmyHMgAFgP/83jXKG10FecwZoDfuandAvkSgIKspjMBCYsoK6nUHJoxPBe94eX7YkLN388K0uDETHLewf9+rrfrhYCIhaFqfvLNyK6W+ICi7jp6PgXj88Co22FgIgxFxfC4gdfqMysQRdWBTutwxkjuQpfv/ZYMF2qElY5FD5645hVxgdwITgnQlSgy+QjfDb5vjS95Y7LjG9l6AF5CM2V9Con6lx8bp5tcTrhpcn3iu/IfzHbHtk3NdejUR/vmefZKuVARAwAMeWRlGyFo/dLpyguBr7Y3Vmn6TEA7lQEyL8j13m3OWKIt1WcPyvxv/w2Mp2LgURSdMDsYWHPGcE/SwWMrKKYS3tiZDu6cOpOZ/LCh3KM9DQ9fPU1AksOX3woXNXLBTEc8qO0DwmESrm4RXUNDwA87qGlAl5STi2tf/w6O1Bk3KndYZPY5A/mAJq40WyClcZteGPlP7SsYV9AteAfjSjnshw/08W0dUMLGxODMJynpuFMRgBhtaUTndjpoJnQY/qpkUVwcOCVSyGO/WFLOR4EkEIJ6X/V1x6evIlct9nU/EFu8GoaxKXmtwLJdRwDG3J0QJ5ocGN2Ty8KpoyMuCv39mwV3r8Dej5TS9J1tAOu5TCthrmtST6D1cGC5+h+4TTJ/pVbukVX2Ei9AiT6DSnhnoWsvU4UxlZXoUwfDTLDLAFzgZrbmySmgPh7lm6/iGS+EfUiKbtE4omYAnfDsysXe2XaIyOikC+Qnefo1SL7QcMSq954IeYrgs+5q8K+UFLrqCmdU8xtmLGSVHsj9vS9MjKgZxdefbGsu/yrG+spbFv9R7KzTaObiqumihf6gzoUL3BQKIeSwhLMutO32OK9hr3306c5ckd/5jyIfbeOqmHWx0Jjen5/co+Oktul++TyM2Mm9f LdO1BABv mYE3jVxqLH7uhe972pUKvShfXgRe8UCZ1xAVtryGQ+yAo8rEtBJGmLK7XBVMoY96cMWp7aLjC8AspP9AwBtMp+dTUPMRMv+ctKtTkBfUlbDbxYSr6yZERG+8PQJaWFyszrZcUsauiJYVcy2Hx1lYJLqz3W483a3IrCzShnp86kmOhN+CvZlGshWSGNVBMeh8kO/mi5CyHMVImFmhEw64n1tIyKqavTRRN4dVLSYkwabnt/5hygRz63PnyfPyDP6ih75SdRK1uXEt0qEcPYixthg9Z/6iD7sREFz7RlVhXupap80aDoN3BgVLMtQeEBkNtEpET3LD0UfGEF5mAVhmtTWgDeQgWArxUO+PqdY1qgk/xsxD0AwhSxqXP3GWX/+XUzcA6ffXWGOO1NneyDIOrtVCxx8+2US3NtUUue20uqyd2nVU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010808, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/23 08:24), Herbert Xu wrote: > On Sat, Feb 22, 2025 at 09:31:41PM +0900, Sergey Senozhatsky wrote: > > > > The idea behind zram's code is that incompressible pages are not unusual, > > they are quite usual, in fact, It's not necessarily that the data grew > > in size after compression, the data is incompressible from zsmalloc PoV. > > That is the algorithm wasn't able to compress a PAGE_SIZE buffer to an > > object smaller than zsmalloc's huge-class-watermark (around 3600 bytes, > > depending on zspage chain size). That's why we look at the comp-len. > > Anything else is an error, perhaps a pretty catastrophic error. > > If you're rejecting everything above the watermark then you should > simply pass the watermark as the output length to the algorithm so > that it can stop doing useless work once it gets past that point. Makes sense.