From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354B1C369B2 for ; Thu, 17 Apr 2025 09:26:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14AD528015D; Thu, 17 Apr 2025 05:26:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F9FB28015B; Thu, 17 Apr 2025 05:26:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEFDD28015D; Thu, 17 Apr 2025 05:26:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BC80728015B for ; Thu, 17 Apr 2025 05:26:20 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0F2F2B2F1A for ; Thu, 17 Apr 2025 09:26:22 +0000 (UTC) X-FDA: 83343005004.20.BF8AA84 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf22.hostedemail.com (Postfix) with ESMTP id 28A1CC0004 for ; Thu, 17 Apr 2025 09:26:19 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=H+EWk7PZ; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744881980; a=rsa-sha256; cv=none; b=qMvh74gf6IqQ2TkuUYKSanA6SZ+3/RYX1xdwWdE8fPeElAkA2++7Hqg0jmpjXoAfqBzWVo 9C7w/RMGZvYQTHwV/dOhre7dXR19NVyUaxhXroLi8mIGrbD21uVaQP7Rx3m3IPwHx70872 aV1IOFl/Mu1p0KC7rEzbKVHVDAat8B8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=H+EWk7PZ; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744881980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eh3FbWA9+X5UO9ZStp4ZOy/ysn98/Ghz+ntZJvZupfY=; b=YA4s3/C0+R4hTfQ/ut2USIiHXivCVXSLA/EFM3ZWrn3tVC4GtS++hqxFFouI6oUjsqPDDg w3fPSZwY3kVa6ZuRVzvOWLSEs8mYscKfN9ROqw+LQ3CuFbnvzjfrLx1XN9C4z+9woFrYTI 3oetx2zCqAvmM30UEtprezFQVYxVc6I= Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so4433425e9.1 for ; Thu, 17 Apr 2025 02:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744881978; x=1745486778; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eh3FbWA9+X5UO9ZStp4ZOy/ysn98/Ghz+ntZJvZupfY=; b=H+EWk7PZdO2ELBF2NSb9e5lPjUySIAc3x8Ma0ej+xnbr3y+XwRUFW41HeJyhONfKYS VCbYB+GLmgo62GFw4HnY8r65k4e6nccKbtqcS+VGdq0eKI7/h2VZjX6R70iBRJxfjIe2 A1BdP7LXi43OKTqWm9joVti/LFVyyOgg7yVu+grn5+sSoaMczYteoCOXcg57LvkP3rtG RhfPBpteQoSrFhSyFLk7WIFNwi6YqsyMlmd+unyYHWlIMGM28EFSwH1KamhXQgjgPs8O gu4SEHu2fmUAcylR5eD6j9PnjPEE5rxZJEP3rmd4mxKrhHXRuIqLc/Y8XFcqhr29syCb fLGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744881978; x=1745486778; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eh3FbWA9+X5UO9ZStp4ZOy/ysn98/Ghz+ntZJvZupfY=; b=OvgapshyAClMX1kwRIGx34PZVcsjKYdQ+srXnmo+uapJ2nZ0VCJd32un8Q1TIt1PwF axOzeafBeD400p/5b2uvUd+mMHl/wpHMxU1Gj0slnPKZp+ru+jgRCye3PpKxxHt15yIJ 84kCv7RSiAr/OiF161SY4ApQvK5JPTnZ19Pdfn/YqiuybeS1ECT3ZC98I61yZ0JnOjNy A6DRHko32ABIXTud61Cg2RgeFCMQ+AjAFJnuUnWspuXW4IfWVpAzxL3z0SoeTzGA2yb8 XHFcl/FqmJYLBbcGWN1gDoVZtyUgA72E8MqPxvcd5tOI2o43PZhGAl32Z8hhIpuuvUj1 lyXQ== X-Forwarded-Encrypted: i=1; AJvYcCV07Rc+LH0AKnk08GnO/B9OMi/R6LCKVd1kQuS3P9bOHF90duNtkO/qcFDQgyEwYkvtxNf1PIb0Nw==@kvack.org X-Gm-Message-State: AOJu0Yz9QU4zBrIvjVfgXP1OCZBx9pw1kwUJFmCAjHcPU/n6ymJVncr/ 6Q4rhoW4Q8r+SQzuRQ1a6oQ0SjbFZFTjZP7kHguRxBGQdyxkO+laQjmTL/w+65Q= X-Gm-Gg: ASbGnct+MPfKFrUMfCVd5qGwYKDSFPqufT7yWex9EuHMmYS3NG1Zb7guWie3+PTpTNJ CNaJIorjZQnNwmK0oXOUNVtsIupOe6A5z1ebV/jKYFX97mJ/WxS/NhKna5V4fWdZJT24yNWgqof rkNdgSRu4UsrORap7y12OVz4loqPzl1M2jC6gHVwubqVynqI9lOJCijhW3Yxicp88AYYNQHqJZH 05lercZdTd+/xaSy9TBnYi6IgRfbnwO4bZtpYuGvp/zdPZjMFoPhCoTVSq2FQgmeaNSxv1L3eeI lUTsRp8WkTKJlyCBDsveG+VjfhquID28QrLtpzqkrLAD3BsfXLHV9g== X-Google-Smtp-Source: AGHT+IEYxZTVXO5DYDGO2NhL2DmdIqaG2JEwEOEFvebpkB3/U6Fhxi3eBBqbMph8OiK0cvolOVKBzQ== X-Received: by 2002:a05:600c:5027:b0:43c:ed61:2c26 with SMTP id 5b1f17b1804b1-4405d63755emr56733195e9.17.1744881978549; Thu, 17 Apr 2025 02:26:18 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4405b512c52sm46125615e9.30.2025.04.17.02.26.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 02:26:18 -0700 (PDT) Date: Thu, 17 Apr 2025 11:26:16 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 4/5] cgroup: use separate rstat trees for each subsystem Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-5-inwardvessel@gmail.com> <2llytbsvkathgttzutwmrm2zwajls74p4eixxx3jyncawe5jfe@og3vps4y2tnc> <88f07e01-ef0e-4e7d-933a-906c308f6ab4@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="adoqqezhfiw7oyyq" Content-Disposition: inline In-Reply-To: <88f07e01-ef0e-4e7d-933a-906c308f6ab4@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 28A1CC0004 X-Stat-Signature: 51iswtjdk5oq1yn6zkoqwud5531egwzq X-Rspam-User: X-HE-Tag: 1744881979-286191 X-HE-Meta: U2FsdGVkX1/zJaioxQLBXJSmfniDxxoTy2gIKG4L6OLk7tw8u85TovvyyqlO6n0+U6oLq2pafDdtMPMAa0u4jXvkFcQuTF6eai3cUfd8PM+h/e0zQi47cqc/PzYLleXv3ZlrOHHqjAaJxPHFevjbuBWNxdjNnExnbNGWRe+WFMZkcExnkoF5cIYlrJKPPF7NrQXiKVrHzfpSozZHi7KQp0P0KmjOJz4IAdCUyDRlTb9jbe00Y4M0O4+g+tMkSmrqgrP10iwIysOv0JBeO8lNodyLb0uxmOm+Kdq20zwYzLa6FUEyVDgnQFExJgnvo/PGYAMWAhGF0qAWmdwdqETULHFimF5wi7xsrTrbVG1fnUKZK0AsE99fvuOWA3tQNLjy9tvM3+R02LY+FgRhRR0UKhU4baAsE+EV6ctGrd33dyNPfT3PLd92TNtmKRG1oOLfEWFKt2p/RF5u9EOJ64J4Y+k6Mmw0alz54hYLnuGCSe5PmNq4Vw4QhJHbW5gRvHO+0C0BGzHmcs34PfeRJD+NoB3wumfpGNZEaP3/8ERB7toLUmOfUNievwbLFrDWxDzZYNyZwE1OiOIzlNK7EtIlPAY/1J3IPpKjRwB/FxzIVvz/MUEUDcB3CWmvh8i6iQCRTam/yEIs9xUhuJTM4TD5RCCkeLZQlPEx8UoowyRpWmqWlOxR1JzDB11xiDClTTlc7SFSjBElQok2zHBj9tRRn99KyGnOJi7m8Hw9IFrhI1gPohmD8eNcum0eppCOQhPt1jrKMv5sESsnEEXwwn3g3VE/qsj744ml1tH8MahfMYGmdGkOcHWpG29gG6WwDpehQkM/1qdSD+oaQuzjlBr4Wt0kafwwo/k/xJ+qRa1oeqUcE1uR4Grv7xS9jYQuBzP8VXRxw/zI2QblNB65EGh2EvwLOMc4WG/znB30TGYkDRfdZbjiEvdKUk4/TQBKS7S0CexQCpDJzna50IVmq66 7OI73Cbw 1WdERcjylopxaG6+7BJ/dI1gZWzNSpMl8rv3pod0O+ISHuTRGFqd32X1RLk+WNfOPeRd9ZJi0ENX6+I/WCxhYh21hmAI1bmj+jVYCJEwco86s0PrntPyoNcBygNGWBT5BshJ/NHVczLKzSE9bcpNuam+PeJvhwsMD/vbWY68W+LDqeg2kuxLXIyPCqXdC6nj5OUhoFC3eaUwDPUK0sj7ixIpz0hA5jSwaEZkN16SNlRnHq1f4k/qBYJM5nfqK3YxGLJw1hEKnUA//JtnDjtZADiZHVq3tgU1NJ92Xm2Ql+i1Wp/wysthOmKaCksTmEIYXCAFKy64lY5hxKtovt86Fgc8y2+zHRIc6/SuFyzORo5Fa3Sz6rtDijXt3+3Z0ALuL+jLZAknes8AxCFaJeII8hSUtXFC19jW3K7JkWt7+IMv9YeZPh2SW0T1mIyXcAtD+dTN8iAU2FfpSa00= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --adoqqezhfiw7oyyq Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v4 4/5] cgroup: use separate rstat trees for each subsystem MIME-Version: 1.0 On Wed, Apr 16, 2025 at 02:43:57PM -0700, JP Kobryn wrote: > Hmmm I checked my initial assumptions. I'm still finding that css's from > any subsystem regardless of rstat usage can reach this call to exit. > Without the guard there will be undefined behavior. At which place is the UB? (I saw that all funnels to css_rstat_flush() that does the check but I may have overlooked something in the diffs.) Michal --adoqqezhfiw7oyyq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaADJNgAKCRAt3Wney77B SYJkAQCd8f1aLLSF949AecH8ekZpzNp13svNWdB0GafmzM3cfgD/VvH4N/d8V44i lZmPnX3zoANmFGwJwXxUG0/mzT5A+gQ= =9emt -----END PGP SIGNATURE----- --adoqqezhfiw7oyyq--