From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A664E77184 for ; Tue, 17 Dec 2024 12:28:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E712A8D0002; Tue, 17 Dec 2024 07:28:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E21E18D0001; Tue, 17 Dec 2024 07:28:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CEA0E8D0002; Tue, 17 Dec 2024 07:28:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF3668D0001 for ; Tue, 17 Dec 2024 07:28:00 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3BF63C068A for ; Tue, 17 Dec 2024 12:28:00 +0000 (UTC) X-FDA: 82904376660.27.07EA5B3 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf17.hostedemail.com (Postfix) with ESMTP id 0B45A40011 for ; Tue, 17 Dec 2024 12:27:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NISsOgaI; spf=pass (imf17.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734438457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f0LZxufIyLTNTAhqLSUtBRCFT9U3DEE8+8dGiQI78bU=; b=vg3cjGL4oRWSNQVip7yCA7o7DL4EJLtkOdW+yxGGXNYgSK+hDb7IxVQYqp3KAWRZBczBqe x42oZQCYJH4pvsK/XMDgpd5hx+T/sFl4qusiicJ471L4pmup6xUGEKCxKm15vkdC+sdcYF UxP1TiOraN9AJNAcZZJJq4tAnINnxDU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=NISsOgaI; spf=pass (imf17.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734438457; a=rsa-sha256; cv=none; b=xnOxlJGHeKAeVzeVLiHpCVWv193ksTaMmljANz9sHQCCvUVti5IGpgWwnq4sl3dX4xO217 WQf+tJwAFCKH/0XjicWHQ7HpX3KARAEN6sB1VupWiO7E7d9D0LF8UT0aZFQGkAqVZstyvJ Go9/6gGeQqA134siQXLFaQ/zh4UHh2k= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so7477775e9.3 for ; Tue, 17 Dec 2024 04:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734438477; x=1735043277; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f0LZxufIyLTNTAhqLSUtBRCFT9U3DEE8+8dGiQI78bU=; b=NISsOgaIPiAMAQkGWUlVhOYl2FsUX0WJePEd7azerX0CoUshfWU2ipIBjRFW4cph4X 3S9hVRTXEiiSAU4UxKc6B5mvH0dztjpSLpbpkQfSH03SPDLonPfeHeroX+a1y1n7whCg rkYuy6SNtusHUbdsl5GjdH6YAzwAE/4LmneFw/+2Juh3cwk21Yhh2nSztRBCY350tIpL Of6Od63xzwENp7qyQLTH8fqW6C+rpY6KyQ2x9YNKdWA/mkTNJ5RGe8eTZKZBk5PhELDL qeTgHE8gV1lUsmoJVjwwsuGU2nd7McU/9AhiE77nYWEUTaWJIwQeFx0lyTd5tDBivS75 Sy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734438477; x=1735043277; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0LZxufIyLTNTAhqLSUtBRCFT9U3DEE8+8dGiQI78bU=; b=XHrzhxwdiR3La0JJbpCB8rPpS61ZRqEHQMH3wUg/MrDdU5NBKTK5xhD/BUpq9I6XR9 1jVasdAD0v2OSq6GO3hcBS6k6ihIAC0/EwS/vvaLoueMGchkMwSVJmzvka0LgtvgUogK Sxr+nK7IwkAC6Sgs+uc5UW25oFRIqOGX16YY0SBkLK/S+W40lRO35tjyQip3Jr8Ogcza /tbNygMVlV92qr6I7ZGSO+B3lB67VTft9XMihSGoqsMsXRRLsKBnrBsp+rBvG3hV8zva wjlaj4BEI3YhEGVVMn6g+7enMMyVu5mRJeHb9oaczPKXndhK2xaNvrOXwa3OlVT7KNQn kxbw== X-Forwarded-Encrypted: i=1; AJvYcCWE7PrP8nzXkseJwEmM9b7rYDfdtBVVS8vH3g+jykCmmO3EBOKBrMp1xW+HyCcelf9PGujakYh4WQ==@kvack.org X-Gm-Message-State: AOJu0Yzu5dAyFSv6DPkf60RqbAlNF4+cM9xiZOkRHHbmUDCPnS0XG1g6 H8922JrXu2IhgOrXxAr7kDoSHTxzt3wL9xaKrMikCE/GNIh6rDBQBaZ57MumlL8= X-Gm-Gg: ASbGncsutX1aQSLILEiF06deDaVRDKW3M63CVxlFZ6TBsve7UbWoZmkiJGlsTqippp6 lDVYrc2fo5tqmbPssc88gzVi8lYCs+SA43tM098qSk1Fb0qLXqq0KHzTynSrlwgsdFp2IatbXCh 8A3uVlouRKA96Jh/soLMsLQUVI5IOeQVURoLsnaBFcnGX03GpKtOgCZS6aGBPtmehW8evnhl619 9rdcgLgaCvjOYioNXBBwhNYFCSRDt6p0F/Bj5G6sqeNcN2FDoeaumUeM1U= X-Google-Smtp-Source: AGHT+IHBtk/ewjC+33KbY4kiTsyCa8gijFZMuXZ9Ou3NqePKUlzgP3VG7Yh6lLlkFNIG7kqZNOpvkQ== X-Received: by 2002:a05:600c:4e11:b0:434:f804:a9b0 with SMTP id 5b1f17b1804b1-4362aaa49b1mr148537805e9.29.1734438476734; Tue, 17 Dec 2024 04:27:56 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a376846sm19216035e9.0.2024.12.17.04.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 04:27:56 -0800 (PST) Date: Tue, 17 Dec 2024 13:27:54 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Chen Ridong Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [next -v1 2/5] memcg: call the free function when allocation of pn fails Message-ID: References: <20241206013512.2883617-1-chenridong@huaweicloud.com> <20241206013512.2883617-3-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3ki3l36ikdb6o5jh" Content-Disposition: inline In-Reply-To: <20241206013512.2883617-3-chenridong@huaweicloud.com> X-Rspamd-Server: rspam05 X-Stat-Signature: uhathm4rrxd3nii4d8g7qu5zt9uz5ktb X-Rspamd-Queue-Id: 0B45A40011 X-Rspam-User: X-HE-Tag: 1734438454-935654 X-HE-Meta: U2FsdGVkX18M2oGqyEFUx2Lvb4vsR4QsepPbhXs2WnHxGmqkIaZ29tLihV6wRR9DbWMEAniIc+MvQkTSMq8SPGTSrfsSqafM6+4huuUx5RpfJeSUGOVWwcS/JCNeNihGSa9jPf5Gv1IStNa0GnBNnf+SU5H1QET9CXkph4Lgs45yR/jSt4ysX9GlVLE13M3uaki1KkRZAgMOnHdPoB4Cxfn6my5Z8jhGOysSJEnMd7E2X4rlh4NvzgfUGA5gSlHwP2kleW5yW4OPFyYz2KuljCx1NiNsfIZRejkg2DGbZpeyi1AEYqkzCSPPACpLJND2oQNoKShceM9p/f6A+0QHHDBZtg36CdqswVzUi2aPQmMxK/Ka5LFR2bYfOxee+AbaWV6TJpoaa7gITDlJ8wXXcdCABPLHU9mf6cQACsTtw286ku0o4hBdmFFwHBCO2wB/vShfzdnmdEYuWyjTpBzZcHT3ualHzSvVKuul7BVKJe34PSo//aWNyRk8xewW/OYDvqt8SRuQFUcKYE0jhkl6gsuFfilQSqzSamTFYmiouKEGZGBUswxtSx8jwuFWFy8TrALb1+DbB/it0MZOS3VSgfIg+rQfFMv2bdxcA0KyF5Akkniof9F/6iDn6/KaTYxG4xhFex3xu/9BRfNlKk8wMLobZsWSLOUuM6+VxlXUM1+LOfcoY5tc7/WVgeg4xrToDpXRfILYt+GCkj6KKacP6bDcQtX/KqAE2hSwvLA+auTrnZZCcEp2Eo6/9/uOMpsZCL12C74eY12FGgNHhJfX419ffrC0iZSzJupvKl2g3Tb5KGcrL735MAY9t7iLtCWPAREYCODdrF9xTtit8jBpYGTUg4BDH6EqnDtYxStIdp2/VAF10LtxV+vrZo3fJPgzY2TZp03+eo2K+6ueS0blrWzTDWXvIBFfpGp07Ib716AEJebi/nCygdOBc5bdLIiu9Gc1eUXEpKynOKdFzQr uLvbS2wD Y6iprLtf2t5PUOwr7kfGaMe8dmBAlV/GGCha8FKzxwLcQ+PIPhMN0+opa6JSkm1tBPt9NnK3/huTqsSNm7VhuTwkxXokFIARtXyO6PdiwTmNJXp/op4SrnCgRiX3xxOGEHv8OrKY4J2bfE16D4ifr0u7gTL2kvxL3apo0ca/6JOF96O8IHK8bhFMsuedtvwQwSK0w3JO96WOUN+6plaxcdC9KYQ7rOq1YzFio5i2ZlkCP399UdLu027z2K6yvX/SW9gSEQvXy1iUrUqmFC6fWPsYuckQ6dnNqAa65MuQLZV3iCwOTD5EItTokWx0O5EVI+3Fj1iJzzzUUGzQn+QDdu5xqZuDFyEXCKmq0PtxRQI+4m8VmMAsfQ8uwgsLKLx5nApsMs1Y+vsbhcKnpV7UytSJkbZMtHdHZlLBsnfGKRKohZXoDw8Wg3piwxJR5OMPP+4v6RkOETx2FQIu1Tq02EPiiUrJN3jNbuT+OdC3Wdt1qc/oIEk2ZPg9LwPa/NcBfn1bNDKClaaqtm6CN01K3nEVhA4UnTeBZhcq1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.230131, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --3ki3l36ikdb6o5jh Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 06, 2024 at 01:35:09AM GMT, Chen Ridong wrote: > From: Chen Ridong >=20 > The 'free_mem_cgroup_per_node_info' function is used to free > the 'mem_cgroup_per_node' struct. Using 'pn' as the input for the > free_mem_cgroup_per_node_info function will be much clearer. > Call 'free_mem_cgroup_per_node_info' when 'alloc_mem_cgroup_per_node_info' > fails, to free 'pn' as a whole, which makes the code more cohesive. >=20 > Signed-off-by: Chen Ridong > --- > mm/memcontrol.c | 27 ++++++++++++--------------- > 1 file changed, 12 insertions(+), 15 deletions(-) (Little of a judgment call but also) Reviewed-by: Michal Koutn=FD --3ki3l36ikdb6o5jh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ2FuSAAKCRAt3Wney77B SfQ+AP9X381Jf33s+FoGPIzwzpwnzlojkNv+6yBvGADf83dixAEAuDtx7wBMm/XQ 5z+3XnDlJossa9WZtwtwcsYoas3gtQc= =d3q2 -----END PGP SIGNATURE----- --3ki3l36ikdb6o5jh--