From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C66C27C78 for ; Tue, 11 Jun 2024 17:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BD2E6B0099; Tue, 11 Jun 2024 13:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46D466B009A; Tue, 11 Jun 2024 13:16:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B846B009C; Tue, 11 Jun 2024 13:16:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 181326B0099 for ; Tue, 11 Jun 2024 13:16:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8AC92A3316 for ; Tue, 11 Jun 2024 17:16:29 +0000 (UTC) X-FDA: 82219261698.26.C1429C5 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 2CA6C18000F for ; Tue, 11 Jun 2024 17:16:25 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ukQZ6ZBD; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718126186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IjEGM0189YXKD5XoQXpyIoWJTRC/+NjjQ7qIOjBHtf8=; b=pTDOdGZc6UEx0EnTcN2N9YDPY/04oAQEomGS6BlOJPlltfnPUqOOE0Q1bmtcDNS1H0mkPt PKN57pCjRtrxu18c+weBUj6hO/KBdqxOqyamlLE3Y8brbNFaHPFZ7POK0SUI+2HxtYsItn 3oMdvKaGsVbgU4U+L936x+wy/bqca3c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718126186; a=rsa-sha256; cv=none; b=x2aR9bv71KAh6CBKvttAQB2Gmbk6z3WjBKCILaeYOd7M28f2lYrEnAgLu4URWcTvw+Gf0w gLbtgpGctPhaSBYOkXhOmiI99ZeVk/C1DKgfCVaGnqfY3wHSpMykQD1Sj3/28yV+F6y2Y/ 4zHjNk7jFjZzc0pGTsXWAxpS/5LL5zw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ukQZ6ZBD; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: usamaarif642@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718126183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IjEGM0189YXKD5XoQXpyIoWJTRC/+NjjQ7qIOjBHtf8=; b=ukQZ6ZBDDQ/M0ByaznMxRAFjxzX0eDvTT42rvEjMfvYAhE58JJDseBRb2LaNnKHCqncXTr 15hFt/Hhlgby2vYqXLnUhW0Zz1Ohm+7fMbaxl+Bj+fvwXT++ZAMF8NWXn0YHcTNYMa5R+J NjmOdz4HpiY6EZlVRA3uWaEO8j1Fu1c= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: willy@infradead.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: chengming.zhou@linux.dev X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel-team@meta.com Date: Tue, 11 Jun 2024 10:16:17 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Usama Arif Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap Message-ID: References: <20240610143037.812955-1-usamaarif642@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240610143037.812955-1-usamaarif642@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Stat-Signature: 5hakbjuif99tjqtpj58tw5j37647hwnn X-Rspamd-Queue-Id: 2CA6C18000F X-Rspam-User: X-HE-Tag: 1718126185-775505 X-HE-Meta: U2FsdGVkX1+T4Oqz/tA8+qtMbRTHH+doALZLEfvIJh4Ua/NSS6FqzCNACIcavg7Q1WXWxCA7l+52Mv08NVU2PUz6OG9YauSG9NWSKSTrFry4VFFD8WkO/maL286hGscWewRjdinr3XaYPfwPFdl9izAutgJ2LT3nvv/jeOLo4B2sPMIKJAtS89gV0KfICGki+7tE5xc0i7SU8U3mrqm2uaDzMI6CFMAGZCzQCIaucstjQ2K25xkm6zgjlX8gLvM7+eys0IHZ75LtrM/HPt3CsjDpbYmpPmkh+ml9hVWlJZDTwqxnmLTDNWGTlVwg7B2zDB1UrqrN64Q26eByKp23VZW/C2B2jHhKCVzvu3W/VGfHokgsXJCYXohpsGTfBahOUGePcrS943hhZ28EBZGsRQW2vWUfv/MpWWojtceD+D7ExniW/jfRJnDp4j2RV45uhVkEJGJkA4pUs3eUy7AhblsgqHPU8eWTQkU02jSJZ3kYdvIiWtay3fB2fXyDwWHoVVRoBeH9GVTnr4UJ7uMzYbJz0ENIO0IakrtyD7TdfrYsKhUNq3EXRIkQY3R9OiRcFBWH1VWxAa4ABc8QJ8w2sgbQ4ewM9hn3mA8Ha8YayPXHmCpOxWFx+QGhYKYX8BQG40K2eItdtQb9GT5p82IQgc0Xy+V2jbvL6Amy4ak8/IPNV3eUn3KLyW1AYQHRlxp9vGUE5iDeme8wNebp3D19Siz/65cBznrMFtw4Q1t9DHot6O8Qd18BAYROD+kZF/f/ihQkjGnqv2uBmIzJbWlU++R/OgV7Jlai9dGn+52yYJCtRXHu3YeqXAU/LiOOvOTYSVtSuiI675EZP2BlZQ6jn+Ln7mP5FbyMtPXkTvx+ZrEYoksKu8r/D/6iNPmbcmoKFMu6v2FdAayZo6mVHc4GHxUwRtwFGdGWvAkeSk9z3QWeQGmslYuk0sFiEnkF85GY/Zzb63QjuUhL9fvf2ml H2Ds2LEO IjQfn61zOeWJfaHlBzelrYYUyAK5vDcoz7ArobiQxjggaZH6dW3L08x8RumZwLPAOZx3Hoo1gnNdy9EBIXkyKH4nnHQDDgvnVdDN4Gg8SDIiq753INFr8QCRxrJqmoYFwzBvGu4jNboO6K9hKPrdDhjpr9KSCjwEoCQe+q6m2dVyOsbc05x7NI/Ga6/lmVMQysTRhtNNw82pVoHo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 10, 2024 at 03:30:37PM GMT, Usama Arif wrote: > start/end writeback combination incorrectly increments NR_WRITTEN > counter, eventhough the pages aren't written to disk. Pages successfully > stored in zswap should just unlock folio and return from writepage. > > Signed-off-by: Usama Arif If Andrew has not picked this up, send a v2 with more detailed commit message, particularly why it is safe apply this change. You can use the explanation given by Yosry in response to my email. Also add text answering the other questions raised by Yosry. If Andrew has already picked it up, just request him to update the commit message. You can add: Reviewed-by: Shakeel Butt