From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21443CFC505 for ; Tue, 15 Oct 2024 01:29:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFA826B0085; Mon, 14 Oct 2024 21:29:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA9136B0088; Mon, 14 Oct 2024 21:29:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9238D6B0089; Mon, 14 Oct 2024 21:29:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 72FF06B0085 for ; Mon, 14 Oct 2024 21:29:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EBFEB40472 for ; Tue, 15 Oct 2024 01:29:36 +0000 (UTC) X-FDA: 82674104478.02.41AEB31 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf30.hostedemail.com (Postfix) with ESMTP id 1A00880006 for ; Tue, 15 Oct 2024 01:29:25 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="J2d+AK4/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=VyBYG3DB; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728955637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dWIurdZSRQ13LvURpdkzakAZJZtdt/xLDw4ph4FEHnQ=; b=R6P7g/9IcAoSUXuEx2HDYIsIwiBgivL4M11kasMmhygtrIOGPFz04gAshzem/dZjGqJpg8 lnidfviDU/TiHFH5jiSv3OxVO7PWKU0uF/MyPAxew/LXDlAP2WLXjlO1EfXYt6RANpfw2F WezewmtZ66PwQL0e8QJ5TLFEjzMLjD0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1728955637; a=rsa-sha256; cv=pass; b=zsNGsJ0k0h0WK/MjCgg9MrK1zzB55d/S2uIpvgNis1qXSONWyrxrognR2FMOjtE5k/CnnT AuI/mvZGwaMSg80+WrF1y4v6rmsODLLqU9PLAgvV5cmhAE/zhEBNwWjVycpQhKILMSYe5A qdItdwgBpcQWnZM3rHTOXc/g8fvtVpg= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="J2d+AK4/"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=VyBYG3DB; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F1Bch4003568; Tue, 15 Oct 2024 01:29:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=dWIurdZSRQ13LvURpd kzakAZJZtdt/xLDw4ph4FEHnQ=; b=J2d+AK4/xlpC4OkAKcw0qKo1+U13vc7mh0 LrfVspmH7UD3uZqxOLi5tGtLs95PONROAFE3jElpj/ddqJDAvzX0J5l+RAQ77/E9 DTZe2VRcmOKsJB6EsFL/kqjyxWB3tqHP8CSiq7BOVHjkoL0IJODO7JMasy1rnSSk nuNuJrStZjDsio0y54GlPBRBNrc4o9tqzIubcVEJ9v3ieTUwFb24OM2DYjdoNfMD 9bBFJXH2u2AgNwP7yFbJ+43aVBLjZr9U7afDisuR/wjk74bJ7gEd+gHKcjFp8QgT uPoScZvxdV51lzOP9QXiC6wGXo12EXiQr5CH2KKcrrcN+SI6i2Dg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427h5cftw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 01:29:37 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49F0Op58026287; Tue, 15 Oct 2024 01:29:35 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2047.outbound.protection.outlook.com [104.47.74.47]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fj6skk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 01:29:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vDBiJTMYg5mvesEp0/uV6DgQ0/bcVkIGOzgjtzvxdhrhKnD6KGVkiOvOnk57np/g30xOJJolaa7kV60Wpdo5aWQiR0t/bf3MhYiRp4JbiIdO+FGT+o2dljAnC2FnDm6CqxK5baaPcPUmWViJ+9VIZYFC8bQKGq4SCQ7v8ZiRvBcWy067JsaO3q8a5qzz7eNUv9IK5PngjYQgyCUM49I/8Tx/V/49ptUvacFq2mf+B1GuAy7WTtf9LN+lh3KkbG8YpOxCQSuFswG+AthhV0eUo0Hj8tSW4eVO2ncmcCOgnmJ2qcgl+tY1Nq77487s610uU62U3IbwesISz5KPAx6tXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dWIurdZSRQ13LvURpdkzakAZJZtdt/xLDw4ph4FEHnQ=; b=RXy9HcxVNt0mUFFeH3oV4rNDW4a2hgjtIV2XF3jWtnij30a1Ksm5eV4f5YVIpon/ayu1lQR7pA1sbETcVR25giIzoVD+tW5u5CvODp/8tnQ8pyy6pV3DQcKlILnYQG2rUtdxwLo2cyVlEEk5Z03Kso0ZH88jDsDoZwOFFTVK5KcX/xQeXLSVfXhpfg2idFwBBqB1NqiKMiLEVZsigOFfArcJQ9sDx+h3e0IRvI75od4EnNM3W+93ek5JAiuNz3POz72798iGs/ZSZVNuHHKDQ+Kwi+441odj41vorKGZXQxgGmmhBkbz/oW4EalzEL5pB/UAUUH2rvxniFvC1eJJew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dWIurdZSRQ13LvURpdkzakAZJZtdt/xLDw4ph4FEHnQ=; b=VyBYG3DBb2tbYCjPDQmEBo4bEAh2aJHdxZzzgJJLOD5RjO0YzDQMmq6On6RM0Iye7qjJjbU5xf4cvcgJGB1apNYL/Yj3rrQJsC6zvz/MWeSutlK+MTzXiGSjssoNqxe3OanZB4uG2aJKS1WJdk8L6EEJC0+mzHAOtZaOfN/ow9M= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by PH0PR10MB4744.namprd10.prod.outlook.com (2603:10b6:510:3c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Tue, 15 Oct 2024 01:29:33 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%6]) with mapi id 15.20.8048.020; Tue, 15 Oct 2024 01:29:33 +0000 Date: Mon, 14 Oct 2024 21:29:31 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar Subject: Re: [PATCH 4/4] maple_tree: fix potential allocation failure even has memory Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar References: <20240924123954.18933-1-richard.weiyang@gmail.com> <20240924123954.18933-5-richard.weiyang@gmail.com> <20241011012725.ffof6uh4huffz73q@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241011012725.ffof6uh4huffz73q@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0496.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:10c::10) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|PH0PR10MB4744:EE_ X-MS-Office365-Filtering-Correlation-Id: 77f4aeca-5eb8-4623-2864-08dcecb8d282 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?r0m2s8Gc0tx8Pi4c0iYE6XO32rrD9VKtleTJaMahVWZ/CvwFIhfIN00fSBmi?= =?us-ascii?Q?QKEy4h1Lr2BAfyEKjuRrCbAUKMUOF7E08TI0GCwQHVxrl5YrWFxmRspqRjT8?= =?us-ascii?Q?UxIiKpsy8Uz0WMz232NPGfZJWUrTfRw7RAiC8Do3ig9PR/3rB+svILj7W0aH?= =?us-ascii?Q?94lnF2glZ9WT26ntRxkMKW6lN9/J34NtLxS375aHPyo+7AxdkmkWXB48WVwU?= =?us-ascii?Q?HGDXa/atuGCj2QlN3Gj2TEEcD0QErP6XWtVVp+yMtyYjO+HjrEzHf80sAi8n?= =?us-ascii?Q?FJRd1O4S1x57751daNinSHWLzU8gvt9YOBHiINRXEjODlzpQY61eQ2d5uYCl?= =?us-ascii?Q?klM+TW42LuikF1O/WJcBaJ+liU6sU/9pnz3Xwor4sgARsIh2LAVclY3DhdQH?= =?us-ascii?Q?EKHfqI95YJsMl4hg++DbDtBMCvKW5LyPQD0dEp7u/uQyeFZ14L3ciToF4a0U?= =?us-ascii?Q?wQvVVgfa6JU2JFb6mcm5x4cuwpg2VBp6Fg6xuOZJm3MLeHxBdfjD3+IGDPkA?= =?us-ascii?Q?ZSPWlqr34ZFumfIORatKa0hVuTtiKSKPm38vA2fZfDNdv6zOCIhwAOnGF/lM?= =?us-ascii?Q?Z4KxFs9qnAnhRrbWF/6CMuKwqbzDLT4kJ1HhHAvqUdlhdPeib3wB0Yco7F4E?= =?us-ascii?Q?KHrvytB3pjRXLhJzrrVHycPn+CTeEumTH0oDxIeVsQu05EJykNtxKjUDdowt?= =?us-ascii?Q?uYP6hrS1ytiZPRjtwxKsz9UO4a6hWbiODakE7ZDnoZFg7EEK8y4X8ovfg11/?= =?us-ascii?Q?kp7xEkzBNk6G82RtcA5J1IWz7C0Df1gGJzsYdi8KBSNQ0WiYjbNoMjIf1rS1?= =?us-ascii?Q?aEZGpKCXfinlzNjSU6RsDWhZK2yS/L2JPWqdI1Sg9Jp4bQeVogJh7Gf/jOYE?= =?us-ascii?Q?vYZKMTukfh3xTNdIA3397JZU29Z8sKNfp/59Avq4S6udjFTGqg9/3oHHDXAy?= =?us-ascii?Q?jVRQ4hJ6SDUKlxy+wFaTzCCRzjRUv4Iw0iAC0DBWGlpnn1t86d8KwhimjlK0?= =?us-ascii?Q?LQUvy1soYaJnhdlExu+KUV+ktDujt97vZBYujgsroMkqjiw7+X/KiB6Adlpf?= =?us-ascii?Q?Hdow+eBsFEfcC/RsALjzuUGG3JQOyI/kUl2rLa54RS7y+o0EU18I/huC9uXQ?= =?us-ascii?Q?xUlGR09XAJZFgTK2+4Of8btD6rPhb+sD5zTVV+DFrm//lKG1rHLkjUZFUWmp?= =?us-ascii?Q?beIfN6Wzj81v03qnziVKOZfLHOApUh8LVYdXaMwlTSxQqPpsa2MuBrGvOCw?= =?us-ascii?Q?=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b6ioua8c/6br0KpNagjRQ29iiNJ2giH2aeaSYHdlIEK9uZ+w/UmG1FK052Fg?= =?us-ascii?Q?ux6t0qfwk62Usz4DZ1tH7/oDXe0oPViFD2Lw0oCumJl4kUQs+dsWeRo0TwsA?= =?us-ascii?Q?McrqGoK1YlKwAuqlXJLly/IoKFg7SRCyc3D7Jk0PC3VS4MeuEpedpRWKLlu5?= =?us-ascii?Q?g6drp6Xb3txNT3AWYHQDqblFQHAUrupRwJ6pY972BE29HfNIgr3tOXBxTnuX?= =?us-ascii?Q?8vWh6s289dqemvyd2C9E056A5uZwaqG5OOFA/o70GLAe850G8xSIHYtHn5pe?= =?us-ascii?Q?A9WI3A+eUq2GKdTueaQEhOJmTlLux8OcYlQxstu9/Od/ICg+5frSkNwB9bk7?= =?us-ascii?Q?V5BI6ueC3kO18K3mISIfrYWiL5lFzR4L1jmrYKN2PJEPQEPv2szq/p7S3EDh?= =?us-ascii?Q?5J5AwiJNqQKprE15U795AuOShlYeTq0bqHK7AmJVfGnvwCJ3KPfZeOO5uhmi?= =?us-ascii?Q?UNjM3vyKKDNKlYy1a/Kox9fomHm7IrVw6m8fkj0WyIKrejmU8w/0adbL7B9L?= =?us-ascii?Q?9An4P8culZzvfsf0WR7bmw90ExN+qAJSBejITj2bR0gyUTFCGewg1jTV1g5m?= =?us-ascii?Q?VbTL02CFbT6OPSvpNCUvKL3JHbVPMiF7pC1T88Tnt7qkS+U9aKd5BJSgGq15?= =?us-ascii?Q?nCAy7TqCE28zlHD4exQ7jpE9eM6l2wcPlRgZUSuVo9islsc965D+OB5y9Goy?= =?us-ascii?Q?W/qCcEe6p5yIV3uoXwiXkfTsQcsEbyAoMwtuo+AqeaFgNcP1cDkSSSkAfYIg?= =?us-ascii?Q?ewnlSzMt7+ZS3G5HkhOWoz04mSvEdYrWkoWzrKScy2N8y5JOQaX5LGJcIKv/?= =?us-ascii?Q?/UvsKzU5C6l0PfFSexFjugXihsTelid0N8lIrwAp/DKlUebMHHQbilOaYey/?= =?us-ascii?Q?9hRXA4zWpMAS11H+EnDEGSV3Ulz4kk8pbYfXyY6V1qhcCFm8kq4aGbYgayw3?= =?us-ascii?Q?CJ2GaUZN/2jsqBJqV6CDxoWa/+rNk8Dovc75HUqGXyN1aqY/A2hSF25llUhQ?= =?us-ascii?Q?rU2nMTp8eDd/8wRJjDQpBrcTxqYoNy+gi/qbS06Lu6SYyCK3pJ+lDNXCPpwh?= =?us-ascii?Q?SA5VYsJkRFEbxq0yQc6wUIXYB7LxLzEfkyeyJzFkJThL5B1+mBl+UpXaRtlF?= =?us-ascii?Q?bmpMC/iCkRml38borQMoEKiZha+976PbqeQskoinM0O8CUCouVp69TPE2QYt?= =?us-ascii?Q?S2zBMc4HG41wtBF7WEJRvA9+iOS6PVgHVcouThDoaneFRguPhobJeA/HVixP?= =?us-ascii?Q?I0PT8Hqe0of+hVP4VaLjPx0Ge7ngrCcT59Chsm20qXzigAeUJE+lDCsg5PhS?= =?us-ascii?Q?UN3FfCWmR7iNtjAoFvcnKdxBveg1RGZxt25pC3Jz+G30Czvs7rFXokUe/5bD?= =?us-ascii?Q?GUABc+AaWNSH5STv/IETSsRTATXEfSDKYscfQlxXWpkelZDOKXhZ9Hr4xQd2?= =?us-ascii?Q?AM1e5Q3ZyBGR3LqNV9BQvOA7lyt+XMnX356+iNLHDT2AC/BFfti58wHSYtcd?= =?us-ascii?Q?6l3+tVQgnICjVuE2Ci+ypyqFPAEqXUC3MzCmTVQhuDVEXmBJSxwNq0RSazE8?= =?us-ascii?Q?OscjWOiyjnrlq9nud4ErEIPCp3SOcm0TpiQ5N+mTyM77M+eyYL2dZ0GO+avL?= =?us-ascii?Q?rg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ABydXMmEakkT2spyjsxEHN03gdy64j6IKvMLTIgvnO9yiSszIcW8n/fP2TJswEY3VtXVVRMdA8rIXrhAMu0rnJqwHSVKEh8kUhwtfSiif2lFms5kFH1kagIMZ9GfVwssuCcWBmTgQv/KYidOo3Dl92oTWMnRruQsbSH/Ke6X5IrG0LdcaKBm5TIxLwATVNHhDZWjNu5SoedGvkpVxlkSqH7MdBfc+Ce8otw43c4QDv6OvOvQDu2jU4Iku3UdUunxOUV6cZZmums5JGeV1ICGcfXlGVHSOh1uXRqHc7rcU37k2c/Nz1M7KTbQn1AS/bZy4n66VdRiiYo6LKvqBAIZ/ndJBEuqiMEE0JUa+HxSBRFg29gV0bRHeAi6lv97AQJ8zV3kStxLO2RON0LKK/8DbOOYQmRDDDKN9RR3Nd4zvAcMDFdSrKlB11dLhNohAhfNGfBYMtHQxKB9GB4AR+xmIZ7GBj6oZDYt8O+iFzanOYiWmSgCGqeKUwq/WwjFYAZjgvUpX7ywkKaA8HSLqtQlWHnQP4TWcWsrxkKw5Lx5/NOOFoknxjD1Qnagz7hf7Z2L5aY5bX/L57oTjWnZUsnaUH64qrvtDVTVK1bA3Ce6Pes= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77f4aeca-5eb8-4623-2864-08dcecb8d282 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 01:29:33.0512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nADpHb622EgjH8opuRlKxzZSpIYTsqGdL1rGMAks6l45bM340ageqs+5Mnbq+ipTbXsJ7xcPyqi58DPQkDpfZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4744 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-14_19,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410150008 X-Proofpoint-ORIG-GUID: H3obrLUNX2Hv0Z-qke6KlKzaOpadHDXV X-Proofpoint-GUID: H3obrLUNX2Hv0Z-qke6KlKzaOpadHDXV X-Rspamd-Queue-Id: 1A00880006 X-Stat-Signature: qe13qqhs7g4yaz61kgd1yu9663maxzph X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728955765-935328 X-HE-Meta: U2FsdGVkX19dWsca17wJqhMIUWrAC1p69HDtvqxcEbdeoAdUh8wL0sNm5KXjnawtAn5vGxPa3U3VR0Dm7bobXw68euYZVn6UATz2FsnjMi6GkBINmvIhh0UM8hdVdYxuHUOwSHfI+QW53mrL1SU1GAZ0srMcGsTCC1oQeYDrCZNmOoTpzi+5O0buoSzSdpKmWL50nJdx7vNZeZlHxYKAxFStbjs8El7/MWNDrtyj1yTWvnxAEVQeHb7SvJPIgKrFHKlbmLzemXd/gXcMAnFmAajpLOJgpFAfWT7SfmLebcmopsdCOLXIti15jE2VAVOT+UNtLzLLKxDgxVs6we8FTX7Neu7DsarNLa+JCQYIowK6XPkHLMrulVNls6AjqVKxDfTiIOnp7Dl6LF1++GSejUOMpPw7uqRFaIVmC3dBLTaRTV0Ik84rYPVw5RGNUos/QMnXLc8Iyw8JLMmf+lAV3Tvy5brsLwCJdpbdFgWQLYkqT0lt68UbmHwXx+8EsRlpPFuSvXcAKLmhgE6cCTaVcpjDmwgdfxvODYZ8XNZAYR++oZqxJ1wTfxpmg6CzbHfS+0UrSQca3wP6PT6M+mSDk5isPiBkn4WI70+sS1F1CFFDYTX6EHVfh1cD6RlFo6nbQNSMw0qUyKztKP0XS6uiUmLLPlX3GrpvXqASAHhtBlbMXkurkkeWiAWW5f0vaanhMwsQiuYEGFkkuY42kinVpMhm+vaQOmvW4FRX/QEqLxoik4W4UtEajen6hIQP0+uMzTW1Pnh71liUZO99WEFlOYhG41tbX+/T4Qrjov2pDHBxttWXZWRP25XZqc82kfYvKzinffq+pvB0o48Nk4rdPA1Jf4EjJZj4Uk90dBMjGOQneI2bAZBqKgD5cC++PyByND6g1umzlNJBgXTyt1fxEOZYqBZCdjT5r/uQyghlqVpBFNoaH9Zl+/cPIHanOmp2XyUYQs9gQH4KPC5W6aG PfStL/z3 v8nlWfWZQMxGOpFZhcRcqufC0OhStOH6gBcuPDVKiYkdDagK61jz5xhFYziWh6EudlYi+/pXyGG+RUtu9D2w68ljbSZk/2colBKZrjaw+YPZtVMsAlpk+ahPR1hgEs6zlB2A++k+t0zhO7+3F2fRQMe+XaWlOEWMT+bW1Ms2a8QLWnpQ4OcWwQXq1Huni1nVj+mIq/lRgm4SFUg1MBt+1IpQbDkCCbgdO9C/GTAqCLtnn8c3qYKo4I5Fp9jzVObtdbAlQIVZCTfkxopMv8TVo8JM9oec3nR6JzF+8cw0nADQ+PxxMLaGOFS5RZIsoCElFo/tgnEhR3o462L19t24hybLRND5h55fwv4DVeLzmL894F7e6wb9SaATZUlkK5tcOWiE43MsUdsEV0ekl/LpeE7sLiAfn+Xs2jTiS8etA+eJPrc30pEuQSGK0NpV4NexQzk6wrno4fjxPHPU5WIbusMMwRo0PjM6j+ahKMrHHZdJJ+37RHuZVNrz9aX85bkMkVuzGuXJrqV+g8II1i+ZC4Qv9RZTJ0xnAykw1hIvVn11jJA1bhDAP7N6D48QlHw0tGFrp3Gb0AeXGiDR1xxh1T0kAcS4u8sbI3O9ZJXZqWA7lUvlasT/c3CAUCL82shLU98PzMbAqZNfp+GaBfNlu1SM2V9C/sUAbgHtJUQFFKaOX6nz67VJj3Yo0AQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241010 21:27]: > > Related fix has been posted, but not merged yet. > > lkml.kernel.org/r/20240626160631.3636515-1-Liam.Howlett@oracle.com > > May drop this one. Yes, thanks. This can be dropped in favour of the other commit. > > On Tue, Sep 24, 2024 at 12:39:54PM +0000, Wei Yang wrote: > >We got an rare case when mas_node_count() would fail even there is > >enough memory. > > > >The reason is the maple_alloc grows downward. And when hit a full > >maple_alloc, the max_req would be 0. This leads to mt_alloc_bulk() > >return 0, which means failure here. > > > >For example, here is the test code: > > > > expect = MAPLE_ALLOC_SLOTS + 1; > > mas_node_count(&ms, expect); > > pr_info("expect %d allocated %lu\n", expect, mas_allocated(&ms)); > > expect = MAPLE_ALLOC_SLOTS * 2 + 2; > > mas_node_count(&ms, expect); > > pr_info("expect %d allocated %lu\n", expect, mas_allocated(&ms)); > > > >We will get the following output, which shows we fail to allocate the > >required number of nodes. > > > > expect 31 allocated 31 > > expect 62 allocated 61 > > > >The straight forward way to fix it is go down one level more. > > > >Signed-off-by: Wei Yang > >CC: Liam R. Howlett > >CC: Sidhartha Kumar > >--- > > lib/maple_tree.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > >diff --git a/lib/maple_tree.c b/lib/maple_tree.c > >index 1cbc5f7ca40d..dd33d0793dd1 100644 > >--- a/lib/maple_tree.c > >+++ b/lib/maple_tree.c > >@@ -1253,8 +1253,10 @@ static inline void mas_alloc_nodes(struct ma_state *mas, gfp_t gfp) > > } > > > > node = mas->alloc; > >- while (requested) { > >+ for (; requested; node = node->slot[0]) { > > max_req = MAPLE_ALLOC_SLOTS - node->node_count; > >+ if (unlikely(!max_req)) > >+ continue; > > slots = (void **)&node->slot[node->node_count]; > > max_req = min(requested, max_req); > > count = mt_alloc_bulk(gfp, max_req, slots); > >@@ -1268,7 +1270,6 @@ static inline void mas_alloc_nodes(struct ma_state *mas, gfp_t gfp) > > > > node->node_count += count; > > allocated += count; > >- node = node->slot[0]; > > requested -= count; > > } > > mas->alloc->total = allocated; > >-- > >2.34.1 > > -- > Wei Yang > Help you, Help me >