From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73C0C83F07 for ; Mon, 7 Jul 2025 15:07:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 604126B0205; Mon, 7 Jul 2025 11:07:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DC6E6B0206; Mon, 7 Jul 2025 11:07:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A3716B0208; Mon, 7 Jul 2025 11:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 378006B0205 for ; Mon, 7 Jul 2025 11:07:06 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E2B041A0184 for ; Mon, 7 Jul 2025 15:07:05 +0000 (UTC) X-FDA: 83637796410.30.AC54F11 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf13.hostedemail.com (Postfix) with ESMTP id 5250420005 for ; Mon, 7 Jul 2025 15:07:02 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=UTVkAmJ6; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=XCdBAEUZ; spf=pass (imf13.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=UTVkAmJ6; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=XCdBAEUZ; spf=pass (imf13.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751900822; a=rsa-sha256; cv=pass; b=YP5dySIndthkfMi+hpEhEzA+HzfHpIKpN4DPyTxbQFJnqoYseH+ckC0UE62rqKXU6fT6lN Pi1Gc5LKVqiqrarYe46V5nXdTrwHQ7lBDsILvXy0DgMfjI5qPwU9eiyMiibxDfKomLw9In YpwXjzcuWcxJzBSs/4EnUtVdiIP76Wk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751900822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C1ipGexrFEDdukyi236/6lyoYJOOjU6mJVa2blYpgxQ=; b=NT01ixPT6WmroSJDxCrJFtj109C2jBgcpcKD/jp/rBZWj7sv751OeZ6zq3H8rrAG542SQc r0idAlwoJjFdbL50jjNIsQmoUEHMAUFhNlHeXgVTeRnhuERdxkwy690V4q6D21LNqyJy0H qz3meMZH/JoAwFW1vbpvzhytoqHxHzw= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 567EMoBf015989; Mon, 7 Jul 2025 15:06:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=C1ipGexrFEDdukyi23 6/6lyoYJOOjU6mJVa2blYpgxQ=; b=UTVkAmJ6PrxPCPl7Znv8qbs1imXU3mBXkP c5PVnPoGNndGYeSJ1hObsJwkY3dWd5l5JcHS74IxUXzwTOFn/jrmVhu8GmvZmy5J 97rIUnrPVCsrvAoZVlhvFm7EUw4dCfy4MxplRvkL37X2j0stSvGZLOQUOiRYbOn3 E62dAHkUB2jKDleUqJ9VhyaLyi1mmt3DKxyzSoz0Gd/eZdh8nmFvZ8k0/j4c7R5Z dDVM4jebFOtItgw+pXUuQ0s09v9y4OGcYBuO22/8qHkr/bSz6PN8hsCytS7g1oRl 12CZDJHTiXCCJBfdoFABYyL45q14atgj/eMneDQ0gjErC392jnSw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47rfxgr40w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Jul 2025 15:06:35 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 567DRaW3040566; Mon, 7 Jul 2025 15:06:34 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2046.outbound.protection.outlook.com [40.107.223.46]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 47ptg8m37d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Jul 2025 15:06:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yQRjGQzrspQm7QztwSx3rnxAUJkcXJ/qsG1AONPhv811m6GuepQMioueYbli/zJX6D7m4vfZYgmsaupmM0XJfMPxjuAO3wlwPsLIJKuMj5AmyhmYTkJr/ywWY5ARBJl+m+G87WtqC+6ituhLKiWX4MB1pwBgg0yBBzH+xyfzZvDfBnWAWSVhjLW8anUeH4mt0nKKQBHTAA3SyyUFNTfRvnGrcUv2a9Sn3Fey414OxS3js1ZGwhfcvMdxhGybhdviDqK2Bpb7eXobVQ7xepGrDLtitn1grOfpL9JwnnvXv8u7DqHLEfTSVJUdOr/uXaud9h8fNEjgKBnuXs0w6JgOig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C1ipGexrFEDdukyi236/6lyoYJOOjU6mJVa2blYpgxQ=; b=l4On/eVzMifWllCZB2HyvB9v2FU9tLVHwkoBRLy/A5/Fm6ziWOjZmdc7qaMk/tJn0hsZo5rcz8h0VyrCYswk2Wf8pQx3GA4n5ZUy2KicG1uWRmeFfXheR7vImkLLBXuoDR/uz8F9DTHpDByG1GgyOoHZxhMtElJiJc5STcsFYA6CYTDtgjt8NKxJoowLHRwa5gTJl3zaSh51yGcTXbSk7offvD+GYsgbIpiSdSXlYo6/zz3Baz4k9Qxm494F+oIUiDY60CsxjkNJIS8JRe0LCuIg+SeBCRs0bA5zabQsgkLlcDn8tSkv17Of+3Slyvx27l/8lDCx7t3xEi7X9TFuFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C1ipGexrFEDdukyi236/6lyoYJOOjU6mJVa2blYpgxQ=; b=XCdBAEUZQVIqB34WBp3RGZ1F78rYj3SILgYzW6DnsG/0Ffsc8Rc18IJM15KIJ7lSzn/NzFCeqMUbyJaDLVGofa6gE0YqUtsGjNSedpYXhwJjDS/StagXJT1/XUsi7kH+PlLJuDAB5L84pUyp5wetJjaBIcRBxLUo1e2yqmlY1YA= Received: from PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) by DM3PPF905D77450.namprd10.prod.outlook.com (2603:10b6:f:fc00::c37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Mon, 7 Jul 2025 15:06:30 +0000 Received: from PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c]) by PH0PR10MB5777.namprd10.prod.outlook.com ([fe80::75a8:21cc:f343:f68c%6]) with mapi id 15.20.8880.015; Mon, 7 Jul 2025 15:06:30 +0000 Date: Mon, 7 Jul 2025 11:06:25 -0400 From: "Liam R. Howlett" To: Mike Rapoport Cc: Peter Zijlstra , Andrew Morton , Andy Lutomirski , Borislav Petkov , Daniel Gomez , Dave Hansen , Ingo Molnar , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Petr Pavlu , Sami Tolvanen , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 3/8] execmem: rework execmem_cache_free() Message-ID: Mail-Followup-To: "Liam R. Howlett" , Mike Rapoport , Peter Zijlstra , Andrew Morton , Andy Lutomirski , Borislav Petkov , Daniel Gomez , Dave Hansen , Ingo Molnar , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Petr Pavlu , Sami Tolvanen , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org References: <20250704134943.3524829-1-rppt@kernel.org> <20250704134943.3524829-4-rppt@kernel.org> <20250707111102.GF1613200@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20250510 X-ClientProxiedBy: YT1PR01CA0129.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2f::8) To PH0PR10MB5777.namprd10.prod.outlook.com (2603:10b6:510:128::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR10MB5777:EE_|DM3PPF905D77450:EE_ X-MS-Office365-Filtering-Correlation-Id: 33714a62-a003-4138-3e34-08ddbd67da6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?t/MUs+V/84BwH59BlBjU3rEHWoYIGSM25iArHB2G3EomOppLWZJF94Mj6Kua?= =?us-ascii?Q?e6aQU2E2mmVRy655tts1Jntk5omW7OYAS0UgpxZ1G5PP3TnWZocvAZubp7i9?= =?us-ascii?Q?osjKhaoeWS0kLQ4TZR1Tgx2rtKVKg1rPJZgQQP3+LJ3gh8L+6jreHnco8jg/?= =?us-ascii?Q?Ko6lUD6aFvMkJF/mEuJi3ri6Jv/t+vwGnSStp1ZHlrLsLr0qCp/o3NV3JehM?= =?us-ascii?Q?LBnXYaVUEmlxFFKCBGzIla0ruZoHsm9R7yrlqiLMIpYLOcgDdg/FtH6Em+Z4?= =?us-ascii?Q?Ia2QizhtXaxTWXM+ksIoEi58TjJMh8vj8U8JLiGfZ8xhFCbqXhnEglTKyCDP?= =?us-ascii?Q?OsY1EF+S5gDrF+zl1CmLqTgOINW+vVnhEmquTLV/Kx2WH1NryjgUp5wLPoMg?= =?us-ascii?Q?/VCkXRLGHZhVSJMuBNNNZQk5SIMLeYsBt6ufK/1q5nMcJXBOhPOxJk18Lgiv?= =?us-ascii?Q?HLZptjAW4JnATBWMfDQE8gW4cUFC81aGCxaAJH2gaRwuOW1tXrg993YRV229?= =?us-ascii?Q?g52ltsdJAjjJ11XldfF6WzM/WBdjeaNa0pM0e3KUKpg2Sks69Ar1psFexO/u?= =?us-ascii?Q?SNJKDHJq9BoXzuKVABIiFuEWBcoL+Q32sbaW/UpkB93LSdpP5Ney9URq8Z65?= =?us-ascii?Q?m0dr5R6XNjUiPi/xjKyJ9eW1W4v1UlZv1OvbhB97h7Aa73i61N2qPXQ9Hrj2?= =?us-ascii?Q?2MxvEf5bMV/9LFxLaNi0wh0i2UB1qumnGh1Jwx2/fZYr/4o/ykgqaM1Mt3kM?= =?us-ascii?Q?+03+TRIQz+M0tPJpCMPpTXJML0NOXnesGfjUSHrS0HgmKTaVRfUi+v1Ct+2e?= =?us-ascii?Q?9/WE+6ucPcEChiiy0fDmPOHdTTdoyFIqxTjIDyKcAWnmHvKtXSaX1LVjXFlF?= =?us-ascii?Q?25ZltzJVX924dkOH9jQBCmUmLSvjTpSfQY6i+tPKqIdeLwCrE1NqfEXk07Nh?= =?us-ascii?Q?1xCiJcGOObob57w4N20ZHJhzWfBGW95QMtZrSG1H7fToYqGVhsL7S+lHkWgR?= =?us-ascii?Q?cSi4TLHHwtn07PBLBv5PF6kbMe13cBE+pJ31q6OWuTCY5E2vzmWn+LbF2AJr?= =?us-ascii?Q?V4Q4xoeqZsRC63A2y1fmDxRUG1iMGwluYpeAge/mODJEDTwTEvQK0WDD/k0B?= =?us-ascii?Q?4zY3p2UeGQSn9OX6PXmjiQbXn8ScR2qW/cqGuQQ6Dw+zKzjiE1H33SIhY3AG?= =?us-ascii?Q?PYyW6d2QV0K5hmUyewQ6pk1RZ1VB3McyaO8+LiyfncdcDk7K6IFk74hRcKf+?= =?us-ascii?Q?EkqnERZI8P51+yHikGXeMlKCjrBFEsU4DF1hisI0OkxSoFrtc61tFQEmBqxg?= =?us-ascii?Q?2lIVR/+kQAz6h1HZn9ms9pm7wzJ6Jn1d5daE2DlHUEQe1LHdwyFxiacWx8+r?= =?us-ascii?Q?NItwccETlnUYhTSvr0dhBrmX6htSSkOaupnOo0g7rqvWlY83BA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB5777.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Bt46qWRABvizY7n3Fb7YzP9N287Aom4Z+Vp4e7D/8AyBN5o69WCZWts0K276?= =?us-ascii?Q?5mBoNtSw64+xIN0oKNTFnl2J7fmplLZ3eA1Yc0cfwpubq/0iMybSG+t/mUlh?= =?us-ascii?Q?9UBF6bQ/cyeWEOw4zs26dM9/oyDW9R0A8Gca2Gy//cPJS8qt4uKM6PFDgqqJ?= =?us-ascii?Q?W0AUtALaGfYqSFvxz1hCAcFUuEngjFjfwQInWTUCIR5F8RYeS4F5PbGuU/RG?= =?us-ascii?Q?KoNReHCksMDCev+YzUkU5F8KxgkBmiVMRA/G2lfQ7eCLaoJIIo7PZD7HtwfC?= =?us-ascii?Q?zgRApaTKgTVMYz0Y6JPFTuRRs7jD32ERcjg3zNTn46Fv3y9gQnN1089plioH?= =?us-ascii?Q?u9BDXUDbfU3wqtxD3GShMQHyP395wHuL+yOW694pBD3LPELKiyBYyF7PSk29?= =?us-ascii?Q?vP6Z435g0C0tLCPqaeFUuzhBse/Z4lGrCpQtGR912Pgy4B+0nJebBZm/VyCM?= =?us-ascii?Q?nRsZfvWybt3CX31AQ/Hb9ApCTUNFr22XJjHo0AxJONmye33KR7/UFmmKvZxE?= =?us-ascii?Q?7cSqnil5kRZCTylGidiA1HqOtePyErfZD5qK0nmIb3AQOZqjpl+wFmO9jaa7?= =?us-ascii?Q?Qdxu4tHACJh3JcZ5avpP9P+yOXi1Hp/VEKwamMcaem4jDlHF+YK2GI9Hjpe2?= =?us-ascii?Q?yCOBcIMhzbOKRqmTWU/E3IlH7empIVS3D9OJi0ddm1QzCOgP3hN2r+rbVgfZ?= =?us-ascii?Q?MrAf7t/JAJcylE1hSssANt9kFP1ltwoTcvS3/EZzR4o9rAFsP3+mGoFsFg8r?= =?us-ascii?Q?oBKcp0W16yXjINpPFUAxaoKLj5vP8U73pg4zCJIQ2/bIFZ8P/e0Mfn/tdb95?= =?us-ascii?Q?8NOA+af6XmAOtNVZ2pzJPbh5jE5P2ijZFDmQFwtvVsCYfb78vuT4xfPnTajr?= =?us-ascii?Q?6hVCOjj/EjEMA5qfhZe4OC+uyieXLXXCPR1UFyBwSBvKmw0Batv3hWi+nF6r?= =?us-ascii?Q?t8AtZbr4ZLZskWFk1kXgX70oMcdJXEqw8RE4QGLUlUvxB3QHXPfhlNXUFI04?= =?us-ascii?Q?E+nrND6rTtIvgkZeFX+L89U4/egwsMgaUsjFzOPkmPg+WMNoW2fzISmNfUVL?= =?us-ascii?Q?9GxiiNHgBc0HudHEIGRIqcB7jrAwrFdDi1aJ4vt6nUzPplsqGMXLWSRst+9F?= =?us-ascii?Q?arv9j4v6RMr8ZV0mudaF5oXWp+48W5OuJ9dDBBxIdVAACBxz4rLCoAc/x8cZ?= =?us-ascii?Q?SBSjl1XqE3i7//soH0U5fbmWn0Mc3mtFStAGcyg2vq4DgYm79CYH19JrcoUs?= =?us-ascii?Q?IbeYQ4CY5rzUYBEGNI7kM1jJzY/nAQQ2qIZUBpZoUEH5406BH7JiRFYPjG31?= =?us-ascii?Q?SyZb0SwyS2a/1Nz2EwOv99bOz7fDJR8G20SY8Z4hXbO+bzyuxWs1Q07SsFG5?= =?us-ascii?Q?qmsIMnh2VAmWwVde0D59/jyRsmhLPZlY3MyexoUSDBHub5gol9JvNuhvIOTK?= =?us-ascii?Q?+b9f3sRLNxkfmYQjiIvyeiCYU6nGy3zZhwx/G5EKvzNL2WbNn36pXxTdcIa8?= =?us-ascii?Q?BXkV13XM/nPretMXMTde8xgYgf15PRiB94r1Wr3PBg3hbAipct9kJ+FZy50W?= =?us-ascii?Q?sWC/Ro7ArdYEIgENmmlguK2jz7EakIrx6HYtLG4O?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Cveradww2skkRjUi+dvu1IrncwtnLLIGnU5uSKiZ0PaJS6VqsgCaSBq+RRy45j7I9Z2ThyHoayhB7atx7mB06UZ2tgD7VfTRfa5v2NkjgA/Va684lKcYckgrDBx/jhuUM3smHomcgMJZfmAyxp9AuUeRjlibYpc/6Exa845Y9ZCjxBqTUEylN1HSJoenaA9dYA1q/BWCXiV1DrOjouQPwk3ORBIYywFViPs6jyaGyhPagoMjaNVsuk1yxw3AJbX8Ur0fApMZ1MeNPJHs3ahVpQiayROLMAg9NWEE9mM2bAO2Ns2OxxrdokWMAVy1A7O8rCtV1epqzIXebsHvAav+XSpuoNS4ZKYh6CPWbwSlTLEtzrQu6E+Vd/j77j/+de5jQ/06bfQ9YMhzUD0lSawcw8eHPaDtFL7MqUJ1zaJo4hu2neNBAFEfTULmEpMDioRsKf8rgHC4IwoUc9n6dTMNlt+nn4xteG3H28NR71/08zc7rxfhAK2p205306d44q+u5MQvjVdLtFQPIHrUZtvj8t0Ttby92dTr1s5TvZQGfQom13anL7wX3qcLOpvilRpRfO8txXqILp3/Va/tiLlhnaJ2TvNHi/BjJkbPvOFEuqY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33714a62-a003-4138-3e34-08ddbd67da6e X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5777.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2025 15:06:30.1860 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CH9ELfhVcQSM2L/MtRL5ZZ3kSCPX/R+em9wYxjrCO6QQhSnmgQldgPIosrzqolOWAuZUlESoB9cHPbE7iq/wiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF905D77450 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-07_03,2025-07-07_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2507070089 X-Authority-Analysis: v=2.4 cv=YMyfyQGx c=1 sm=1 tr=0 ts=686be27b cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=GoEa3M9JfhUA:10 a=VwQbUJbxAAAA:8 a=lg6h33418Od_XcSoiEEA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: Rb4_2TVe7vcpZJ-LfBdiOFiXePZV0T5e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzA3MDA4OSBTYWx0ZWRfXyjnv8IrxMeGR Bln+vhgK6QwWWSYHMXHpFYl66ENr4CNyuvw9NAzwpeRKcCkUt47ahtyTvd09FxZBYd/YZJbay4A vM9fnqcByIhk94W+uKhoI+8KVbJoacRGFSUbKMMUlDxQiKmVP1QcEd5NA/8AttC6v8j95t2Rmh7 m9qRE3M/bBKnHc261fNcqOfZe7UjPMeUc819OWhfh6hikDxaINsCC4q2TPzm8fg8vmykaBg5wcR Xtx1hZdxCMs0HAhvhHK3VjNXQuHJiTyyF5cS0ZHLPr65jVbo4A5X5FdS8Kparu4Jbbw/Fj/3/8+ OYLh4YXjr4r1c8cntsb8pVrVzPoY2wL1yrAztJsKFyTKG98MYyQmUQfjhGXSrOQ1ZvHnxNA77kn xYe2PDh8cGOeKVQBQxFUOCpQ42zE+rl/JZuPn6cTGIZqTdNYGCTgpkfywnhupE7eY2TaOwZJ X-Proofpoint-GUID: Rb4_2TVe7vcpZJ-LfBdiOFiXePZV0T5e X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5250420005 X-Stat-Signature: d3tser6kycfgo58u8sbqc9unjunupidr X-Rspam-User: X-HE-Tag: 1751900822-15296 X-HE-Meta: U2FsdGVkX1+F5BTmzXSocZaoDGqFEZZ2R0W7ShozpH5WdJ71z2Rq5LYuSAuV0duIP87N05vz6hcg89thNrfWHv+Vp/AUzwOKkA09TliMUBLCHRzaeidvXvZ3NI48gvcCLcz1Ph6KHcM254fQm7bcOxeqZL9KJ+8jwxP43XpVlPea8ykPCOfiqhLodp48R7QmOUcq3qoWNDMBVNJ5xSQ2pOKnn8D1fZi7ivOrVLhtaQysQzVNSRSXyujMsiSVEeu7l1qFKEXYS2obgFjvDIb4eXlyjeEYE/H3JzYIqombRAtbgjcxjhXKrt+UErDAL8y+tFQF38jODXErSC+acPUpoPmTeMXc5/Ok2Kiz4NXpD+lr1geYlyEJ1oBwAUeJYbRvbvxFN8jyXfdxndQgNPCUGVPsjzU+cSWmVWPTmHSooKANNcXEUipSaqu9e0Pf2uj46rvJwcrRsv+56nxlGdVmoIcih+MqIxsaqxDkXOBdBMiiDQTTdXOpgHvjIxRbudSSJAmZD0h6mVqqPo+phoCkV99LfEri6bfTUMusWp3lrS3/tJLIrGC3xoKZ9V56zJx7Jd9lG8sIqn/4oQfG3KUdiFcR41Prv2/ZJIre6z7XLC/yPViW+BkurM4hl+929fkckxLuuDSul543fHQFpYH1+BBGJYHRSEMYf70WbSx37uhuvOjfLiRjTyVCUKeBhXAQmSV/YyeQwWkeuw367KJyzi6XXb+AoIOY3QD4jnPoo88VUrpJdS/5XneQ1dqakPpo5MKzYZoSZJLIRCZoSi3Fgo7qIobMM+0N7uoB0lqjmET8tBValNE2F6H356uRk1F1z5irrApFBhd9T+vp2AuD78Nk9AviDzmP609x7O9iNtlyiOf3/if4jPNNgYMUMeLkwqSIIbOnVyY1jOffad5LeIjN0OXDwgBqKhrBdyFRMav4Avo9/wIwNycQYQvTA+iGEioCXS0+oV+uuEfkxwN rvo3euk+ PIllvhNkqNwljTV7n4yRP67YT8tFTf5JZeHzNhooYnBlBUe6x88sSwbT3/1sGm2oFJnDDptYb0Evv60t1FGkf2hJMDXiW7LGBBl6JWgwK+Eu7Tjzv4mzppxYBXdKhfGoWxFo3YfaNa1O18cCY1wHYSBALe78KoyN65b0EfCrMt8uFSWOdlySn+R/OLbTjSstrkd3eoW3vz/u/JkXj/JIUX7gvzR+Ts7mwRXFbkXhBzvF4TIqhSwPjR/E6umG2Id1L8p5VEmie5jaWzzXinb3U5h+xRSj89ur0HSYBNK4t/opiKShQyE9HrYAzuMrNUZ9JUOZj+VjPrX/+QsJG0TJeUj2H0+3pi+lEDCUhHM0wj8H4X++vMqR+HYZdk3/FXJy4ldS5k+ZEkkskhRC+lsGZS/FeGu9UvDFlO7/Dks3N0fcscbfVYkDRKmx1z5UNGtB8VIYipnwZUD22B8grRMVbHHKhri+YoQzqRt3/UMMnbKnBQYYj7wWHeRPiuFVwitEJh2TxY8/O83FhpxCD4tK90Zp+ZPJEPeOENqudnObUWU+BROB1W+yCaV+N5Na3rk7g26EiBvWdzAbqU6lBf6H7eCxZElqBw0TjgciDD8JyZozMIukXeqVDPYpqE1/xDcTS3x2cBSFVnDARgczkgV1dfdwTitW7/P7oO3Hu9bU18kGlBCs54W7GMXRV+0jxoL2Iwkptvn3aw/KLSu8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Mike Rapoport [250707 07:32]: > On Mon, Jul 07, 2025 at 01:11:02PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 04, 2025 at 04:49:38PM +0300, Mike Rapoport wrote: > > > static bool execmem_cache_free(void *ptr) > > > { > > > struct maple_tree *busy_areas = &execmem_cache.busy_areas; > > > unsigned long addr = (unsigned long)ptr; > > > MA_STATE(mas, busy_areas, addr, addr); > > > void *area; > > > + int err; > > > + > > > + guard(mutex)(&execmem_cache.mutex); > > > > > > area = mas_walk(&mas); > > > + if (!area) > > > return false; > > > > > > + err = __execmem_cache_free(&mas, ptr, GFP_KERNEL | __GFP_NORETRY); > > > + if (err) > > > + goto err_slowpath; > > > > > > schedule_work(&execmem_cache_clean_work); > > > > > > return true; > > > + > > > +err_slowpath: > > > + mas_store_gfp(&mas, pending_free_set(ptr), GFP_KERNEL); > > > + execmem_cache.pending_free_cnt++; > > > + schedule_delayed_work(&execmem_cache_free_work, FREE_DELAY); > > > + return true; > > > } > > > > This is a bit if an anti-pattern, using guard() and error goto. Since > > Good to know :) > > > there is only the one site, its best to write it like so: > > > > static bool execmem_cache_free(void *ptr) > > { > > struct maple_tree *busy_areas = &execmem_cache.busy_areas; > > unsigned long addr = (unsigned long)ptr; > > MA_STATE(mas, busy_areas, addr, addr); > > void *area; > > int err; > > > > guard(mutex)(&execmem_cache.mutex); > > > > area = mas_walk(&mas); > > if (!area) > > return false; > > > > err = __execmem_cache_free(&mas, ptr, GFP_KERNEL | __GFP_NORETRY); > > if (err) { > > mas_store_gfp(&mas, pending_free_set(ptr), GFP_KERNEL); > > execmem_cache.pending_free_cnt++; > > schedule_delayed_work(&execmem_cache_free_work, FREE_DELAY); > > return true; > > } > > > > schedule_work(&execmem_cache_clean_work); > > return true; > > } > > > > And now I have to ask what happens if mas_store_gfp() returns an error? > > AFAIU it won't. mas points to exact slot we've got the area from, nothing else > can modify the tree because of the mutex, so that mas_store_gfp() > essentially updates the value at an existing entry. > > I'll add a comment about it. > > Added @Liam to make sure I'm not saying nonsense :) > Yes, if there is already a node with a value with the same range, there will be no allocations that will happen, so it'll just change the pointer for you. This is a slot store operation. But, if it's possible to have no entries (an empty tree, or a single value at 0), you will most likely allocate a node to store it, which is 256B. I don't think this is a concern in this particular case though as you are searching for an entry and storing, so it needs to exist. So really, the only scenario here is if you store 1 - ULONG_MAX (without having expanded a root node) or 0 - ULONG_MAX, and that seems invalid. Thanks, Liam