From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BC76E7717D for ; Wed, 11 Dec 2024 20:45:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B74086B0093; Wed, 11 Dec 2024 15:45:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B23F36B0095; Wed, 11 Dec 2024 15:45:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A13226B0096; Wed, 11 Dec 2024 15:45:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 836686B0093 for ; Wed, 11 Dec 2024 15:45:25 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 038C881331 for ; Wed, 11 Dec 2024 20:45:24 +0000 (UTC) X-FDA: 82883858148.04.6B18C4D Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 25C12120008 for ; Wed, 11 Dec 2024 20:44:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZShGqhjR; spf=pass (imf29.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733949898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w7t+KorEtSawtI5MSpoIQmlEIOdqN2q2ix3mEzFEVRs=; b=4JAWW5gcY/2gcit1pin4Ff9okxpUY4f36S/pxBPfHHI3wLVe0FUdEQZM8FELG+0wh4Il1R CYKa/TPlgzBQBzHn9cg79my24z+TAA7jEEXvyqMTV4SZg+glzC/PsjuHrUfjlOV5SyWWpW 3Izk/VtRDo7EFtDwjZt+js18mCXQDDU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZShGqhjR; spf=pass (imf29.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733949898; a=rsa-sha256; cv=none; b=U9e2DS4fErOjfIcBNbdPPgSbWTtZZNV61sPT4Mmv1E7sBQWrClAoMDjSegYv5Fv/IlLgNs cewo5frDY6lB9vOnxLZ7A1gJlApTAJk5JFpA7Pp7xhIr9S2QI+Ig++LDR18weqsdqnn36o fZ7q+frBV4LFulx3C2qW7R05aQNFFQc= Date: Wed, 11 Dec 2024 12:45:15 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733949920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w7t+KorEtSawtI5MSpoIQmlEIOdqN2q2ix3mEzFEVRs=; b=ZShGqhjRRetiCdBj+MmiL6GOD9OmmWicXoCHHVHgDfHNAoy8aJrCIFonrEKRftLNLOweHL JRfUHvz2WMEDQ7T4GukNikeovUnXjs+N+QHoP1uebhRgtuCKhm9NMHCd7odz4ZW+Zbm5kE SHXSoU8qSsIsNocyhw30ygtWTQxq7cI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Christoph Hellwig , linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , cgroups@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] vmalloc: Fix accounting of VmallocUsed with i915 Message-ID: References: <20241211043252.3295947-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241211043252.3295947-1-willy@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 25C12120008 X-Rspam-User: X-Stat-Signature: 1dwt8a41cxnh89shxjb4qzimih1ur4kc X-HE-Tag: 1733949889-967614 X-HE-Meta: U2FsdGVkX1/pFDb1lA1ZL935qkiQd1TrlMaprIFi7ZDJhK5JvE+g55DNT9JsMLq3ONm053LzGt7QBjt6j9vG+byfAaART9+jreby3MKB5XwZG5hHHSJ1ySyyu+d2CI+lRcXTvhJN/ojX1otkdzvNAJFCAy+Y3vp1lmD1c15/FgkkKVDJIOLvogY+7Hsh0BmsOAj4jigAgznqUwQ1ietJw57itf4l0OSWCcDitxJvoHCjY7mIU7O2Wyq6DXwXP46cv+VoyVQ50DYWoCcox7Mw3dhwDb5XI7jB7qO9CzyyTBptzZHMbX+dGWy/5BweMs9+eEzslG2oLUl1RAzUFo8gyhfpsqFmQ5oBTv8Fo9GTZg7zvnr7jjEX9sT0Omtcip2ghsndl8ri0XtvA1BHxxqi+uIJes3g7vFBkP4qkoL3bwQOBp0m9wqavmNJL0g0YprUaKG7KYzrAgfZdhnXpKfjrcIQ4U1wcEBFoM0mrecMRszwAA1nhpklW1FsVQDWjQob49S53f4PDNckz/3FnIF5lGSitX6HVHDxqKM6UcE9N0jejwtvDYOVWWxFZGgWsDSISCmkvZlZMh02l35UZAxjR3EOHYMnr9IkrktatNpch9TDbfeO8sUSlLkEmrJ0rq6tSeW6/JPkoqE7+aVtoAFre1cFQFhUkjq+t+KOteaAEpYZob5MxXYU77RFK0hIxltDAzYNILUO7/b0hReUwuRVYF/34uZVai2YvEGntskXBdmthaPttjK4Micr+6JzT0YCOSXX+3qgAu4daz9iLT3RGxXA5CUqSoSUTGAOP2NsIMX3aMqTkS50sl52WBrdrj/SnoVckMEiXvJc78qPYAvVX86nVsHun9Umtm7gTQHP0HeInPO2RO478KlKNCrYevQfS789umqr/hy3UmdvXuiSPeJN+K5W5jE1TyMSYc/tNTghRFgtRsHh9LWcs2fyOvAvmjh+9D76lLqbk6kKSnK +cD+o64x +lEtq6nfYykpELCWiwUJn5xQOqdITVktbZvYctKTm2Le/20ps/Qd+xmz1buL1lXdTi1/0i4lUYxosxaX8yQADwCdMmJ3Mad3lXkhu3RYPcCSXK/vthJv3GyCv/anm8utZs+N+MO2RM1e3JagxiYvx+/ZKGsn1yJomV2zZ3FY+EKrpZXf8edtGwHCIcrL3iBV8z7EqJQbJq5A8JoMPAsz7EyGcHI6JupErK4wc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 04:32:49AM +0000, Matthew Wilcox (Oracle) wrote: > If the caller of vmap() specifies VM_MAP_PUT_PAGES (currently only the > i915 driver), we will decrement nr_vmalloc_pages in vfree() without ever > incrementing it. Check the flag before decrementing the counter. > > Fixes: b944afc9d64d (mm: add a VM_MAP_PUT_PAGES flag for vmap) > Cc: stable@vger.kernel.org > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Shakeel Butt