From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD1BC71136 for ; Thu, 12 Jun 2025 10:04:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CEAD6B0089; Thu, 12 Jun 2025 06:04:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F106B008A; Thu, 12 Jun 2025 06:04:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3952C6B008C; Thu, 12 Jun 2025 06:04:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1F7766B0089 for ; Thu, 12 Jun 2025 06:04:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E4871D76F8 for ; Thu, 12 Jun 2025 10:04:32 +0000 (UTC) X-FDA: 83546313984.30.58D8EA9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf02.hostedemail.com (Postfix) with ESMTP id 58CD680006 for ; Thu, 12 Jun 2025 10:04:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e2TvbBmT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="APnNyG+/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e2TvbBmT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="APnNyG+/"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749722670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y/1XDCp8OYvA+z/UwMP73ZXJFEOA8NUW8dP0h9kaHSg=; b=GsVcBSE6+K1R+oGedIZWQrWd/gX9767KYKD9wQjn+PlXL0u5hwRyYg0wThZ08IQIbwP7WL W1+v/GUeblZyDPPiW2DQzmMEkcfwWX01kkBPbcWKcV6eDfIJQx3Ds0TpH1UIv9Jp2yx5zp 8htDcMmtKVcNsxLkI/AIW5Q+DLFFK3M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e2TvbBmT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="APnNyG+/"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e2TvbBmT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="APnNyG+/"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf02.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749722670; a=rsa-sha256; cv=none; b=SSnbLeJ2QJjO//N6hZ/khrwF4AMgePhsRsjk8qRuqODOsGUHKov5pd8dFhFrj547uFkP2c HegW+LvCXT2WDQXQf1AWiR+QTmMv7Gc3UnQGydfSJJ5BZ2Us506llvjXRCJOayCPthnbxN bq7P1kJp5R8QVVBPD56PfE1k5PRpQhY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 943781F78E; Thu, 12 Jun 2025 10:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749722668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y/1XDCp8OYvA+z/UwMP73ZXJFEOA8NUW8dP0h9kaHSg=; b=e2TvbBmT7qvjnSUmPy0aoqTJ4Xkn288Soe26WsexCH6VJT4Cr5ByDKa6XENAHlB5Wy0mYv MiBlgH75zqWei+0qQ0ojiMstCKkYfjigBr/tMGffbkwNGMnJJ8Hqyz+Sa/mflVtXwnqQnT mUDE5hNdUrxkAJmdRvZPgIXb+FBY0Xo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749722668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y/1XDCp8OYvA+z/UwMP73ZXJFEOA8NUW8dP0h9kaHSg=; b=APnNyG+/RJKg54lRj7u9CqnuK6TC3LwbAOrN3GFBMcXpF04O33ZwNX9KunKNrQxXOJFi+y K5MioudQorDcqtBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749722668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y/1XDCp8OYvA+z/UwMP73ZXJFEOA8NUW8dP0h9kaHSg=; b=e2TvbBmT7qvjnSUmPy0aoqTJ4Xkn288Soe26WsexCH6VJT4Cr5ByDKa6XENAHlB5Wy0mYv MiBlgH75zqWei+0qQ0ojiMstCKkYfjigBr/tMGffbkwNGMnJJ8Hqyz+Sa/mflVtXwnqQnT mUDE5hNdUrxkAJmdRvZPgIXb+FBY0Xo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749722668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y/1XDCp8OYvA+z/UwMP73ZXJFEOA8NUW8dP0h9kaHSg=; b=APnNyG+/RJKg54lRj7u9CqnuK6TC3LwbAOrN3GFBMcXpF04O33ZwNX9KunKNrQxXOJFi+y K5MioudQorDcqtBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C0C54132D8; Thu, 12 Jun 2025 10:04:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CdvkKyumSmi7SwAAD6G6ig (envelope-from ); Thu, 12 Jun 2025 10:04:27 +0000 Date: Thu, 12 Jun 2025 11:04:18 +0100 From: Pedro Falcato To: Dev Jain Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, shuah@kernel.org, vbabka@suse.cz, jannh@google.com, pulehui@huawei.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, aishwarya.tcv@arm.com, broonie@kernel.org, ryan.roberts@arm.com Subject: Re: [PATCH] selftests/mm: Add CONFIG_FTRACE to config Message-ID: References: <20250611121011.23888-1-dev.jain@arm.com> <7ffffef8-d2ff-42ee-8a1a-da208109ac2b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ffffef8-d2ff-42ee-8a1a-da208109ac2b@arm.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 58CD680006 X-Stat-Signature: 6setexk7hhtjoesckfxkdzocaxfxjs58 X-Rspam-User: X-HE-Tag: 1749722670-315879 X-HE-Meta: U2FsdGVkX19upP06p3Zkar3klMzFQwPWiC5IsTGeMaECrPrC6h2mnrjcQQ5ZMmKOFTwmrca8MtyJKQR5/QmFamyqj5VpKxQHbJCSaCFNBogl4twRZQt+85YFmFc2ANjIcwgjEkn373q+J2uqyhSwNp68i7sWZkl7RDcH0qkg/pF9k4oziIQsfYB35YedPUDFNQXCPfAQGMU9qyLfa+ay/1A030I3+Zfeen1iygZJ2KPHzFPmaCtdnzVsklQPVDlPUJ0J/Wspl/AK/qcAwRpSCHkxCetXF14OXYHHhk4LdTb0oSOAoM6SQ1hLpLjS1klZ+1LE8R0lPkEcaizpLh8MmzAFVTwxMHECoURl5W41ZKaOd0MwxaBWpwin3fFOU7hHOMLgh/gD8jGiyYc3K4TZ0cA5sEae8c/dzKhSGCf3zgWbs9yDrngyY4tVK/Wqgdn8oxWvgo2H9vY9Yt77xP38g73U13jEU6j8VPdVUQiOGGUbgm17E885sUGNwXUTuNIn07WkujWkE0avIiIXR2K1ZrU1B4cNSMMidROrmX9WUA5o0UQPdCSEomxz+AbC9y/kPJs/W8QN/JtIxxNCO7rOdpVnr+1vxqFi9WfhCheThZiaB6rSR89IZALDzE+VKyuSeBmfcyHOyWzk1wBGcu+vJYvcA8tjiy2SQjCL2kicvrFQVJvyt6N1FXKLoP5NNyRT6DauIKE/sHkAhpE3OSluZCGWEs5+cGjOII18lD86ron8K6k0dUffKgOZmYGBjuj3ldNRJeEy533eSx2v8OITgWepi3INoMc296Jq6UHd1PA7n4LNCmUHleCcgSTe+PRjFxLfNFi2kL5C/WGo4NH6lWloM6CDaJ9gc6RPX+KoI5KcbflFk5h+1MSdXDO6jr88Rmf0u2u++sk+bQjCK31Epb5GpJ0xxk3wiraAJhfbRWaudXs5cq2lJ4+jVLls7mXsKFyHLiUifrWlPBq37LE qhM6FYpz yTIOBuX/Unqp/vTMj2CIVUGtfnfWG2nijyn3jVDZu+prdVvMKsafzjRk/demE4DoNU7oBTzbDJrnEVHbIisgcOOnyWxMaHHa9SPBL9Bbvdjkyf/s1Qx+Kyw/WrT11KzgODAXIA1XTLIBp79GrLny+oLRRkxfGmR03kFXgSqmWS3RzvteR//EdhDcoENyQ8iKh4JRRmo/vOFkVSMC6Vxh6yhNoM2wfLiCIq1fM+mGQzv0IfHOep/GN8KIAssZDuaHyWtsyamS2f7RAlmOp8aXO5fxV1BKUNkfNkH/yo9eZBRK0lA7fgII5FE2WDmNkJvlC5B/RbBb5fYKZYlXI54KuNQXKP+GuWnrYemdd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 12, 2025 at 11:58:21AM +0530, Dev Jain wrote: > > On 11/06/25 6:00 pm, Pedro Falcato wrote: > > On Wed, Jun 11, 2025 at 05:40:11PM +0530, Dev Jain wrote: > > > If CONFIG_UPROBES is not set, a merge subtest fails: > > > > > > Failure log: > > > > > > 7151 12:46:54.627936 # # # RUN merge.handle_uprobe_upon_merged_vma ... > > > 7152 12:46:54.639014 # # f /sys/bus/event_source/devices/uprobe/type > > > 7153 12:46:54.639306 # # fopen: No such file or directory > > > 7154 12:46:54.650451 # # # merge.c:473:handle_uprobe_upon_merged_vma:Expected read_sysfs("/sys/bus/event_source/devices/uprobe/type", &type) (1) == 0 (0) > > > 7155 12:46:54.650730 # # # handle_uprobe_upon_merged_vma: Test terminated by assertion > > > 7156 12:46:54.661750 # # # FAIL merge.handle_uprobe_upon_merged_vma > > > 7157 12:46:54.662030 # # not ok 8 merge.handle_uprobe_upon_merged_vma > > > > > > CONFIG_UPROBES is enabled by CONFIG_UPROBE_EVENTS, which gets enabled by > > > CONFIG_FTRACE. Therefore add this config to selftests/mm/config so that > > > CI systems can include this config in the kernel build. > > While I did consider this before sending my patch, not every architecture > > supports uprobes :/ So this isn't a complete fix. > > > > Also, does every architecture support ftrace? If not (and it does not seem so, > > e.g there's an ARM variant that does not), I would guess this config fragment > > blows up. > > Sorry forgot to reply. > > What do you mean by "config fragment blows up"? I think scripts will just pull > these configs and build the kernel, and if the config is not supported, it will > be thrown out of .config, and after applying your patch, the test will be skipped, > so everyone is happy I guess? Right, I spoke with Mark Brown off-list and apparently it should be safe to add unsupported config options there (and I wasn't sure about that, maybe it could fail, or maybe kbuild would fail, or<...>). So yeah, I'm fully supportive of a patch adding CONFIG_UPROBES. - Pedro