From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB747C369DC for ; Wed, 7 May 2025 05:40:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39B956B000A; Wed, 7 May 2025 01:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34B446B0083; Wed, 7 May 2025 01:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EAC46B0085; Wed, 7 May 2025 01:40:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F39E46B000A for ; Wed, 7 May 2025 01:40:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 80A36BE090 for ; Wed, 7 May 2025 05:40:26 +0000 (UTC) X-FDA: 83415011652.05.A8B0016 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 9D99040008 for ; Wed, 7 May 2025 05:40:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="KJIVd/uZ"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746596424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=outIt2Tzb0nU9gZ1BTuUgZWqA3ZwKfB1X1BxnDdScyQ=; b=dyaw3zocLo1wswxV7GtwDCIA04GddAFS9FmEjTm5YaSef7rhyI2kd3jQyLITx66JQmV1oh HzyGI3c+Si/tmp6+bujjwNWJIfa9GVuSPeJ06+Kp/8SW/h8bqkKAUfGwZ6qVgcTI+0Izz/ 5hLLIdguwAlbEZSyzng/4zPyLPhHo9c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="KJIVd/uZ"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.54 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746596424; a=rsa-sha256; cv=none; b=0BI6n+9VxASIRVkvtQjHbDFwanPILwdt7DN/YxJ6lOElhrsDuM3TLp4DPqmTQrRHBsJ4gl gNeXdV1MfILMEOcNJYnwBscqKWZ97McZtaLHOnfi89s1tQoLJHRxu74+hIwTq8MYuCFMH/ SXN50Wp1gtmPGBV9aH0ii1ZYVBSAx+g= Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3035858c687so4927235a91.2 for ; Tue, 06 May 2025 22:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1746596423; x=1747201223; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=outIt2Tzb0nU9gZ1BTuUgZWqA3ZwKfB1X1BxnDdScyQ=; b=KJIVd/uZ+HhaEAAxh5FasVnZ84pJvUrMb/JSnGxHvy05Fo2c7vAqoj6R+s2y3CCd98 gJYQ9GlUrw5Lu83qjfg9ctWXPCOEwrxHsxoIH8E1LwPnWvW80bUuBfkxkatApxpclsXZ wYoINk6N/y5Kq00xrVDDlfjJBVwZkUb3J2ql4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746596423; x=1747201223; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=outIt2Tzb0nU9gZ1BTuUgZWqA3ZwKfB1X1BxnDdScyQ=; b=W7ZBm+prtE82uVA155+kCGNk2ncQgNo1Qc/KCfRh6476DCLiNRvQ+ftzPs5Yo4iV1q ot6XfQ+mK/sUVvrzAgcDDVdmVoPeV3sq6dy7g1/I9QkoechXCAMhK/Yqrn9ifxcQTaZQ IRfpuBZsGYD2RwII5eRoWL1un1dRkmwWZglQAfWs8nfUuI1Gm08abNs4064MoBtqriN5 CpaGa0/YnMlZ6AFRHhJFrqiOxVA5kxeVlnvqVzM0FqbReGXk/AesUxi3V2nWnmW4InRM e6xSWIfjhScp3chPXDKEFZtFdjnJXgJpHe+iPJ09Ts1NqHfAEFYDl4nRK38l0oTpqf53 GBLQ== X-Forwarded-Encrypted: i=1; AJvYcCXLxpCKzigYfyi7+gvVu+U82pfROTE/nM+pwWIKnh2hv78TZvi1PcH0tKqtltC1uqx/ErfvH59c3A==@kvack.org X-Gm-Message-State: AOJu0YxpvmdJUydX8vCR9Jw3+bHmtajwdkiScLGwnbz5Of/o6kaxAha0 T5fjznHnNdPqTvGOELinYeFjUhnW9pPdVkBc8VN2GGOvdPGnWyDzpaGFj+TVTKUwfBGozWs4be8 BhQ== X-Gm-Gg: ASbGncvnWkxEboi3tKtQmr5bd1pGfQmtULnENdIFu7QZj2eU62Cwtc5A+hKF1RFr3I0 jCEpsz+Vj03BWgX7NXxMCwWKYxnI/Er3oKBUXi/B5ZRMylRjAlWWN3O4LvDi0iazn6PkpkyDUcg TBmdG9mTYon9BqJyHvAxC8DikJ9YDmziR87ACEkYeOjCggICib4yEmTJpoGA5pBgCN5x2DQo12I RzvkBmF2CEMpvGuaYt7d7Tv5EZV8GICdiwk2U4cZTl//OgN+1CDL//yqnjBnGNnf+5mbW8lK3aq QS/K1ddpvttc4IK9BLg2cqBWEgDEOqs+bklY23eA0jro X-Google-Smtp-Source: AGHT+IHDckEhV3VdKPDU2NI16nX908GbEl4+N4IQWfDv6w/TD99gxmV6rqQ8kPZ25udKGxGZw/Yeeg== X-Received: by 2002:a17:90b:3882:b0:2ee:7c65:ae8e with SMTP id 98e67ed59e1d1-30aac185045mr3372912a91.11.1746596423308; Tue, 06 May 2025 22:40:23 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:284f:37bc:f484:cbc6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30aaead24bdsm1014185a91.32.2025.05.06.22.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 22:40:22 -0700 (PDT) Date: Wed, 7 May 2025 14:40:17 +0900 From: Sergey Senozhatsky To: Johannes Weiner Cc: Sergey Senozhatsky , Andrew Morton , Minchan Kim , Yosry Ahmed , Vitaly Wool , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Igor Belousov , stable@vger.kernel.org Subject: Re: [PATCH] zsmalloc: don't underflow size calculation in zs_obj_write() Message-ID: References: <20250504110650.2783619-1-senozhatsky@chromium.org> <20250506135650.GA276050@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250506135650.GA276050@cmpxchg.org> X-Stat-Signature: cop3b8ixd3479xysmypnkwuw4tjg9jit X-Rspamd-Queue-Id: 9D99040008 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1746596424-447575 X-HE-Meta: U2FsdGVkX1/6PROtEL3hxXED1NJcjaQebKxljTNXXJvG/9aKLdb+VObcoZJ/sOo0QNPURw/GKKSr9dszlPGX6IyiLcb+FMk1Pl99+ORMN+5AFXEOUBO2a0LSpssZHgBZspe2vh1qj9uH+0HY3AiPHGgWi0FZh1Jjg3qbeazOeuXCBnEPEvZp8WbNu+y35vczj0BaJc6p1k44ft2Gs859+8KEBcjU9z5awVI8tzYC6fpYIwOYVvnXiTq6olHCDmCtZZPtAcqrooXKvfSAjwU5694d/ZRVQ/GU4KFaSPH3FNe8+IKMI32clwRpbYY1mVbjwisaUg9AzSI52+i/tcEOcFOf5A/JL3Ulj+KuHdEuJsOnpqnzlESwTUYgPalgA17rehNJO0vzVZOcdnAd+fegnPdLGZg9j4UZMnD2zUZL9+xG7a2pEyvf0sWA+UnB6mp9q+QU4iMVWyCNI1UDXcj2oT3SxlMzbvWITTJMgazdSk8n4bq+Cxh0MW4M0MFFNsrwgBax3hIzfUWsgm/M+1CEd5gPrEU1JVd6vNvsbrvGLZvEYIGDsuWSTg9Ajrtw7cFSYM1ah54Kf1CfWE6A0iMLmn6MLDWTlmPb8WjVwSwfQfy39TRpZE+h+4J3tMbfwqGFqYyGs3LiNND2eB7JXdFL4r2sf3xjJDkSdPBI8Iq+qROqwf7mX6aVJDyF/g+OkxlD0AYLiz8Ww7FSg/MJjifqc1iNzoZ0kUJBZUnvF6GY74q2ByajwLKdd3vrrIRag0WjaRDthvesT7fP5x9HT/63o4KWWXAPcshUeF06hXI+NXckUZyPrlaUYLdG3FzGAAuN7hKVkpXf56RD4VvIWF2L05RQp1W5bB/x9rY1niXrunsso/2hO5nqLMgmgN6QKTVPcpOSCVx/IIPdgNOpDi5KpHovTGgk+UNAvvn+FwpVpDl2BrH3oDV/LMDaDpWl2unvA28X5fxctfblceF5NoB QQf2UTfR 5h3HaiUuv9NNQUqmTnXx4WLrCWz8dYIVprNPvAQcLds3Pj6/9F0/sZjxhxP31h2H0Tphe3pN5kmRmOsnHTptdXYlS7ULKmAi/mcjIN1A+DzqHptv4qs2l1BUZM/mR9kH4seO0AUtHZueO9Z88p9EbzjDp2mLqE33hjA7m7gYmeoNBFwTgB141rkhiQODsIkrK/bLVv2ScbfvGozF8FVXsF6KV5XsXxpcGRequ9jpnT/iIrsSN+Fvzz9m6D+5KAmVTTacReuRLfW6Xy28tf7kbwWNB0fMerDyTQQtVrYlFntOvt1eY1n3GnMuEDofc/V7fgYYPo+k7NwHNuBSFp2LYR/0R57a7PHwLfWo46J2ih1m/hl6LuDo58UvTllVyR8qUGQ/ur/YPZQ+Gxpl9dL6CzBugjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/05/06 09:56), Johannes Weiner wrote: > Could you please include user-visible effects and circumstances that > Igor reported? Crash, backtrace etc, 16k pages etc. in the changelog? > > This type of information helps tremendously with backports, or finding > this patch when encountering the issue in the wild. Fair enough. I'll send a v2 with updated commit message.