From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C3F8C54798 for ; Sat, 9 Mar 2024 16:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7A876B0075; Sat, 9 Mar 2024 11:34:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2AFD6B0078; Sat, 9 Mar 2024 11:34:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F3666B007B; Sat, 9 Mar 2024 11:34:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7D8AF6B0075 for ; Sat, 9 Mar 2024 11:34:47 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 29E4FA0EB8 for ; Sat, 9 Mar 2024 16:34:47 +0000 (UTC) X-FDA: 81878049414.19.A7F245D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf11.hostedemail.com (Postfix) with ESMTP id 86DD14000A for ; Sat, 9 Mar 2024 16:34:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RfNqyFjJ; spf=none (imf11.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.10) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710002085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x+GNATMhIDiu+kb/rARm8mpEA2Vxheo9+6lg+XEaMJI=; b=CpUHxUCO4pZaF9efB3Co0ielsH+sMqkryaVwRPyTWnvWgJx2CtpZUTtWL+XPjaBATANvub u5gdqPTOxMTKML41Pcur2dkh2NHtCo15CrR5AMQHU+1bt9hQG7XOxe3i0N1f1yL7dTxWO5 d4Pfnpjr/ZiMojgwig7dwZn9j+0wd1c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710002085; a=rsa-sha256; cv=none; b=zMEAdLsHLPEu4W7X9AZPkosaAcT5vJxsL5TrR5WmiCo/y7m6G7+rHkT5gPXp4L351+Kjj1 UVhDLJJu3Py4PmAYJWbAmtUIVNRcuO1EAqWe2bH6le20jaRPTxLhKPDDU2lFS6bXwhELHZ u/BEmDUrfBXXRvRUpY5K0m5UjvXDqlk= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RfNqyFjJ; spf=none (imf11.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.10) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710002084; x=1741538084; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DQDKbUDAAhaEkqP/f1HxAcFJ7R5k8edp3JBjX62hW+4=; b=RfNqyFjJ88IuKUyziWdFKWKlT23T3Oz0zXCYW2bzBBOVjxOTyeEJsp8o syNimFS4aWXhc/RLfjA7jbqCkmztfBwlsfb/59REFAT6UsUnt/dBfZ3D2 CGL7J34tN85CbgJun3aPJ8a7tSKxQw6Rzj79+WLwuZQWXVQaNvFmI7O+X iKnXhtcuvaQmlPzxu1S6YO22LeFWYRbJbX9BeuGVnFFsXRgmqNb1wo+16 ukhW6PbE+h3597FqqGEEzrhW+JUkTldxsvRksHRaqfFtj/r85BFGVnOcL Oou5xy22If+u664hcvuSKANmkOFOxBpOn9YB6bXKwjpe0mbFqRRkZIhrb A==; X-IronPort-AV: E=McAfee;i="6600,9927,11008"; a="22171181" X-IronPort-AV: E=Sophos;i="6.07,112,1708416000"; d="scan'208";a="22171181" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2024 08:34:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11008"; a="937048341" X-IronPort-AV: E=Sophos;i="6.07,112,1708416000"; d="scan'208";a="937048341" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2024 08:34:39 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id 897662CB; Sat, 9 Mar 2024 18:34:38 +0200 (EET) Date: Sat, 9 Mar 2024 18:34:38 +0200 From: "Kirill A. Shutemov" To: Yosry Ahmed Cc: Dave Hansen , Andy Lutomirski , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Peter Zijlstra (Intel)" , the arch/x86 maintainers , linux-mm@kvack.org, Linux Kernel Mailing List Subject: Re: [RFC PATCH 2/3] x86/mm: make sure LAM is up-to-date during context switching Message-ID: References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-3-yosryahmed@google.com> <420fcb06-c3c3-4e8f-a82d-be2fb2ef444d@app.fastmail.com> <35b670e2-9ef5-4d3a-b6ea-f8016dfa088d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 86DD14000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sainecq78498hjeoktwnz83ar9jzckdt X-HE-Tag: 1710002084-700685 X-HE-Meta: U2FsdGVkX1/U9BmBwRltc+9g9tH74CHIOzn/m6rtu/aEkqj8oEEVEo7vJlNPirakNDyOenqeA+IN35zjdEykwFljG38qwI/RvsI61kfliWCQ4hgMb2Dv9EpmOolobgCSNHg2th2V/1DE1F3QjTzfXhJahmyLnM2bmu7i4VjpDgud81MRGEsPJE67eAbAiiNlLXfH53DWwtIrZqAgTBfWMw+QX5rxL/0CPWkJlW42SeDPz7LIdAUHv7yZpMSA5R6q5oOJ1INLPnAb8AswWv96TeWYkhLK9PwvnAAZg/62IhpXNvlC87wtwcsznNzUHECIyWO/HSPMy7lk9zf6QQ4erpMDTgCvPpGDygS7zTZbwgb86V2utQuFwwK5c1ZGtZcWlhT1MalojXZ+NusmAY0uhtw81JV2PVibf/BQbV6euTE+0iLfggcQL2owAYB+YcPbPoNZBLOZJTZKMpzNOhhQ8lxy8KzzENKoiY/J5q2DbH+2eKNd7lTuddexU6rqzNN466RS9wVXlzS2rdoi20EqoJ5aexgP3Vzlqd7TwT0ysekLKM4xmmly4MQjysApa69ClUd6V1772R5mYTOiGlwVspSHJRZ/cdZiRNIkKyFDMbf6tYCA2OcTRPMytP2hUeEV0ij71aKOc5DSB7WL7XnGV5k1S3prVf24VQWRpAb1vy3dbEg/9JP1MNeGegkay+ScH7dORcztKn6fIMG0gwxfPezNH6rQChOyp5ExXyKCwpatf+y8OqoNXXH0Hom4GkQ1snkT5FFtYeujNQTAXXJ/Tp0IsqUeR96zmxqWz0gS0YVHexR8YF/7iJ544mrxDtc8AoQNizPXZuI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Mar 09, 2024 at 02:19:19AM +0000, Yosry Ahmed wrote: > I don't see how skipping set_tlbstate_lam_mode() for kthreads fixes this > problem. Do you mind elaborating? Define what problem is. Yes, in this scenario kthread gets more permissive LAM mode than it needs. But nothing breaks. -- Kiryl Shutsemau / Kirill A. Shutemov