From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D06C433F5 for ; Wed, 4 May 2022 16:23:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD4A66B0071; Wed, 4 May 2022 12:23:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C82E46B0073; Wed, 4 May 2022 12:23:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4AA86B0074; Wed, 4 May 2022 12:23:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A6C096B0071 for ; Wed, 4 May 2022 12:23:21 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6D0E227F9C for ; Wed, 4 May 2022 16:23:21 +0000 (UTC) X-FDA: 79428580602.16.702FE0E Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by imf11.hostedemail.com (Postfix) with ESMTP id EF58E40084 for ; Wed, 4 May 2022 16:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651681399; x=1683217399; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=OsPbQDphxyS5T5cxqp789eGU8MxcDNRRBBbsrR9WKHU=; b=tdrAjZg3D4ICk1wks3cTbbSoRjUzq0m6r+FbSJG6rZ84DzO9ftfzJsGX LKdwS5gG6JKogcDzl0T77X5tD4c7I9y+vvT6aB+xsSZGJi8EKQm5wz8Xz ep0k5cqW+opB+0ayAen7N02AVerH3SOxsWWGj/LbWON5caArht2b78Lcy c=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-02.qualcomm.com with ESMTP; 04 May 2022 09:23:17 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2022 09:23:17 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 4 May 2022 09:23:17 -0700 Received: from kvalo10 (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 4 May 2022 09:23:14 -0700 From: Kalle Valo To: Dan Carpenter CC: , Carl Huang , , , Linux Memory Management List , , Wen Gong Subject: Re: [linux-next:master 408/8237] drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: inconsistent returns '&ar->conf_mutex'. References: <202205032236.kofEquX3-lkp@intel.com> Date: Wed, 4 May 2022 19:23:12 +0300 In-Reply-To: <202205032236.kofEquX3-lkp@intel.com> (Dan Carpenter's message of "Wed, 4 May 2022 11:46:27 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EF58E40084 X-Stat-Signature: 4j9buynxq1xy8zypt7fd7uoo3uded446 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=tdrAjZg3; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf11.hostedemail.com: domain of quic_kvalo@quicinc.com designates 199.106.114.39 as permitted sender) smtp.mailfrom=quic_kvalo@quicinc.com X-Rspam-User: X-HE-Tag: 1651681395-802697 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + ath11k, wen Dan Carpenter writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 44a2f39e611ac0bc1f17c288a583d7f2e5684aa7 > commit: 90bf5c8d0f7ecddf96fc1cd9434af4e157b51970 [408/8237] ath11k: > purge rx pktlog when entering WoW > config: i386-randconfig-m021-20220502 > (https://download.01.org/0day-ci/archive/20220503/202205032236.kofEquX3-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/net/wireless/ath/ath11k/wow.c:712 ath11k_wow_op_resume() warn: > inconsistent returns '&ar->conf_mutex'. > > vim +712 drivers/net/wireless/ath/ath11k/wow.c > > ba9177fcef21fa Carl Huang 2022-03-14 653 int > ath11k_wow_op_resume(struct ieee80211_hw *hw) > ba9177fcef21fa Carl Huang 2022-03-14 654 { > ba9177fcef21fa Carl Huang 2022-03-14 655 struct ath11k *ar = hw->priv; > ba9177fcef21fa Carl Huang 2022-03-14 656 int ret; > ba9177fcef21fa Carl Huang 2022-03-14 657 > ba9177fcef21fa Carl Huang 2022-03-14 658 mutex_lock(&ar->conf_mutex); > ba9177fcef21fa Carl Huang 2022-03-14 659 > ba9177fcef21fa Carl Huang 2022-03-14 660 ret = ath11k_hif_resume(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 661 if (ret) { > ba9177fcef21fa Carl Huang 2022-03-14 662 ath11k_warn(ar->ab, "failed > to resume hif: %d\n", ret); > ba9177fcef21fa Carl Huang 2022-03-14 663 goto exit; > ba9177fcef21fa Carl Huang 2022-03-14 664 } > ba9177fcef21fa Carl Huang 2022-03-14 665 > ba9177fcef21fa Carl Huang 2022-03-14 666 ath11k_hif_ce_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 667 ath11k_hif_irq_enable(ar->ab); > ba9177fcef21fa Carl Huang 2022-03-14 668 > 90bf5c8d0f7ecd Carl Huang 2022-03-14 669 ret = ath11k_dp_rx_pktlog_start(ar->ab); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 670 if (ret) { > 90bf5c8d0f7ecd Carl Huang 2022-03-14 671 ath11k_warn(ar->ab, "failed > to start rx pktlog from wow: %d\n", ret); > 90bf5c8d0f7ecd Carl Huang 2022-03-14 672 return ret; > > goto exit; Carl or Wen, are you able to send a fix for this?