From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F9EC433EF for ; Fri, 10 Jun 2022 08:32:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C1AB6B00A2; Fri, 10 Jun 2022 04:32:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 371D76B00A3; Fri, 10 Jun 2022 04:32:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 239486B00A4; Fri, 10 Jun 2022 04:32:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 148C16B00A2 for ; Fri, 10 Jun 2022 04:32:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9357920 for ; Fri, 10 Jun 2022 08:32:15 +0000 (UTC) X-FDA: 79561659030.23.04C29F7 Received: from a3.inai.de (a3.inai.de [88.198.85.195]) by imf07.hostedemail.com (Postfix) with ESMTP id 285264005F for ; Fri, 10 Jun 2022 08:32:15 +0000 (UTC) Received: by a3.inai.de (Postfix, from userid 25121) id 43D6D5872870F; Fri, 10 Jun 2022 10:32:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by a3.inai.de (Postfix) with ESMTP id 4326A60C247DA; Fri, 10 Jun 2022 10:32:13 +0200 (CEST) Date: Fri, 10 Jun 2022 10:32:13 +0200 (CEST) From: Jan Engelhardt To: David Laight cc: 'Bill Wendling' , Andrew Morton , Bill Wendling , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , "linux-edac@vger.kernel.org" , LKML , ACPI Devel Maling List , "linux-mm@kvack.org" , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , Networking , "alsa-devel@alsa-project.org" , clang-built-linux Subject: RE: [PATCH 00/12] Clang -Wformat warning fixes In-Reply-To: <01da36bfd13e421aadb2eff661e7a959@AcuMS.aculab.com> Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609152527.4ad7862d4126e276e6f76315@linux-foundation.org> <01da36bfd13e421aadb2eff661e7a959@AcuMS.aculab.com> User-Agent: Alpine 2.25 (LSU 592 2021-09-18) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654849935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ncRWd2L52A+VphiCBk5vxKLdT57ynA6SX9ETZhhBmoU=; b=tUrMvWkYi0uNjGZIHgemqq1glSqHuL05v3DtrBXwUSgQR4SIVoSR2mZ58erKVtyW260SyW WJfwMphipA5NvAJDbx7BrxUrMswy8yxfIA8xXzwWW/kca/QeOZKeH+Zh8yGAI/JrtgU54V TxCzZBif9Ne2Q3qILEW+RjhSqio+dAg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654849935; a=rsa-sha256; cv=none; b=aZNtrLU1+Crb4iEDPIx5ZZg9ViyYO8PHNvq8xzyaltkie9yETXjPOTf5Y5C3VhsPpsBI2W 9GWSzmFBQQtnzGePqFrRu7ldPD5XI3TyOhQqMcZtP1qxcAIIankFoRyfsWEpgaZbEzf3q4 TR9+hgd0FGx4D9k+dtOKLuNS/z9SRMM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of jengelh@inai.de designates 88.198.85.195 as permitted sender) smtp.mailfrom=jengelh@inai.de Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of jengelh@inai.de designates 88.198.85.195 as permitted sender) smtp.mailfrom=jengelh@inai.de X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: z5jjfnn5a5b31jfbuf17wibo3bdqixzy X-Rspamd-Queue-Id: 285264005F X-HE-Tag: 1654849935-345229 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Friday 2022-06-10 10:17, David Laight wrote: >> >> Calling a "printf" style function is already insanely expensive. :-) I >> understand that it's not okay blithely to increase runtime resources >> simply because it's already slow, but in this case it's worthwhile. > >Yep, IMHO definitely should be fixed. >It is even possible that using "%s" is faster because the printf >code doesn't have to scan the string for format effectors. I see no special handling; the vsnprintf function just loops over fmt as usual and I see no special casing of fmt by e.g. strcmp(fmt, "%s") == 0 to take a shortcut.