From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443C1C2BBCA for ; Tue, 25 Jun 2024 17:01:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE8C66B0083; Tue, 25 Jun 2024 13:01:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A970E6B0088; Tue, 25 Jun 2024 13:01:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95EB46B0089; Tue, 25 Jun 2024 13:01:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7794C6B0083 for ; Tue, 25 Jun 2024 13:01:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D28E81C1069 for ; Tue, 25 Jun 2024 17:01:06 +0000 (UTC) X-FDA: 82270026132.28.A801517 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf05.hostedemail.com (Postfix) with ESMTP id 6F267100026 for ; Tue, 25 Jun 2024 17:01:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xX593xil; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719334850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RFwFF3kbG222kuJ6wzNiSOqgQ+6acgu5GnzvYPY9Ado=; b=7Yj6TbyAikwrlhA9A+eQGy1QFnsoVTiNpYYeA49NujsQEp8iqkKkfAqfUEJ28mMC8FtS5d e5qYfWvnurDvxLdfLpKaSgB35y5a6UxRTobtdaUVxuiPiXgePrIAzogFqc4AjeSu4U7B/V vrfBYE+4t8RFSIRZw9vZwC1njBn/FUY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xX593xil; spf=pass (imf05.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719334850; a=rsa-sha256; cv=none; b=CUn7Vs2LGuKUXIFawtByQR1CQyOHVrP9zwrtkvTcmV5otnNORJ5nL1Kailk3zK10YAODho O6JbxfWDho+GL0UFLDPX1/aOzCyzhFKffA0H0xjezc2BUE0U+lDUA1oEht69fxmc/PUWVA 7RuITK2XakpCrMePSgdWiLZ9u2lQW6M= X-Envelope-To: akpm@linux-foundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719334858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RFwFF3kbG222kuJ6wzNiSOqgQ+6acgu5GnzvYPY9Ado=; b=xX593xilwY2KQ5LCMOSkvjEqu9oOXyINxZwkTVL2RxYuqzEGO8Px+lVD4MTmR1OVo0Pl0e iB58R435KtpfoXYmEqVV/0X5Y8BjxIylrynbXJJ9ySHW0PkiPhKVbZ3b+jwqJEjTbvas2f lG7ff3w4EInvglLe1tq3g6K5G1p24OQ= X-Envelope-To: kasong@tencent.com X-Envelope-To: ryncsn@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: willy@infradead.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: longman@redhat.com X-Envelope-To: shakeelb@google.com X-Envelope-To: nphamcs@gmail.com X-Envelope-To: mhocko@suse.com X-Envelope-To: zhouchengming@bytedance.com X-Envelope-To: zhengqi.arch@bytedance.com X-Envelope-To: muchun.song@linux.dev X-Envelope-To: chrisl@kernel.org X-Envelope-To: yosryahmed@google.com X-Envelope-To: ying.huang@intel.com Date: Tue, 25 Jun 2024 10:00:49 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Kairui Song , Kairui Song , linux-mm@kvack.org, Matthew Wilcox , Johannes Weiner , Roman Gushchin , Waiman Long , Shakeel Butt , Nhat Pham , Michal Hocko , Chengming Zhou , Qi Zheng , Muchun Song , Chris Li , Yosry Ahmed , "Huang, Ying" Subject: Re: [PATCH 0/7] Split list_lru lock into per-cgroup scope Message-ID: References: <20240624175313.47329-1-ryncsn@gmail.com> <20240624142654.7b7aa167b8fa61fb805a732e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624142654.7b7aa167b8fa61fb805a732e@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: kx6amtsezsajfgjem4sbm6otkcw7trum X-Rspam-User: X-Rspamd-Queue-Id: 6F267100026 X-Rspamd-Server: rspam02 X-HE-Tag: 1719334861-495900 X-HE-Meta: U2FsdGVkX19zZw+xqM4owIoIM6y79iHyyz7JQVmj6ZLeKp7GfopCsQwNy90SWgrKEeM+i8DTDBbIq8lTL0NgIoGqVGb77cPSMF1xFByq671VmBh13j/BqUT0I90k5ooLZvoL7UYujqKGAVLGqvLzG7w/XYe3K7GXdmjPqEjBquGEtA7XjalfQGtamcSV5tvR3thN0I+OkwCTFGHSEzJQPrxhf3oaGgL5ox6HIQYdN1CVAXQ0FxfdlyL21aL5HD9EoHI9V/27+fJwQYAK6Gmwe/ZkGkhT6M4dOf7RSTB1SHXjGeDdiEep1u9Wxztw7GM1yP1e6E7BnaB+QZTjPN4InO/h1jtsJ83PaHYL8nu9Bv1ApIZaHtJFCdapFzRPEW5pVRYwhSQYXksnKUIBBxP/+mo7y7dHgbEXOdAzV5kC8VVkWlQ1RpXcU9ZQFyq03bqASffVKFAL8KQhyt8IQFnuasLXDS0T++M3ZyGA56Et8egqUMdPOFqHmHTmEJvIqHJHmpco7sE73oG+h0ZUbEF7/0MOqR9e7tOv9HxoPYPn0K34JwFMx2cCyzPtzxffiVLkOFdVikuC17SQUOtCR2wdKAyJEqHnaG5T6hmvdMhH95/8vrTh5uKonxKDQojQofEJWBRGeT6kcQvnSuZ1NJHeTQLzB51rS09NA6ujGCBsgJKZCuZ2QMR3eMHWIhQbF80j7uaWzev8R42xpn3oswdaJVtvBi2Rfs7EjCE9V5iwVLWSZVYH1v7ybYFQs6tuFR8tt9JPYRHT5jcJCeB8N5lWCFniKfP3smpOvMIuOUzsUEBkPmoSk4rbuxuOOG204X5mj3HgP+F3lyNycvzsDMGimbiHO2ME+0E+QSlDjj1nfByxv5apQPMcKk280jyns6JzHaYL3Y02ld1lCK5f/KbPdO+R+TJlW8m5vqofzThkUFpIj1cUuVdffWXy7z7ofPDDlY85+u9akTrh18OpWX9 FRzYsv3J ICUtomJjKaC/dj+xIn5hVgwf8iK9JefBkME7xgO9+qTT8VhzcLk/eZfjJkWHalfDPRM02fSbDQ+ar1vRl4rWHvuJLFrW44KpwTbI1fF624LvsiBuioIJ6jAzq8r/1XjVsXcIEjHYcar0OJhSoFwsDmPOHtSHQApx1L+EL7c15wEucpsUthuDl8/Xuf2yrQ4vHzLIG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 02:26:54PM GMT, Andrew Morton wrote: > On Tue, 25 Jun 2024 01:53:06 +0800 Kairui Song wrote: > > > Currently, every list_lru has a per-node lock that protects adding, > > deletion, isolation, and reparenting of all list_lru_one instances > > belonging to this list_lru on this node. This lock contention is heavy > > when multiple cgroups modify the same list_lru. > > > > This can be alleviated by splitting the lock into per-cgroup scope. > > I'm wavering over this. We're at -rc5 and things generally feel a bit > unstable at present. > > The performance numbers are nice for extreme workloads, but can you > suggest how much benefit users will see in more typical workloads? > > Anyway, opinions are sought and I'd ask people to please review this > work promptly if they feel is it sufficiently beneficial. I will take a look this week (or next) hopefully but I don't see any issue or concern missing the upcoming open window. Shakeel > >