From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D4DC2BD09 for ; Sat, 29 Jun 2024 00:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD7106B0092; Fri, 28 Jun 2024 20:30:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5D156B0095; Fri, 28 Jun 2024 20:30:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D7216B0096; Fri, 28 Jun 2024 20:30:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6DF7D6B0092 for ; Fri, 28 Jun 2024 20:30:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D2897A2499 for ; Sat, 29 Jun 2024 00:30:57 +0000 (UTC) X-FDA: 82282046154.06.45DB386 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 9071340002 for ; Sat, 29 Jun 2024 00:30:55 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dHrrzMEY; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719621037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IWXE+pd1tA7tWFX16NxlXvVl3NJJq7zNI9CADPNo6YM=; b=D7FpLS7qwVAtIUMC6xiSkiN8elSCQjoDl6nhPA2XiMdwIOY5Z4K8wplH6vYIUXs4GX0Xzx GLtUJEaAqQbNX/nL4AKWT46/Lj3dGK49Htpr2RlSQK4fY3Qn2QNJXfjEiCEM2a4F8hdPiX Izst6EpMHtHchTQuMKoc2jXcpJ4w7Zg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719621037; a=rsa-sha256; cv=none; b=59whl7u2XOOkGNn6hmQA3NwdKCwFltZi/Fcf17leWC5AE5l+lbonnpPS7DlZ4D1B23viLN 15fQ5XZBshy3V4f2v4AdV1HmbHSK4sxSMKjHS4aPOkR64rmpt6Kg/t9sGAByYwLFG06+SL EM/z4TKIa4O/WdOlofrxuu+nSbPEaxw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dHrrzMEY; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719621052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IWXE+pd1tA7tWFX16NxlXvVl3NJJq7zNI9CADPNo6YM=; b=dHrrzMEY8h/nwrN5qCRzZKahmPhj7drTrbDPSgdeiHh9s4/f1vrRFfj33nBtP5OsRlXTI/ aqk3SmcgjztRQxkrItwMIPkHb7RlHmPaVgmFO/qkFyVLOo8uQNKEZNWfAnZ8tmFEza7GsX 1jaEugXxcQPYBGDqCcl3pBJhtW55/hw= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev Date: Fri, 28 Jun 2024 17:30:47 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH v1 1/9] mm: memcg: move memcg_account_kmem() to memcontrol-v1.c Message-ID: References: <20240628210317.272856-1-roman.gushchin@linux.dev> <20240628210317.272856-2-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628210317.272856-2-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: q7m3xzxa1tm363myp64kj8ebue7y7prw X-Rspamd-Queue-Id: 9071340002 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719621055-247557 X-HE-Meta: U2FsdGVkX1/03l7TxQ+w3+mhQLYWAuKylSiMBjR0Oj8dkO3AcvLLjijqEXwinbVCeEOOoWw2QAjvSNidsqxHaPlyP2qUDwvWyvSMKRT6yLrIyOcBfVoOhPuKLtlZQbcpIJUtxehrYD0FS3bFeu2liDV2Sncxx7Lu6cSF0xrCPKZ1NZNGNXQo6O16G/gpQsMo29S+GSKOgItyVYpFJmvN2KemPV9HCI8bOMJFlZ05wQ+YGAFSx49wAqhqfEVDR4tWt9huV89P2GELBnRNeX56kLUT0pVgqjb/CTENOwiacSXEcWDI9+RX1p+kznik7CdqF8NVUDlIcWocH02mNLC7RxvsYh2mggxlGa9kscyxmDgQF2Bou2Agtlb1yksrCyL28kjAzdlPEZcacuntYRf2v9tP4jJoRi+F8/6Uy4wfYQDqKamCod1EHFUI3UrGGI+LaCNhwLGTXRWqa46txf7jMEpF7bUfk5BlEuRKI0cRMW6UDDmThg7CfXVrKCdlrXvN52CPsj6TK/KdbPA649GmZUWBL21u8dF+1gPwFHRkApBhvW511ej4m5jC4cBwMP/3kpWGfcqiYH/eRsQzzcGm7rVNekRHR0/iGvNbrb9PSD4ePe2BIekKq1KVurA+LpPJ7/9uTYWwj1X8mCsbXPaGsn6b9RCwb8qMqRnKJBHEA7PkfHIqCqx6+Vs2PRsqwTLPNQByWv+x5nY+qH8KCnGZKjTvZt6/wwncqTIbeX+wJavdrSqDXHdlJQUuPE3r5SrtswpU7jYomFrj3qY62fft7YWmvJA4ZcG6WSFnSssTekOnULoMzfiMVprBWWjS3IDsxdMuBY4wWbamlExg3i1OHGbIDJE+Pbz9iGYkln7E1WbnAsyB/z57wF7ueKhJNBSnb7IVjSNPkX7sgp+KuJ7521m9ArlNwFk4uuTKNMALFF78gtojIjCp35w7tb1Qnkq57WKywyCBUvX/dkmbx5V rU4ugOj+ X7tjAKAdT1iaqdhCvgVQIJI5h3n76sTooGpcREokeIkzkflQpCzuqM3fenXGnSg5o92TbCt1r5CiD5HRmgmsCO+A2JbkSXmHEOa9+4DNF6HHmY7Sjgg0XD3bHvQB0sOCm8SzH4PBxBln4VuTAXbMNZQfmBVaDfRG27vl9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 28, 2024 at 09:03:09PM GMT, Roman Gushchin wrote: > memcg_account_kmem() consists of a trivial statistics change via > mod_memcg_state() call and a relatively large memcg1-specific part. > > Let's factor out the mod_memcg_state() call and move the rest into > the mm/memcontrol-v1.c file. Also rename memcg_account_kmem() > into memcg1_account_kmem() for consistency. > > Signed-off-by: Roman Gushchin Acked-by: Shakeel Butt