From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0254C282DE for ; Thu, 13 Mar 2025 17:08:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B056428000E; Thu, 13 Mar 2025 13:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB41F280001; Thu, 13 Mar 2025 13:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A37D28000E; Thu, 13 Mar 2025 13:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7E7B3280001 for ; Thu, 13 Mar 2025 13:08:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E7D90B2408 for ; Thu, 13 Mar 2025 17:08:14 +0000 (UTC) X-FDA: 83217160908.24.3D3BCE8 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf12.hostedemail.com (Postfix) with ESMTP id 23E9B40020 for ; Thu, 13 Mar 2025 17:08:12 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="myM5/KS/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741885693; a=rsa-sha256; cv=none; b=D4h8lfBkT79M/ExIGmqSm16MlMoZNQ+tpoqWXRphLkrKFm1/hg46WDv5QbOJ1PVZf0ttZ2 ncahH/yXCngsmBiCCE0okr8CVrE83iZz3xcTu9dUkeWGBmgshAvgnsMHl2GoathQqg7TyA vE07ERRgFBDh5nqeXwsl8ZctxcJAY64= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="myM5/KS/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741885693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hRMHAONMm14/ZVHn1w1PRAJWbepOypKRPfQlZPlVG+4=; b=PSHMoG/4rMb+XrSdjnfdnAK/GaxyZ/EO52db/qIFoXGg4ATmShahdN+F300g2o+kLlBWuL zVeTe13eq1OHFokXHr4QBJZQQJ5+DgW5SwsSMjD0flk2dfAbKTwIy8UVucqdChNem9OGCj LmMsBe8wbCeA1xvmFiUwLOJCzdDn4b4= Date: Thu, 13 Mar 2025 10:07:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741885690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hRMHAONMm14/ZVHn1w1PRAJWbepOypKRPfQlZPlVG+4=; b=myM5/KS/gaODojg5kuj4nkMXWeiXGsf5mz9mFdn6psFUspQFx3PwTxbn+iD3cgSl+dexrr nTnoXWHxp86SCxtIoeCtCqcsOMfwINwhJEgkV4AEGPnXUAVe/ZNc5HWuNZkUwa97f70asx 3yDQkxd/62avrd89HbaakNvo+OMEFv4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Zi Yan , David Hildenbrand Subject: Re: [PATCH 1/5] mm: Separate folio_split_memcg() from split_page_memcg() Message-ID: References: <20250313145856.4118428-1-willy@infradead.org> <20250313145856.4118428-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250313145856.4118428-2-willy@infradead.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: sxch4wp8k87n8m4aybpa5q6qso3p3996 X-Rspamd-Queue-Id: 23E9B40020 X-HE-Tag: 1741885692-341042 X-HE-Meta: U2FsdGVkX1/KUb0hr3E2zknRQUkJcSMIR+ByCtNhfl21AhQOfJQAJ/W0R7gKhOYBfJw816pJzDKDeJeUSkUJ9EN9JIR9encehiPL+Z5PsG/Du2E1sKJh3CQI9KDm1HTCHvDWT8mIiLn65quKee/TO0B5HJyJCxQkxr5w2zzL7ph4EtYMFm3SC+LSHh2MmZJPjH1/kJlA3+WrqSJxD/yO/PgK3e76mhJfnGfJhn98F0ZjazfkE5mt8SRBYxwy97HXckiluF/WsctZWvKcgN3qlgfcUzRGX2fvz/K4L4UgK0QzGdA65K5yKt59s8/jnVvUODM3zbgF1zcskQWl06WvM1HivKUO/06epVBzzbk3gqF74LsXVWlPvrUxaBoAH+lJDYTiNvXoZKDxqtENX6B8IVOy/UhvmOjdM5F/i0HltzkbiMudARRrzjnIr8YjEl7KPH++BjZexglxf8rLFIC8wFLm6wEdXkGbZQvrFV1Q5i2y9R8bqL+0tn+zHu2Qryqn1ZkszokFV3lnNhzKfIzkJfe8sHI2ggN2UUAqStLm9bE0Dv464gOvTtVU4AF2NbqTVObM6oRSxF2NDweNfq4bZkDayF64RjT2Z2SGKUIHsalDy6nRyIpnd18dLaq5O/N/BcTx/sbGiIb6B0nM3H83E2Z01ojSoOc0TrzgFv0Q6IzZSWWp5o8mT3SQfYI0Ya4T+m+8XL2JjJZ2CoXfO0T5UTzHI2qrVi/zHuY4/Z7PlQmYA4Ja2Qfbxu+yLIM/EUeCV9dKXG28Fjlxbxyy1Q/IXkmTvbO03xNmKhMV6v/HM2cpFmkIqukYHkXIbOG38YQwASPssSZbFvElIkgm+tG6WlKNi0NAA0RSf1oKkxR8kpj2mVlh6YO8P9Y9PMDP8AgpvXpfLBeyBl9UhTwZDksnsgtx7CFuRlxNyjLXqF2iOD0xM7xoDOGxHJ1K1Rglp7o9+k7VoJumFaG11ilDVNQ 8gwtEmTQ 1sOfzYKAIFLwQjnzyNfqpPeFmb/jq/zk3FZQUBOVaGcJGzBbkzc7uBvH5uor6YITXwZUwewi/m801fxPfxmdPtNb058KwhnBxU6gZ/d6E2i8qOCjvt/NMReIJZeNTJ6xAlSKePzP9R2JEmobvOJtxSFK9nK7cWi1FZamWPhYHoBMYiHqIyjJMiJDRU5O3vmrBQvQKgLczOdkt/JaAmNnf5lWw+AL+31NVNf3hRiyU/3X00coQFmiVb+d5oGScfCH+ZDwcLPxriPJsXb/jmG9DQuyVxCJ2QqPWTMF2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 13, 2025 at 02:58:50PM +0000, Matthew Wilcox (Oracle) wrote: > Folios always use memcg_data to refer to the mem_cgroup while pages > allocated with GFP_ACCOUNT have a pointer to the obj_cgroup. Since the > caller already knows what it has, split the function into two and then > we don't need to check. > > Move the assignment of split folio memcg_data to the point where we set > up the other parts of the new folio. That leaves folio_split_memcg() > just handling the memcg accounting. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Shakeel Butt