From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org, akpm@linux-foundation.org,
willy@infradead.org
Subject: Re: [PATCH v2 08/16] maple_tree: print store type in mas_dump()
Date: Thu, 13 Jun 2024 10:29:18 -0400 [thread overview]
Message-ID: <nuij35r6vabz2s5qikvn6t3v7gabshabv5o7ngyzkkbh5tw3ik@lqy322zs2cua> (raw)
In-Reply-To: <20240607185257.963768-9-sidhartha.kumar@oracle.com>
* Sidhartha Kumar <sidhartha.kumar@oracle.com> [240607 14:53]:
> Knowing the store type of the maple state could be helpful for debugging.
> Have mas_dump() print mas->store_type.
>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
> lib/maple_tree.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index a955316b6745..91b18eef81e1 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -7731,6 +7731,45 @@ void mas_dump(const struct ma_state *mas)
> break;
> }
>
> + pr_err("Store Type: ");
> + switch (mas->store_type) {
> + case wr_invalid:
> + pr_err("invalid store type\n");
> + break;
> + case wr_new_root:
> + pr_err("new_root\n");
> + break;
> + case wr_store_root:
> + pr_err("store_root\n");
> + break;
> + case wr_exact_fit:
> + pr_err("exact_fit\n");
> + break;
> + case wr_split_store:
> + pr_err("split_store\n");
> + break;
> + case wr_slot_store:
> + pr_err("slot_store\n");
> + break;
> + case wr_append:
> + pr_err("append\n");
> + break;
> + case wr_node_store:
> + pr_err("node_store\n");
> + break;
> + case wr_spanning_store:
> + pr_err("spanning_store\n");
> + break;
> + case wr_rebalance:
> + pr_err("rebalance\n");
> + break;
> + case wr_bnode:
> + pr_err("write_bnode\n");
> + break;
> +
> + }
> +
> +
There is an extra new line here
> pr_err("[%u/%u] index=%lx last=%lx\n", mas->offset, mas->end,
> mas->index, mas->last);
> pr_err(" min=%lx max=%lx alloc=%p, depth=%u, flags=%x\n",
> --
> 2.45.2
>
next prev parent reply other threads:[~2024-06-13 14:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 18:52 [PATCH v2 00/16] Introduce a store type enum for the Maple tree Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 01/16] maple_tree: introduce store_type enum Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 02/16] maple_tree: introduce mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 03/16] maple_tree: move up mas_wr_store_setup() and mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 04/16] maple_tree: introduce mas_wr_store_type() Sidhartha Kumar
2024-06-13 14:27 ` Liam R. Howlett
2024-06-07 18:52 ` [PATCH v2 05/16] maple_tree: remove mas_destroy() from mas_nomem() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 06/16] maple_tree: use mas_store_gfp() in mas_erase() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 07/16] maple_tree: use mas_store_gfp() in mtree_store_range() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 08/16] maple_tree: print store type in mas_dump() Sidhartha Kumar
2024-06-13 14:29 ` Liam R. Howlett [this message]
2024-06-07 18:52 ` [PATCH v2 09/16] maple_tree: use store type in mas_wr_store_entry() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 10/16] maple_tree: convert mas_insert() to preallocate nodes Sidhartha Kumar
2024-06-13 14:40 ` Liam R. Howlett
2024-06-07 18:52 ` [PATCH v2 11/16] maple_tree: simplify mas_commit_b_node() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 12/16] maple_tree: remove mas_wr_modify() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 13/16] maple_tree: have mas_store() allocate nodes if needed Sidhartha Kumar
2024-06-13 15:00 ` Liam R. Howlett
2024-06-17 21:18 ` Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 14/16] maple_tree: remove node allocations from various write helper functions Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 15/16] maple_tree: remove repeated sanity checks from mas_wr_append() Sidhartha Kumar
2024-06-07 18:52 ` [PATCH v2 16/16] maple_tree: remove unneeded mas_wr_walk() in mas_store_prealloc() Sidhartha Kumar
2024-06-13 15:02 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nuij35r6vabz2s5qikvn6t3v7gabshabv5o7ngyzkkbh5tw3ik@lqy322zs2cua \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=sidhartha.kumar@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox