From: Shakeel Butt <shakeel.butt@linux.dev>
To: Muchun Song <songmuchun@bytedance.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
muchun.song@linux.dev, nphamcs@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: list_lru: fix UAF for memory cgroup
Date: Tue, 23 Jul 2024 10:52:42 -0700 [thread overview]
Message-ID: <nrtjxxhblvuzkv6sytcjay7qr64jozdbp2klipoo2a4ddqe7dp@gufvv4uen76q> (raw)
In-Reply-To: <20240718083607.42068-1-songmuchun@bytedance.com>
On Thu, Jul 18, 2024 at 04:36:07PM GMT, Muchun Song wrote:
> The mem_cgroup_from_slab_obj() is supposed to be called under rcu
> lock or cgroup_mutex or others which could prevent returned memcg
> from being freed. Fix it by adding missing rcu read lock.
>
> Fixes: 0a97c01cd20bb ("list_lru: allow explicit memcg and NUMA node selection)
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Yup I noticed these as well while reviewing Kairui's patches.
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
next prev parent reply other threads:[~2024-07-23 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 8:36 Muchun Song
2024-07-18 10:30 ` Vlastimil Babka
2024-07-18 11:20 ` Muchun Song
2024-07-23 11:23 ` Muchun Song
2024-07-23 17:52 ` Shakeel Butt [this message]
2024-07-24 0:45 ` Andrew Morton
2024-07-24 2:23 ` Muchun Song
2024-07-31 10:06 ` Vlastimil Babka (SUSE)
2024-08-01 2:42 ` Muchun Song
2024-07-31 20:28 ` Andrew Morton
2024-08-01 2:42 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nrtjxxhblvuzkv6sytcjay7qr64jozdbp2klipoo2a4ddqe7dp@gufvv4uen76q \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox