From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C68BFC4345F for ; Sun, 14 Apr 2024 04:58:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57BEE6B0087; Sun, 14 Apr 2024 00:58:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52B4F6B0088; Sun, 14 Apr 2024 00:58:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F2F96B0089; Sun, 14 Apr 2024 00:58:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1FE136B0087 for ; Sun, 14 Apr 2024 00:58:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB8FD12024B for ; Sun, 14 Apr 2024 04:58:00 +0000 (UTC) X-FDA: 82006930320.29.06A8787 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf14.hostedemail.com (Postfix) with ESMTP id 04952100002 for ; Sun, 14 Apr 2024 04:57:58 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QtAFfyn0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713070679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZA5aE3j3lTWxM9WMGZSCrXNcLpZkWfP1rN5XDhrTFYg=; b=VELbEgRLd7LknNFU37E3Rdm4eJc/ye8MvJktorrj2tFQbAE74yDbn7aL99sI4w/3MHvDwl S3Gpq22hvA3oiFXk+gDpFCyBjUZvZmw1cVUcHPnn2ckCQi/M31E/F0ycHjmbVcYEZsjJB8 knWZS1MdLkeB0y9RsOSiarzySXk8mDw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QtAFfyn0; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713070679; a=rsa-sha256; cv=none; b=l3atwkh6IKPcttQVa1t0XX7+xeV9qnCU9h72MqpkiVdHk54yY5lPz/cQAkjFZgYspxYSC/ 1SQXpCgvQc0Shy4a/v/mDxyQW3sHdawK+SQoO5nf+blvjOyEvDzFzGgzrCSTEWT9qZkYFw E4VvZLVoMbS2d8cUKdn6b27/9risMwk= Date: Sat, 13 Apr 2024 21:57:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713070676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZA5aE3j3lTWxM9WMGZSCrXNcLpZkWfP1rN5XDhrTFYg=; b=QtAFfyn0DU6DX7p0vHWdOXK+ihaVNuodpMdIhGtBvpUEsDR0RaF4wREOEPDALySzXhWQ19 Xqon6q7mFTvSbHeog01EYdTWf53b0pE6Eg9DO0camN1FNwCz5A7SUir7IdKarfjlCP8bRL qZzML8WeqEsztT4SsIcfPqOsvyKjmiM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Vlastimil Babka Cc: Linus Torvalds , Josh Poimboeuf , Jeff Layton , Chuck Lever , Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Johannes Weiner , Michal Hocko , Muchun Song , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm, slab: move slab_memcg hooks to mm/memcontrol.c Message-ID: References: <20240325-slab-memcg-v2-0-900a458233a6@suse.cz> <20240325-slab-memcg-v2-2-900a458233a6@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240325-slab-memcg-v2-2-900a458233a6@suse.cz> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: xmoyhg3eho7xttd6at55ws6o1rxa8mzb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 04952100002 X-HE-Tag: 1713070678-319295 X-HE-Meta: U2FsdGVkX19iPTVgqSsWMP7HnTKhIfKYYC4jB8HQL74zPiIySlY7GTZZANVyIY0GY2jq2sk/86F7L18gA/TLLJEb4DsKgEvA+5Kosofb7Ebwxg9fs7HEZNkRb+hNAprTdi497XEflTSBGmGOEIsasfMlx9+yIjbvY/pV6uY2cy7fzHIVP+Dp6O/wV01VQt+H0rvGQE0aTq+1szrY2g3waGuJSuGHrhKkDxR2yx6JnDmaxQmu/EwVKF5hJL/IYNgxCeGe0e3X1j2UPt43ancyDbMlEYQzY29EDp3hHgAs7B8JDhzBLsb0O3+LnytQDmmLhP/mQSVIWh1GZNsGkvEJmv2n6DJaQOE9R/wC15K9OBsz0BSJetu2xU4zuYO53E0mqHw9W3ptYjR1wxS4WMHpbn47zhCxRdl5hfrNZDOwJX6+X9IN/uLPoicGqGAtKUBr7r6JVFSqivEEkEfgtO1DRgCSFZGPeMv5ooFCq+/AqNZpUViYy0E+8aXVfw+sJLXV3nlqYcUeImuW61u4DhJNB1dAtmMO5cmeGaUo0nKvafudOVF6joGBwVdPl1iDplAyCQ5haQSp0Gqf5SxQDsgZT/eN1dL/pqoyx2awfiumTCZQJagjYroiaCaS5GVdOlfV3pxcuC60NeuwTJOO4rQ1OrGfJcEDUPo7s/bcfowuGcvD+2135Xyk5CVKmXT1T5yRN+rHLTSM1O+hwbo8FlYX/ZpFgmtEF4jpAlcPBsW/suQAeHRHx9ScYsm7CUxDGRmfoOrjKYMzp4PET9mVo4bBLh0tD0G/l8tBbScoQpY/Rbpm8G4C8F6OaQSPFAhRoVJnAfTapvsjZxZ7d7BBXOfF7+B05vgbSGE9n4i+Uvuccq1pvpMEZ48p+H3cuYokGFXltvS4k8IlULnQ4HQpUvKreguJTMeqddjTsy0iTK5p5NndDy+HGdbrA6CYxWKiSSRsuhLj7RBXYVLnlMSfC8L 6mGjrMJx QIhD3jsN1np+Kk2hjb/XYeglsyQvbEaSv3+m586gsVFGzBtiL+2dS71sLIQAmve30KOOpMTS6XcE/oUDKe6zkjBX+2jxiYDOvcVbYcYsJ4owsjDfudgncKhu/HBnAq8VspMEx+yhoZiFktG41IHESZezpjpgDGi8tqhr3VV1upT4abjbQe3D3i/d1nfy6ZOlkJ/+I4K0NqaoLRVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 25, 2024 at 09:20:33AM +0100, Vlastimil Babka wrote: > The hooks make multiple calls to functions in mm/memcontrol.c, including > to th current_obj_cgroup() marked __always_inline. It might be faster to > make a single call to the hook in mm/memcontrol.c instead. The hooks > also don't use almost anything from mm/slub.c. obj_full_size() can move > with the hooks and cache_vmstat_idx() to the internal mm/slab.h > > Reviewed-by: Roman Gushchin > Signed-off-by: Vlastimil Babka Acked-by: Shakeel Butt