From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEBEC2FC0F for ; Thu, 17 Aug 2023 18:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 462E3280041; Thu, 17 Aug 2023 14:11:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 412F1940009; Thu, 17 Aug 2023 14:11:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DA7D280041; Thu, 17 Aug 2023 14:11:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1E1BC940009 for ; Thu, 17 Aug 2023 14:11:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AF4071208B9 for ; Thu, 17 Aug 2023 18:11:56 +0000 (UTC) X-FDA: 81134390232.10.F9B6ED5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 606BC4001E for ; Thu, 17 Aug 2023 18:11:54 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KDpTJyGn; spf=pass (imf27.hostedemail.com: domain of lkarpins@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=lkarpins@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692295914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rTErNomPttgl/viRXoYlofNYirDpLy640wteux782+8=; b=ZQXGCpi6N9AENz511/1/CAVb65TEI4VOfUTiySqHDgUR3sPbjgkIRvChTyW67VPMc29uKw 7LNoj4+S/NgQrOjTdYpkXcTAIwEVwi3lvmUisNOUkeSSL2ADxvatyVwAZS9xl8H5lvdRj0 ePdn99YJ08KO5oyI4pd99G7C1vuOdtk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692295914; a=rsa-sha256; cv=none; b=36/m6/XJaKwowUs4Y8EOz8ixc+/TuFVKq2S64OynaXkyh+pw1MW3IVtIoAQnlZBBW+xkvb Ezq8qJ3qMZ2DIjt91MlirmzRUGhHDe0BkUSuugu6vljogLHucGQQNY1H2Gewhy246+oHbE H1B1nsffge6BpuD+ZOJjWPdvkwt0pBY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KDpTJyGn; spf=pass (imf27.hostedemail.com: domain of lkarpins@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=lkarpins@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692295913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rTErNomPttgl/viRXoYlofNYirDpLy640wteux782+8=; b=KDpTJyGnrmte9E1jvxmVO/haJA+0zv4AfsImkSXeRO8NmFoO67pkbTy/KDUH1NiY9hnLyL 3yJQKtdS3jjhvbhkL/wzr3Z2bKMQUrrDkh+XFUPnZ6Q0qYbqjFctE/VvizQ8hfLFp/oFAD /K5DV3jwL7jk1UUJDBIPz3yaWgcJ2FQ= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-al69KnFhPda8RGfyN5MkUg-1; Thu, 17 Aug 2023 14:11:49 -0400 X-MC-Unique: al69KnFhPda8RGfyN5MkUg-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-56d2cebf66aso178134eaf.0 for ; Thu, 17 Aug 2023 11:11:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692295909; x=1692900709; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rTErNomPttgl/viRXoYlofNYirDpLy640wteux782+8=; b=jG50TAjJFN0i7BSo3pJtY8oJOFZw0JbknJbeJu4DnMdbFeXy/4X+6gq/ZpPY19aezz QBilxOYa3yE2dOhwJf8cudgOw9WBEd2zxWFXsW8Wu9qK7l/f5H7avM0PbulUL1unPiMy V9k23Y5uAFo/FY6/3sDj6I5lvq74SrjTDJpkDWbRt3Jf6RxB8+hc72W2ntci3dd7SUQT Zsx5ILPlirQGpaAk8IaUTYftOnYKRGX1zEuW5tKvwa3kQjwg5LbcfZUIoCb+tkA8QKOM wUrbfVKNAZ5aCFmefTYWlvKek9UfE7/IxqdsdOzeGI1XGMZMuCshYWx9icRyiaPqihJo AQRA== X-Gm-Message-State: AOJu0Yx8MVBPf6URDJgZ8XwZBTDQX+plkb+jh/WVIWaXkqijFmzBvqzl tTogIzZC2SiCyZJuVupBd2GUpokY0jXl9tZXIizKyZjXpvHrQVrshS8PNepdYZrkyYnLF7VhX0x Py+aX+YNl86U= X-Received: by 2002:a05:6870:210f:b0:1ba:c622:3d5a with SMTP id f15-20020a056870210f00b001bac6223d5amr221685oae.18.1692295908799; Thu, 17 Aug 2023 11:11:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwERhgiG8BQEbAQpSqEJpeljF8hq9akQQFNWC+aNaxzMmCXPlOlMxrBacbtRCH+3VoEl22qg== X-Received: by 2002:a05:6870:210f:b0:1ba:c622:3d5a with SMTP id f15-20020a056870210f00b001bac6223d5amr221663oae.18.1692295908583; Thu, 17 Aug 2023 11:11:48 -0700 (PDT) Received: from fedora ([174.89.37.104]) by smtp.gmail.com with ESMTPSA id p15-20020a0cf54f000000b0064721cf1535sm50551qvm.62.2023.08.17.11.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 11:11:48 -0700 (PDT) Date: Thu, 17 Aug 2023 14:11:38 -0400 From: Lucas Karpinski To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Tejun Heo , Zefan Li , Shuah Khan , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_memcg_deletion kernel mem check Message-ID: References: <20230817170702.mwem4nsy2ka4gj7n@google.com> MIME-Version: 1.0 In-Reply-To: <20230817170702.mwem4nsy2ka4gj7n@google.com> User-Agent: NeoMutt/20230517 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: x4u1pnjbaqsh3yss6ahrw7brpoqe4sp8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 606BC4001E X-Rspam-User: X-HE-Tag: 1692295914-972628 X-HE-Meta: U2FsdGVkX18PiD1O+WGekU9itMxj/Et1Jihqd+w6zYeXWL0aZXF4ZjZx/w/fDephXbZZsRJBcUU2X7OylFSyKzkuLVYFJs9+3aehqPBHLjW4hJdkvG5e0mCV/ElBVvXc7DAGHpDzcEPyPUbY258WCORhkbAaMohFZFKC6FGmrg47ZDiN5MZBwM8K8mde1+eDXusOSYhsvPXCbzl9j2xCSpJbA+UGOwPf4VSNLLxzKxYrEnJuSyjIzJC+btFBPH1SoQ1OXKwthC1NXEMCOaCg8IsqPI0rMQf4Sm40nZkaQo4kTTPuL/K8NfLbP47EV2Fsd1lQGv5gmW8cZSsD4E8ULragBXn4gBfjOMzGxk86CFp8LvNRxzBHjoFTabLTfX1C4CkjMVZrPqKUOK5vKNHRPv03Fu3BpEOTIInlN2L77MrSGRa2E1smt9VlyKuexZlZjSuex42BfM/GAmiNaK+wwL3vIhj/b4ASVSg5WEz91PiJPdJpBQQx1a1H/Kx1OcCgTpaXQ0Mt4yj44vE1zebT1WPfDgS5h3zAIwsanHGQl8VOwmdEQbhnnfstQCbCSC6oEIQxbdLDfEFWzrJxWMj9uiNiIpfifmKbChcQAcX0s5JwRaDPrj1LvZMGtatgbFnuM4V+Ek/zezxmVyxWs+iSYh5Urg6zAIFQIW5yPh/AgJ0kB2/3UH3HMF1DaR352Yw+/4IHnRKDK2aVzr39Ul/qEtz1JQrEO44UruNAOUMpKVjgECo1WJGBC3Hw5+GuSavuTakAod3JO7sajZuqNyV0qmg8ESZpsit6S0m38MigtQBe7mZSt5AwEQa/8UKPr+LgHPjzATOMh+KgAR+UkjXrr3VDq5air7GQjoINNn14RzZ+EsauWpqvRYFtovNHjlNhqA2HtunijBu8DsbTMKkBjDbhHDo+3gPlJfjdNAKTRdqhXobkpqH8wHlI7FuRRfE8zrLMcvgsW8yfcSGhx4p shtWFF7I Dx9LoU8aYzjllD3Nk/Qw908g3REfewUwS58kxsrNGBssDDTk06kzocbOBAzGV5zifSXhUlJmyaFwwc42pGf9Q0omM6rGfAbyhIKlSzuN0MmLczBjZMfjtNKUcMpd7sVJbBNOcbdnggHZ5kOxixIy9pAczt10YjV+//Pv2l1vgcI5FXqmuB+YUtcTKcngoR2gGvbpg16Gs2G9riP2CDR9gt0JS0ivXBhIjkI7pr6HgWB4nTWpcnE29EkjcLkSm2KsICnaZcIUMfq05oLn6SIQu0jxZewA1J1OSERJzrUra/BNh+JW9yU/V+evshA885Tw/4iPmfX20RyGw4MZWIrICRDJZ9X+qmmEswYPe5h8TDBVfWGpvA05BCmchRSF3pxAjD3aJmEFyhsBgpqL4FCp2X3zPHI/AMPFOVJKL+wC6O7IYyYEBWwSBEOewh8By4VyAMCVhHYW+6QVym37ddjGhoJG0ImOnfuSz9Smu50qtdKB8UOQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 17, 2023 at 05:07:02PM +0000, Shakeel Butt wrote: > On Thu, Aug 17, 2023 at 08:47:26AM -0400, Lucas Karpinski wrote: > > The combination of using slab, anon, file, kernel_stack, and percpu is > > not accurate for total kernel memory utilization. Checking kernel within > > memory.stat provides a more accurate measurement. > > > > Signed-off-by: Lucas Karpinski > > --- > > v1: https://lore.kernel.org/all/eex2vdlg4ow2j5bybmav73nbfzuspkk4zobnk7svua4jaypqb5@7ie6e4mci43t/ > > > > tools/testing/selftests/cgroup/test_kmem.c | 25 +++++----------------- > > 1 file changed, 5 insertions(+), 20 deletions(-) > > > > diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c > > index ed2e50bb1e76..3ef979ee0edf 100644 > > --- a/tools/testing/selftests/cgroup/test_kmem.c > > +++ b/tools/testing/selftests/cgroup/test_kmem.c > > @@ -166,7 +166,7 @@ static int cg_run_in_subcgroups(const char *parent, > > */ > > static int test_kmem_memcg_deletion(const char *root) > > { > > - long current, slab, anon, file, kernel_stack, pagetables, percpu, sock, sum; > > + long current, kernel; > > int ret = KSFT_FAIL; > > char *parent; > > > > @@ -184,30 +184,15 @@ static int test_kmem_memcg_deletion(const char *root) > > goto cleanup; > > > > current = cg_read_long(parent, "memory.current"); > > - slab = cg_read_key_long(parent, "memory.stat", "slab "); > > - anon = cg_read_key_long(parent, "memory.stat", "anon "); > > - file = cg_read_key_long(parent, "memory.stat", "file "); > > - kernel_stack = cg_read_key_long(parent, "memory.stat", "kernel_stack "); > > - pagetables = cg_read_key_long(parent, "memory.stat", "pagetables "); > > - percpu = cg_read_key_long(parent, "memory.stat", "percpu "); > > - sock = cg_read_key_long(parent, "memory.stat", "sock "); > > - if (current < 0 || slab < 0 || anon < 0 || file < 0 || > > - kernel_stack < 0 || pagetables < 0 || percpu < 0 || sock < 0) > > + kernel = cg_read_key_long(parent, "memory.stat", "kernel "); > > + if (current < 0 || kernel < 0) > > goto cleanup; > > > > - sum = slab + anon + file + kernel_stack + pagetables + percpu + sock; > > - if (abs(sum - current) < MAX_VMSTAT_ERROR) { > > + if (abs(kernel - current) < MAX_VMSTAT_ERROR) { > > I don't think this is what you want. Since slab, kernel_stack, > pagetables and percpu are included in the kmem stats, you just want to > replace those with kmem. Basically keep the anon, file and sock stats. > Will fix and send new patch version. Thanks, Lucas