From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BF8C35FFA for ; Wed, 19 Mar 2025 19:36:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EF2A28001C; Wed, 19 Mar 2025 15:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 973A7280010; Wed, 19 Mar 2025 15:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83F3928001C; Wed, 19 Mar 2025 15:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 60721280010 for ; Wed, 19 Mar 2025 15:36:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D06B4B66CA for ; Wed, 19 Mar 2025 19:36:28 +0000 (UTC) X-FDA: 83239307256.30.D8E2B2C Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf20.hostedemail.com (Postfix) with ESMTP id DCA0D1C0004 for ; Wed, 19 Mar 2025 19:36:26 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TEIueVsF; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742412987; a=rsa-sha256; cv=none; b=GIPzSRdGmDpCYcCI2MP+6SRvHSeapo5J08FrTxEXU+0LpKouc8LZ9pg0x/zx79C3lekXpF 1L1mGhocCB/2oiNPu1e2IayY8YbJvOJxpmQjADiOv+kSewtBjWQZnYciHlRfTlbIOpYuP2 BgJI8QfKQRrQ6U/bye9jOn6keQpKRHk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TEIueVsF; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742412987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DUhHul+GQB09ExhXQGylt0MFwmGkY50Obp7AgaSPFNY=; b=PfSwfBUSvxnf0fES0Soik2doFItoNNBUa+jewy8NNCiR1DuWp0M/0m0g4UzuulrDuARDY8 5Cf0op/ZQpklKor4Nx4NCuw30dsPxlZAiPxyvf4TU1P0cthvRpftirAzIBmKDQYJN4pWw4 nfnqbeNO0BZW/Fy1Y8MH7IQkWufHbKc= Date: Wed, 19 Mar 2025 12:36:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742412984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DUhHul+GQB09ExhXQGylt0MFwmGkY50Obp7AgaSPFNY=; b=TEIueVsFglnybKo8FFiwe8d5GLPH2u+QLf+3Il+MaswPlr/59POrUuE5tSIiPjjxwCSVmS PeiJ1VlXSSCcDSnUdPUfk/YJKQKRMtNdnMKjtttRsSSm1Pkccio4ZV4iZS2Dmu0GuPXVIh nprhIvmQaXlQXRlXeU5DSXCfqKst3Xk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Jingxiang Zeng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, kasong@tencent.com Subject: Re: [RFC 3/5] mm/memcontrol: do not scan anon pages if memsw limit is hit Message-ID: References: <20250319064148.774406-1-jingxiangzeng.cas@gmail.com> <20250319064148.774406-4-jingxiangzeng.cas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250319064148.774406-4-jingxiangzeng.cas@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: DCA0D1C0004 X-Rspamd-Server: rspam05 X-Stat-Signature: pfkhfa1qh65tdyxcj4hx3qwxcuoigcom X-HE-Tag: 1742412986-247030 X-HE-Meta: U2FsdGVkX1+loLGuLBX5u2G8notI1UhZ3xx8LPuKA89cEw1ktK1ILcwHEFAyd6oHk6oF+ZqWcSWlCWaJ17Bk+HuxXiZpW/B0lik248MnmFuQmOBHkd9J4ypx59N1AUJz48cwd65DarGaFsSGhf9mRAOcE4/UCEgtGZO/EeEoLoebAO11xbNya9UfZWPnp22utx1uD2tvf3SCTCmC2vfYYj4Qck+vjw7TgiCUmQE08rFTXLfeOU3RFaFcrcl6cM2Yuviagx7cuut1eWUeNSm9TKbZ7yoPK+2na3CfMmoG0wQEEzNCfEMWOFMvrHcQQXua8hqwF/QQtq3ee6NP9oZLbyoeIom+nUM1UxVMT6sfTv4lkPtyXoc4PvmnOLsKOQPVtUsCYkRuWzySR5K5zDU61HtbU134ZnhG66PatsL+03IWO/ehKg2cGEUgcUdMgs96L1ICb71HPtW7D4CBUMbrfzupdLIw+Z/VOQ/Dxv0+MHgVXwgEKGXeEdpsPLxNM5MpzhYJzTeFHEAsWB11YgOd0g2yCzm2Lj2q1jHsWNGojKttHoYO3J/uQDRKhHxJmhs0Zu4TmvgZyqrkipZTbb2OLvbKejOff5w1T/TdrCien014QeSGYk0Il3aPb/47bt8PZqJZM9qpkdKEDv159rT7KWC/r1eRp1l11K2DcBYalOXCIcP9FbIfQagKqJhVqcQscXOelSZLmOlzsO3XEsAO2why3aPJEaL2SzAvcA9Cg5fqoEr8ooJCsdRAhWcqP42PJ2RD+JKakHnLc+Iv4NrH5VTInxX5vQk9bt8kvehHcnKgm2ZFDug1dQlEOvhqV8T/HWh4OZF1XJVFUfhCmYvs+EgKnwA146NbRqqlgCP27WUy5QdM+XGSfJRxlHMNtkN1g4uLf9i0tUmbipWF5iQL+YUteoSGbh96MoUC5VAdN8KvRDnAgFhvUZTUi1mwsPcSr6G0s0yYmu/QDkRzqsJ Kr7EB/8y HhaSD5NG1iMLCO4UrNv3Z3F6/HXkbG4I57+fNf4Sz6QSmtrlTAo/p6OPPxFgmCWoINJjfMmmOjNPLWm0ZVEocuhCSzP101ml/n8SHGxryHbpIiFrwGPVjFauGZQx84Q0UoACcZK34syfE09IYfbU/UbE89z9s6m0/4kZNlQYoHFzvPHTdAAgEgaSNVxlKdyNkueBMwj6cvZ6FuIA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 19, 2025 at 02:41:46PM +0800, Jingxiang Zeng wrote: > From: Zeng Jingxiang > > When memory recycling is triggered by the hard watermark of What is hard watermark? > memsw, anonymous pages do not want to be recycled any further. > This is consistent with the processing method of cgroup v2. > > Signed-off-by: Zeng Jingxiang Is this patch orthogonal to the series or is it needed for v1 as well? > --- > mm/memcontrol.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c1171fb2bfd6..623ebf610946 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5072,14 +5072,21 @@ void __mem_cgroup_uncharge_swap(swp_entry_t entry, unsigned int nr_pages) > > long mem_cgroup_get_nr_swap_pages(struct mem_cgroup *memcg) > { > + struct page_counter *pg_counter; > long nr_swap_pages = get_nr_swap_pages(); > > - if (mem_cgroup_disabled() || do_memsw_account()) > + if (mem_cgroup_disabled()) > return nr_swap_pages; > - for (; !mem_cgroup_is_root(memcg); memcg = parent_mem_cgroup(memcg)) > + for (; !mem_cgroup_is_root(memcg); memcg = parent_mem_cgroup(memcg)) { > + if (do_memsw_account()) > + pg_counter = &memcg->memsw; > + else > + pg_counter = &memcg->swap; > + > nr_swap_pages = min_t(long, nr_swap_pages, > - READ_ONCE(memcg->swap.max) - > - page_counter_read(&memcg->swap)); > + READ_ONCE(pg_counter->max) - > + page_counter_read(pg_counter)); > + } > return nr_swap_pages; > } > > -- > 2.41.1 >