From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12ADC25B78 for ; Tue, 28 May 2024 16:21:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1DC66B0089; Tue, 28 May 2024 12:21:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD01F6B008C; Tue, 28 May 2024 12:21:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C950B6B0092; Tue, 28 May 2024 12:21:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AB3E66B0089 for ; Tue, 28 May 2024 12:21:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5C43040530 for ; Tue, 28 May 2024 16:21:06 +0000 (UTC) X-FDA: 82168318932.13.B0FA982 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf24.hostedemail.com (Postfix) with ESMTP id E043A180028 for ; Tue, 28 May 2024 16:21:03 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SxkxAFRw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716913264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kE86HA2Pl0WMSgmbtH/SqDoMVET8ixgS0B8pGBr9o2Y=; b=JNvf6BJb5XsCGYgmhZPIf2qJ/ypPpRQ/DVhGBlcwhjBF5jr1pAB8itFoyU2QOoLEO439C0 FmzHP7Zh4kiVMIba5uTYROkq/9bo99Aj33BB7ZUligfUiFSRnkT5EJLb3StoK9sqTbitfI ZAGaNTXm7vjt7pkklAbkqGetASHojUQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SxkxAFRw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716913264; a=rsa-sha256; cv=none; b=eRBgo+e8MyuHlTd84DzxD5C74eONsxcJT4OFtpFlulpfQ9fSJWK2A7+RwPZFicp4iPV/fk bfIFo+ldc9icFGNfjr/9OnBsRyXAWusMXSQChjGxjbuJjC+DfI79TQfdS3rp4DXoBMQ4A0 kLn1XWt+ViCbo3hXJD0rnqEeo2vN1Zk= X-Envelope-To: bigeasy@linutronix.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716913261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kE86HA2Pl0WMSgmbtH/SqDoMVET8ixgS0B8pGBr9o2Y=; b=SxkxAFRwvnEYce/S8woEfiSMwbGyG6lAcmE9c7Z6D8c18JY4ADn3/YM5h1L1Ij1S00/mkq D+D00IFcgn6vNp0+nM2jUOxqS/UQ1GEkAys9zesCfi/Clrx5rsC8yZowR8de1lrfqosZqv w8DlDj9bu4YZ1jjJc2KSMl3MHD3MgvE= X-Envelope-To: vbabka@kernel.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: roman.gushchin@linux.dev X-Envelope-To: muchun.song@linux.dev X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: tglx@linutronix.de Date: Tue, 28 May 2024 09:20:56 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Sebastian Andrzej Siewior Cc: "Vlastimil Babka (SUSE)" , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH v2] memcg: Remove the lockdep assert from __mod_objcg_mlstate(). Message-ID: References: <20240528121928.i-Gu7Jvg@linutronix.de> <09e085bb-f09e-4901-a2dd-a0b789bb8a4d@kernel.org> <20240528134027.OxDASsS3@linutronix.de> <20240528141341.rz_rytN_@linutronix.de> <20240528150856.u4rArjaq@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240528150856.u4rArjaq@linutronix.de> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E043A180028 X-Stat-Signature: 95bqjerqy67wnsytmk9pzfxq83sjpft1 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1716913263-2015 X-HE-Meta: U2FsdGVkX1+4aVTzrZodCkOnNEnFYZCC0dIFpBEzGIekLm+AK2h0LwS/FfGnkT6HvO6tFzHVdddS4AswCnRNhAHHgqxDzK7C0oZ29+YlXetJxn+q/0DxHB1tgHjbbzO9pD4mVRaLK30M28n4AVBqtIweDklcIksIjCKSjnGfdhn/D1wtkYb67OPN6sPXnnpAgOsakm06ai3bTe1Gsn0+UmY2Pne7PpT1PntiSIMYGO7QYRjo5Q9djw0clBk1jKOYWsZz+Vin2vmSxu1UmLFCqa9Ajf/zuMvZEo4t2BDTYin0cpFUDkxYvA7eFnfftsZTaE9crKoyvI107niCcQ738/ETXKjngi7dxG6GPg3Th6NaymUfWtFAbVL4VK5qmQQ9ucXm0bUufWuQXJhi8sc7bpfkSITO0niH96AxUP7dqz0IW4TK8A8VLupF7I0gDlJNdTA2+A8B3qN4+IoXGmuu7NS6EIO+KogUqKO8x8hqccj9Es6fD+yVKarZI0XGEcAdYQoYl4Xgp5ghBboaPsMZihcdUdej71pJekJpkuMCpJxQXbFNdx7+uatBcOHRyOx2eqFa9xOqxgCraIp65scdP90gW9a2tLE1uTzltFuyjmh79f4SyDBecncqKenh8f7DPlxN/91iFmnw4OGaMx4tLOVy0MsmHz6GItIFEwN+hkQFQZZf+E3RsvsOJAx7KZBrSX7lW9cceoIp2thci84h/ukFJPL4HSabE0H5GSPoulDgW/Pp/dtckOQa+MT2e/zHhznJFmsB3n3xPSnZvGUgZ66CP5Xv90IS3PXXDS8dnZjCIY1YcPitD7WzkUkIQTFeKph0BwQ5rzTp9K97Q0LiowrvT3xj1z8/jKqqttTTT7/vr0zOzHmXWXzvBTpIPMtvGEose4YliRj2ewjCxHKt+iyYiTgli50X/hAkPzxG44X79FwzRejxNFDyCa7azIObXe8je9MdmMFLgl6kSGG ncbsxdHY WMA1LMY/GM2/D0Yc35A49p3h5ivP0plnmmTFKjOElu4fHEJqwKvNyOfyF5FQPAJMFRI1SBvCa4R4EryTAF16X+EG4Ze4+10qCYnvLS2NEKk9KzgM3k/bZASOG6xjMuW3IabYqLif1y/WtTwfKzNJgmHiXjrlNFATTxf0W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 05:08:56PM GMT, Sebastian Andrzej Siewior wrote: > On 2024-05-28 07:59:57 [-0700], Shakeel Butt wrote: > > One question on VM_WARN_ON_IRQS_ENABLED() in __mod_memcg_lruvec_state(). > > On a PREEMPT_RT kernel with CONFIG_DEBUG_VM, will that > > VM_WARN_ON_IRQS_ENABLED() cause a splat or VM_WARN_ON_IRQS_ENABLED is > > special on PREEMPT_RT kernels? > > we have the following in the header file: > > | #ifdef CONFIG_DEBUG_VM_IRQSOFF > | #define VM_WARN_ON_IRQS_ENABLED() WARN_ON_ONCE(!irqs_disabled()) > | #else > | #define VM_WARN_ON_IRQS_ENABLED() do { } while (0) > | #endif > > and this in Kconfig: > | config DEBUG_VM_IRQSOFF > | def_bool DEBUG_VM && !PREEMPT_RT > | > > which means on PREEMPT_RT we end up with "do {…" Thanks for the explanation.