From: Shakeel Butt <shakeel.butt@linux.dev>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] memcg: Remove the lockdep assert from __mod_objcg_mlstate().
Date: Tue, 28 May 2024 09:20:56 -0700 [thread overview]
Message-ID: <nkgueigu3ybnzyj424ngxyb26jnyph2rbuyroxkgmrcj6ze36h@q6m7xfoiis4r> (raw)
In-Reply-To: <20240528150856.u4rArjaq@linutronix.de>
On Tue, May 28, 2024 at 05:08:56PM GMT, Sebastian Andrzej Siewior wrote:
> On 2024-05-28 07:59:57 [-0700], Shakeel Butt wrote:
> > One question on VM_WARN_ON_IRQS_ENABLED() in __mod_memcg_lruvec_state().
> > On a PREEMPT_RT kernel with CONFIG_DEBUG_VM, will that
> > VM_WARN_ON_IRQS_ENABLED() cause a splat or VM_WARN_ON_IRQS_ENABLED is
> > special on PREEMPT_RT kernels?
>
> we have the following in the header file:
>
> | #ifdef CONFIG_DEBUG_VM_IRQSOFF
> | #define VM_WARN_ON_IRQS_ENABLED() WARN_ON_ONCE(!irqs_disabled())
> | #else
> | #define VM_WARN_ON_IRQS_ENABLED() do { } while (0)
> | #endif
>
> and this in Kconfig:
> | config DEBUG_VM_IRQSOFF
> | def_bool DEBUG_VM && !PREEMPT_RT
> |
>
> which means on PREEMPT_RT we end up with "do {…"
Thanks for the explanation.
next prev parent reply other threads:[~2024-05-28 16:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:19 [PATCH] " Sebastian Andrzej Siewior
2024-05-28 12:34 ` Vlastimil Babka (SUSE)
2024-05-28 13:40 ` Sebastian Andrzej Siewior
2024-05-28 13:44 ` Vlastimil Babka (SUSE)
2024-05-28 14:13 ` [PATCH v2] " Sebastian Andrzej Siewior
2024-05-28 14:19 ` Vlastimil Babka (SUSE)
2024-05-28 14:59 ` Shakeel Butt
2024-05-28 15:07 ` Vlastimil Babka (SUSE)
2024-05-28 16:21 ` Shakeel Butt
2024-05-28 15:08 ` Sebastian Andrzej Siewior
2024-05-28 16:20 ` Shakeel Butt [this message]
2024-05-28 16:21 ` Shakeel Butt
2024-05-29 9:16 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nkgueigu3ybnzyj424ngxyb26jnyph2rbuyroxkgmrcj6ze36h@q6m7xfoiis4r \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tglx@linutronix.de \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox