From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA83EC77B7C for ; Wed, 2 Jul 2025 16:08:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A81F900002; Wed, 2 Jul 2025 12:08:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 857CC8E0002; Wed, 2 Jul 2025 12:08:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7474C900002; Wed, 2 Jul 2025 12:08:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 63A948E0002 for ; Wed, 2 Jul 2025 12:08:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9F3CC160300 for ; Wed, 2 Jul 2025 16:08:33 +0000 (UTC) X-FDA: 83619807306.10.AC56F0C Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf15.hostedemail.com (Postfix) with ESMTP id DD4E3A0004 for ; Wed, 2 Jul 2025 16:08:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Fn9j41WG; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751472512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DA9or3GnPWkEvPbsGm5zpjvC/QtJWGUlbNCVxhB/hgs=; b=QZ8MeUHbnwiTByBt0pcpeOoofPsebuw31zFjr02/RNxC3WwU/JIyvmk+he1khg2xRCdCxX YZXHHjeUXpgNcCaCe+EuGnVIGpTOZyRMrubbfabpZqv0HlPYX0uVwbPIU5T7HFZlWbuyxC R5fK3hbq2c8OVx7eJkqizILA+HhivW4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751472512; a=rsa-sha256; cv=none; b=hoEsACN2EwAgijrVveLqGCOtIUZHIsNI+AwwTLQebNuQrAc771bA9AYRQ1NYluXeDOyO2p CzB0+8DMUrF0gIjzld4UdSkH3s3wGbOafgGD2XvzPlXpt0RT5skJbt/1hgjd6NfP0HFNNG nEQyHnUZnchv1kN/sZaZHsP6KQeFvjA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Fn9j41WG; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 2 Jul 2025 09:08:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751472509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DA9or3GnPWkEvPbsGm5zpjvC/QtJWGUlbNCVxhB/hgs=; b=Fn9j41WGIBtS0B2AR1FkyUdgi9wB+rAiywwC4QP/aiO37R/IPaGNa1hVDiCf8VNbGbNfJF s1LqDJHCrp7YVBJktjSrVa6y9JjiP5/rzUbcYgnoMOm3VDrRKjuIfSZpZPYcbuNAhDl1TN K7Pz1c/ryKYG4fwDpugJW4KoLi5YPt0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Dave Airlie Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Christian Koenig , Dave Chinner , Kairui Song , Dave Airlie , Matthew Brost , Andrew Morton Subject: Re: [PATCH 02/17] drm/ttm: use gpu mm stats to track gpu memory allocations. (v2) Message-ID: References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-3-airlied@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630045005.1337339-3-airlied@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DD4E3A0004 X-Stat-Signature: 9ggbz4jbwecimiqeezugfo8pwk617hc6 X-Rspam-User: X-HE-Tag: 1751472511-954868 X-HE-Meta: U2FsdGVkX18nT9oxdrqcUhMe2sFdcfBiOPWvJnJDiwOrQ2InRc+X2qYPjhDtj1qclo3JGIOrXHt+Eefhj/yJ8ENntWiA4qeA6gMIPMzDrR4a86L0RJVH+fJ1Pc6WiD4IjsdRteAaGPCWquGHPoEPSar04wljMY1gLYPZaujRY7XFT1S1Y9XpVYINbbELdehqTRT+VSxqjbVv/TzK7Bgfb1yEJOIYSsqkH+NV1fXp/px/mFdMdhuDfucejuzJkH30AR+YmrIL8869k2r4EnUitMUkIE339Bq6d2yGJoD9osdIslZT2/f8QufbLrMZZnXSmbfAPuCV4/9gMztKiDF9Io82URvdWvP7vtKQ8DN4/U9q1XYgRuwS0+k7KWD5aUwncfEAA2G0T9J1CfUEbEr1hlOeXyXOgxNkblcqjTyUQd/6ZAbt7XxXQBjbEhR604uueyEeffxftEAWvItV2B2aP6ZCE70IA68KOASliNV4SVeoA229ldDxgM6AU2OAXzNwyfEpARUIObz/bqQl2sSknQ9eId8KVAmZwozZQBPM45Z+iU86M+nUaWdsJaX7bWjMNeF3AHLcjHlhrE7l5A5ISz8NyJeHhVH9jG1nNy5UC8aw2JJXzKCI3DgLffmpqCjscSTFQ3H/n7TGyv2MbeEVDHMcDDbJagsPesJiYzFr9P57xSAkm6hR7+EUhV97SmtBo4cLsZ94tEif5JpP/uQx26GZVixN1ahqlYQzlnMVMYydez1K2bCCBv7miKnl0NbgBm+POrPacw7aYj1KuUjyhkcrFHFBx5tnXU5YxJjvqzSN/NP7scda3C7bCyVnTDroIeS+d9I3Pmi3EUp95iVybBwNSPzxBv7AGOWkNNaBu96/glHcteaItPkh63A7C+GWsNs+YcII+gniddKCagmrwOZy0MnsXhpfY4OOrf6uctpDt0ZLWxAruPjolkZFxKo4pC9PUaeRVqbjMMuY7uW kanUBicv OB+cdj8sBnVPnfapFeZC7uXY07DgX/5ij3wngge/6Kt5Gx89FvBB8Her0Btp9w3C+PXMAfjx9NnNYlrxi+oQHM60CxCTRkt/vRb/GcIx0+Lck6tNegXq9XilJs18jD1/0iWF65BmZItAeP+cXvbPWzzpghcmVmarwxrkZblz/+E2LEEcAA5iMy4BUis2GBlcAFr/T6avWU1jqtyA9aMVBibJ0uj2emlOdZWVq7FfN7K+SCQFv5WwGChvDMWcIeeiPhylGdpB/gXoLbwMWJ7Z7/p9WWhUX8Xcvok/krhl99ZTxWvCNPZoB9bgHet87Thr9khV3AA8Vof7flpbj2YzfHA0PbYVKxIA+k4IXSSM7shCMOIf5w6O7Qb6vpT5polKXe0i1ltBcVAFYUF7jrPVF9pbctfmOZpX5LbRo2GBcKcwO5GUD4UqScXYdcg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 02:49:21PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This uses the newly introduced per-node gpu tracking stats, > to track GPU memory allocated via TTM and reclaimable memory in > the TTM page pools. > > These stats will be useful later for system information and > later when mem cgroups are integrated. > > Cc: Christian Koenig > Cc: Matthew Brost > Cc: Johannes Weiner > Cc: linux-mm@kvack.org > Cc: Andrew Morton > Signed-off-by: Dave Airlie > > --- > v2: add reclaim parameters and adjust the right counters. > --- > drivers/gpu/drm/ttm/ttm_pool.c | 34 ++++++++++++++++++++++++++++------ > 1 file changed, 28 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c > index baf27c70a419..11a5777b4a85 100644 > --- a/drivers/gpu/drm/ttm/ttm_pool.c > +++ b/drivers/gpu/drm/ttm/ttm_pool.c > @@ -131,6 +131,16 @@ static struct list_head shrinker_list; > static struct shrinker *mm_shrinker; > static DECLARE_RWSEM(pool_shrink_rwsem); > > +/* helper to get a current valid node id from a pool */ > +static int ttm_pool_nid(struct ttm_pool *pool) { > + int nid = NUMA_NO_NODE; > + if (pool) > + nid = pool->nid; > + if (nid == NUMA_NO_NODE) > + nid = numa_node_id(); > + return nid; > +} > + > /* Allocate pages of size 1 << order with the given gfp_flags */ > static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags, > unsigned int order) > @@ -150,8 +160,10 @@ static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags, > > if (!pool->use_dma_alloc) { > p = alloc_pages_node(pool->nid, gfp_flags, order); > - if (p) > + if (p) { > p->private = order; > + mod_node_page_state(NODE_DATA(ttm_pool_nid(pool)), NR_GPU_ACTIVE, (1 << order)); Use mod_lruvec_page_state(), it will handle both cases of charged and uncharged pages.