From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F8ED743F9 for ; Thu, 21 Nov 2024 00:13:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89C936B007B; Wed, 20 Nov 2024 19:13:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 825916B0083; Wed, 20 Nov 2024 19:13:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C6596B0089; Wed, 20 Nov 2024 19:13:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5176F6B007B for ; Wed, 20 Nov 2024 19:13:33 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8AE971A0A7D for ; Thu, 21 Nov 2024 00:13:32 +0000 (UTC) X-FDA: 82808177340.11.03F6882 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf22.hostedemail.com (Postfix) with ESMTP id BAEDBC000E for ; Thu, 21 Nov 2024 00:12:25 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="rSRMelt/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732147919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D+3yoI3Tk1l4Ls0opWZrCxxqVyBTDwb3hEjQXTZi1zU=; b=KMdS0KCnyw1Eoi60WvUq652pj3m3iDZ9s6pBYxJdtpQESIozTguOMPhvJPMenSxY1PbWR4 IS88DmzAljsPO7z9jmlMT9Wr24U4E9EkPmCPHvUcdampEJJp5S1YjGlTDEdGRoLpsxFoIp AknZuXbTxlxi1QoRo5OjxFTHeH6ew1U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="rSRMelt/"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732147919; a=rsa-sha256; cv=none; b=DQWMofsL2IWaotZLgBXGrTZIhD1u0NDaQuIqQru1MaW9ZzirXxDO+iHT6Yg//gRYpnLQv1 2SMxB+OlLpMnFJpPSOTRuRllko66kIIvpPmkH1gXd72dErLT1pJRg2sp4icVMElptXIeCV rVI9ld5uhn97vFviR6aSuRxyE6hHhTs= Date: Wed, 20 Nov 2024 16:13:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732148008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D+3yoI3Tk1l4Ls0opWZrCxxqVyBTDwb3hEjQXTZi1zU=; b=rSRMelt/5Wn4N8XUn/dJZwUqVAEVa288uiM3gPK/8TPDcTZGy3PYHUxZyME8j04Foq2WZq 7Ns7G4yqbANrlkjIJXEn8FDvnOyR5MnLQwycCi5jsPgCqb3kJensaFaAbJdjiX8j6EGsVw k/4/oyWWpXvO3vGTe0gV0kRSdGNOT5M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, souravpanda@google.com, pasha.tatashin@soleen.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 3/5] mm: mark vma as detached until it's added into vma tree Message-ID: References: <20241120000826.335387-1-surenb@google.com> <20241120000826.335387-4-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241120000826.335387-4-surenb@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BAEDBC000E X-Stat-Signature: q981ynonmp91taiqo4fcok6nkyw3efkf X-HE-Tag: 1732147945-564101 X-HE-Meta: U2FsdGVkX18Dvo1I+jgCXuwmyvuCNcFpGMjWU2EGB91HzyqdqPT2fbPKeWw7OaHvGuG+QcjYyFw1NsImueq7pIiRTaxAqmAs2OcCYz5fdJ3/evy1RANIw8N/K9jdjGJcF5TbL2CJxjaj2VShwTobZ3gC30QdVKFqyKjCeLc8wRjm297uIiYJsrFnrSgs9G85fstooIfxRXDBASS97CdOXcGZnsk0ouaw7p9NOWYzAtVP8JZfoyayWklqcmYYHE99sgqUCt6zjWI5nkV31Ra56AecYpO+hEzWnnaEtMKw9WCRcpddqqG4wDgE1BFxsVkMsiBq2/btVDILFDRaM93TPvW2jn3ow4f/Bz0ndIrrVBXX3V+hwYuu+UpO91hGcr5WLzICO8qbH20rSUm9UTYbndavbIvihXoqZBPA/c1Rmbehkss5aVCTOns7zhDku9BZPIn66Jga8h6MQPxh7605cFyx2+51CSow4q14zPQuRLVIL2HzKBMf8W5er356729ZXWiPRk8A1sNnqQZZToxho4eCd7kPQz9JplNuDoaLI/dLHJ7YUZ5C7V8mOOXjTALrBcfClF4DF2694xoQlk5klzDYOigip5mI8XpuRGwSO7dZxd9TyNJfTa1ldPynWnswiM3sQxoOcwkwFmyFyqoLUlE6rS2Csqcpx6CzcyIW5dLq2oonjCFsdzXxETaeV87yV/rXsT1mE44BivCWVt8zpY8BslmKHHdfaeRDbDfMdvM8g0mn1RkCM9rYtBqEf1xSWScPyK22CdWatHiyvcYkGdFtpd/3jC9P5qHZACLt2fwR4dQwJU2qIotcSDSRsGcakgvkihEw3x4olnnEm3Bo+FdDHaE1WWQkUUbFwrOneiFvWtQjOncZCYyU9XZTCcuHnWcQxD+k4kF1gLXQiqGUIkJeMg8NIP97T2cMipJmQUVuHS0kwDFOkGtuKadzkXe5NID3k9EIefux0Noiopi lpkj7Tlw E3lWlgQI0HYaA6gXcNp4YqEEY+e43+IMc5Rx9sf+3VlIcSK6fena1R0kXbLuOvD7OdTLEm+3uojIZrTKlEY05lGTP53Age3WZNM7LZ0b/iVfLlKikral+PG6s/73qKqrg/wYvPN7NtW8b19PylKauXaYSGignTejfMzZ1eCuI2/eTtm8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 04:08:24PM -0800, Suren Baghdasaryan wrote: > Current implementation does not set detached flag when a VMA is first > allocated. This does not represent the real state of the VMA, which is > detached until it is added into mm's VMA tree. Fix this by marking new > VMAs as detached and resetting detached flag only after VMA is added > into a tree. > Introduce vma_mark_attached() to make the API more readable and to > simplify possible future cleanup when vma->vm_mm might be used to > indicate detached vma and vma_mark_attached() will need an additional > mm parameter. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt