From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C7FAD0C5EE for ; Fri, 25 Oct 2024 09:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16F1D6B0083; Fri, 25 Oct 2024 05:12:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11FB06B0092; Fri, 25 Oct 2024 05:12:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F29CD6B0093; Fri, 25 Oct 2024 05:12:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D49006B0083 for ; Fri, 25 Oct 2024 05:12:47 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0539AAC038 for ; Fri, 25 Oct 2024 09:12:09 +0000 (UTC) X-FDA: 82711558776.27.0DBB333 Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) by imf02.hostedemail.com (Postfix) with ESMTP id 362B18000D for ; Fri, 25 Oct 2024 09:12:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="T ywMtwh"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=iUZ7jcUJ; spf=pass (imf02.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.147 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729847487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w90BgXkrFsRin3ZA0UiaoPIiEDD9yrDl2zP9wy6weXY=; b=DgyNNmg0mjmfsDDoAV+lUcaTxxNd9KFfGKTBXI9eEpAcb89leD0oYkFqIxZG4yyoPeON9y muO4aJtfcv8Y95OAK3ZVZUvmyh8P8Wglv9IrbdPc872Tld+uM6MH7mkFWuT8jdQFjVgu6y QqC4EMDbnhTjlYVDaPhq68wxRFI4a5Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="T ywMtwh"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=iUZ7jcUJ; spf=pass (imf02.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.147 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729847487; a=rsa-sha256; cv=none; b=biFL/E5bxEYNdfhZn6wzmYm3Cc3i/dzsDZsd0hbsxW25XK9ms+KrAgtC2PTY9bhV+2av9n vjS8goV22Yn2qru4jb6zAZIupXKGEkLl28aThnJtsy8qyYKq+V8Xd08QMgc4zKWNKREJAk RmVY3kdT4nD8L8lVnhQU+c7NipiCEwo= Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 9781413801ED; Fri, 25 Oct 2024 05:12:44 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 25 Oct 2024 05:12:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1729847564; x= 1729933964; bh=w90BgXkrFsRin3ZA0UiaoPIiEDD9yrDl2zP9wy6weXY=; b=T ywMtwh5pNjPoXvkaWMViB0gurqQzbKQ1WduZfHd36oRSIfwSHF8u7gsG8hic2Dqe ffyRZMvsyghPb5CL6Bfq35flzxkmLK87v113FAoaOe2lPrqa4P60gq4njnwYfGx7 QLyOtnOlCupjalbjJQpNnxjZA1yNS3W/drgiOGfRb3xefDnps5U9DmegGSk24a3E CJuBIp9vFav6UFwxqCJokRvOJ/A0zQJGv91WzTXAKyG5bOhq4brFQ8wCwtLwsAVd dyHppE1rQYv3M1X0XI0hSis5UFxgpL/oZjFmSDjFfOybgSHhhQsbVcGanXteTPZi Anwn1Q/7eemNnRo7chFow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729847564; x=1729933964; bh=w90BgXkrFsRin3ZA0UiaoPIiEDD9 yrDl2zP9wy6weXY=; b=iUZ7jcUJnGnhD6ztMNffjtXlr5FNyl2M3x5QHOhQvTas GvB1E06inePh/QxpufqBZr8HkdSIIuMnAwJtrjsxpMitGFq7XPxgB8NPvkLcBxCk ugOzjvDzF/R+mDl+NRaocTCzlqFHut5VfPK6z1yySA6vg1LsWGFKD0IwHwn1HWTJ 1kbCbVyDcaVUVPCpe9EPoZmBtCImVAk1pPabXaEapsKcksNs+o+Z6zxpveW6T9Le rDGlJcl5Fy3TARkccl04UXYUpPHe3QXO8EM8twRU+FHkYrND+fuHqWeLUtitPhds KuJDE2wxCrg6Sy7OmfZKgQUNVTrIY2yf+tMuWvaICg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdejvddgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepuddvpdhmohguvgepshhmthhpohhuthdprhgtph htthhopegthhgvnhhrihguohhngheshhhurgifvghitghlohhuugdrtghomhdprhgtphht thhopegrkhhpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtoh epuggrvhhiugesfhhrohhmohhrsghithdrtghomhdprhgtphhtthhopeiihhgvnhhgqhhi rdgrrhgthhessgihthgvuggrnhgtvgdrtghomhdprhgtphhtthhopehrohhmrghnrdhguh hshhgthhhinheslhhinhhugidruggvvhdprhgtphhtthhopehmuhgthhhunhdrshhonhhg sehlihhnuhigrdguvghvpdhrtghpthhtoheprghnshhhuhhmrghnrdhkhhgrnhguuhgrlh esrghrmhdrtghomhdprhgtphhtthhopehvsggrsghkrgesshhushgvrdgtiidprhgtphht thhopehlihhnuhigqdhmmheskhhvrggtkhdrohhrgh X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Oct 2024 05:12:38 -0400 (EDT) Date: Fri, 25 Oct 2024 12:12:34 +0300 From: "Kirill A. Shutemov" To: Chen Ridong Cc: akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, roman.gushchin@linux.dev, muchun.song@linux.dev, anshuman.khandual@arm.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3] mm: shrinker: avoid memleak in alloc_shrinker_info Message-ID: References: <20241025060942.1049263-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025060942.1049263-1-chenridong@huaweicloud.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 362B18000D X-Stat-Signature: 94555io3rbbjs9696oofymo13fppd8x9 X-HE-Tag: 1729847528-399863 X-HE-Meta: U2FsdGVkX19sLFL8VLd9zin+zHMp9dcnhXshNUZiyrOLJJ2blpio0pl7Ryo8XyeWHHibU2ok3058TppbVRSeeLBGif2OS2M49go/KoDsRbeezKw06C6uTb/ebv8U1GOjt3czioxryKKVDuYpDZnD+h8NTcEqq6ugwok8WFKgpowdajhUOPzANggbxk0q00uYObyOY4cz+vChKplPTBjhAxj/+TVtzFXiRpDCds8lSiT639srCKDkUOGyDUfsa1a0QCKF5X1aR40nhWgb6AlWCMhek/6dBqtekefIFcr3SWnOOPppePuHF/aZCL4hy2knH35rQmIoWp9suyB3iFED/RfL7Xq6v+5+wacuEyPXrhXEYSfArDDt/Tvz0HOAWJAMWmdfZkog4bY5OSntpcn+8KnWRXtEgctxTntphvhzIipByORFWMWAVzsgodsyqTGEbtNmwTzsOog9nxo6HHvLyAcxV0HnDqo9ZNOONIEp6R3eLLN2lXjS/D04sGKkS+S6txhpjSXsLN2gB0jfdQA0V6TdtUI6b6tWDtub+SagKsyisluOARM97SEsUX/RUJB0vf49Sr34ISX7kW13MkdeO7dAVlF4YbtqxXgSYlUGrQIhwUTngkoCjqqM1OyIiSKULacihwPjXSxC1wDz8ZLYHxsq07iQmKFBxfrCk5fX58XsLMvlbCeFCi9+LFuND6R2qB06S4DPmyDKsIVi5a3sMihjLDYSeglWLUXG7u7qPKjRPl5My/PqvF//mu43vVj4Cnk7GCz2iTWrm8thyF0VO+kR9Qu/cPJR4GayQlvvh9HYFDRIdB08BVoyAlTVu0FbXp3oGm6TwR4eSFcwZia9t8lR1JdWk64w1toVzDBDsVnN9QBQVrGKhGgsBPLMwDys060ARBlcrQ+lT2tjM2rD8OmdxYPf8kLKmCefost50zrH2IA5G3tq+eHPh7OU1SCEuEstIcY+BlIoErjIJfL STrZTyA9 rsj1j8iuxMNTXbYjpEZGlC/90SGEoPpPGtR2gz+gXwb+5ThM30ATqz/Spcbs7j9FifXaU9Z5y9SdALCHclBd4vksxXuEUotrnO8Va9l1VuR7geZJwfmVe3vOEWMXJlopDYq6CMwWt89OBq4s2ifX1+NZlx6MDP/qe4WSsdxkRkmj7YGMnMH4vxjJ0chJSE7WrR1aN/fY6bZN1MdbA1D0oN/LTnA6I2CvoknPJuBlJH2S+QEcTcWaYKx23Dnq8/5thHa/Sc8AaoBRsPoWPxig5gGQAmUJ4yWukyZDRwsKImMjrkojn4rOIfdKFYs7vF/AH6r7gWsngW9mCA4dLO+TMB5OyKWVpXcIVaTclmVGYHYZLMieNdsck4IYuE2+ZQGJIY1B9s+ggCd/+av4WyvS0piJ7JjhC8XUWH8Te8622G3TNXgM6sq8WRI1UlaRJjPmNyFjYH5dqIkbiCG2GEtap1P4NQRxgliQzZ8bCZ3oQODFG+cU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 06:09:42AM +0000, Chen Ridong wrote: > From: Chen Ridong > > A memleak was found as bellow: > > unreferenced object 0xffff8881010d2a80 (size 32): > comm "mkdir", pid 1559, jiffies 4294932666 > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 40 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 @............... > backtrace (crc 2e7ef6fa): > [] __kmalloc_node_noprof+0x394/0x470 > [] alloc_shrinker_info+0x7b/0x1a0 > [] mem_cgroup_css_online+0x11a/0x3b0 > [] online_css+0x29/0xa0 > [] cgroup_apply_control_enable+0x20d/0x360 > [] cgroup_mkdir+0x168/0x5f0 > [] kernfs_iop_mkdir+0x5e/0x90 > [] vfs_mkdir+0x144/0x220 > [] do_mkdirat+0x87/0x130 > [] __x64_sys_mkdir+0x49/0x70 > [] do_syscall_64+0x68/0x140 > [] entry_SYSCALL_64_after_hwframe+0x76/0x7e This dump doesn't add much value to the commit message. > In the alloc_shrinker_info function, when shrinker_unit_alloc return > err, the info won't be freed. Just fix it. > > Fixes: 307bececcd12 ("mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred}") > Signed-off-by: Chen Ridong > Acked-by: Qi Zheng > Acked-by: Roman Gushchin > Acked-by: Vlastimil Babka Acked-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov