From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F377ACD37BF for ; Wed, 4 Sep 2024 02:25:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D4938D0214; Tue, 3 Sep 2024 22:25:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 484058D018A; Tue, 3 Sep 2024 22:25:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 264DF8D0214; Tue, 3 Sep 2024 22:25:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F22CA8D018A for ; Tue, 3 Sep 2024 22:25:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6D684803E3 for ; Wed, 4 Sep 2024 02:25:21 +0000 (UTC) X-FDA: 82525464042.02.AC40D0A Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf02.hostedemail.com (Postfix) with ESMTP id C521C8000C for ; Wed, 4 Sep 2024 02:25:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=k1BX43+E; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=N6buhWpn; spf=pass (imf02.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725416642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EoI9qqJR1UNdfBjSdpDuwM3v98Ynh2grVpucb/7fwjE=; b=bBwK18cNHngeotZH4+ss3y0+YhZabogjron11l8ldzXhCHF8V2EMRySO0kWlHh6I7Vl7Lz 5/QAH1l6iOkxoDto8anpsRsrVYZyvGd/N3yccXy1I1VmMatFwbunB+KTXqGkqE+/QCGos2 I13bMRbcqQjFqnM+NE/EdeyOupvVSHE= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=k1BX43+E; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=N6buhWpn; spf=pass (imf02.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725416642; a=rsa-sha256; cv=pass; b=oXNY5jfSDQW99GtiVJN90wSspZ9ZjCvHysJT4v1DuhJrs2bhVNbphvHz+s3oAMpJ1emr6c Fq9bXLY/5mrt/CxRyzfSiN0hBR2NLK5vzuY2u1zne9S6VuDg2uppPBeGh90M32DAqA76vB eU4TyC5I3wVDUpSuvgxKj6N84metNpo= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4841MWYt016005; Wed, 4 Sep 2024 02:25:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=EoI9qqJR1UNdfBj SdpDuwM3v98Ynh2grVpucb/7fwjE=; b=k1BX43+EHUFMrrS2EnpCTN9uMg2KgaI VCc7WTKioJe308ukTGCtfCyNz42cVmaz38hQ82UJE8OmlIOXTFFJnLH7mp6d4ITU 3D4Gl7IZnu2ktiobYKHmzWK8EZHLLJQXotu/wAfcqbCr0zoL1HMmWPirlIoHwVZm fx7QSSqZsLLbuGzhUsBDrQgZkPL7oNTrwlG5szc/0ayPmZi4sGsg+KDUfQexVOGy ew6REKZlcbjF2ELLQr3Zx3FY6aNwYvZaaKKInaV0ik5/9guF1XVfnlSvyEEynU88 jCBtT8BvEiVL1KweFt8Y5TqwJDHrSABdFp34xwsvMyDis0xcdqs+veg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41duw7tc9t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 02:25:15 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 484053GL037355; Wed, 4 Sep 2024 02:25:14 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2049.outbound.protection.outlook.com [104.47.51.49]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41bsm9g131-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 02:25:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hax+Tg/707Xtn3agddZvZvu9U0UDbxZbtYO06Q3v2+NmE6UFZF7bzpTcz5Sj5CgDN6wOSuzMrMLOMHmVDekTi/l1ll59XPKr5ATZSQaoJOnctt4XzSs6xL11zWAKuYXFqFUUjhfqEblLyheWqOat2p+Ca6qvYJ+w3CN2JK6FENZv0kpFd1ODBZLp+jm8mzJILWwEDUYTVMHpfBcGz6fTrtJQs68tRH7yO0tQqlq/wF/Tg1z30E156NESFD9s3fJzly6JzVboPHv1O6tWyyrJKiI8c+Xra77yEP9F2+ptMAX25kuFgndKmOkZDw3Pw2wc34OlkcJpZr+jh9EbsoHrTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EoI9qqJR1UNdfBjSdpDuwM3v98Ynh2grVpucb/7fwjE=; b=yYUVthU7j3b6HH9ZRaiEhgltaqXLfRwS+rkxzGq20YWoWknXmt+Jm25QzEEx/ukrCJOIQxaDDjrchBmVLwh5i7tnpm3o6fXTJenkMBO4HQzW86Gr9cWW0GHZHhmvKrVqGboyByCZ8wlcLJefsbENePfhKw3T+DWacL7qZ/22aN5b/9xGZIGhZCANDi8gP2C2hrM88C4877gVQnAHAt77AogXWzVbrKDxizmZ6TCxoUsmtLWzgvh47+5HpXH8Hb698rRduCcb6vba/UlR2fLLvmOm7CscY5d8IFtt1o7XmjmoO7sDBkzXh/xtCf17xGmcINALAArxnxY7K9uK3emchw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EoI9qqJR1UNdfBjSdpDuwM3v98Ynh2grVpucb/7fwjE=; b=N6buhWpnQYvRX2El+qQzhgN4lnH8JNqffRLgpmgB0OT5rRXa/8gjXJ0VBASr+BhseLX1kn8NecGIrT3NM04Mp3M/GotMRw6oF2c9evd77kB4RMq+D/V4XPXdDHwu3kQXxjYr7XTIDMOd+n1k4ZZ5OPxvr3rNHILGUj8TagkxDio= Received: from LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) by LV3PR10MB8057.namprd10.prod.outlook.com (2603:10b6:408:291::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.14; Wed, 4 Sep 2024 02:25:12 +0000 Received: from LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d]) by LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d%7]) with mapi id 15.20.7918.020; Wed, 4 Sep 2024 02:25:12 +0000 Date: Tue, 3 Sep 2024 22:25:10 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] maple_tree: use ma_data_end() in mas_data_end() Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20240831001053.4751-1-richard.weiyang@gmail.com> <20240904001525.5zshbivv7op4ana7@master> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904001525.5zshbivv7op4ana7@master> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4P288CA0003.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::11) To LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR10MB7943:EE_|LV3PR10MB8057:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f2f1201-7e33-47ec-ca5b-08dccc88cdb3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?CELnijsiosQ2F6/zAz+k4zuUSreS1N6wy5zMrwAd+sUtJxz2/GCEXrxR8nXP?= =?us-ascii?Q?P0DmjQ0oVArep31Bmz7Kp69MSa1ev/WCcqYGilUYYWeI3fqBxYNn5ZSaYG4d?= =?us-ascii?Q?crGShMh0PJ/M2kEKT48j6XSz11h1ghEcCCzBSHNTXZJVGbGcRGccwd/IYEcN?= =?us-ascii?Q?g8cGdElKK369UvUe3yIMwLRVMQjoPP0RJ0B0NXDlM0ZGNKr0EwVLvLMxI7lu?= =?us-ascii?Q?PtN/jq63nnUx5AurwkB4DAgMrm/qDC/w7p0M5TX4mgbXwpQYCdAdQfelkwvW?= =?us-ascii?Q?FwzgIg/MCNIepo/RP/2ndYp8DW7x6M2Qk3LJN8Ho/txtbzD73fqo5tGhOmHq?= =?us-ascii?Q?FblXA+OM5XdzlP1eBpZFJotS6dDWBOaJFVoFfTAcgQuy21XbVXYHn6sbPLmK?= =?us-ascii?Q?nsPx1aBPxlpkgAncGu0qhcrRGEArI+AufzPk+qEYH8VH5bi7jI3kWr3/ZPn/?= =?us-ascii?Q?7pAmcC900v3M3qjWlyDETGMP3XFWh6vrfGs5VZIA+gFc/vVqapRktqWUwChx?= =?us-ascii?Q?+pK4S2LrCjIfSiLeGLMP0vgqKH/zF3dozj62TOWdPMg5HQzngLA+EZVwY2dC?= =?us-ascii?Q?Sv20g+MrlJaE4Qx7lMOECs76gRVvbCbQVREtaNxupfHFxFihRJFnWMxl9hhF?= =?us-ascii?Q?qLIpR3IE+Q4fZFjywjY25+Pma527frCKUemi602WnybXlWDVzShzdsL9U1XK?= =?us-ascii?Q?qrx190TFQ4n/EGbQbXTg6VRgPJqJEnWDmTGgc/B9Agy+G24AkerBz+9I0ko2?= =?us-ascii?Q?n31ypMJwOEiyFn4Mkbn7BWtgrbU5x8EWQz12SGVe6zRWb1rGugfMhlQBrdUH?= =?us-ascii?Q?aCc9ezDDa/pDFA9RroI/6Qu+sj5+2iYraiuqxjIDdg+6QqKrUYyw2dOcOiHl?= =?us-ascii?Q?JRwVjjfIn4tPW/WFvruf/isoE6avy+RtbDT/RwSHoUIYwajhEpq+yb7/ZU3+?= =?us-ascii?Q?5QLFa7WP0fD3WD4xOuF5SXhhbptbPrUsHd2E8EsXl7QPk47u7osHk3aszhHX?= =?us-ascii?Q?pOjEZJjPw6aFRY0EbP1wzHKPH7QbhU4fql8+9VZq8WO/Kgp/D2qQfVQHkH1c?= =?us-ascii?Q?Gcw7hoJDO8NxPhZNGMLVDI1BEKVyS0idrrALcs9NyNWjQi/p9geqXnXvH0Lu?= =?us-ascii?Q?21fsDLWXyMyxD887dW5CeEFtTskrTaAF5+Ud2k+Fp4uDi7ZVoFDWaQ4UUOT1?= =?us-ascii?Q?ioBIJsTpSsbc/HYEpX+4H0Y7vTqlogu2WBfUZOlqawAJUFN62OvycVud2L2E?= =?us-ascii?Q?rb1QqYl7Zwd4vX2CbihEKJ57kX89WwhgOviHFXGisSFLxFOoWJd7qLC+6o5q?= =?us-ascii?Q?EVulcj1T2HwqiLhp2OxZnXBdiHWyRKmJ+X9deqSUBnYRfg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR10MB7943.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MCd7FIFexyeHCqIfes/Zi5Cbl1RZXijDXAP06i75Zv6dpzh29NVArV1nD0Ql?= =?us-ascii?Q?nNk74JAewds61E1Q1c3C4a5Y4Ar6sRTNosWv2KmLT6ZVwpWOpbOHEh6zwbz8?= =?us-ascii?Q?rU0t/mMwUZ8TX1HVrmBWrCbAOtB0D378y/8wixOusnRVaZ3HEJQcnDyHrN8D?= =?us-ascii?Q?p8CLkwBnLVrS0FWejWauA2QG42BKzrNjn8ZdP6m9mlnQL0OvXu33req3bL/5?= =?us-ascii?Q?BnRhh1DJZemCCKg7krfeZicDd42+9qB45Fk3YZhvEnUnumA7LiKm+GVZnHRL?= =?us-ascii?Q?Pr5UOF3rjaLSG5HIYVmL+hjJIgH75k023e+fnyKGuAG+zUrp8aNxojDwet2e?= =?us-ascii?Q?Gmc85VGhfZwcUPT4FeExUt6rwBhBy9pejzi7sv2KZLv5oEo4Waq3qhCfcBdQ?= =?us-ascii?Q?+wWR7zRz5P9lPNFiP4nkMZMT4PK/vl5X4WS13iPaMa8k4k3Kfy66Q3pWdKin?= =?us-ascii?Q?fWovLaIjod/QldC24XDf3fEn9w2SggloMP05ecURIEAer7dZVPIjgtYkywTX?= =?us-ascii?Q?BcgBu5CKj+7vSIe5YArTlt+f+rpRiPq49EW5QPL1gR49hD+mgOlMnq7Nm3vy?= =?us-ascii?Q?TtHqirCk6YIGp5kmtaRhk2oMZ7/Yki3RoGPB7P93tBqWzoCx2BY8oRxg3eO7?= =?us-ascii?Q?BFF3rgYMeYNx2k89PvPInbaNrDgVXjmyQ3W+tEpxbJYa3Zni3eOtSvnLc49G?= =?us-ascii?Q?GwSW9ZC9DWxIC+IiUiciIJpyAXWTDxgqLTiJ1/GINqqRwTd/L8hOaadtFkXd?= =?us-ascii?Q?kEabYBbImqS8fgkNYe11DSvnQZdLZorfyozs35HdMSdrQtacYC4glGXgZRXY?= =?us-ascii?Q?0CUZ35zAFwgwfL9RXS4M/oe9qZSQwLdC66o3mB1QEg2fwBx2P96COhoX6nwT?= =?us-ascii?Q?c58CICwlyftZUAxb9s6MB72J3axlMuBMUuEkcuGzTCfg7Xm43WC8X5NygnzY?= =?us-ascii?Q?/FTMDTbRip8570R1Y4z4VeznrfZjzH3Rtm9kJVqAtv+skc5lpCzt0QdvmEv0?= =?us-ascii?Q?xBQnGT//fdyp9xhobDgUa7sfO51EOruAyO1SXhPOEbWtTTr0T2fpZqjbLhTF?= =?us-ascii?Q?5y6zHW2zo9d/xY2OlPbB3TC0ZPaEmjsxZzEAylx5SFJjDqYAjVWDVVuCoaQ/?= =?us-ascii?Q?EDQhFQ5AYJSHHtGY8VUNV+qEhUXJr+5VSpo/p1vu+rVn4YEqS5SRWPiVMv/p?= =?us-ascii?Q?v+82Pkh0l9cIdDhiyu/PCDjDjccth4yjK0zTJ8HEEXAkvfdzOLiIvtcgtsAG?= =?us-ascii?Q?XElcTGhDKb0uTcTQ2G4a7uzC9/12BfHC7MYrxlUACGwLhlznFEGjyjNdUypi?= =?us-ascii?Q?/+hpbZIwURJM6omc1xmE0pKmO5kqk5pjgU+yCXRzVKgiVtl0nDTFY1j3Hnyn?= =?us-ascii?Q?r4SU1pO4c1m3sSZrknlxUkjE7VUCasE8Xjje9ROUiZSbc/xIw6lMFePBAA8X?= =?us-ascii?Q?GiMEZ2aq/h/5tdQ3+TdanOv21rESu8C4ASz33d0XBkFUUV+UGZrgv5wYXHek?= =?us-ascii?Q?kfHvopYPNvUUSRprhhOFmDp7pqZzH/uyTBlZORCbV8esLTK/wD4Apt8N6CPX?= =?us-ascii?Q?b8EQPLKSN9rSLmcAQBKmawfTNLbk3mhk3WSvPBGJeHlVX0gL/7DmRQHlNC+h?= =?us-ascii?Q?Lw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8NSgaI9cwVyM71oK+V/xv5hJJoEkZv3Vk25AOQqFsiigMQUXowkB52H28g72DPMDzbn4kumpsNrL1Pn/Lm2seqh1GH98/oA//D3aUjnspPsuwkgnGF0fW8yafBRe9G/0dsjOKoptBuDng9nZsghsHMpIgxZ2sNma1CFwWhlhtpR0sY1CsiwVUIlLpH1QsFDOejE9VCf2rMKN+JcmimE+X3IX5eLrDskx/2appKtdBCeK2lIxxONZCUTVpSq3raqKqURdg5laSLuG2l0noxxy+i9eBLX3Xgib3r0wCiRELu+6X9wvPvyVBpTP8MUxmjgYahcjIotJjYULJ6r/innA/3QK5yPMHMBWrnbTOzS8meoALtSLRj2o2C9KRS6ZHm30c1DraXnnMstr5QFeyZm/nd9Ar1UIQRvk09tD7B1JJRXB/rDXi6BHo7C94WVrRmWjnQmd0CmpRiLmS0+Mzen+wkd/QuqT9PgVCeLigiNOLp89J6CJjSBOBmp6EQKsVjOvnAkt+7rehvNQGHHYmRarfAgzM2hc+KUuAOkpfqr/A0efCHo8EPAdJzdv/tBb4ZuMTVTaMsDxCOtzpX/3pMznmOM5JPkA+2CYaOXrzNpBBAU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f2f1201-7e33-47ec-ca5b-08dccc88cdb3 X-MS-Exchange-CrossTenant-AuthSource: LV8PR10MB7943.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 02:25:11.9840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8k4iK2cYWhIVXe5qkEpzI/omqvImV0b1REVqXNv26/O4193SoK+saiX29TDCf10nD5ej5U+RqCuvvdrOUlbUuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB8057 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_01,2024-09-03_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409040015 X-Proofpoint-GUID: NG_y688Q_AW9SEwMqT-GdQlb5QqdacSg X-Proofpoint-ORIG-GUID: NG_y688Q_AW9SEwMqT-GdQlb5QqdacSg X-Stat-Signature: 9u511deb45r7kdxjdcxzttm65jqha6a3 X-Rspam-User: X-Rspamd-Queue-Id: C521C8000C X-Rspamd-Server: rspam02 X-HE-Tag: 1725416717-554914 X-HE-Meta: U2FsdGVkX1/y3q959+jXHZ9yqC2N85vifNO1eYWJj4z6SEXXH3e9b2lJHQvnRuhGYvqEVkoiUMZdDLsd/7UuClZ4+MSDR417d7vthzeW9Xbb6X3CAb5KAZlxGmjQwV+cgrFmJGUyaJAjiefL7xdbNAIAnmN6J2D10pat+kaHVHQV0NznwU+i+Pr2ylxhS98frCLHCY9xIPE/YPYMnlphkAFFPBYp1P7M/NGMSyr8OE9cL/iHrVkQCc2t1aVPa8xfj8ISybtq9apkAILPk2NVuxeGbb064viKrXcsep9XyB0LNalS7DSZfC/cV2Kz78+3F6HTwO7xNncogeS9TYMMq7mWRCCcablhBnftXHQcncYXHzVj2ek7oBwudHSXuNVpCLpYJHkuymDGnMtBCLtU2Dj9bB6J+I5vJQei3YEFnMMG348pauThHN7VRzO7osnyHythbIDP8H4NmmTyCagF5yVjT7nRKKC1vKmeZNXtRodNnKRB1d4Feje2708ADdYmsTIgT6WEFGWlubB0mW+o1/eOUm695+0Om0ypfW0ug03VRfzqs71NErD3dyMCTgqTWOxjMjNKgtcgeKGF5ukYeSxbrMnRdZAfo5g8qkFJkF5uYBOVeARW7C38q9wnPLEY+YdY9oJwQe4LbfABgafkX2SJz5sBJJiplz6F39pTAbEQfY1vA5WxAibr0VNNsA42wVrgiZjIfmE6tf0R1FamMWd3BU+HvIjqPpLf+YAXeXOIqGimmBUMz3cY0yfTgEJYFV/OR2DeHpSOOfsREVnNZtUEmeZCY1brW7umv9BUz0S6UdHnladd218stgE0bcSY9JtFOC79xsdv2tjhrvslpsmMBJGyK0F5Mr7u5jKrancU0rFsa28WfZ8AJ+FTDc8gqp+oi64iIQhXVag3wTZP6R5PTroHDS7gbDJwaLv0CqVEdXob15KALcihTnAjvsoVhFbpXQ+7VOXoeq4lbLi gfWOqtSa NOMRWGxHFjntsk2+K//f3Ns0XqFR1hk7pGyCLqrYrE0M4hU1Kl9lLYQ633X8uq1O7+QXoVQQR97s3a7bUenHHs+YF3LomlSjgTd3H2IGkgLXCU54238Vp017tmQfboGyi25axsqB+7aF3MlhNyY9oAoPdQTMLtyWLjslSsITxKaibwRQTmgit07RR6uHcYyKNgYZBMyXYkBfEgMg0Un0+b0JlzmrSKu5O1pyi+PzDlsxpJSU/laGJK4VmRcVA+cezsYoVWzrxUa93VGB/NqJ9h872sBVOnVKarC6iRuSM3Yi6GvTst65KqI7zSUn4EY5st0OeeNt4at47M0Tj/DH7C20pMtlUsXdW1i2LLXktxzHomzTp+M4wCsLUeOV3t8PTAflaJ7DIouKQpxh3dfT1KAMPEb+nY3FIgfM26cJ9yHIUQwTERZ2KKDf2vmhgRtFrn0QqeQsLR0RqvweMpzN44TfUqdalkgL+mwa2eSgTL1Psi1u2G1WQPrE45PxMFli/jPOliGw6gjdB9We+hp2Zsp6UOm9z5y2D8lb4GLdciA0y4sr9OlzYy6LESuG1QKT0sJmPayTCP5ejHycje83EA0tbWr/2R+1FHwJtic1HS9VwLE+iKSkgBiH1cZ+oCsbePlf5OrwYe7yLTro= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [240903 20:15]: > On Tue, Sep 03, 2024 at 12:12:39PM -0400, Liam R. Howlett wrote: > >* Wei Yang [240830 20:11]: > >> These two function share almost the same code and do the same thing. > > > >Please stop trying to optimise code like this. I don't have time to > >verify you are not making things worse and you haven't done any of the > >testing required. > > > >I went through with perf to optimise dereferences and static inline > >functions, so unless you are prepared to look at the generated code and > >actually benchmark, please stop sending patches that I need to verify > >like this myself. > > > > Would you mind letting me know how could I verify the generated code and > benchmark? What you expect to do? There are a number of benchmarks in the test code that will run specific tasks in iterations to check that there is not a regression. Depending on what you change, you have to run the right one. Usually I write one if one doesn't exist. You can also use perf record and see what happens on specific tests. This function is all over the place, so I really don't know which one to run, and I don't have time to write a test for your changes - and I don't think this is worth it. > > For example this one, these two functions share the same code. Do they? You have removed the fast path for maple_arange_64 using the metadata end before getting the pivots, which means on basically all vma walks we will be adding instructions to the walking of the tree (get the pivots, check if the node is dead, check if the pivots pointer is null). You have also added a check for if (!pivots), which is essentially checking if a dead node was hit - which is already checked in the mas_data_end(). These two checks are the reasons I left both copies of this function in place. I am looking to reduce the execution time, not decrease the line count of the file. So, the last 8 lines of both functions are the same. And please don't submit a patch that adds an inline function that does the last 8 lines to reduce duplication. > What's your > concern for this? The inline function expansion? Your clean up is compressing setting variables to the same line, which is a bad change. It is better to have verbose code where it won't make a difference in what is compiled. And certainly not worth adding after the fact. The inline of the mas_data_end() function depends on the expansion happening by the compiler (which might change based on the version or if it's gcc vs clang), sure that's a bit of a concern. The biggest annoying thing about this whole patch series (without a cover letter) is that it isn't doing anything for fixing, helping, or adding functionality. I'm a big fan of forward progress and this isn't it. It is only changing code for the sake of changing code. And it looks like it will be slower, or the same speed if we are lucky. I have to take time to verify things aren't slower or add subtle issues (maybe an RCU race) because the code looked similar. It's just not worth it. > > >> > >> Let's just call ma_data_end() in mas_data_end() to reduce duplicate > >> code. > >> > >> Signed-off-by: Wei Yang > >> --- > >> lib/maple_tree.c | 22 ++++------------------ > >> 1 file changed, 4 insertions(+), 18 deletions(-) > >> > >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c > >> index b7d747a7938e..85668246f944 100644 > >> --- a/lib/maple_tree.c > >> +++ b/lib/maple_tree.c > >> @@ -1435,28 +1435,14 @@ static __always_inline unsigned char ma_data_end(struct maple_node *node, > >> */ > >> static inline unsigned char mas_data_end(struct ma_state *mas) > >> { > >> - enum maple_type type; > >> - struct maple_node *node; > >> - unsigned char offset; > >> - unsigned long *pivots; > >> - > >> - type = mte_node_type(mas->node); > >> - node = mas_mn(mas); > >> - if (type == maple_arange_64) > >> - return ma_meta_end(node, type); > >> + enum maple_type type = mte_node_type(mas->node); > >> + struct maple_node *node = mas_mn(mas); > >> + unsigned long *pivots = ma_pivots(node, type); > >> > >> - pivots = ma_pivots(node, type); > >> if (unlikely(ma_dead_node(node))) > >> return 0; > >> > >> - offset = mt_pivots[type] - 1; > >> - if (likely(!pivots[offset])) > >> - return ma_meta_end(node, type); > >> - > >> - if (likely(pivots[offset] == mas->max)) > >> - return offset; > >> - > >> - return mt_pivots[type]; > >> + return ma_data_end(node, type, pivots, mas->max); > >> } > >> > >> /* > >> -- > >> 2.34.1 > >> > >> > > -- > Wei Yang > Help you, Help me