From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E01C48BEB for ; Wed, 14 Feb 2024 10:13:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7747B6B0095; Wed, 14 Feb 2024 05:13:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 724506B0096; Wed, 14 Feb 2024 05:13:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EBD06B0098; Wed, 14 Feb 2024 05:13:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4E7806B0095 for ; Wed, 14 Feb 2024 05:13:45 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D39FD1A0D80 for ; Wed, 14 Feb 2024 10:13:44 +0000 (UTC) X-FDA: 81789997968.12.1EC8076 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf21.hostedemail.com (Postfix) with ESMTP id ACDC21C000A for ; Wed, 14 Feb 2024 10:13:42 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=dfPOhhPg; dmarc=none; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707905623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tukJiiXHxlnAZSRWrSKvYIrOKtvtQgT2kcRjC7iKjgc=; b=6frWELZ+zznN9phhFYcDqNmu6Iua67eoor7lBn7jCM+eozC8lr10Jc9DyhJlmvlsrw/+h5 kcHiXtUnsWVmmFqDwP+LkaeCGA8gVd8vgIW3W+G1PAcyUYgsnRXqpDpKtDa0wqJ29l9vau njQwxi0avUFYavl1mPL+QhwxXcRGAZQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=dfPOhhPg; dmarc=none; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.161 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707905623; a=rsa-sha256; cv=none; b=553Sybb8pYvJJDRZnPwgn3UarjJ6GfPnBUbICUoJcZEG+hPio4b++By0MhIaX/ZOJ+hFTl /gqN1Ku9Af+OipqpzGTd01xU1bYiMWz4mNjthPPufVUYxN3nOWmPglULd4bixRvv6SL0Ab yVOPeABE2m5NJFzJW66OSunzgfPA87U= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4TZYtn2Pyrz9t7V; Wed, 14 Feb 2024 11:13:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1707905617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tukJiiXHxlnAZSRWrSKvYIrOKtvtQgT2kcRjC7iKjgc=; b=dfPOhhPgpRh5rz/wIjBRF7DEF9ooEVW/TGmRGGvvJ4bRRbD9VBVGgWZsqHQyL2FAeBmbXr 5kbQJlEP3G/FafnxH5LXfzU27cCWvRQFUhqCoBvFjv82vo9jted1y5DLLtdMLy7a2uD+z3 1jYQfuGoLgxe5uVOZYbI0bpXYXls+9eNl/QUhBYcSyYp+6niCpZ9wxx0XPbW7vwaa7K5Q5 9jPcNdvmGXtVYZftGaVdO3XyKKJ2Lu7hM8lC8/PA3CZpyUm97CwfMUJOBI+O5lXl+1OADF rnMpXX0+1KTzd851/9R0okrIHkxPOvxcbgEcr+oGS1AVeyAkn7cOpTKoFm8lxg== Date: Wed, 14 Feb 2024 11:13:31 +0100 From: "Pankaj Raghav (Samsung)" To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, hare@suse.de, willy@infradead.org, linux-mm@kvack.org Subject: Re: [RFC v2 03/14] filemap: use mapping_min_order while allocating folios Message-ID: References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: tixip4s5zkp1wjknusdumnqo8kzryiuh X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: ACDC21C000A X-HE-Tag: 1707905622-714572 X-HE-Meta: U2FsdGVkX19G0YL8/Ig5yeuQajpiedzoLfQ24KdSC2J7TpdmcRWUDUt/6saUBH04G2atUdJFm4W+1rYHeqikcAvLWMyURCI6JGt0Qlop7R5QAVl+5GWFeRLSEw33sHMeffcJE2uh0QqI26u8ru98JeDy9K2DGEQbvruOxnMpZZLb2qU8HPfSVUAA+xVW7Z9zyFf8wdAMJLHKzR0ud+Xsy1CSlNUx6eiAkEIfNp5I1dYPjMpZ3bH+7gxsrwnSOrsChcXAA/+dyxhhCaWgZdYUsSja5YoEIE4DWVTebsfgj1yo+TlUFaJ9ZNEBuCahtcLcZYzGH8YghVegJ2Sn3zostNmAMl/dEJMFNNSmzus6KfPpkPWNT15ULlsUh26AV70OSA8GIRmbHaBx7fkCFlTf/Stw2GdlsIttLlOeBi6ZeQSQ+SNvbgBl85GJEgrZy2Uawe0mt0pxk4MB3ciqlPojVwTfaJqiLfA7VJQr2m8PXyzLqHgB00OiizVIOtzdEB8fIaAt6LHGZ65EpY+TNaQNnvuR8pyRv7GebtwCjCMBQ4UMtjcsCiisd77RM2Vhz7+bgOKyaCY3qFrcZ2bq7hyfXz1MyEE3AXKcKZqPzpHRdyFkJm3+kmrg6ePXdNn6xjb0cRheh8WXPNkEOGlrdPufBiGU0YMEUHsuV/KIca2RCQAgRQG+X7I/nCsopbOM5sB7Pbiph/Xqn8SHvWoguf/yyo+Sjyoxw128PpDq6rroUcN2ffsMWiNlhTdw2MJBDmzXSfSi2bCvxnQJTFvIKxKrGFlQ8V+PFComa/0xDsR7qYZm4Gfp1ZaDuqUaSVIgtgV93o1qmKLhjc74x9Ti4nUd3gekSb4Zl7AaAz6S/NJan48yzgouoUlfqblsC+QOHIDcIETUu7gwSD6cKUkBiNQXtbXYSj9B/e8lVjO7O/df4gwW+dGrt+5JHQFMjdMiwQTTa8rzPA6A2uN3dub0d0e bBFtbpQC 7DTN/3w1B3rBQNL3KmMNmCHjK5P1XMNMvc6jY/evlaCjfRCDpE1zSd+kL5whh6RxiwKcsydiR5q+MV85yA6dS/G1rI+A+g+x/NUTcQAbNUJM963tNbNraqL/mDcC4i2KgyhbbE8hsG1pfKC7sgo2oMNGcYY6sdVf1Ha85I2PMX0OFFJ0MxFIm68HTPhQ/4ozgYJe1WjsN9wRvY6niu5gYMKAKtjV4LQABH6DbsYceZPCKgrPT4w0GcubZjFPY9ODL4/VEyZotHSqLWc9AVIDngxWZzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > +++ b/mm/filemap.c > > @@ -127,6 +127,7 @@ > > static void page_cache_delete(struct address_space *mapping, > > struct folio *folio, void *shadow) > > { > > + unsigned int min_order = mapping_min_folio_order(mapping); > > XA_STATE(xas, &mapping->i_pages, folio->index); > > long nr = 1; > > > > @@ -135,6 +136,7 @@ static void page_cache_delete(struct address_space *mapping, > > xas_set_order(&xas, folio->index, folio_order(folio)); > > nr = folio_nr_pages(folio); > > > > + VM_BUG_ON_FOLIO(folio_order(folio) < min_order, folio); > > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > > If you are only using min_order in the VM_BUG_ON_FOLIO() macro, then > please just do: > > VM_BUG_ON_FOLIO(folio_order(folio) < mapping_min_folio_order(mapping), > folio); > > There is no need to clutter up the function with variables that are > only used in one debug-only check. > Got it. I will fold it in. > > @@ -1847,6 +1853,10 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > > fgf_t fgp_flags, gfp_t gfp) > > { > > struct folio *folio; > > + unsigned int min_order = mapping_min_folio_order(mapping); > > + unsigned int min_nrpages = mapping_min_folio_nrpages(mapping); > > + > > + index = round_down(index, min_nrpages); > > index = mapping_align_start_index(mapping, index); I will add this helper. Makes the intent more clear. Thanks. > > The rest of the function only cares about min_order, not > min_nrpages.... > > -Dave. > -- > Dave Chinner > david@fromorbit.com