From: Yosry Ahmed <yosry.ahmed@linux.dev>
To: Nhat Pham <nphamcs@gmail.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Brian Geffon <bgeffon@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] zsmalloc: introduce SG-list based object read API
Date: Tue, 3 Feb 2026 23:37:31 +0000 [thread overview]
Message-ID: <n6n2q73tcujoz64it7p7bjjydsptsd6fyu2wwrlajl23uit3su@mvsfy7ibggni> (raw)
In-Reply-To: <CAKEwX=MRz7dL5=cP=4QN6uTgUJLh-xCt_zpfxytqZkYdycUN5w@mail.gmail.com>
On Tue, Feb 03, 2026 at 03:14:06PM -0800, Nhat Pham wrote:
[..]
> > zswap_decompress_fail++;
> > pr_alert_ratelimited("Decompression error from zswap (%d:%lu %s %u->%d)\n",
> > swp_type(entry->swpentry),
> > swp_offset(entry->swpentry),
> > - entry->pool->tfm_name, entry->length, dlen);
> > + entry->pool->tfm_name,
> > + entry->length, dlen);
>
> Just style change? :)
The line was too long and it didn't look uniform, so I snuck this in :P
>
> > return false;
> > }
> >
> > --
> > 2.52.0.457.g6b5491de43-goog
> >
>
> Looks like the new zsmalloc sglist-based API has landed in mm-stable.
>
> With that, the zswap API conversion LGTM.
>
> Acked-by: Nhat Pham <nphamcs@gmail.com>
Thanks!
prev parent reply other threads:[~2026-02-03 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 3:46 Sergey Senozhatsky
2026-01-13 4:30 ` Herbert Xu
2026-01-16 19:53 ` Yosry Ahmed
2026-01-17 2:39 ` Sergey Senozhatsky
2026-01-17 3:23 ` Yosry Ahmed
2026-01-17 3:48 ` Sergey Senozhatsky
2026-02-03 23:14 ` Nhat Pham
2026-02-03 23:37 ` Yosry Ahmed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=n6n2q73tcujoz64it7p7bjjydsptsd6fyu2wwrlajl23uit3su@mvsfy7ibggni \
--to=yosry.ahmed@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox