From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C63C3DA4A for ; Wed, 14 Aug 2024 21:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA3D6B00AD; Wed, 14 Aug 2024 17:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35B306B00AE; Wed, 14 Aug 2024 17:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FBF16B00AF; Wed, 14 Aug 2024 17:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F0C4B6B00AD for ; Wed, 14 Aug 2024 17:42:23 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9590480FC3 for ; Wed, 14 Aug 2024 21:42:23 +0000 (UTC) X-FDA: 82452174966.24.7532432 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf28.hostedemail.com (Postfix) with ESMTP id C8528C0013 for ; Wed, 14 Aug 2024 21:42:21 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hB5dbF5f; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723671661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OIhfQtAttnBaCpCE+ey5b1+F0FxQnhTmRpcsEUiZYG0=; b=eHgaDQf7WPLdfXQ8RjzHucPpLYyMhb/xkwcTjJ7dbq7O/PNjRyw6b7KK09OFshPTIfdZ3m qXF61kisDQ8K8jQKaVikSVHPMQWuxx3xOrvW+A+U+hOD94g+cpoBugQo/w/TKG7Oy3gR7X C3mxlhyynU0vZqbV3Ks8A9qyDghYcM8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723671661; a=rsa-sha256; cv=none; b=6VJuTJT+28p3K5AFbGUeQUVHBBZ2gKfgVugfR81/EcpeYRou1LjNx9AJBvZWNYzbtccFRM mKz7/LXy/j5Tgki7K6NMHmCRQs2cY58d5QGjPqXm3JwzJp2Z4Asm+wqUDWeViqqEFSK1C1 eQR/d1tgYzIObjfAhUtRtNSbpbkvYhw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hB5dbF5f; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf28.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Wed, 14 Aug 2024 14:42:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723671739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OIhfQtAttnBaCpCE+ey5b1+F0FxQnhTmRpcsEUiZYG0=; b=hB5dbF5f5HKHT9IkH7wIxVJs4zWWmjrgTJohxAnDR5uve3hQCRMeHNnXF6mcWjjJCA1FSU UM2vkmYMyXiIBFRQEBcCzKrxEycYztbmeod0EflCrPTu1bcD1DMN6o5N5Gf1R7tgeQv8ED rDhR9sejBHpc4Zs+4henHSjSXJVnyhM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "T.J. Mercier" Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Subject: Re: [PATCH 1/4] memcg: initiate deprecation of v1 tcp accounting Message-ID: References: <20240814202825.2694077-1-shakeel.butt@linux.dev> <20240814202825.2694077-2-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C8528C0013 X-Stat-Signature: 5s3tcyekn94k6hw8zjfxz8d9z6cw1b5y X-Rspam-User: X-HE-Tag: 1723671741-174955 X-HE-Meta: U2FsdGVkX19pE6SAX6eoYeFhv3RDywReLSDZRKLHfqf7gGqQ+16TLlRNbz3YnxAdP0pSLrAW9HQby62S1BqH69R5BzgSD00+0YsGKcuDIVJJFMRiUb+cWu7BzlvZuinykos9DqmHZI8GKo250eCLcDfxNwtsoxKCtXZwrKugWCwK19LiTkRA4NgDR44nNvAMSbPuCP2w6nOarJ5rADNZu2qrl8mn/AK3Z8SaFTnd+5JU0672lfoHcW1jPa07fiMnE22yC3QShmL/856pTYNom6x7exEfCh2rJaG+1sjhxH09F6kxufRaWkHupwLuRkYIZ6KTId6GpDr2mqtu+/5fixfa7mjgOq1P8+B8gkiOeCNHWyi5AnTXHcklvr62WwQxhGq2fWxRwix+R6CAZZc4MQL9vdVMmhlDgV3QmsomkUYPVaKgJ95lWT6nvPJJDNe4IOkdzBYwnGty9DXmVux+seSsFzG3+cUolSaZMdqAuM7RAoU6RixySqc5Q3heuxBbFpiUh8Z/eVOG7bHTNaokkmnNaPnEjGeB9jouuxKdIL6kmdmumXjdyuhnZPo4dA2xLliw3dmu2EgSNuiHW6PPZu0vaJTGoMRQfVgeaoxtZ3ROxdFjVXDu4ZeZ0agtpS2QY9597T7Efh+HGPLPs4h5pUSpZOMwsC5ewoFOECd9Ju94nAQ5vBKMuts8GCfrmA7dZIYyhSQlSDnrAs5pDOv0FnF4Xh1u42ErOwO8WIQC4eW3Yy2rI3eAaCiWpOYTP+3jhwbOeWeZJfPJ+QDOdDB0QCoHQHapQXMwCicQnAF+cPoodCyBU4dgi5heVltWZcacNPqCfOD0VWYLfQ9JZPHGra8xsQgnLn0yZGjWdvYjnXPwMWofIaLgCL1+cv6s3VrfYYKnpZByl8a1hUHZkJmEXiJ4K6XyJurq0AB+u+ZHni+LmJpWDxUZgtjDngTU1PHxxQ/0pSOAahExKnW4qtv pHFm/yU0 7E8ggtutfHMw0tCu17N8Pj+JI77O4VIyP/P9F3fCt0VSaCrj1Li3o2VbRIZi9biDjbriHLwr5lKH4QgHLTKqXmr/BbiN25pw4gc69wgV6IfzPN+KMhoUliqSbQEChTiK0NWp9KxK5dXXYCarHQO4ZMdPU9eKiB+dFFwWg/zOnu19n2sBALs15kI/BzIg30DIT62NJixB7oPMR9gmEpg8Y8mt1XXC33NVyuA+QhfwfKU9CA8U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 01:59:15PM GMT, T.J. Mercier wrote: > On Wed, Aug 14, 2024 at 1:28 PM Shakeel Butt wrote: > > > > Memcg v1 provides opt-in TCP memory accounting feature. However it is > > mostly unused due to its performance impact on the network traffic. In > > v2, the TCP memory is accounted in the regular memory usage and is > > transparent to the users but they can observe the TCP memory usage > > through memcg stats. > > > > Let's initiate the deprecation process of memcg v1's tcp accounting > > functionality and add warnings to gather if there are any users and if > > there are, collect how they are using it and plan to provide them better > > alternative in v2. > > > > Signed-off-by: Shakeel Butt > > --- > > Documentation/admin-guide/cgroup-v1/memory.rst | 8 ++++++++ > > mm/memcontrol-v1.c | 3 +++ > > 2 files changed, 11 insertions(+) > > > > diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst > > index 9cde26d33843..fb6d3e2a6395 100644 > > --- a/Documentation/admin-guide/cgroup-v1/memory.rst > > +++ b/Documentation/admin-guide/cgroup-v1/memory.rst > > @@ -105,10 +105,18 @@ Brief summary of control files. > > memory.kmem.max_usage_in_bytes show max kernel memory usage recorded > > > > memory.kmem.tcp.limit_in_bytes set/show hard limit for tcp buf memory > > + This knob is deprecated and shouldn't be > > + used. > > memory.kmem.tcp.usage_in_bytes show current tcp buf memory allocation > > + This knob is deprecated and shouldn't be > > + used. > > memory.kmem.tcp.failcnt show the number of tcp buf memory usage > > + This knob is deprecated and shouldn't be > > + used. > > hits limits > > Looks like you split the description (that has weird grammar) here. > Thanks for catching. Bad paste line. Will fix. > > memory.kmem.tcp.max_usage_in_bytes show max tcp buf memory usage recorded > > + This knob is deprecated and shouldn't be > > + used. > > ==================================== ========================================== > > > > 1. History > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > > index 9725c731fb21..b8e2ee454eaa 100644 > > --- a/mm/memcontrol-v1.c > > +++ b/mm/memcontrol-v1.c > > @@ -2447,6 +2447,9 @@ static ssize_t mem_cgroup_write(struct kernfs_open_file *of, > > ret = 0; > > break; > > case _TCP: > > + pr_warn_once("kmem.tcp.limit_in_bytes is deprecated and will be removed. " > > + "Please report your usecase to linux-mm@kvack.org if you " > > + "depend on this functionality.\n"); > > ret = memcg_update_tcp_max(memcg, nr_pages); > > break; > > } > > -- > > 2.43.5 > > > Otherwise LGTM > Reviewed-by: T.J. Mercier Thanks.