From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A5CC282CD for ; Mon, 3 Mar 2025 15:22:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65A2A280002; Mon, 3 Mar 2025 10:22:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60BBC280001; Mon, 3 Mar 2025 10:22:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F96B280002; Mon, 3 Mar 2025 10:22:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2ECA3280001 for ; Mon, 3 Mar 2025 10:22:48 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9F2B3160BD7 for ; Mon, 3 Mar 2025 15:22:47 +0000 (UTC) X-FDA: 83180607174.06.3CA4A80 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf21.hostedemail.com (Postfix) with ESMTP id AD0231C0017 for ; Mon, 3 Mar 2025 15:22:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=BSilMfF8; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741015365; a=rsa-sha256; cv=none; b=msAzvE7ucajHIoXbZD5E6LkEFR4c1+i+llNYsNbZYeqo3p7pZ/rFzUB3G35ibtpBMXwq6M qS93tI/nnCO/9G0UOtARgBTIG8u+PRLhnaYb4TZKtHGnkjaubyWIj6SJh7yOdKNnRLzxe6 d3BYKS7PU/JpM8iS2Dgz9JH9FMyvYdI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=BSilMfF8; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741015365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4wGs7jK9Bj7vq9uXprxwNi5fvQ9EvpRq1hi2k41CtAc=; b=KI+jdXnClObU3bfWDRlRns95q/CW+FrX0vsuW6DmZnfrf4o+JYJ2yeJ9bImc9tDPDEfEnH 2opkzOrSl7hTAX4mKUZEAe7XSR9/hk24QfAaJ58N4bGiqub9P6aR0z2bmgkdG6GGk+NuG1 7Zklr4I5tcAvTLlgEPuBu2rla4veSDs= Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43998deed24so43707665e9.2 for ; Mon, 03 Mar 2025 07:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741015364; x=1741620164; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4wGs7jK9Bj7vq9uXprxwNi5fvQ9EvpRq1hi2k41CtAc=; b=BSilMfF8HUfHwtFIb8Ka/w0ONjK6ztquumQo1K3gCrHctZ5bcmih0tbq4qb9Bk0Gtb rOwQGXM24Co5FePLzN7E8ras2wR5VK0084k1r6f1vO2GYYsZQaIqJh3/SZYMU4ru8Ffr 9TEhE9M/nyZ9XUBNj2YCiEvS8gCp4ClvEiSeTm7syKHevRBxPVZqU2lWs+CFNuRtZ9Yh ccfqYfyKmAe0c3IUihxwTY4i1X3VqG2sxS1NfmBXQILf2fu9N/RxxnloYDfQW49XvLtk DjgLEnu+BEzm4EE0IRJAWrGf6+eGytfPgj/Oqjv7Wn2UzKDco+00b0ObxlI/pN5/+dNj r25w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741015364; x=1741620164; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4wGs7jK9Bj7vq9uXprxwNi5fvQ9EvpRq1hi2k41CtAc=; b=MKD+pmNvk0RK4pSdqGIFNH7vvec30+9NRJA1l1eW/PRo/HYPIxfzqX1VWKnVbtOssC 6lC6IFNmkDJ8rPlM7kzXGRllGaErSNjB1tuQy6H0tOhz8i7b5XEfR5cj/k7+XJHQCdTc JDnIx8B3YTT1ooBs6uda+X3GcarqHjPp+rFbq+ziiH3RaMZs4EU1yzBTA/cA/Tz8rm4B IZvz/teh6NwYyPCSogTlLyrMlcLs9WGbhlNuV/IekAXZvScGyDaBsuaRNZmneMH1Ye4X ejDxIC42+C/HJhhqFIr68gSGE/MCfPkHb0aC1hrh3o8+PiCdjK/3uJ3WVuTq/EUZmh4m mZwg== X-Forwarded-Encrypted: i=1; AJvYcCUA4vZ6s82dtQppHwmRzr+C7IZuVC/qBa83PIQfbuOAIjeqJnczxpFQRjNGWCnS303ew9gdkiMFlQ==@kvack.org X-Gm-Message-State: AOJu0YzN/jK8acA5plBeQYJYE6ZDEY72mmdnmhfcszWwEz7ShZrIUt6Q Xz1LVZAzm4q3SmgxFEtRM23hAkS+++GebsHu6XrdXtuiS8XAZei4t7sL+9sn6qM= X-Gm-Gg: ASbGncvDVs+obUekmse/i3U3OkcXXIdCYaAhDh8/2uOdnQiBIcSggW8KMJHwj3irwSZ CxfIChNLlZS71Qcfsk8I2ZU98KExbEfmYJqJxaZcL+O+efaVr3gqu/mUm8zlt18nu6teoYVDPkM cr8Mgir3tc7+eCeg2IMh6KfM/6rZYxr/K2F4jlFzAJWPEjZtGgSOE+Y571hcfUVSOZEI8sYVeAP FNH9fcxne8FeD/8Jwf81eMdyibJb5K3KwVCSQIbDW1udyizETBZjALHMfuiN/F47Y1a3YuJ20ha bqWvprYjjqd1NNcZUm/VI9bnyKNZLFlR7WRR9idUhfzNo70= X-Google-Smtp-Source: AGHT+IHZlYjKKBZMfn/9ucHLf76EfZ46eRVHZD3BqNqZmIeGhL1H+Iyhtl5P0Uvx6XKM3wU0JcP1yA== X-Received: by 2002:a05:600c:3b0d:b0:439:9b2a:1b2f with SMTP id 5b1f17b1804b1-43ba66f980dmr107971195e9.3.1741015364344; Mon, 03 Mar 2025 07:22:44 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bc447a0b3sm30778325e9.3.2025.03.03.07.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Mar 2025 07:22:44 -0800 (PST) Date: Mon, 3 Mar 2025 16:22:42 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: inwardvessel Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems Message-ID: References: <20250227215543.49928-1-inwardvessel@gmail.com> <20250227215543.49928-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pru4evwusljqesxi" Content-Disposition: inline In-Reply-To: <20250227215543.49928-4-inwardvessel@gmail.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AD0231C0017 X-Stat-Signature: 5s5gtoyu85igh3bni61mcucrd6b9s8y5 X-Rspam-User: X-HE-Tag: 1741015365-83903 X-HE-Meta: U2FsdGVkX1+SbfcaqS155zJLgtqBaz83ly1phdpPvbyYjOsMnG+xBqZPhrxciMk79v1CEk2vcwcfPYU+73drzc2dO3ufKqksap43p8YUVxNnqf3jIWXt8+BVrY8hAZ0y5uIc+HeLMhJgIEvTvvaD2RHKTWNI8FP0XiEkRfC5NRjNjCqAdBF2CRZEOK0Ri1IlHcIOht6N+Mbbd8/QEpTMEaSCheeLp8kiMD3RDB52OVtHMas5mTrwin99f+9MUs0ycD0ZJEeNJXLImPm53pmbIQErhMXWWQF8V8cIgrVV1epZ8q/aBlWeWz54FYWMxqpwRR2rUFuf18noQZnnn/m7cHymzl/fkgqy7kaN38X1QFkNqGiumrX+67LcG/EKF79opc8JlbXW0Xf9dfJexcYdv8VQBfZ/d8vXoU0gD+6yokk6dVxGVFggS9OJcx9lHKzKmR8KDKZsukbPe68u0aWE9XPRvXektB0EdoFJZt7UPlmEFdhvea3Zgj/5RGjQHvk8FdI8pZFjJLRQ9/Nk/FJkbdVa9chrzovOa0PCiC8rFsf5CqZppQIoz3YHzXaPIpxvISq2erSGiR0rkKB9JWnUO+jhj7EOb+t1BJsomYLzwW0kN5Q9w2i0t0bU11DuW2APNAZSgohXIYQOSLPrpB+a7xEIxMJ1KdDkekZ+TEjcEcwIPepc2tUyCVU4nR1+i/tVz6yrc1a36rzgkceINfQ6xZUkhP5sf5d8kW3KbUpe1/fhdQAHQaTFXtRYCtU8lFUPwyuLJeMGPYBc3HJWiZVGM1CACyHiBa1AeQnZCH/fkD70f18lsJkTaxRj7r6QgMAA5rhr/LqeiGwOpOuP9+CRxuBmaMZ9vX5iDhvL1osSTovUMOkR0kABWIP1NMNczUC7KBRAfEPSUUv3M/FvziHUBvfR+GwOYJo6n7G8bFw4pyB3GCnwpS6d78AOGbR//iqZqHaVRS/3qX60O8JG0PS Isu8KKEr NpAk0yWlo648gpfnKJd8U4zoYWIWmX13ykq+TT9d9hP/JLk30NySrCMW7O92+7Mm2nJ+aMrPAlA0dXIT04NjFpa5DyXfOfV177kvMUZKmTEbTo/jMXOS33p/FSIkZPLt5nqEEMOrnfI/Ku1usGtKSwunTQUTrdmMUJy0MFyaOtNv9BZG7UOgjYY8oF6pOfrvQqwTA+gWkzfQhGkiNPta3AMvIcS8tY8plN4TDRMAnHV8EbUTLQ3XJoivaVv0u99igQ+UJh5ktpz4tdxymnDkfuKLeEJtKOYF21iHxcr/wL9FvlInTl8dEZ/A6FOo0zls66wI69VDx56eBygEV9Cetb8tCE9iKXrBk/d+0MQwN6WPfhnwB+UoYOP35r6PckLSpCTCOk79tCo5C7w4sOMktS2/UJBXotmzLTgjdmHA4XHCahG9FGN+vln9aR2wKMb0MpeniyUEbXdGGIOg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --pru4evwusljqesxi Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 3/4 v2] cgroup: separate rstat locks for subsystems MIME-Version: 1.0 On Thu, Feb 27, 2025 at 01:55:42PM -0800, inwardvessel wrote: > From: JP Kobryn =2E.. > +static inline bool is_base_css(struct cgroup_subsys_state *css) > +{ > + return css->ss =3D=3D NULL; > +} Similar predicate is also used in cgroup.c (various cgroup vs subsys lifecycle functions, e.g. css_free_rwork_fn()). I think it'd better unified, i.e. open code the predicate here or use the helper in both cases (css_is_cgroup() or similar). > void __init cgroup_rstat_boot(void) > { > - int cpu; > + struct cgroup_subsys *ss; > + int cpu, ssid; > =20 > - for_each_possible_cpu(cpu) > - raw_spin_lock_init(per_cpu_ptr(&cgroup_rstat_cpu_lock, cpu)); > + for_each_subsys(ss, ssid) { > + spin_lock_init(&cgroup_rstat_subsys_lock[ssid]); > + } Hm, with this loop I realize it may be worth putting this lock into struct cgroup_subsys_state and initializing them in cgroup_init_subsys() to keep all per-subsys data in one pack. > + > + for_each_possible_cpu(cpu) { > + raw_spin_lock_init(per_cpu_ptr(&cgroup_rstat_base_cpu_lock, cpu)); > + > + for_each_subsys(ss, ssid) { > + raw_spin_lock_init( > + per_cpu_ptr(cgroup_rstat_subsys_cpu_lock, cpu) + ssid); > + } Similar here, and keep cgroup_rstat_boot() for the base locks only. --pru4evwusljqesxi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ8XJQAAKCRAt3Wney77B SS6HAP43BFlFZii8ME858IQ21EkBriG+eWmMI8IPJfDAtopYwwEAii8NEIgzMWUe i9P27K+r2zvIj9J8wyAkITZTO5g5/w8= =nKWP -----END PGP SIGNATURE----- --pru4evwusljqesxi--