From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3691CC83F05 for ; Wed, 2 Jul 2025 16:42:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0ACB6B00D8; Wed, 2 Jul 2025 12:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABC096B00D9; Wed, 2 Jul 2025 12:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D17B6B00DB; Wed, 2 Jul 2025 12:42:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8E0E16B00D8 for ; Wed, 2 Jul 2025 12:42:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0CCEE1D4AD0 for ; Wed, 2 Jul 2025 16:42:04 +0000 (UTC) X-FDA: 83619891768.18.3E368AC Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf23.hostedemail.com (Postfix) with ESMTP id 1FC3A14000E for ; Wed, 2 Jul 2025 16:42:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Ecv9veGN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751474522; a=rsa-sha256; cv=none; b=fHzOww2Lzzfpy/3G8yvd5ULNQAqNDpLUB1tLAOGp4YPWxoAM01INJwHlm0fM87Jt4WEg4x eX3Q1jw83lobs4dhGL+EMzg/iz7mLE+77zgPG+MIayosCVHoh7rDGc0xJ3zd9lTKPJM6yu Ug9cP8iegEevq9H6dbhI7F1h6XDltHc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Ecv9veGN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751474522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A5s48M7rOqcXqOSVmS8nx3gNeb8aROKoWGRX0CL/xU0=; b=RfIEQJD7vTtLlsloo/41KSwejm3CMKVuNhun7RPXXDacVvwDXbsxe62swk00GeMErqpRLA pho9JnE925s7AW7IR7MGrVx2c942XwnR48CqjyW0GOuz1vGhZDcDmui9fgTy3ft1y6lgVQ kmPtXfbap7BCRGMND8EuKsfKNQHit30= Date: Wed, 2 Jul 2025 09:41:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751474519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A5s48M7rOqcXqOSVmS8nx3gNeb8aROKoWGRX0CL/xU0=; b=Ecv9veGNTwcetXtwhDTJoIXK82M1FgqoiD9Q8aotMISEZ4tVjF0dInAyWF/G8qydHa99nY OqrYRFZ6/FFjXYGkQgz5RfVV4/RfK9cnmmSJgdDD/L7CnqlK6SAtctrTcxLYXVx0lNKnhS EjW54sKA06SLu0h6LtCnv7WVHIpdmHk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Dave Airlie Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Johannes Weiner , Christian Koenig , Dave Chinner , Kairui Song , Dave Airlie Subject: Re: [PATCH 13/17] ttm/pool: enable memcg tracking and shrinker. Message-ID: References: <20250630045005.1337339-1-airlied@gmail.com> <20250630045005.1337339-14-airlied@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630045005.1337339-14-airlied@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1FC3A14000E X-Stat-Signature: h98c9n5jztza471iqx1b5dzpb91k8okg X-HE-Tag: 1751474521-504489 X-HE-Meta: U2FsdGVkX192qUmG/GyiIK6zZj/NlubRvWTIOHTFO0BsZBBZca8hol7HRl4qiQfDJOXsZ46iJfoEbIzTw1/3pXW4a1hf5l0ce/+CvwBwuIZtiUsXJOoNa8GcNX4znwBOB/jMycZYBnd2UIGQLJ9XEqhaJphWQXaAaU06p3IRXDo5J8jsAZARApwZ+Ujtmvdtf1C2pD8/GySliPDklECKGmZyw9jG3jKwsG2eKl7f/TKu4wHYtJv09A7Bdt5vOtWu6twBzW7sgXAth9Ep9K2/gJ7Aq0ld0n1iz56L4IxKOC35lodhxZno+TwgoR4+ShxN1g3+Urug1ZHpSJ76MPLibyt0iB6n0odn0E0a9cBGq9BMqYRHK8xNaBXq8az7Uo2KPS9awQI0pWdlZikIXfyjDXrVsBV1fmuSHhbcbEMdHHiiWCq59V50kKRyES8freo/9FnpRwWtZAsKTuyVTl+AmpGDQBaGue0hgtl7dw7drwmrsWN8aJ91HjY3HxvWv8oICwgJn1M2Wnn6rVGZr7nYE1x/pfvNazVfaqhlDpIXJcXihQ2PaPW7/tdI1H2CL5qiL3gMO6ftv0b0U6+syBBgxR7uk1iqYdueV7BOueynd27OqHnQ9PymgUN6svHuzv3BL60z2HxtpCbkuwdt5H5/mo+vvCpgLRghEzI2ovg6ihMpVFmtYt5HRzYFMfEQ9rRYVeLkrK2phQaqBeg0m6pD7yZ9lDeblYAJbErxGPzsRI15HtYRjNZhUeCiuFjoRr0Wpmsg99rr46aPdnGN5fNRJiu3xAam7QDQuy3qqZ+Q6FP9oyHwYyV01GbcLw2VIljZCHVsIeBu09Nb8Pj93mUyGQAi45yVU7HStBEtBfSprgriyHPlRQjqLHMkvcXx2coCNeB6cJDqijynkeDujePVw59aribRbLqK06V0f50vE9NAdlE4iRyUelLSfiSF4frEWL99re05WMarn2rKx36 MVj8WTu+ 6OXhz29EcQiMNX6NSqZWLdzIfj5HhEIjrsxQCWDlxc/bGVX9nCTBTTbDTMKG4vB7IVHifPeEkWgymzc7RroXDWMLev8LZ+32y0pE4sATzhh1N7O0ZtfpHvD8JLfl4eMNb0PXTQWE7N+ZlYFj1q/xpZ5RlWux2iZAtGvTUIsMo1BC98l0wBFG0OUaPOAqlHopQZHR1gok8jMrxE9x2vhBuYjmTtlCDpoZtXsIWoGxXdxvH0gU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 02:49:32PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This enables all the backend code to use the list lru in memcg mode, > and set the shrinker to be memcg aware. > > It adds the loop case for when pooled pages end up being reparented > to a higher memcg group, that newer memcg can search for them there > and take them back. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/ttm/ttm_pool.c | 123 ++++++++++++++++++++++++++++----- > 1 file changed, 105 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c > index 210f4ac4de67..49e92f40ab23 100644 > --- a/drivers/gpu/drm/ttm/ttm_pool.c > +++ b/drivers/gpu/drm/ttm/ttm_pool.c > @@ -143,7 +143,9 @@ static int ttm_pool_nid(struct ttm_pool *pool) { > } > > /* Allocate pages of size 1 << order with the given gfp_flags */ > -static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags, > +static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, > + struct obj_cgroup *objcg, > + gfp_t gfp_flags, > unsigned int order) > { > unsigned long attr = DMA_ATTR_FORCE_CONTIGUOUS; > @@ -163,6 +165,10 @@ static struct page *ttm_pool_alloc_page(struct ttm_pool *pool, gfp_t gfp_flags, > p = alloc_pages_node(pool->nid, gfp_flags, order); Here I am wondering if we should introduce something like __GFP_ACCOUNT_NOKMEM to avoid kmem counters but still charge to the memcg and along with set_active_memcg(), we can avoid introducing gpu specific memcg charging interfaces.