From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53DBAE7C4E9 for ; Wed, 4 Oct 2023 18:32:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 822DC8D0003; Wed, 4 Oct 2023 14:32:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D38E8D0002; Wed, 4 Oct 2023 14:32:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A958D0003; Wed, 4 Oct 2023 14:32:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5594E8D0002 for ; Wed, 4 Oct 2023 14:32:46 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0B97C1A043C for ; Wed, 4 Oct 2023 18:32:46 +0000 (UTC) X-FDA: 81308625132.23.2AFDC30 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf19.hostedemail.com (Postfix) with ESMTP id 341481A0028 for ; Wed, 4 Oct 2023 18:32:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="q/nTqZ7H"; spf=pass (imf19.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696444363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t4VXNBgch7cHxmFAAfzZ4yk5G9bBv4IijY2ezEVg1sI=; b=H54lhDYt0deFl4uVslSz3QDdYyizG06hcIrGxUIBwayfpM87ByHSpImY5bNHHRil33gUNX z8CFnxR4YR1LlvVCcA3U5WS3KXnC/klUf7bkkFRxrQFm4DyBKK32k+TzXxrZMg8h0BW4t/ gzNEwDjN2ptxqOm7ZRoJjGomDEIL774= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696444363; a=rsa-sha256; cv=none; b=Ms3cTbcjLU2TrtYrnMRfGU+VRqQz8ekgE6/zo1ub1nHaWA/pBSy0y2REdPpA7RSJv6NHlj ciEC6o3AbT9XVlBvUeq3GE8pv5y6Cw3E4XoTLsbWV4hVIY8tXOoW6oKln5fem8aRMJvDJm r5qnjIOadd8azTPVZ+eBF5ZpFUYcTxo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="q/nTqZ7H"; spf=pass (imf19.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E4D771F45A; Wed, 4 Oct 2023 18:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1696444360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t4VXNBgch7cHxmFAAfzZ4yk5G9bBv4IijY2ezEVg1sI=; b=q/nTqZ7HNJl0vlRvhOtwEPvLtgxtFocf5ftD56dKVl0FPuULOQaHC14ugXq6VkQ/dD1SpJ XxPViUE9If05/xUd6xRLKOJ3xpJ0nNQ8JkqyhiNe9A3TuQ72DIqatVz75ZWCdVixXdLl76 ZZURgLF1RgVTYYjoT1TQZBB+/EO2tyo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B6ECD139F9; Wed, 4 Oct 2023 18:32:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UpfVK8ivHWV/dQAAMHmgww (envelope-from ); Wed, 04 Oct 2023 18:32:40 +0000 Date: Wed, 4 Oct 2023 20:32:39 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Roman Gushchin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Dennis Zhou , Andrew Morton , David Rientjes , Vlastimil Babka Subject: Re: [PATCH v1 0/5] mm: improve performance of accounted kernel memory allocations Message-ID: References: <20230929180056.1122002-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xrhdawqlfcfif6oj" Content-Disposition: inline In-Reply-To: <20230929180056.1122002-1-roman.gushchin@linux.dev> X-Rspamd-Queue-Id: 341481A0028 X-Rspam-User: X-Stat-Signature: bpaf3bx7sk9ggm1dt888kd55sd5yhidt X-Rspamd-Server: rspam03 X-HE-Tag: 1696444362-999002 X-HE-Meta: U2FsdGVkX1/3ovvZ2hBxNKHNXlgi4weeT1CL4hK8RJ5XbzzRMIlvkPUZFnhQ6narMgkPwD14oKq1yMhVOLiQJRZUf3vqO22dIriVqdzuXVZX8pEp5TXcyxlTa2aJysS7MwjgoBQq2LwGOhserxxSm1LJR8gjQUn6yz9g02Tgr88+WHEKvfV1AtovvAt1w0eQm6PqLElexLHre8opdWjPCuIA1A5dJrGLKImL42ZiEDazhHASwTKQazazQsbZw1+tzZD7XWfUP0OQ9B64xIYGkK/H0UlcD2czvDIkrYdykThQ4hN3wxSMbEj0VelQyOLmkpWCwe0q6BROtDyaurNkwmBTs1SbXEx+ER1ZyGf95qYyzFQRazRN1T1jif54awWj4mT33A7zxtyF1nuYT4pCFvOYJC4kg4Io9qhFGoDdOkBkKyKsKREP7v5qhlbG2NuHftyWIj2410bT1HkvLT/wo4aVeoz0SPzGKOvLLf+FL2+lKHvQ8TF10YOoYP6KGFzZ8bO/HcHTtDlCtWTGuY+nJNcH5ot738joD3TEVnulY52ElRy7B60dDhhEU81oDIxaeYU1jZSNRLus8OPrLeJqO5VnchGLWW8eDbefcIkxyFo8rDd/Ne0xMsxjXI5NwwSBX2g9ErnhEpADjiK308D/fEGKtf0HeMsuCbv1IMuS2GFmjO85o5nJJixsaqWcsMuKqcBaICfm/VccqLpQA5DIvNnyWu6piKVo4Ej/t+cCaH0ph7eR6Pep05aIAqWRTSPeSQ1cViEH7Wu1STxosNe8B0eh54i1Di18B5OAjG9Wovcv8r3/7DeVjMk8/ZwheZtDGJTlz2yjbjKe4vpCJLKKqJ9YdUmceF03f7G3BxjhH3RlqpJYaFlGtzffdA6ZPM7EDDgPDEmXIYtSPePSFA18cciJbAy1nHs36V/56cUCGrDS3tvFSldabOM+tOBGlt2trGgLvuI8CBKCe/qfSx1 zZakPJ35 wMRXvcFecaTH9GcmFzUoCOZuweycuv/tDYv9AY9SF7r2IkeG9gNN43GlBWplGWYOB0H2tq0bIgy6/pf/utcyrE6WDpo01tmS0UZuLuJdlnE0emvqUANkXPrU5OInCuQGS6Tnzlir7kEA/FDodkCYkWtwEpru/u27nxADA1Ra+rJnEUEPLBipC0FkBIYIv4bZ3M1BFAHb4qIl0DOUbDbdScCEA7gdU4Ecw105piUiHX53taYbjEreLfM4Aeu6VKq6M1+jwMwkh+m73f64eYTS+Xr3V7X5Lq38OxJmyuCju2BLFG/vmbI5f2Gx8nYKD1LkrEqKP7zFM1wpmBAByP5FQ8LvfqhuxZA3QedktTCuChLAisbV3wFPyWHthJoUy7zTZdrtq2JVTxO30W/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xrhdawqlfcfif6oj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 29, 2023 at 11:00:50AM -0700, Roman Gushchin wrote: > This patchset improves the performance of accounted kernel memory allocations > by ~30% as measured by a micro-benchmark [1]. The benchmark is very > straightforward: 1M of 64 bytes-large kmalloc() allocations. Nice. Have you tried how these +34% compose with -34% reported way back [1] when file lock accounting was added (because your benchmark and lock1 sound quite similar)? (BTW Is that your motivation (too)?) Thanks, Michal [1] https://lore.kernel.org/r/20210907150757.GE17617@xsang-OptiPlex-9020/ --xrhdawqlfcfif6oj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZR2vxQAKCRAGvrMr/1gc jrolAQCd8T26iT1xL/GtSHTC7BZH+GIQ5QrCf0gJt5shxk7K2wEAu4q5L5+nO7Hz BDRacJqGpEoX/IwT3UmgeM1mIClLHwo= =SuM6 -----END PGP SIGNATURE----- --xrhdawqlfcfif6oj--