From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8324DC10F05 for ; Mon, 11 Dec 2023 16:38:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D9DE6B0179; Mon, 11 Dec 2023 11:38:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 189586B017A; Mon, 11 Dec 2023 11:38:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 050A96B017B; Mon, 11 Dec 2023 11:37:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E6B126B0179 for ; Mon, 11 Dec 2023 11:37:59 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C452416071F for ; Mon, 11 Dec 2023 16:37:59 +0000 (UTC) X-FDA: 81555094278.22.6A9CC91 Received: from postout2.mail.lrz.de (postout2.mail.lrz.de [129.187.255.138]) by imf08.hostedemail.com (Postfix) with ESMTP id 11C87160006 for ; Mon, 11 Dec 2023 16:37:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=mlVfJUG6; spf=pass (imf08.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.138 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de; dmarc=pass (policy=none) header.from=tum.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702312677; a=rsa-sha256; cv=none; b=glPZenbBBf5uNtKKOsP5b5SCMCpK1iAqG3YxdVFhdOYWta4m8D8a3vVtA7eB8l15ocEtuu yHmlBATywKwzm+dQn7Fy9mx/p1mOUneko2qLji2ToEGs8gSEgELPzseFw1fUXESUq2spNw +LtlSeMRRR/BgvONSn5xlY7PLMsmkTo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=mlVfJUG6; spf=pass (imf08.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.138 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de; dmarc=pass (policy=none) header.from=tum.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702312677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7+HUN9YymZ4vhBFtbMavTxW/F7DkeQt7GVW2zJaY3Y=; b=rXR1bi184gTeB0bd38SdRHq81KTsVGUi7Ue00jRwRJQX5kfmG8YT+iTQufFYpIHLYJmon2 7OAdTUzBs9a8NxQJ3Y8qFxXg8HsewaxXC0N1I2DTANDCq91xHHZqZbuDUKWN0ffYWWytSI TKE073CyosvSrCpo4NU08/0v8R1vJrY= Received: from lxmhs52.srv.lrz.de (localhost [127.0.0.1]) by postout2.mail.lrz.de (Postfix) with ESMTP id 4SpnV85qdXzyVM; Mon, 11 Dec 2023 17:37:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tum.de; h= in-reply-to:content-disposition:content-type:content-type :mime-version:references:message-id:subject:subject:from:from :date:date:received:received; s=tu-postout21; t=1702312671; bh=I QZ37jqHjRiCVAog/SxFby9In37jtg4+0rtjT7Qm7bQ=; b=mlVfJUG6uMk6HCn0w GE8s0S6afNDFSYXDag/1mnxPJU83BIHAt5ccF6i6+x4q+kPHXTfqbpKUI9Ps+DAF 7D8eu4qS/ue6gZ+7mSqzxmc2IjIlsroDoEui4w3/8jgYSWMiAGjcFqJnh/DPmCFp Q7CQReOfLxA6F1jgf5NtgCYPReIDWM0YfYvjGSgEGEnhblaq/CUnk9ORGvG5I7F0 kwCPNTX2zDiMKPtA3/f7awuim9OgqtxoQ7x9Fp6M++kSsdq2glcx6ocd8eQ8FnQx Nkhv+Ky1mpE0itBEcrGbXhyyAWvWyBF7TMZjun8sFCHHOrMNirXCaG80D1y6x/K9 eW/BA== X-Virus-Scanned: by amavisd-new at lrz.de in lxmhs52.srv.lrz.de Received: from postout2.mail.lrz.de ([127.0.0.1]) by lxmhs52.srv.lrz.de (lxmhs52.srv.lrz.de [127.0.0.1]) (amavisd-new, port 20024) with LMTP id qxvPLSwCoF-F; Mon, 11 Dec 2023 17:37:51 +0100 (CET) Received: from Monitor.dos.cit.tum.de (Monitor.dos.cit.tum.de [IPv6:2a09:80c0:38::165]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by postout2.mail.lrz.de (Postfix) with ESMTPSA id 4SpnV65Z38zyTN; Mon, 11 Dec 2023 17:37:50 +0100 (CET) Date: Mon, 11 Dec 2023 17:37:38 +0100 From: Paul =?utf-8?Q?Heidekr=C3=BCger?= To: Steven Rostedt Cc: Peter Collingbourne , Marco Elver , andrey.konovalov@linux.dev, Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Message-ID: References: <20230215143306.2d563215@rorschach.local.home> <20230505095805.759153de@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505095805.759153de@gandalf.local.home> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 11C87160006 X-Stat-Signature: f13bhnaqqy3woe55mr9k5wtkbtw4hp7c X-Rspam-User: X-HE-Tag: 1702312675-543986 X-HE-Meta: U2FsdGVkX1+WRZ6G02HoQStx1fxZ/2+uV+T9VeACM6t9u1+mL/Suqzwu1fdjcw09dQRm/SwusD8aUkwKGfTWEOsUmw/loH2C409I8YNj5R45IJKRtmDTW3A+NCNa1TLrSV3bfh8wT/sWW56NsOId2YNvdxYD+W4Z06epEHro3QqvrEjjJiLcDs4W9jKUACmb7iJIhS8Qz+/bYajElFI4EaaXIKdYjrU3RkDF/dxt7eRWFnXykufN/C0CtEDeVeQ0WiGd97YbnpMN0YTJ8GtsCZpf6CJLrQqqEzTg3w3W7zNt/3/k6+MbG0On4TT86+bn2jYjdhtuXX3iHllUaAOIYGsEgzeJ+Uvv5jl8gZnXnl0FeYKczM269StsqcCSPJcL93JpYcSnOoZCwSIlGE+XFyfbPqpLQ+oEZNTELKOEO+6AEaZnsr3ch2KtXAIHf6pa6qJQxShRGYN0j8MtngLxem0x5aaihwGCTspLl08pLmh5TI1srhdgPhmDldu868HeDhv8H+8HRkybnTOTKLE/lF3voadTXlG3vLuaCa2uVgwmoSabbQbKo2EfI/uRLuRMXplRD00JOoINkTlHEcEu9zbmPrjeCl9XNKIyKi5OVcYpZI8UGlBIUYnG65FHsIWZO43Pv1vtT4uakQKMTBxTVTSKl+Wdvq9wNvqDBsuvh5soSzIcmJX1jPO5NEy2J4S//D80TOP5wwbbHxDvWDVkzGh12J176PJwqneGYHY4es6mYz+9v0t1TXOOrM+p9jR6fuP6vtwMlXD9a0pyuiDKj+qzvDDo5D3vB8H5PpFZ9sAgd4VWx+f0xSurVvoWLqsnK1VEOLY2wrO8cWMY/dLAMt3VN+JnnF+znjhr3VWF5q91EzvJEJrrO37IoPweyiKCyC8IfHG738IIUhLmIcdADyAorBay+g3/DKDw0nW51CkJCEimC3J+1g+QpwzMfsZ0EwA/dudKhiEXzVgCXsD 52771aXR NBTzhGRB9RBD4t/wm+OfmY0KGCbeiZVY9XhcVee68ojS4XwXYxS2mqrj1y0yWd19J+Egi/AKqEBplFnHrMY7wA46r3iKAmy3FTsUVSUg0atWXOzgS0qydu7rYRdsHRO4Ppg0/1Whol09v0SG1egvJFXJfwdFwlzQe6uy2tla6k6JgTY7In3CJfT2byrvrJn9/gi3FW9u0ILJcIqcfz646fQO5fFwzNgssnEJycjj4sxx344O8Z7ja9/vj7ep2tCOA8LfJH1aQf72zQLYpyBvQeOiMI8smrN0ZQaICuQzRqwHPZT4+CQArJ5GEj6VfTvcdCw0kYh+WBAMnlaa0hw26Yu+Whz1ZLPVaGWJczTaFJzFyDw7ZqOkzPqAOJUYV74dPxsVo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi all! On 05.05.2023 09:58, Steven Rostedt wrote: > On Mon, 1 May 2023 15:02:37 -0700 > Peter Collingbourne wrote: > > > > > "ftrace" is really for just the function tracing, but CONFIG_FTRACE > > > > really should just be for the function tracing infrastructure, and > > > > perhaps not even include trace events :-/ But at the time it was > > > > created, it was for all the "tracers" (this was added before trace > > > > events). > > > > > > It would be great to see this cleaned up. I found this aspect of how > > > tracing works rather confusing. > > > > > > So do you think it makes sense for the KASAN tests to "select TRACING" > > > for now if the code depends on the trace event infrastructure? > > > > Any thoughts? It looks like someone else got tripped up by this: > > https://reviews.llvm.org/D144057 > > Yeah, it really does need to get cleaned up, but unfortunately it's not > going to be a trivial change. We need to make sure it's done in a way that > an old .config still keeps the same things enabled with the new config > settings. That takes some trickery in the dependency. > > I'll add this to my todo list, hopefully it doesn't fall into the abyss > portion of that list :-p > > -- Steve Just adding to Peter's concern re: CONFIG_KASAN_KUNIT_TEST's dependency on CONFIG_TRACEPOINTS. I'm having no luck running the KASan KUnit tests on arm64 with the following .kunitconfig on v6.6.0: CONFIG_KUNIT=y CONFIG_KUNIT_ALL_TESTS=n CONFIG_DEBUG_KERNEL=y CONFIG_KASAN=y CINFIG_KASAN_GENERIC=y CONFIG_KASAN_KUNIT_TEST=y CONFIG_TRACEPOINTS, which CONFIG_KASAN_TEST relies on since the patch this thread is based on, isn't defined for arm64, AFAICT. If I comment out the dependency on CONFIG_TRACEPOINTS, the tests appear to run, but KUnit isn't picking up the KASan output. If I revert the patch, the above .kunitconfig appears to work fine on arm64 and the tests pass. The above .kunitconfig works as intended on X86, no changes necessary. Am I missing something? Many thanks, Paul