From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19AAC5478C for ; Mon, 4 Mar 2024 15:38:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 678EC6B0078; Mon, 4 Mar 2024 10:38:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6285F6B007B; Mon, 4 Mar 2024 10:38:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EF946B007D; Mon, 4 Mar 2024 10:38:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3DE646B0078 for ; Mon, 4 Mar 2024 10:38:41 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EE3201A0C0E for ; Mon, 4 Mar 2024 15:38:40 +0000 (UTC) X-FDA: 81859764000.12.7DFD3C5 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf26.hostedemail.com (Postfix) with ESMTP id 5C334140007 for ; Mon, 4 Mar 2024 15:38:39 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=nCigb0N+; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf26.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709566719; a=rsa-sha256; cv=none; b=4HgXl21xT+UNdNNSo6yoa/LGfU3cFRRtYJhmlLUFFiQy7aO4nGA3oj2iqu7npPDuacYqtH 8pOYl6Ybs+VeqPyd9HI6HyjFN80VBZmHeuj84p1syoz9RIsWx6V3O3g2LZ8rm2jO+7fwzo 9y8dtV7cN3C0AdmL3rJFxhzcXCdiNv4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=nCigb0N+; dmarc=pass (policy=quarantine) header.from=pankajraghav.com; spf=pass (imf26.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709566719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SCUZrMhv+Ip6AlhQv9o/ZyuuqgJYxTQNgNIIwuFAJhg=; b=7NLnUlxMm24qEvjwGAc6SUra1n4E0LbSLPUCTSSlOlWGRBkwbHJfO1bnxK2Wan/lVj3BTP NE8UvpFqRQz+Dte9Xx2WHuqmWUQcUdccqHsK9ERz9vB8eKOjSXXhN0A3/r9ln8RwsoZUtj uz+I1UxnFFfMElYvnH26NcdAgSJxzv0= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4TpNC02CXpz9t2x; Mon, 4 Mar 2024 16:38:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1709566716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SCUZrMhv+Ip6AlhQv9o/ZyuuqgJYxTQNgNIIwuFAJhg=; b=nCigb0N+NOC/Z7x7NK4bJ7M9+yqmc8/b9bw3lzKhp0Hwd9ojAausgLTzVrc1WS0moifMpl 5Dyx7gEheOypByjZutu8yfpfcMISQamT9Fr+aLVBl4A/v3ye/jUtGJla2D5HT68lqkx/yA y9rCCQXBZe4IbOeNFWnHwBtrDLfGDqAW/zjonKERsI/7jMqAHmoxd9AQ8mW46gHr4j/pOE xlMj5xGeBQ5bHBk7MgyfcadTXw9pNn5mb61xaMpNl87L/6uPrfIS5WbJaDSMbihfkmW9bD 95zSya837PM4+vyODLRrA8Coka9IfQLAqxh1txUNOl8nSkIDS5yamMvj7NXUmQ== Date: Mon, 4 Mar 2024 16:38:31 +0100 From: "Pankaj Raghav (Samsung)" To: Kent Overstreet Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, djwong@kernel.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, david@fromorbit.com, akpm@linux-foundation.org, gost.dev@samsung.com, linux-kernel@vger.kernel.org, chandan.babu@oracle.com, Pankaj Raghav Subject: Re: [PATCH v2 03/13] filemap: align the index to mapping_min_order in the page cache Message-ID: References: <20240301164444.3799288-1-kernel@pankajraghav.com> <20240301164444.3799288-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5C334140007 X-Stat-Signature: rn83dpzzm1egc4j9idz6e9mjg3w7erce X-HE-Tag: 1709566719-594619 X-HE-Meta: U2FsdGVkX18fQQjrtKgwCBQS6m46y6ro2/OWwdMhKUTm4w408fmT4/80cOvtKbnWpHTFg2fi/UAPsW929FQbVbTAsXmxTd9eMukEPa/0VWYLpXKiIMoLrS7Pio07DXAwzvd9y9CbsmAZYybBcbxRohiFDHgcIBI6egMPyFTR87q7hX0jH37/2SpTyox0VML7uGQkqrh7kjFVYI0pT+FGsQ0Mqqt0yC0teCqnpGGGXoCjeNZ/t1xr2dYtFUuCUXalF6eZiDoo4vC6SxX2vsqDFXEJV7KnIMEw34bq0veOJEOB9h4lzfol3Tow9boSGdjm0jYqN4nlT1v4H27nU0O9wWLJBq7NRfHp5g+4W2Ta5pGWNTubhJeuU7u4JgnE9v4ETWV+H8UFN1RxS3z8m+f+SGwiCgwoDyA3o4rtfkBPW6Q6Q3Juz++K3DfDzpaiCPaRpFZZ28vIfGIi92MTdDV9FBC7LRg7zWKJPL4RjNYGN84eN8ekqTNButd5r5Ube9v8QpbxHM7fEwAsBTRA5tntRVMS64vLEdi7GZraSabb4tKvl98KCmkNRsa0cIZ4Bpuygv2Nkxja0CHScE9FLBdAW/xuy3yeNAq6V9NreaJlLGGQy/4zDMZNXrFPkaGX7hvIvYrBZqkqKlVqbqPUQFtaUtr1/mFCeEQNT6V1xkotJU4e6+o1hnvRbJFH8EdGZYvAOiq4GBprxOd+mg44djEZDDf/KJjE7Mw+zw+fTexjumBdbMJnt4RK1YBcugiLuaBG8nBvuzDVqXGKqLqVsiQVGI4csLhq6fVvwUArZOb+7GwB0J8BsBNXvR3FXnCYuGgL1G/P6+hGyqbe8S75wluX6OvMgl9nr8D+ekce+vWRPGU5LH1y2+9eMgDPRdeszjJkb+mmQSkP+rLX33RF9849Yvg1zBedokhZi42R0vh/yos= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 01, 2024 at 03:04:33PM -0500, Kent Overstreet wrote: > On Fri, Mar 01, 2024 at 07:26:55PM +0000, Matthew Wilcox wrote: > > On Fri, Mar 01, 2024 at 05:44:34PM +0100, Pankaj Raghav (Samsung) wrote: > > > +#define DEFINE_READAHEAD_ALIGNED(ractl, f, r, m, i) \ > > > + struct readahead_control ractl = { \ > > > + .file = f, \ > > > + .mapping = m, \ > > > + .ra = r, \ > > > + ._index = mapping_align_start_index(m, i), \ > > > + } > > > > My point was that you didn't need to do any of this. > > > > Look, I've tried to give constructive review, but I feel like I'm going > > to have to be blunt. There is no evidence of design or understanding > > in these patches or their commit messages. You don't have a coherent > > message about "These things have to be aligned; these things can be at > > arbitrary alignment". If you have thought about it, it doesn't show. > > Don't you think you might be going off a bit much? I looked over these > patches after we talked privately, and they looked pretty sensible to > me... > > Yes, we _always_ want more thorough commit messages that properly > explain the motivations for changes, but in my experience that's the > thing that takes the longest to learn how to do well as an engineer... > ease up abit. > > > So, let's start off: Is the index in ractl aligned or not, and why do > > you believe that's the right approach? And review each of the patches > > in this series with the answer to that question in mind because you are > > currently inconsistent. > > ^ this is a real point though, DEFINE_READAHEAD_ALIGNED() feels off to > me. Thanks Kent. I am going over the patches again and changing it based on the feedback.