From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5DCC02194 for ; Thu, 6 Feb 2025 15:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C943E6B0082; Thu, 6 Feb 2025 10:57:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C43496B0083; Thu, 6 Feb 2025 10:57:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0B1D6B0085; Thu, 6 Feb 2025 10:57:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8FED56B0082 for ; Thu, 6 Feb 2025 10:57:45 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 40A1D8124A for ; Thu, 6 Feb 2025 15:57:45 +0000 (UTC) X-FDA: 83089975290.19.41F2032 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf10.hostedemail.com (Postfix) with ESMTP id 350D0C000D for ; Thu, 6 Feb 2025 15:57:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=OMotyL3C; spf=pass (imf10.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738857463; a=rsa-sha256; cv=none; b=OswE9jh8dWiUsF8FK+0YTy9BAH0V73H/lzQS153pgUw9G4LR39cI9huIoNkmo8/WwUNolY c9CRV7ffmJtIpH9qS62Jyo8nCxuVei9yw9Tq/q9G6l/DuO4pZ0uJOpuhVpRdjo28nUZxOy ML+jfJDWP4j90nQUXV90RiPISdDpmFk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=OMotyL3C; spf=pass (imf10.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738857463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VVbyILDZ8O23cCbLemWssIEyMVaqbxgt8Ip2vBbHLgI=; b=HCgsAevHO8AK2/VOy0J7UwXhLSdmDuju8G/dMKu9MtzEtt8vOXLEL/M9cCDcj0XBA5gt4w GUiwvZRD+ANjnJJKGvWrwdlwSCs06Yp54baHKFFA9TIZLkpEsnH6cqh/pgIK4edKsHFvij uF087sYlkvy9UlKvnM7Ai0zOkvOg3Uo= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-436326dcb1cso7712485e9.0 for ; Thu, 06 Feb 2025 07:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1738857461; x=1739462261; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VVbyILDZ8O23cCbLemWssIEyMVaqbxgt8Ip2vBbHLgI=; b=OMotyL3CDtT7myhkJZMcV1vHRFarkHQ4z1MEXODfj/2WR/hGVjWE2wldhiWuA3+ddP W5+0yTKpWR1D3w7gS/ydv24T1ut+wwRIimDqpaTmpOrSa6xmt1ABJev6snplThFux+Sb tRGZnjZdXnF40CZ2Da6UO5S5wr2coEYpVSIFYn8mhX0xkaQ5jUFHEB+6NlYooub7yS6e aOMj838Rm4k+fhc2TkO1YxEuZNy92icXTUTJbNNExXOi5VkhJPxg+j0Be3kc9qHALE0T b4rZpkrQARSn/ogrFRsYxt9NQKwB0tS53sFAkeX/Wm+vS0ikIeaiDxkQsB0xkZdrPol/ ZDqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738857461; x=1739462261; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VVbyILDZ8O23cCbLemWssIEyMVaqbxgt8Ip2vBbHLgI=; b=ukk1K7jgRxJg4/w3CHJ66Rb7Ht//yuzJx+nNVB06gN1EvAvf54bQ4bi3D0iwKxCwYX Cebs+R1pfBhp6QGQcepRqK78E9u2sQXOdOkItsCQ9R6JdW7+Cmtni0TIIHxr2n0kap9P bh94xhH9P8+goAEyKMb21RGxQrcNn1IfpjU5NyfMfFDOn3dVDzoe5LnolU6eBin5hUFU VFEBUpbfCBQV2h45sVewccVjlrShYz4h/n1Cj/uGQeWvqFHA8qBIfLwZJlebOiLpoMAc 0yQU6tlHoOqgmifLmdCLEQ6s8S/OaWK3iyBOFBwemPMzpK4XSlnGE5Rq1BgPIiiTKaWF RTrw== X-Forwarded-Encrypted: i=1; AJvYcCXOSJHB7EDVI79Rt4kWNaR34BY7H0jrG33dHOB2gIwB3fTlx/1Ehz6j7p54IFNymkPFT9W+3wImzQ==@kvack.org X-Gm-Message-State: AOJu0Yy2ZBDjx/sPcOeK3o1iua0sAejVzNfENepuG8N63xFw6qEFZDl+ h5vOEmxL49mQHYbF/QxnDcUB7K2UXzF+/ksgUYqwq6pai11izz43IwXVpu1kefI= X-Gm-Gg: ASbGncvj74UQOLHlxuEUJZTTP5boWbLo9qyuC6ZQFFB930If/dqO5tOachh93ROA5Qx oc77okJhJsQdHAz9qZ9yWqnQ9da8NGq4EttiP5q/abmTwKPlMVifHgpwcTIdJX3ZdrbdsIoyK9Y TFiavDvrhKhURU5gXceFnhHcOdXtA1j4VZ+C4p+RzKdZ6I4SdjjKu82DeO+7YX1SVawTrYXYKgE tB4xZMDdNKfhB2Sym7qP2VJ5N3wHmv1ljPcuOb+eWBT8M3ldxeAsLI2E8qJl/9sAGmd3EaohPPt LHCj6XkU+ra6cIpXdg== X-Google-Smtp-Source: AGHT+IEtnYVZgigZSV9GOOjiw4uU0akvJHJHUr5mEW7I59L42GPOmQnzeJu25Ocod8gQri8uVU0GSg== X-Received: by 2002:a05:600c:354a:b0:434:fbcd:1382 with SMTP id 5b1f17b1804b1-4390d435cf2mr78308015e9.11.1738857461578; Thu, 06 Feb 2025 07:57:41 -0800 (PST) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390692a66esm58718075e9.0.2025.02.06.07.57.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2025 07:57:41 -0800 (PST) Date: Thu, 6 Feb 2025 16:57:39 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Shakeel Butt Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: add hierarchical effective limits for v2 Message-ID: References: <20250205222029.2979048-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="toufq4e4fjypkuvv" Content-Disposition: inline In-Reply-To: <20250205222029.2979048-1-shakeel.butt@linux.dev> X-Stat-Signature: dpyc1bon1qjpjatz917rnfr1p5dx45r4 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 350D0C000D X-Rspam-User: X-HE-Tag: 1738857462-499371 X-HE-Meta: U2FsdGVkX1/uiOfQkn/ZKrLDMptdnnSEy6NxEbzrhLEbWV46dqkHSOkONE0m/PvJBLIfCqcF4qCvs/3IVIW4/tP79nGYu2+uBhRpsknkEuvOGQLLo4PnQpSIhIL/ggmIKHJ0NzkhdrbmlG0OHuj0badoHSoxIkcKZvZm6YNURtW3zxoevacOkaP16G03rMg205St5F8iOp5cAXsAAUAGML4aMPlNTHcUaX5EHuTFHBF+jsS4j3AmOuS7N/nySAz/njjH/aRzmwZyMmxeHejP+uAVrJeOtJc/JOp8gk61e9JhVqbIFmCXe10buQAUxAlwxjH+Hx5Re39zNY9mqkzZi9EqUHgKQbt1lQ6tK2dtDoagbrrNwAAXsNy85n9dBDBXopRVMLCY3DBAAYsw5VxBsFMspm8I1CYJsaauuwiDoUZ72I2EmBm7pXlaHRZKA5k5hLTzglgfmaXqlGBNmRoBhI/olfihkazFh8dnoUqd7E8SuXmQ94ApiRzL622RX4KyJolKNhWD1WTz2EC5zRhUTP8LvtlQAyUxGD8SVZsMYcg7bNK9lBs5HQ+v4kCCo5hBK7uFqPnKbpWcxx3BXyRDJPA9uD74EXnACZpS4l2F6rOUgfSJfpShow/r70aS7U+P0GruarStfeEfJ7n7N0KeN9jjfA8Ehcm4cffyPn5CBXTapHOb9/6gHxAxVEsuljlQubPWHzpcm5NQA4QizxkK9ctcHULjZKRmd6Nk6Imq7MBuwTJTImAICmscArXb2Rt/kpvnjkjKfEi86+yJeRlBCumgCg7VcvZi23IPoGx6++Q0TWGaS0QrD49+jBSJlLD5dAM6uKoBtHagh5nUOYqSQypB3HV1rMEPq7vIALo7ZoK7AWz4h04qjlqESwjHmVKkv3oGozGpv1o11MaJC+cemAzFNPBvdF15yfwf3mj8daG5tTEXi1LxZo6fQUX2oioc9OMwwpxOPn6kjco+TrQ 3ZzbunQC U9kY+cC0bSlopihG0kR1mMaYOFZMaONvlLr9+VU80A6Wf2VFZGovEQIbVFUXCwrlSIjNwqpgMP3Fj7M8VuhrJGmVqdqpWtaDXEVtGpnBBcXPDgMRimSXoSVuu1dSOtmcfTW90zeZcLVxRAimRLHTjJk7Q58R6bvOQ/v9Mr/lHXxfE1s24r8YNwJUC9Ak717pqqcAWMDOldlY7/vh944P1ZM3SMc5scSHm/eI9RZu4IrFLSFWCIA0hWhyR6hiEs+CgeuCoK4/v0Iwn8l7ktlN1OIqtATL1jziH+y3A7nEffKfZp7IVKcXQirbjIacUJ2COfALnsbd9MsFigsFEVqF4JoaCtIsa4JPwVrpLeIcYIk4hmWKDV0O2VLZLT8Woz46xWbigTQkro1KLjvUqxyUuMGZyIdN6CWlHHS/FkeoYYaK5wAi6trxc287BpWzXPsDEOr/M6jN3fqYYTlU9ZiJXOw9mxsVwx3ZXKw7/OHdyLWERyModM8W3ZN9Cy6F7Zd7ecM0W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --toufq4e4fjypkuvv Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH] memcg: add hierarchical effective limits for v2 MIME-Version: 1.0 Hello Shakeel. On Wed, Feb 05, 2025 at 02:20:29PM -0800, Shakeel Butt wrote: > Memcg-v1 exposes hierarchical_[memory|memsw]_limit counters in its > memory.stat file which applications can use to get their effective limit > which is the minimum of limits of itself and all of its ancestors. I was fan of equal idea too [1]. The referenced series also tackles change notifications (to make this complete for apps that really want to scale based on the actual limit). I ceased to like it when I realized there can be hierarchies when the effective value cannot be effectively :) determined [2]. > This is pretty useful in environments where cgroup namespace is used > and the application does not have access to the full view of the > cgroup hierarchy. Let's expose effective limits for memcg v2 as well. Also, the case for this exposition was never strongly built. Why isn't PSI enough in your case? Thanks, Michal [1] https://lore.kernel.org/r/20240606152232.20253-1-mkoutny@suse.com [2] https://lore.kernel.org/r/7chi6d2sdhwdsfihoxqmtmi4lduea3dsgc7xorvonugkm4qz2j@gehs4slutmtg --toufq4e4fjypkuvv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ6Tb8AAKCRAt3Wney77B SV0+AQDW1xJCBatKi6xRC0ZESDInrTI1kQ6qqN9CO6w5z8FpQgEA1zRlG0NxFEN7 nUgSeD9K4yF5HvSYXGo3jlGZRYaPPAc= =wGHN -----END PGP SIGNATURE----- --toufq4e4fjypkuvv--