From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A697C02183 for ; Wed, 15 Jan 2025 16:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2248280003; Wed, 15 Jan 2025 11:07:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD22C280002; Wed, 15 Jan 2025 11:07:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B72D8280003; Wed, 15 Jan 2025 11:07:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 973E9280002 for ; Wed, 15 Jan 2025 11:07:41 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1C60B1C8C05 for ; Wed, 15 Jan 2025 16:07:41 +0000 (UTC) X-FDA: 83010166722.21.F3C6D66 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id C95F6140024 for ; Wed, 15 Jan 2025 16:07:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qh43N2B+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vpDzlYZU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qh43N2B+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vpDzlYZU; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736957259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x+7SqcHnnkzJcwDMjnUMrGebzaj+4kMmmW5nLwPqTxg=; b=hfqCra6q4qO1VFBQRt7jUreZRykETU64oroY4vyKsqZyvs2EmfMmbXSkWJIoH3QcAZu2yz FPQJi1qFcrFB+svdkYnBbTdvL4yMeduPJ43iAzK2mjmMlod8fmGSKVGRqUdljhdbRnenSb v2WK1bZlwu1Fv8ckRvLiR9572d75AGo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736957259; a=rsa-sha256; cv=none; b=KD1rray2ls1zU7Zs76czsW29ywLCceCMp0f8zObQ4sRW48QH7cq7mcFbAOFA6605z0hTLC pTJKrcus5yicESFbLfIBwSggf3WieLs5JDKmkASCLKJ0yb3qdBufx2faNPPDojJNHyH/Fs 1df4BjZD4KzUieZxItV/Rh64mrLHh3c= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qh43N2B+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vpDzlYZU; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Qh43N2B+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vpDzlYZU; spf=pass (imf23.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4DEC721216; Wed, 15 Jan 2025 16:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736957257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x+7SqcHnnkzJcwDMjnUMrGebzaj+4kMmmW5nLwPqTxg=; b=Qh43N2B+FVnV9W+NicTCuj3zofO9v3qIeKDX+sYkuElJVk3sZRFVI2cUML86CsrFllI3z4 GqX7kAQehkuJbaDm4UJeUNvLwk/ubsALj1Hr0vrH7eFrm3d2AVtVNBWbruioaY+Jqf2XS8 mE3HSsyz8HLhCrwFiYHY/6SasCskRUA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736957257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x+7SqcHnnkzJcwDMjnUMrGebzaj+4kMmmW5nLwPqTxg=; b=vpDzlYZUVS2TAbRsXbyBXz2EnK9sgI5sCeE79awpWbospp9tULDEGNqaJZfXlvi6wC3XMP I2zQ8j/3PL72h9DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736957257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x+7SqcHnnkzJcwDMjnUMrGebzaj+4kMmmW5nLwPqTxg=; b=Qh43N2B+FVnV9W+NicTCuj3zofO9v3qIeKDX+sYkuElJVk3sZRFVI2cUML86CsrFllI3z4 GqX7kAQehkuJbaDm4UJeUNvLwk/ubsALj1Hr0vrH7eFrm3d2AVtVNBWbruioaY+Jqf2XS8 mE3HSsyz8HLhCrwFiYHY/6SasCskRUA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736957257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x+7SqcHnnkzJcwDMjnUMrGebzaj+4kMmmW5nLwPqTxg=; b=vpDzlYZUVS2TAbRsXbyBXz2EnK9sgI5sCeE79awpWbospp9tULDEGNqaJZfXlvi6wC3XMP I2zQ8j/3PL72h9DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 40A5B139CB; Wed, 15 Jan 2025 16:07:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sDy/D0ndh2f7FQAAD6G6ig (envelope-from ); Wed, 15 Jan 2025 16:07:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id D8419A08E2; Wed, 15 Jan 2025 17:07:36 +0100 (CET) Date: Wed, 15 Jan 2025 17:07:36 +0100 From: Jan Kara To: Guenter Roeck Cc: Jan Kara , Jim Zhao , akpm@linux-foundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/page-writeback: Consolidate wb_thresh bumping logic into __wb_calc_thresh Message-ID: References: <20241121100539.605818-1-jimzhao.ai@gmail.com> <64a44636-16ec-4a10-aeb6-e327b7f989c2@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64a44636-16ec-4a10-aeb6-e327b7f989c2@roeck-us.net> X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C95F6140024 X-Stat-Signature: snrta11bj3uz5hhwcgpwcgj5imijm7ne X-Rspam-User: X-HE-Tag: 1736957258-662489 X-HE-Meta: U2FsdGVkX19qBZl682qsSzq9xsCEJJyKFNQziXB+UeismScO6cY1gI+HbWP4frFIGLCYcWeFmtFdNjWeoNBRJSJkEP1P9/jnsx7s6eTua1p9vBVm9ld5dqNSmXf3z3b4epoe7bHhTQcWLcHQsfrhs7/B39ypU3WX4KHv5jjly2COjmp3uxbXI8PpRgq4KB4x6Hr0nOXB7l/N1TKx3q5OUDTxufoGIdsZGyFfjoKVnpODHGAO0UOlfUV0tdMqp7aSPlwdJdggx6RmzFNJijarY9VEAqayXaSfjxsTEQmDHPQzs9VkNp4uhH13i0kWMnJqar2x2+ng0TEalqgEAKrxVpe99NtTec1yP/EfOuSUQwhIvHQy5TmhPy2ZQpHJO+7jg32LQGjRbiExf6u4aQnyd+Ej1XWk6OfAY2ksPx6Wq5jWsaEDxASdvg1E7sQ0piuD/A+YSLntcSuIDTu7136PmMMQcJ4uFAn84quFT/LGg43/WRcer9lLC8QLqV99wJ/M4Iklv4w2JO8d+JLVfpd9uK0MLyKr4bQw7IrW69IfeykjTqVeAZ6avmm+qSDQ5zDi0stHfpVwW1+sI5sFtJeBg8lmWJvBoAFPaw6BcpnLtp7UeYm0og263NZAcdLwrTMX57pTydW/FZshxrJLSs6gECXDG0OB8P7/oNwa4aVBo+ixTbT/hR26SFmPEDt21Yw88HmXGmb5P5nRg0MBclEf3knmuRu6zNnwbH9+y2LVsA6chfTehfstzBBaMp1Bm5aIebCziM5nEgztHHzHmRkOpaoPMtfoeKNhvR+/vAopNvd80ijKbiNTX1O56yhoWgWfW7Ep4v0MvZIrZITBDw4HstJN9RYSx5XbBgkpjOEMGN5DDf29Rw08zfdf41BC7NWYbtSHH+jPL42AOp3SeRyWgjSiikApDPq08Jn3ptLtkdZVAZ4biA+Bjy7ZlHbV3sHxHr/2rLKivKuJUXSqqO3 ImuV+yxm FH6hU7yZCu3KIQypf/+LSagnUZcxAzz+NiUyVkDgCUP/clDeKZRNL8PeZb/8bDdFSk/G4EY1b4GfNelFYILrOMOzz1rJYP8XVbezWinqt6dr6eeEGi6vM8xijIOphzkzrrnZBJa85nYPKW6z6U4vd9gPheUhYLBM/FuIhEKojib2dwZ+ikJF3GxennozMD1T6xrCVOH6uzxEi6DzLx5msr+gwxGVisH3Fyezse/iUFxvv5nAOTCQcGQWecPRQijqBmVsXLHtQLk6MWl85mgD8UaCYPP33N9TGPgZ38xgbHD/zSyv01U8v4VV9pT9gA2GAefBTIhVCIwWbDufsbUcVuNkhygagWI1iLVkx0rlWdDkySvwOqYt4y7/x0dVDqKrM/7LKmcEpARB9Pc9mHoz2HMdHPu3aSs3AhjeCYeG3KWDLJOld9fwZLOEEYkCEAV3t89dMJbgOwxxH8/r2vmhL7dzN4Rkikrw8h4dWmVKcZX62Sk/EzEn+y5WGnHfmD+all3UO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 14-01-25 07:01:08, Guenter Roeck wrote: > On 1/14/25 05:19, Jan Kara wrote: > > On Mon 13-01-25 15:05:25, Guenter Roeck wrote: > > > On Thu, Nov 21, 2024 at 06:05:39PM +0800, Jim Zhao wrote: > > > > Address the feedback from "mm/page-writeback: raise wb_thresh to prevent > > > > write blocking with strictlimit"(39ac99852fca98ca44d52716d792dfaf24981f53). > > > > The wb_thresh bumping logic is scattered across wb_position_ratio, > > > > __wb_calc_thresh, and wb_update_dirty_ratelimit. For consistency, > > > > consolidate all wb_thresh bumping logic into __wb_calc_thresh. > > > > > > > > Reviewed-by: Jan Kara > > > > Signed-off-by: Jim Zhao > > > > > > This patch triggers a boot failure with one of my 'sheb' boot tests. > > > It is seen when trying to boot from flash (mtd). The log says > > > > > > ... > > > Starting network: 8139cp 0000:00:02.0 eth0: link down > > > udhcpc: started, v1.33.0 > > > EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 > > > udhcpc: sending discover > > > udhcpc: sending discover > > > udhcpc: sending discover > > > EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 > > > > Thanks for report! Uh, I have to say I'm very confused by this. It is clear > > than when ext2 detects the directory corruption (we fail checking directory > > inode 363 which is likely /etc/init.d/), the boot fails in interesting > > ways. What is unclear is how the commit can possibly cause ext2 directory > > corruption. If you didn't verify reverting the commit fixes the issue, I'd > > be suspecting bad bisection but that obviously isn't the case :-) > > > > Ext2 is storing directory data in the page cache so at least it uses the > > subsystem which the patch impacts but how writeback throttling can cause > > ext2 directory corruption is beyond me. BTW, do you recreate the root > > filesystem before each boot? How exactly? > > I use pre-built root file systems. For sheb, they are at > https://github.com/groeck/linux-build-test/tree/master/rootfs/sheb Thanks. So the problematic directory is /usr/share/udhcpc/ where we read apparently bogus metadata at the beginning of that directory. > I don't think this is related to ext2 itself. Booting an ext2 image from > ata/ide drive works. Interesting this is specific to mtd. I'll read the patch carefully again if something rings a bell. Honza -- Jan Kara SUSE Labs, CR