Re: [PATCH] xarray: port tests to kunit

["Liam R. Howlett" <Liam.Howlett@oracle.com>]

* Geert Uytterhoeven <geert@linux-m68k.org> [250130 03:21]:
> Hi Liam,
> 
> On Wed, 29 Jan 2025 at 23:26, Liam R. Howlett <Liam.Howlett@oracle.com> wrote:
> > I've never used the kunit testing of xarray and have used the userspace
> > testing instead, so I can't speak to the obscure invocation as both
> > commands seem insanely long and obscure to me.
> 
> The long and obscure command line is a red herring: a simple
> "modprobe test_xarray" is all it takes...

That command worked before too...

> 
> > You should look at the userspace testing (that this broke) as it has
> > been really useful in certain scenarios.
> 
> BTW, how do I even build tools/testing/radix-tree?
> "make tools/help" doesn't show the radix-tree test.
> "make tools/all" doesn't seem to try to build it.
> Same for "make kselftest-all".

make

Or look at the make file and stop guessing.  Considering how difficult
it is to get m68k to build, you should probably know how to read a
makefile.

> When trying the above, and ignoring failures due to missing packages
> on my host:
>   - there are several weird build errors,
>   - this doesn't play well with O=,
>   - lots of scary warnings when building for 32-bit,
>   - ...
> 
> At least the kunit tests build (and run[1] ;-) most of the time...

Do they?  How about you break something in xarray and then try to boot
the kunit, or try to boot to load that module.


This exchange is a good argument against doing any kunit work on my
tests.

> 
> [1] test_xarray started failing on m68k recently
>     https://lore.kernel.org/all/CAMuHMdU_bfadUO=0OZ=AoQ9EAmQPA4wsLCBqohXR+QCeCKRn4A@mail.gmail.com/
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds