From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 028CACDDE6F for ; Wed, 23 Oct 2024 11:22:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81C696B0088; Wed, 23 Oct 2024 07:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CC076B0089; Wed, 23 Oct 2024 07:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66CA86B008A; Wed, 23 Oct 2024 07:22:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 441726B0088 for ; Wed, 23 Oct 2024 07:22:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 619AAC09A3 for ; Wed, 23 Oct 2024 11:22:15 +0000 (UTC) X-FDA: 82704628314.27.EDAB400 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by imf13.hostedemail.com (Postfix) with ESMTP id 481622000F for ; Wed, 23 Oct 2024 11:22:14 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="Q jOAujD"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=NzPlBx9Q; spf=pass (imf13.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.151 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729682500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DyXy1uENe8BhOOL8uZDqsDDMDgXhYxR835mX6crlWnk=; b=SpGwykynqxBRU0jYimb1XPc+n7ZBatTSJOGU6eEgljGADfuAKMSY2pQBk4KedB5vbJ8Pk+ pS3pXOlp5tgDW83MEpM23htOiEcb73ZijGq3t2zjsEeNlB4Q+GLJGZ/l12ZwIShvRjaGRy sKz/Vcmit0jNsyxw+UBmtEkEjAGc1Q8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm1 header.b="Q jOAujD"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=NzPlBx9Q; spf=pass (imf13.hostedemail.com: domain of kirill@shutemov.name designates 103.168.172.151 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729682500; a=rsa-sha256; cv=none; b=JlC8J4ROMRuhIz2VP4tzGFuQaaaW8VK2lHazUwB+Msmg+qCA7N1kOUyby89Qpj7XTxX/Hy BYpnWU/RJ7/Qchv+pSbRQrtMqBspgiWqv8FEoyWYD2Y/seKmMcFdj2kAS6BkFY5wfPa/8G 9o3zfDlTwF5shFglNqtXcargewVtGiI= Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 5C5FD1380796; Wed, 23 Oct 2024 07:22:31 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Wed, 23 Oct 2024 07:22:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1729682551; x= 1729768951; bh=DyXy1uENe8BhOOL8uZDqsDDMDgXhYxR835mX6crlWnk=; b=Q jOAujDHOrZyThdD8qapTLfnoT46h9P5A9bvEdGTqPv32KYANtGHAkT1qPWAfxOAx Frv5Vql5inxQF2NNw1gMMOcHh5/RwBcRIQdNof6fOvsr2a2nt2UCFghqAFirOCO6 jOCmtSygMpBfMMxdj89reZgLo3e23g8r4qSUCaKXRz2waQs0xxM8XBZ5OqsvGa4G mPCg07WW6JlyhDuo7SmNT+B7mdrS92H/xevUhSaaxyj6YJGWFwXJtpX5KDHXsYvZ 4aLydJxmJ7i4/1apAe77AtF62+8oPKGJQu3uCXInQAYWECSYFb7CaDpYpegTui3p hXU/PRfYwHKm5rbiNc1cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729682551; x=1729768951; bh=DyXy1uENe8BhOOL8uZDqsDDMDgXh YxR835mX6crlWnk=; b=NzPlBx9QSepyGtxjwwTsbYWrJ5BrU1l3MkLrNLqVmN+O xWQT8H3LK2IYFFMM1SgSSZn5h7BE5BZLIUbZ/wDO5VNWfW8939Nj694C7Cgtv21+ +87rG/z0LM534IOHX3aWtucylKyzoISJVKrkrftpCabE7zCcN0pIj68OPkmSGxiY oCdYDmYrJ94SWejDb9ZZ9N5FD7QeNOjlfCr0kCuODY0iF6nyQtNzAG3RcMQHYG8Q SXEHgHIvjWVqDVsF8+N6gzuEgcxuzh4+gWnamp1vh1/Ht1N/3Hd7zxFjnlCMaArx Wrl3RUTVX7ibbQQeK4FaeJ6tTeHqKDNLc53VOa85hg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeijedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtsfdttddtvden ucfhrhhomhepfdfmihhrihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlse hshhhuthgvmhhovhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeffvdevueetudfhhfff veelhfetfeevveekleevjeduudevvdduvdelteduvefhkeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhv rdhnrghmvgdpnhgspghrtghpthhtohepudekpdhmohguvgepshhmthhpohhuthdprhgtph htthhopegurghvihgusehrvgguhhgrthdrtghomhdprhgtphhtthhopehlihhnuhigqdhk vghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhigqd hmmheskhhvrggtkhdrohhrghdprhgtphhtthhopegtghhrohhuphhssehvghgvrhdrkhgv rhhnvghlrdhorhhgpdhrtghpthhtohepgiekieeskhgvrhhnvghlrdhorhhgpdhrtghpth htoheplhhinhhugidqfhhsuggvvhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgt phhtthhopegrkhhpmheslhhinhhugidqfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpth htohepfihilhhlhiesihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehtjheskhgv rhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Oct 2024 07:22:24 -0400 (EDT) Date: Wed, 23 Oct 2024 14:22:20 +0300 From: "Kirill A. Shutemov" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Tejun Heo , Zefan Li , Johannes Weiner , Michal =?utf-8?Q?Koutn=C3=BD?= , Jonathan Corbet , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH v1 03/17] mm/rmap: use folio_large_nr_pages() in add/remove functions Message-ID: References: <20240829165627.2256514-1-david@redhat.com> <20240829165627.2256514-4-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240829165627.2256514-4-david@redhat.com> X-Rspam-User: X-Stat-Signature: 1hdd6ojzxp8s6kbteuhj6yeo95i4hd7y X-Rspamd-Queue-Id: 481622000F X-Rspamd-Server: rspam11 X-HE-Tag: 1729682534-626840 X-HE-Meta: U2FsdGVkX1/6EzyMGjVK+XHLiHZ2oDgIacJu0opZibp+Asjln2NPFloBfEdUC/mrcpI7MitPIvnOCMuORCTiIxZlA0MlCyNCOk5LyyxtA8Ob7h01U/fGAZfMMDB3ZR/wOcbPCQ7tsiD6YV0CZVWrUY6Z0tjUOnDfuOLdOcq7krLYEw0DaObODDZcmzf1tEip+pD4ehmAjGPrnjk9LQ7XNjTBOKnekFMuXyA30Uf/SQthpDr7yMwHTuP+AuV8xxwn+c+xYK+NzAYlp1bAIvLs41jcezRjCMfzHRMJO/QGPMsdtZ1kk8hJc0OF9CH1fJ0yTArPXqrRFBTEKBRhjbLlYIUpMlCApacGJvT8Lqs8lONPrvTEuCa48L4Bed4cC/aD5dXcsEmUrTo+tSBp4ebqlmk4LHWPv8EXkWycpBzA2p5S1zMmP8qRKT+kod4nrWOOotb6Dz0TnZwF36CQ85b3KbI50aIcSS8u0dlqBGmZfZ9ihz/49IVgeE9sSkPMS9hgsqEVAt+fcVFkALlOeaGtgwMIyzD9XkwtOFMHibShxei6NbH5lL6HvFpi3EnmuxqRRCkjDK0uORCRE4nbeIxHgK6CBt8aueqsMfHf1AcsghlHv7K/y7ibaDB9+Bk9AV9yU1m9V0pLHvv3pqIJK7s4XAzNAtH46/B2TeMrvO6gXTqN0LeB2cLe29k2kbh6CMbGurJZVHT+Qb5uhlXntMnUziDzMX+vdKT5GD0oPkRrldD8xwGwx1IoYjgUyn90V+lkvf1kW3EWRHItW66yIERxOF20lvagF9VE6kuZ6pxV911K8b3hN07yqW7razG2URdhtECQMqVs4IQ+vaN+cMCTFcdgDqV5rf5Vhb1lO0BiMa0mNNAUiBPvQvS2KSaQ7Yjmjnz2NUh8IAqp4UZB6RFVQw8O8NqnNVNLPYFIUP5hsIQI0WSNhVAp2BiVUDcQwgPZYErOt/qqA7YNquIW+oo Q4XR0s7w +4dNSFTQoqjGeQI9iAmFyr2xWIsLAKTOKOPLZdqvCGGlYeiD7rNDTXGURHLv/8mo0xMx31NqtbPEGTj99181RpLEWSYJAr5cx3bEpAB4Ys+OY4NcJOnu7R9XgulxFYBdgaR/Mo8IqN7CvPSFneJ58VM3KaNFsPdRR1tgm3BCpa2VadelAg8bNf+oRHS5RtppnPvwZEpUr8rSHZk0e1V8Ro6EXTUkO7Xs8CpwE2p9K4jgbwnSDHteod9BW1rrf/SjQLY1l1sPNIDW+SksPwN3BIyR9MjOKlnAD5oYGrtfQX4RePNe7Ttt0Yu9dSth0vY47LKMa4pbNT/yySmvgc/z2vbxyjxKcmkF6VYMGmN7OQDa5wc/hMuZOh1TK18pBfNRi7hxTuGqx7zxODP+/yflZt9zZ32eDJ72uHydTnBP5s5edUS6AYul9DXbCnxAERihAhVjClLwgKZSXspI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 06:56:06PM +0200, David Hildenbrand wrote: > Let's just use the "large" variant in code where we are sure that we > have a large folio in our hands: this way we are sure that we don't > perform any unnecessary "large" checks. > > While at it, convert the VM_BUG_ON_VMA to a VM_WARN_ON_ONCE. > > Signed-off-by: David Hildenbrand Reviewed-by: Kirill A. Shutemov -- Kiryl Shutsemau / Kirill A. Shutemov