From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE204CA0FEF for ; Fri, 30 Aug 2024 13:08:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39A406B0146; Fri, 30 Aug 2024 09:08:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34A606B0147; Fri, 30 Aug 2024 09:08:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2133B6B0148; Fri, 30 Aug 2024 09:08:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0513F6B0146 for ; Fri, 30 Aug 2024 09:08:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ABA9EA18C7 for ; Fri, 30 Aug 2024 13:08:55 +0000 (UTC) X-FDA: 82508941830.12.D88A680 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf10.hostedemail.com (Postfix) with ESMTP id B1A60C001F for ; Fri, 30 Aug 2024 13:08:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="i/rbPlxk"; spf=pass (imf10.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725023287; a=rsa-sha256; cv=none; b=HDThLQNc2kqc8v2TC98afK4OEk+sWutSu2hCEQ5kf+iZeW1S3fNj6XRfxC9cjw4eyOl92r +17QHnoAfyC2VXLfHnaYso+tmvHQBpPulnZFm36BD+NLp82JfejXAjUHzrXznORLUMa2x0 egSRpJTiSAFp4HWKRLibcO0fJuAegTc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="i/rbPlxk"; spf=pass (imf10.hostedemail.com: domain of pedro.falcato@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=pedro.falcato@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725023287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7WQyzbmRu68QU8VeltZmjYN8+8Au5DAuISTtQwEMld8=; b=bX8te2qCRM9ch2FNPUfHpLDrSBqOrcnuasiVlaG0qD9Co7r13NG8dCyL/z7AwsV+kaVz4x y2YTKrll7xblhLgiN7DDNAsyQn3u4LxodVyzZQh5Copi1qpdOFdQhb6ZkiM41/bqnfiS7u YxLvfS1+qUie+5bfm6TjK5gV/sSadWM= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3718b5e9c4fso1063009f8f.0 for ; Fri, 30 Aug 2024 06:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725023331; x=1725628131; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7WQyzbmRu68QU8VeltZmjYN8+8Au5DAuISTtQwEMld8=; b=i/rbPlxk1/sPY9Cqqa8yCn/WikfCozwaH0Jmn2sZ2E5nzamNWEnjhpd0bg72VJ5fuU XJwq2b2RiabpNDyhHwecWX1eK9cbYoQBoGq5X8gx8QbckHqu7B2u2EWDhHQteOBVLFXh hMSCqzV38gg6V88MqGnVBuE12/xr/pXbgQ5EjUFUtCsF8xqFGrCqfOpjC5YONLfzdopR XTCiIrXWontLqiRM3KTPZHRn8Hn6+nt9WoWM4w1J5gcVckL6LsEXknfKM8PJc6QBYN5t dYUiNQEs71M+2zfGGMaulHuZ7SvAM6Tsg54l5aO/VVxqVqyhClzNwcIak7oAx1MF9v3g MukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725023331; x=1725628131; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7WQyzbmRu68QU8VeltZmjYN8+8Au5DAuISTtQwEMld8=; b=i+8lqefowhkChJn58gp9AIg2fv9X+kCy70V4lyIYYmrd8vGV+mjjj4DxOKmBbHyu/j oYwYYzgB459pLU6Mvx4Cc0ALzeKssBMrSeXiD1EBO/h/Kp+J3+zDyC3PKgG0CSioaIvf nVs+CWRgYYN4mgE3+zh/n7D0O/R5zph5SAxYRsV7oMk/T0BCZuA5++5N03y/KKtvSCVY nUIXRiDwdFhFnhqhRjm12cU5fkXHBey5g/s4UDcljIZJThn+UWOC3019KHPvFg2CXjVA /XW2bY5kNhjxAlj0a0bX1MMX3Lx3oOo56us5SQU/BL8c3cTKR9oe3YFF362L5tBNax3T +fJA== X-Forwarded-Encrypted: i=1; AJvYcCVZY8bVcxHjox5k8dSfU34jiG29oqQC5/i+bfVLVNndsoOLtKGGjbCtWawem64gcTlyCjzkDK+7ew==@kvack.org X-Gm-Message-State: AOJu0Yz9fJH//Qe/BmbnoMom+lsJc28HnnnksN8pmNh29bKxf2odQs+X IR1XNHoP1DCSwdxrFu5F6liu7jBI7K+V4l3STgiDr+zyogHhxX75 X-Google-Smtp-Source: AGHT+IFGvkOe7LLFPdmBxoGL8SUp4mb+v+Ykw5Sc8e/WPr3w7zE/65PgxqrXHQgpN9FpIHcZLmz3QA== X-Received: by 2002:a05:6000:c05:b0:367:8a2f:a6dc with SMTP id ffacd0b85a97d-3749b57c610mr4016930f8f.44.1725023330482; Fri, 30 Aug 2024 06:08:50 -0700 (PDT) Received: from PC-PEDRO-ARCH ([2001:8a0:7862:ea00:1d36:5f53:3f57:14ad]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee4abbesm3973840f8f.23.2024.08.30.06.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 06:08:50 -0700 (PDT) Date: Fri, 30 Aug 2024 14:08:47 +0100 From: Pedro Falcato To: Andrew Morton Cc: mm-commits@vger.kernel.org, vbabka@suse.cz, torvalds@linux-foundation.org, shuah@kernel.org, mpe@ellerman.id.au, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, kees@kernel.org, jeffxu@chromium.org, linux-mm@kvack.org Subject: Re: + selftests-mm-add-more-mseal-traversal-tests-fix.patch added to mm-unstable branch Message-ID: References: <20240821020807.755BFC4AF17@smtp.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240821020807.755BFC4AF17@smtp.kernel.org> X-Stat-Signature: a6yd7n1gu7q61oeg1skqmqm6jn17kj1a X-Rspamd-Queue-Id: B1A60C001F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725023332-869847 X-HE-Meta: U2FsdGVkX1/eXahlbuxyTfh2jcymLAeDlg0+rLyofV/rBwCjHHcDvDH0+br1ae1lBVaW4jHaYNfKu8nRJMJ9fnXhDhw7lijIOaUCPuyQqjqUsEcnggeIztsvYJ4AcsWSzI6TvGlewRPQIOcup60r8eskCq5GNtRhqvPjwoyWGZxJ9Sk4OSQq7cD53NBd0TLWNBdqK+85vI2VkBXlwC2IBA/cOdcW8y+T8bK8i8nNfjuBc8bi7T6t+1F+qswTJk7JU2j1hS4/4+12mLFzrhtBqBM1x3s8DVfVNwLn6FTTnfGggS70Z3ZWbGQJH1jIN1Or+heSb3kG6vK6Bf1uWC7pTdIrOBM1lI3s+aOR3/qzx3eiYc+guAdewhoXJvSEr+Kde0j/1CbKfFwCCc1Q1joELyf98mXpDpSELsmRxaAUjcztgUGSjYdcg7WB/5fzu8cJ1s8EY0l4BrFWve6nhdPviS1pXhF0KjpB1Oj54Fj7Bt9XlgskLdIEnRGujjSKjyCcfBY4LTJQdrsc1wB51VBE/aRScHfIZkmm4Mne0lm1SscCQ/nZeHzjN//bkeYcWfqEOE5/j1iiSSzoFnfV3oX7Ag4b53ORLFTMbXkRUqDTnGggkWS15mnSp1kJIrhQHnv+zn9gBRyBi/LEC3kNEr7k8heZAXG1mH6ccHp8qRhFbfzeJoYXNUQGKJ0juFxh6biq6S642NB8XUCxmWPR6Z3k3xGg48kreezeODMobSSKSU9TO5JyaLujJon618anNvZhYHkl43UY62LBIcri7xgRpA8L3ayU+znL9/qt6rkbhURPzGDfwdscO9q03iiEWnWlRxC610DlmF1OQPCCuZIIcS6G4BQZyFfpp4kxEgXzi8ZK8LdiKBXV7/KrUhqzlQ6tQNNGZvCiP4NoYgL0L5Y3zSP3pNBTHec6uvwTclY63lFvpyyQSRmOQ/epxmHgzc1btr9AN9qT+AkaIFA4F+H b9OOObCt 2zwv6JEGPbUC75tJ6Ixdhny9iP64N4NgzxsAk3PZ9nU0I4YUBoONRRamT2qUM2hedQQEI8dh7DTiHSo5SVSmYiQrz8c81VjQNFMRVoLTWx5V5h3FeL2VvCEAsBFNCrIQ8yDcRSdD/8mvUgtnZqHJoiWsqL+LQTcMPjHVBKxwjVyCHfxlHY6JS0s+oU8AaIDOEs00dKCDqZf3/y/5Tj3QJfEkr4t8/KD0Ll1cd3TCp/aXCZIjaSg5Qb5NghfnUY6Vyd8dFq6KEpCv3K2nN89ETwPKNPho3N0oWR4Wwl09SToGQmElxWxlaJSlGA9Fb1TQPmyNhxNWw1HNNQiTf+AwZbmG7CzettQB6yh7AvXAQ8zZQzt2qCKHhTsOSLjBcqRq3EtXJNvRO173aPAtZ/pTbWBh1gVgsndiIHdxRidQc0I9gTmPMekjkfo2+Tu7wSgcqx9i5w22V7zKZOEXvSIsSlHDJvileV4uvBfwrtpHskYcmgpG9Z7MB+xHVG8qInDwke4caC4TWNHzV4T8Y3vml15FsMkD4e7fmcpoAIna8hoDse9quR+QEMwyFS92t7vZghtTb0j8sMUfQFzU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 20, 2024 at 07:08:06PM GMT, Andrew Morton wrote: > > The patch titled > Subject: selftests-mm-add-more-mseal-traversal-tests-fix > has been added to the -mm mm-unstable branch. Its filename is > selftests-mm-add-more-mseal-traversal-tests-fix.patch > > This patch will shortly appear at > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/selftests-mm-add-more-mseal-traversal-tests-fix.patch > > This patch will later appear in the mm-unstable branch at > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** > > The -mm tree is included into linux-next via the mm-everything > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > and is updated there every 2-3 working days > > ------------------------------------------------------ > From: Andrew Morton > Subject: selftests-mm-add-more-mseal-traversal-tests-fix > Date: Tue Aug 20 06:51:01 PM PDT 2024 > > remove incorrect comment, per review > > Cc: Liam R. Howlett > Cc: Pedro Falcato > Cc: Jeff Xu > Cc: Kees Cook > Cc: Linus Torvalds > Cc: Lorenzo Stoakes > Cc: Michael Ellerman > Cc: Shuah Khan > Cc: Vlastimil Babka > Signed-off-by: Andrew Morton > --- > > tools/testing/selftests/mm/mseal_test.c | 5 ----- > 1 file changed, 5 deletions(-) > > --- a/tools/testing/selftests/mm/mseal_test.c~selftests-mm-add-more-mseal-traversal-tests-fix > +++ a/tools/testing/selftests/mm/mseal_test.c > @@ -774,11 +774,6 @@ static void test_seal_mprotect_partial_m > int ret; > int prot; > > - /* > - * Check if a partial mseal (that results in two vmas) works correctly. > - * It might mprotect the first, but it'll never touch the second (msealed) vma. > - */ > - > setup_single_address(size, &ptr); > FAIL_TEST_IF_FALSE(ptr != (void *)-1); Hi Andrew, I was looking at Jeff's patches and noticed you deleted the wrong comment here. Can you please replace this patch's diff with something similar to: ----8<---- diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c index 0c41513219ae..01675c412b2a 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -1027,11 +1027,6 @@ static void test_seal_munmap_partial_across_vmas(bool seal) int ret; int prot; - /* - * Check if a partial mseal (that results in two vmas) works correctly. - * It might unmap the first, but it'll never unmap the second (msealed) vma. - */ - setup_single_address(size, &ptr); FAIL_TEST_IF_FALSE(ptr != (void *)-1); ----8<---- Thanks! -- Pedro