Re: + selftests-mm-add-more-mseal-traversal-tests-fix.patch added to mm-unstable branch

Re: + selftests-mm-add-more-mseal-traversal-tests-fix.patch added to mm-unstable branch

[Pedro Falcato]

On Tue, Aug 20, 2024 at 07:08:06PM GMT, Andrew Morton wrote:
> 
> The patch titled
>      Subject: selftests-mm-add-more-mseal-traversal-tests-fix
> has been added to the -mm mm-unstable branch.  Its filename is
>      selftests-mm-add-more-mseal-traversal-tests-fix.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/selftests-mm-add-more-mseal-traversal-tests-fix.patch
> 
> This patch will later appear in the mm-unstable branch at
>     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next via the mm-everything
> branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> and is updated there every 2-3 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: selftests-mm-add-more-mseal-traversal-tests-fix
> Date: Tue Aug 20 06:51:01 PM PDT 2024
> 
> remove incorrect comment, per review
> 
> Cc: Liam R. Howlett <Liam.Howlett@Oracle.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Jeff Xu <jeffxu@chromium.org>
> Cc: Kees Cook <kees@kernel.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  tools/testing/selftests/mm/mseal_test.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> --- a/tools/testing/selftests/mm/mseal_test.c~selftests-mm-add-more-mseal-traversal-tests-fix
> +++ a/tools/testing/selftests/mm/mseal_test.c
> @@ -774,11 +774,6 @@ static void test_seal_mprotect_partial_m
>  	int ret;
>  	int prot;
>  
> -	/*
> -	 * Check if a partial mseal (that results in two vmas) works correctly.
> -	 * It might mprotect the first, but it'll never touch the second (msealed) vma.
> -	 */
> -
>  	setup_single_address(size, &ptr);
>  	FAIL_TEST_IF_FALSE(ptr != (void *)-1);

Hi Andrew,

I was looking at Jeff's patches and noticed you deleted the wrong comment here. Can you
please replace this patch's diff with something similar to:

----8<----
diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selftests/mm/mseal_test.c
index 0c41513219ae..01675c412b2a 100644
--- a/tools/testing/selftests/mm/mseal_test.c
+++ b/tools/testing/selftests/mm/mseal_test.c
@@ -1027,11 +1027,6 @@ static void test_seal_munmap_partial_across_vmas(bool seal)
        int ret;
        int prot;

-       /*
-        * Check if a partial mseal (that results in two vmas) works correctly.
-        * It might unmap the first, but it'll never unmap the second (msealed) vma.
-        */
-
        setup_single_address(size, &ptr);
        FAIL_TEST_IF_FALSE(ptr != (void *)-1);

----8<----

Thanks!

-- 
Pedro