From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70BAEC54798 for ; Tue, 27 Feb 2024 17:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE7C36B015E; Tue, 27 Feb 2024 12:10:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E951D6B015F; Tue, 27 Feb 2024 12:10:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5BEA6B0160; Tue, 27 Feb 2024 12:10:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C686C6B015E for ; Tue, 27 Feb 2024 12:10:07 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7C6A340551 for ; Tue, 27 Feb 2024 17:10:07 +0000 (UTC) X-FDA: 81838221654.26.65034AC Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by imf24.hostedemail.com (Postfix) with ESMTP id CBFAD180008 for ; Tue, 27 Feb 2024 17:10:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="Bp8e/1d+"; spf=pass (imf24.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709053806; a=rsa-sha256; cv=none; b=DkA8VfzKHizjHeKSNGKc+6JvCvQirGvdYFF04K0RNMgk3oyvcfSeYdO3QnppoaA7IS+Tuf gwaBogvaOM9O2S00TqePr9NHeccXgCWTTEi2Kxvv3DZ70cBaqfm+D1YW77ChCozeLummOR w97TcugC/mrC5QRU6JTfrwrjYoe3V2I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b="Bp8e/1d+"; spf=pass (imf24.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.172 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709053806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L3rbyqVBPDOPP9EM6vMSpLtzZtbMxF8srL9v40G0eMw=; b=hTuejt+3fYqnQZ58gDl54pe+GToepB0p9DzdF4QRPW0C5tCPQPeKynl2yZxoqJqU9RI9r5 /96QwaytrSYCkxPzjVWeTJ9VKAWwYs/7BngjS4bzZy2RUADsz1ajf0RbYMQ6uATFEtwQFl Y0SfU+5MhgRfpPw6nkrVJhQPWEbZgBw= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4TkkWF4lXLz9stn; Tue, 27 Feb 2024 18:10:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1709053801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3rbyqVBPDOPP9EM6vMSpLtzZtbMxF8srL9v40G0eMw=; b=Bp8e/1d+0s6eBqZSdp+nDUYyWX1I3kndK4tVYRukCkdA303SiPrLBul3QkDt5kyngCAxCH CclK+qmQimTSdZ37SJNF9ZyYlxC93pioBZL4JBPcXSnaSjNn4wsAlRppgX5jrhwJxVS9NX rk+zeg2BZoiI5WjnQfuFp9jTA9Fdr8Fuk9FkmCwPZzIFW+auxXD6VRyLQMgnSl02jeT8oe LaWL0DWKVVRHCLtwmfY2MAoo0lGBlMy6M774uvUCrgTYrqzgVjPMSNZ53L/bAQIBVmkAem RnWbBaahhuYcPF6ChRUiqlfzXlCRTxqpmuqKCms8KauMe4oQE/CatYUOSDAc9Q== Date: Tue, 27 Feb 2024 18:09:57 +0100 From: "Pankaj Raghav (Samsung)" To: Kent Overstreet Cc: Matthew Wilcox , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, david@fromorbit.com, chandan.babu@oracle.com, akpm@linux-foundation.org, mcgrof@kernel.org, ziy@nvidia.com, hare@suse.de, djwong@kernel.org, gost.dev@samsung.com, linux-mm@kvack.org, Pankaj Raghav Subject: Re: [PATCH 03/13] filemap: align the index to mapping_min_order in the page cache Message-ID: References: <20240226094936.2677493-1-kernel@pankajraghav.com> <20240226094936.2677493-4-kernel@pankajraghav.com> <37kubwweih4zwvxzvjbhnhxunrafawdqaqggzcw6xayd6vtrfl@dllnk6n53akf> <4zpsfvy3e4hkc4avvjjr34rgo7ggpd6hpflptmiauvxwm3dpvk@5wulihwpwbyp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CBFAD180008 X-Stat-Signature: bhdkbz9dpjxuupw8s4d6mkmry3pfxntk X-Rspam-User: X-HE-Tag: 1709053805-320117 X-HE-Meta: U2FsdGVkX1/RLNqiUsU+bC2qaVQci/RbxLhxbTtRDOQ+izH9yclW4iA7Um1muDXUz7VDddu4Tg8ZOIkOxAic9DCEWx6Fw4Yi9uN4hpUF8lKlTbGACFSKWqEiPYw/M+RobwT6EnI4N+W+b3dlGKE70y502Bl95ZbLQR0saYMOPZg/kw6LJg5eA3W/oYJkQtizha9f5QpxHLNaSXw4gM/anDs5n770kzP2qvmZ/0Hor9JPUzTVJfgcalNSEF9ayhH92ctYgOOfqz2dcqlUw/df4yZQxE72NufA1hDXdHMp9SUGgLHwLMQsFeVjVk9nend2IwSNaKr6yTrnse0ZHQ5K8WAf8D3nd1bRoJzcd6MV62sYIyxKdI9BRQelBgvYNwf7Etm5EquTeFtaZqCKo1utFIZerkH7vtaWhJi+/zBLlUxdJr+HvfkGIw5c1aJ5FsKpXSvludwhKgaI/sFLFO5CfgIzqUyRQkHJMvNAlzEaKx91AQbtSwJps5+evAWn9SFIkdGEvViEgUNsIrdqeUJ4QO9UxgrVr8msS6kTknh9i0wg3Ok3Od+Gtaw3bezBPBopxS03aHwJoGofrVR6RwCaZP9R+FbCQ1uq/38P2nbXWpzbw04WYPdFCwHCO2YvaseyyXtHmBCfYZPb62IovdRQz/XT59ac40VpYxAxZXVNZpqg2Fm+XF3ySTpgVki0JK5lxLmMu2fG0H4uHB4TZY6nuaUlHzmZ69ykteHIv4XCJShkSG+MPZey1qvjt1zXo2AkG0YIt8kHnrsCvN32yxA9qfMhlGuyIWwL+CinfbPXUkC3hZ+Gf90Lg3VFO/93xV6/zL3Ir4zB5BgMgho5gsWLoe7F2DpCXMeyIBaTa1dZpPsCZDiS5/qY+LmQjbE2Ug+lJcg0dAHv7yU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > > > I have one question while I have you here. > > > > When we have this support in the page cache, do you think bcachefs can make > > use of this support to enable bs > ps in bcachefs as it already makes use > > of large folios? > > Yes, of course. > > > Do you think it is just a simple mapping_set_large_folios -> > > mapping_set_folio_min_order(.., block_size order) or it requires more > > effort? > > I think that's all that would be required. There's very little in the > way of references to PAGE_SIZE in bcachefs. Sweet. I will take a look at it once we get this upstream. -- Pankaj