From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F218C52D7F for ; Wed, 14 Aug 2024 19:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04ECC6B007B; Wed, 14 Aug 2024 15:56:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1A156B0083; Wed, 14 Aug 2024 15:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1D3C6B0085; Wed, 14 Aug 2024 15:56:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ABE846B007B for ; Wed, 14 Aug 2024 15:56:09 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2E6548105C for ; Wed, 14 Aug 2024 19:56:09 +0000 (UTC) X-FDA: 82451907258.10.4BB3FBD Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf03.hostedemail.com (Postfix) with ESMTP id A150E20034 for ; Wed, 14 Aug 2024 19:56:04 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="H/jdf7q7"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=WCzhXCB1; spf=pass (imf03.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723665329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZHKdbL+kmW//SPJ/8MfNcR00potmnc+URCvxzfOLbRI=; b=2eiNlSHLZfZh1CP6snP0f/UNC9tKWTcmT7X/C3IqZ9EitKIOW0XSr6T8I8nUahylsh1Mhj bKDtl5cPmh2ghMf0CeU+MeydL5dKoqd29ih83g0qrCbHqv4r3FtMyvf2s2UZQ9aEd/ZbQD O97RdhE3TbuK/VTIhpdJMdFMhPzOyZA= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="H/jdf7q7"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=WCzhXCB1; spf=pass (imf03.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723665329; a=rsa-sha256; cv=pass; b=MEQo4Wl/nslPrJo9ZpAXAVW5uoanaHKNzdOdAXrXkj8rgisEUkQykkajV+ceuEa/3MM5TG C2cEzA5m+kymzlp9S5PiQV2OHSjyTc+JvcVKdGtmhBYIHG5GlSn+B//Spby+rSZI/o6r5t f585c8ISHIioxOkcfX4UROzvi1MOBqY= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47EIYdnN028335; Wed, 14 Aug 2024 19:55:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :content-transfer-encoding:in-reply-to:mime-version; s= corp-2023-11-20; bh=ZHKdbL+kmW//SPJ/8MfNcR00potmnc+URCvxzfOLbRI=; b= H/jdf7q7KlLhmeGZOdR5XVuoaWwkP/LEVJNGY+DkCEarej5EwbVCPRGVPdtUo+lF /xUT6wP9E6eQyxv6O9kRTphPBMJbMIwKHHYGtJYYjE9aJ0xeeZA+1gMNOySNqNRd 901RkqYVAolF4KJ07D7bOTOOF/nefhOqp8tnzpzrRfsMQrlk0r1NRpjkmy6yOhix k9hra8JuipR/OiqFO0B6Dt6RAEBGFUhm+61mrkHmuVucd4NVAkBEjJHu0vsPlxmK gbUTLsLlH+WIUHi9Sa1A7rsetuYMg7DacDs40+Qtz2S80pI3UAHosiIPElR509ts q2VTteSr22H8PPunsJcSAg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40wxt118b0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2024 19:55:50 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 47EILN0h000679; Wed, 14 Aug 2024 19:55:50 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2170.outbound.protection.outlook.com [104.47.73.170]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 40wxnaaavu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Aug 2024 19:55:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p+Sq793O3sFU2vjIzw06HjDcO7wBAhuWeRaPXfH+3JEmeRwcE8y+CaVhJZmjq1yHKXyFb+xrSs9pup7+foSjoD4oS1lgSk+LHnA6RU7N3WZR03n8/joE+If1vM+qaX45wIatRL3x276n0/LYEr9OIdcPegkKVHjiFaA33e8feVPP4YYyDw+YTpVFsuWsFp9ekzsNAhV+ieGmMemkm4Z4zHZVXZvoVGIjD2mO9Bd5T/sS30kkXZAzwbvQx9kC9S8eyncyxCGEPeSxbKfnLblM0OtGcRQxTkhOZAd1+f/D0dyb6WAcLWDNne9hCZKFrfQfe2GqJLbl0EL+Rl3421242Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHKdbL+kmW//SPJ/8MfNcR00potmnc+URCvxzfOLbRI=; b=QImtglZvjJxeuvQc9Z/lMpPPYQon6bF0DpwYxyFrZoE+BmBEkO+p9+7bNjvoxrradmvCh4YE6vq4+vEbonkH3JWf3gq63XNxzfwaZdQtW5y4CDAWnx0e63uLHlWMRFSy+aWPmWP7nCbe8e6lDe4td1FNco1SVr3c4P04d1mFAf+kUn5psuwA2evQxLoIKCxQTc+y0XXsfzvpFvUB/Kg0KC70E+Ra5dUttLaLxmaWYQDwEJ2yfw0bFCQU2C311Gks1ZzrUC6jvIJ3Ncof6J07ND9wDhsWcA3L+RnaChSjvSPMUpjM2W1J19M/k6QL8XYZdfufQTS293xRyZ3f6LUIZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZHKdbL+kmW//SPJ/8MfNcR00potmnc+URCvxzfOLbRI=; b=WCzhXCB1gf3MY/P4p9OBwB6sENRjJaRFMknr9aN/Kc/FUQa74O7lGKlDGULkYbfZukPx2sDyNLZt8cyKGVYwW2fhJ7hOCmWzGW8KVos2s14cL7a6yW30Ve33NV1lOKRTB9/6CJiGvNK8yrR8JWe5ps2jNOw80onEzwa7a38fKD0= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by PH0PR10MB5894.namprd10.prod.outlook.com (2603:10b6:510:14b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.18; Wed, 14 Aug 2024 19:55:47 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%3]) with mapi id 15.20.7875.016; Wed, 14 Aug 2024 19:55:47 +0000 Date: Wed, 14 Aug 2024 15:55:44 -0400 From: "Liam R. Howlett" To: Jeff Xu Cc: akpm@linux-foundation.org, willy@infradead.org, torvalds@linux-foundation.org, pedro.falcato@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, jeffxu@google.com, lorenzo.stoakes@oracle.com, mpe@ellerman.id.au, oliver.sang@intel.com, vbabka@suse.cz, keescook@chromium.org Subject: Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first. Message-ID: Mail-Followup-To: "Liam R. Howlett" , Jeff Xu , akpm@linux-foundation.org, willy@infradead.org, torvalds@linux-foundation.org, pedro.falcato@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, jeffxu@google.com, lorenzo.stoakes@oracle.com, mpe@ellerman.id.au, oliver.sang@intel.com, vbabka@suse.cz, keescook@chromium.org References: <20240814071424.2655666-1-jeffxu@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0225.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:eb::13) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|PH0PR10MB5894:EE_ X-MS-Office365-Filtering-Correlation-Id: 8932c810-ccbd-4686-1653-08dcbc9b16fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aDBKTzk0R0ducjZWV1RrbnBWSEpqOWpLbnE3Q2tDMitZaVhkTGhmc2YrN0VM?= =?utf-8?B?UUNaeEJPNVFka0NSbmFWREZhVE00SHlNS2d2Q2xOYTlxd0ZqZ0tGcENnV3Fn?= =?utf-8?B?ckJ1YkovSHd5dnUyTWtvLzRHMTN2UERKZ1Zob3JyU3hScDkvc2NKYUR3NFMx?= =?utf-8?B?dm94R28zanFLNlhud0ZqZWNGY3JiRmZPeXJweWdjY296RUhKajdKcVZwa0pp?= =?utf-8?B?ejUwT3BHL3BESFpVL3JZK2R4Sk9lNHM3bHh6UkFkUDZUQlFITzcwSEJCeUJM?= =?utf-8?B?ckx0dTRNM2Y3S3l5KzdsdWM1TUIvK0xBelNjTmNqWWxjR044WGVuN0Vic1Fa?= =?utf-8?B?YXpSTmhVckZGMHlGaStFc0lsd3FSZ2o2V29WMFc2enUrRnpuNm9HN3p5K0pH?= =?utf-8?B?QzcxZVJWTnZGY2Nld1VXN0xhSUQxRk52NDhYQWVJbW44a0x6MVh6TCtTa1JM?= =?utf-8?B?c3FYblMyeDI3b2g0bGVsUnV6TVhqa0htRXFOeTVhR25vNU9XN3RUQkNFeXAy?= =?utf-8?B?MmJVSklzeUsyREMycVV3dnEzODEwdzVtbzRjcW8yemZlZ2ZPUHhnckxqUlNz?= =?utf-8?B?THRtM2RHc3g1QjdpNjV5SENIYVpiTUlZN1Q5Q2xkUnhQRmN1Ylp1dEVkQVZ3?= =?utf-8?B?UlBvNU42RUp2K0xmRmF4OEhsRWp1SUpZUk54NG9hV3IySHFtWWtyNXZKL3dk?= =?utf-8?B?eGdyb2piODd5VngySVZwV0kxNnRTcEZpQW9LYkNMN2lPU0tLZG53UjcycjEv?= =?utf-8?B?WEVYbFBTZ1IrMTVaVVBnbkd1aXVGRWJ1SE55ZFFpQTFtNmkzS0VzUUdJNnFT?= =?utf-8?B?Y1NvYy85T2wwU1o3TGFaVjRNa1dYNGtjVG5vREMvWkplMUVUdHU5ZUVuRnI4?= =?utf-8?B?UENzWVpkcVpQbHF0MjIzd3plc0ZzbGxpZkoxWjltZ0J1VmZxb0h3OUIvUmhO?= =?utf-8?B?WGJDdzVTZXBvZDgvaTFzTHplZVBUYVphVm1rcURxMDdHZmNaYnZkdURrREJ0?= =?utf-8?B?Y0RoSVU2QjA2RllnWUd5eE1YUitmNFFrTjJ2QklreDJITjNFTjV5QTJzM3ZI?= =?utf-8?B?RmlrWkZxT2ovY3NRYVVhOWdqQzl0SG1wak9SbFV0QnU2d3hFYVoxRmFMSGo0?= =?utf-8?B?TTFVQWFiNTJRQzIzeWQ5YW52USs3WVV6d0VseW96TlErdCt4eTkwbzUzNWtZ?= =?utf-8?B?UVJieUJhaTR4SjJHRmUyejFtOENvVGJZZ284V2Fjd1NCdTVuU0tDVnZQUUFq?= =?utf-8?B?ZEthcnBXdGtaVWxKK1VpVGdETjZna2ZIQUhjaTA0QklSYmRFcXlzR244S0lm?= =?utf-8?B?Q0F5d21VVmxRb1Y1c1h2VWtCUEpkVTQ3eXFUVmVXdVFrOXBIeU9QcnljR3V0?= =?utf-8?B?ejB3SlZXcUlTQXhaaUVLZFNRVHRQbFU4VnJ2MnRFSG9uSEEvcExoSlNpcHM5?= =?utf-8?B?QjEzTmtPNnlkNkdvSzhYWVQ3OTlaRlM4U3hqQ1gzeVZhVUoxdUZYMFBKK2px?= =?utf-8?B?MmwrZkFwNDZNT2hPUFhqSFovR3NzRW1rZjlnVlZiNk9veTFITW54MTh4Qmh5?= =?utf-8?B?bEk4TVhhMC9jcFViZUJXemRZcVFRT1pXdFFrODdtcnpkU1pCV2RHd0lVSU5s?= =?utf-8?B?OHdzU3doTHozNE5zQjJZV2IvT0FtQXh3cTFUQlFTTFJocEg5TjBWNWhhSjBI?= =?utf-8?B?RnYyRzF1UVhueGZLQTRyQUhaSVY4VCtHRXN0ZXdyS2JheHR0WWRWSzlQa2JS?= =?utf-8?Q?MtxB19fGgm0DWX2f2g=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2ExK0dDT0xMc1NsTkVFVHhabUhzcW9wZDR0ZEdQV1c5TzYyb1J4eFpkSGRs?= =?utf-8?B?Y3M0Q3RUdHcrZHRxb2FJRmVzQ3JCL3U0OEwyUldXTGpuU0w3NUx5RzR6ZEVa?= =?utf-8?B?WTJ6eFVsMytMOE5FVEJ5QlN2TWZPWkdyZUpacEFtTkREaTFiSFVwMGtHWlFX?= =?utf-8?B?aStCSVFBYmlrRXJvdW9JdmdRZlVpWXdUY0lQaStaaTAzYm4rWWlLQnZNMnBo?= =?utf-8?B?d1FER0d4SlNmTWxmcW5wZ2hTamt5MWpabW1vdWtoOU9YTlM2bDF2NzhvN0d0?= =?utf-8?B?M0FqcXdvc2I5aHpMNFU0SjlFMmp1dXZZMlA0Z3dmVnJnSVZ0c3JSQ01jc1pa?= =?utf-8?B?cGNEamord21DY2NHcDRPUFlmbUZEbzlLWGpRQkJvN3FQMiswNXRqSHBXOWdi?= =?utf-8?B?bnZkcjR3YnRBbkg3NzNlRStFVENNenlMNUdJQ1V2YlUvR1JHZE96QzRlZi9T?= =?utf-8?B?VCtnd09KNkUzM2ZmWVNJTkp1bktJRnVlSlo3WVQ1MnB6ZWc2bDJuVWZpWUlJ?= =?utf-8?B?U2hKbk9xQkprWk82ckU1ZitIb0w5em55bHRpZGhGa1NCQWJacXhOSmxOZjUx?= =?utf-8?B?cFdWNDViMzNYRU9EUGoyYU9ZTC9PRmx6SWdqTVl3UzEzbFFWNTk0dVZpczVw?= =?utf-8?B?NUtDWDdJMmZiQVpJSnlmQkZPdHpUdDFLalRiS05lRW1ZQkJDZEtRVVR5Qlls?= =?utf-8?B?cFlkR2pCanF6a1grT0hBKytidnRHQ3JKdmU2YmxnYXNycWVlT29oR0Vzd0lx?= =?utf-8?B?Rnk4RzJRclkwUUVtbXZOTnJNU2xZSnIrdzliUEhQei8yY0IvcXAwc1l0djBr?= =?utf-8?B?LzFla3IwbExFaS9mMk94U2JZRjNEdXBXanl1NzRvZnJibnhwOWdoT2NyR0Vk?= =?utf-8?B?SXg4RVB1TncwTkQ1cFlucXpaM2x0SEVBZFFRLy9KazFqNHNNVG02Rzdid0tT?= =?utf-8?B?WUlGbTFURFFGbm1MTStkdlR3UnIrL293ZXJJdHF0ZWZiVDZSeTMxaXZOQXZJ?= =?utf-8?B?TnMxU0tMY0Y3OVBGWXIrOThzZmZYc05Wb0hHUHBGWmkvK2V4NGU0VDRBMnJj?= =?utf-8?B?a0Q0OTFZcm95WUFnNW5QUllEMWkxdkRJbnZHVy9QbmpHNU9BMFBQbVBSZGFU?= =?utf-8?B?Si91cC8yNXhDY2d2TFdlYmZqMEVWUmU2ZEpDenJyaUdOanBvTmhZRU96QUFT?= =?utf-8?B?QVFQTFBSa0dFeVFHV1JRYTBQeU5hRi9GT3NQUVBSV0RVUnZCclcvWjk5aEFt?= =?utf-8?B?ZGFDT3pPYmRWa0N6aGd2RklRcnJaeG8rVlA4ZUd6MDJVcko0TnZlSmxibWFa?= =?utf-8?B?T2N1NHhmQjZQakJrZktoTG5Uck93bzljOGdIYkpMMXk2TGFGSmVQZTZ6Tmtr?= =?utf-8?B?ZzljM29wOTRZdDVYUGVvSTFQa0I5alRlcHJoaUs1Qy9sL3p5U0xSSnZNWkZU?= =?utf-8?B?YTVuUjBiNUdqRU9LdDBvaWhrWjJrUERiano2ZzBjQlF2Rkd5TWF2TWlyTFJ0?= =?utf-8?B?SXRFVWhKb0FZTWtBOHpteFFRMGhhSnAzbXFMVXg1QnJNTjBPS1JnTFhTdUxa?= =?utf-8?B?OXZyTktrZ1lVNURaUWFvZHJhN05wWXJjL0JSK1ZFYlNvOGtwdUhWaGhIQng5?= =?utf-8?B?MDh1SXhTNVVPUDgwTDNmKytmZVl3U2NIdXpSRGNyNVk1dEVRNC9CdXRxTWNk?= =?utf-8?B?WWdFcVBRSHZpbndiSFQ5Y1VKMCsxeS80OUtwZFMveE9YaCt0VSs2U1FET2pk?= =?utf-8?B?Wk5iU21hNWVWcFREY3FUaTNtaXhNUXk1cnVlT3J0MmV4RzJEWWI1eU9YQk4x?= =?utf-8?B?TVIveFNzWE1jTlcwNGp2NUZ2RG5kTjlKZm5GWFZWY296VmcwM3dqNHFiVnds?= =?utf-8?B?dTM5ZDdBbDBIMlQ4YWNWVDZ2aTZZbGJJVzNUU3ZjaURrd2w1a01tbUZSbUp0?= =?utf-8?B?bzBSTTByQU5qTElzNE1jQTdDU2VTTUxackRTaThyeEtOemZISFNueXdnRVZS?= =?utf-8?B?UmNKdXo1Wk9TYkU1OTh1L2R0S1pPQlZtNkxkQmZtbXRDV2dIQjlJTU5uSisv?= =?utf-8?B?NDBWZW5KNUxpMFdPdWRycFpYazM1TnlMd24zU3kxTlVvU1dscGRvRkZkVG5a?= =?utf-8?Q?N6S5CNiWBXUm6TjNgLnxIvF67?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gmsZbddyqB60cWFs/0ADASGtZSOwGwoUIMlqin32vCGU+88CUQAa4Z7nH8KtjZn+CgIoM7x0ENq15wMxX0Jx0mlP2b6vmhstlI7A/noBRGFUm5CT8/R/o3YQsEmZFV/fU22GUYyZWZtNq5GDG5fWBcTRXrA2c7egWLRjgouakGBQeWnq5APcPWAxHd9F7kX8e4cqq4H9ZMNx56KYzv3brbAdndvObJsoe6j+xgCaubmu5ZG+clrtQh1ySuT/b5t4d8G1ppxshx1EXX64k2sO6XQ/dPwe105NJ0OZB0CiwQ7VI54SJ+JLan/VSDZfTXsYvysSmt9pZUR1oncZIx8iv5mRAdyjcQkPQE0spG7XrgZfRPpYn7F6d7f1ikzyKTwh+x36sgs1JDeTRMwqFE1swUqz0pvN4sPIchle149LKrhZ+sGVQ5lvrToDOlNXvbdi08PlpNcmv0BdVpv1VYCmJCUxLPkwLX7aLAlhh5TCuUAH/tBPzj3yPEi/gKcwbo9zNrQ1hHWb3ZJdlGN23kFJNicR9F7SXCjjO1yp1Nqy0OlmPS9ZjWhKyq8zhj14qx9ZTGAnDSjcj4p7GQRc3yU6qDVhD8Em/BaKvNGe9Eflu8g= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8932c810-ccbd-4686-1653-08dcbc9b16fc X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2024 19:55:47.2967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G1gxYwGCs4kq8AvOsw+kJqF1UyWfDPxWF6dtEWxklkM/WgWSEsJ6I6J8LW5jFr5szCRPb8tNjihJPs7yZXucMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5894 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-14_16,2024-08-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408140136 X-Proofpoint-GUID: EAJ5E4YxHIkGCjboydPmZo9Fk6t_rBbM X-Proofpoint-ORIG-GUID: EAJ5E4YxHIkGCjboydPmZo9Fk6t_rBbM X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A150E20034 X-Stat-Signature: do437dbiu873bugm6gbz3k39xah58ej3 X-HE-Tag: 1723665364-484806 X-HE-Meta: U2FsdGVkX1+G8i0GOfqzjzo2KYelex5QqscqOse3ha0RiM+dWU8zEYDiq2DBCCTwjsi31DS4cMJqo5XZHd8UzaVlGgOhLnAct19BgnOY89gg8DGBuJB4nuc5sfYLJY9itW8ZKnORqJBPcWpNm8wa/ESY1V+0ZecRZJVKhSNPbZJT1vYhJXkWGatik0clbYdfZTVzznHvuTkfrXtrjCuU+uhYoZOdnlb+27P5ls3u1zyOpasOBRJ5Xl8nLfNataylkwxJnZ1DELqrpQ6sUedQYHC4YHY/LLJUv4Q0/1ec+AmAIQbTqdYCEfBpEVJYZR4bR9c9SQRHsmKB8+YL7+VK4aH1tZNcal/ljULEqg9hpixIZM/5eLtMTmd+om9Pme3ApvAB2Eu8JRlxPxaA0PuX1a5potb3617Nrk3UfFL6VVndh+7jfK3LEbmn7WgYOKs8a1kbonvqREdUeOhFRCMbMpd4eVXTfGl/5UgP+DiqTmDJZ7bfA0gLeIeTUHjXaBx8h+H4/yiLZQqf7OUoRNdlX6mQezRrnktus05FQV/Xq+oTs5JrltEBW5b6xuR/4jwfnGCA8rp+Ojc3TqX1E5HP09PWucwWP3jruZSW3VqAXqo/+N/DHA6xt7rS1o9jZtJyrdDwIQHtxH01VRNU6A6qJ59TuDFLGsodcNk9uzX8wNJ8CFPAjHArZxCsvUAllnvDeLVL92n8Zoa/Lgdo4k88hPMqI2lLRshrW+LchW7fo00L9FMwlBWF2pvaCXaif24lwyqWbd1w8QgRVU/MGrvZH4sAz6MGuGXYj15qLV4efJXOCdfZ57irdlVUOVYwWpE0HrQwDQPTX8rMMijBFazFwNJneK6Tjs2GuZHSjb3MIxgPMNUXk40iRlWeE/rSxd9j2KLmyy8ZMXca/w8bVnGBSjNdri1CykliFsoXoM75CbF15nv5yeg5ht4hfqJjz0QZWF+Wt4aW3KSbcg4a2pR y15mxpwU lZ5StKi33ytR+HKfn6TqCtIxxDcx+m/N1dyHNoXwhfkhdeiLbeKJP3TceP1l95vfOB3qYNnmfrgV2vuNrHwOy1kEq6ppQ9u9pECeTBJ20A5VMzbaPfv3F0kuf+4Q3HFvMpPEI4ZoolmaXuc6/KoNO9dNxOKTIGG2nFSh8nxMrdGagnX9gsv/PheCbZAJlRAHySILyfPiXeMvu+vixxiq1frjjyrGsalG9tdRXY+cGw9CxwQ3BG9pJP0IzDPUXnIkONh5pwsZA1XHo4/K0UN50BMBO+Sfz855BuejrZa5WjLYMBeMvvi048HicUQXkRBH/TYWCY4YYBLu34f+Mn+Av8Ure/xdOikV/j+FNqNR6qdVC5h6ptL0fDWQJ1A6JJEqf1bjrut37Mz4Oz4RSKUugxSL3NJJXUBvU/FZNLlYXxhFAY//fsLxmA6XoqZfAuqluuI+2dvIpkEaHRLW+R4MBk5EX8kt/ht4q5uskZaBXmhMuKMbUQK7ISxa/PqsCdUV5EViBaEFw4f4xsrDZr3oqyzBMPTg4p1I5GjpF4lke9pwe6BJqPRe7A0YAezHPcbxDptpT1cj845uEVOtmtXtUSoM4zEkqG2PMWcJC79V6WH9U9zT4R56KBiKC+rSj7kz8lGOa6T+qNWQyA7OW3ksnmdDwQbQpxAhtOO10zNvN022bZDuLLb+uZGqt/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Jeff Xu [240814 12:57]: > On Wed, Aug 14, 2024 at 7:40=E2=80=AFAM Liam R. Howlett wrote: > > > > * jeffxu@chromium.org [240814 03:14]: > > > From: Jeff Xu > > > > > > mremap doesn't allow relocate, expand, shrink across VMA boundaries, > > > refactor the code to check src address range before doing anything on > > > the destination, i.e. destination won't be unmapped, if src address > > > failed the boundaries check. > > > > > > This also allows us to remove can_modify_mm from mremap.c, since > > > the src address must be single VMA, can_modify_vma is used. > > > > I don't think sending out a separate patch to address the same thing as > > the patch you said you were testing [1] is the correct approach. You > > had already sent suggestions on mremap changes - why send this patch se= t > > instead of making another suggestion? > > > As indicated in the cover letter, this patch aims to improve mremap > performance while preserving existing mseal's semantics. They are not worth preserving. > And this > patch can go in-dependantly regardless of in-loop out-loop discussion. No, it conflicts with the other mremap patch as it changes the same code - in a very similar way. >=20 > [1] link in your email is broken, but I assume you meant Pedro's V1/V2 > of in-loop change. Yes, the email where you delayed discussing the fix so that you could test it. Which brings up the question you didn't answer and deleted: Does your testing pass on those patches? > In-loop change has a semantic/regression risk to > mseal, and will take longer time to review/test/prove and bake. There are no uses, so the risk is minimal. > We can leave in-loop discussion in Pedro's thread, No, it is directly linked to these patches as this should have just been a comment on a patch in that series. > I hope the V3 of > Pedro's patch adds more testing coverage and addresses existing > comments in V2. The majority of the comments to V2 are mine, you only told us that splitting a sealed vma is wrong (after I asked you directly to answer) and then you made a comment about testing of the patch set. Besides the direct responses to me, your comment was "wait for me to test". You are holding us hostage by asking for more testing but not sharing what is and is not valid for mseal() - or even answering questions on tests you run. Splitting a vma doesn't change the memory, but that's not allowed for some reason. These patches should be rejected in favour of fixing the feature like it should have been written in the first place. Anything less is just to simplify backports and avoiding testing - "avoiding the business logic". Liam [1] https://lore.kernel.org/all/CALmYWFvURJBgyFw7x5qrL4CqoZjy92NeFAS750XaLx= O7o7Cv9A@mail.gmail.com/