linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, willy@infradead.org,
	 linux-mm@kvack.org, da.gomez@kernel.org, mcgrof@kernel.org,
	gost.dev@samsung.com,  linux-doc@vger.kernel.org,
	Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH] docs: update THP admin guide about non-tmpfs filesystem support
Date: Thu, 3 Apr 2025 20:21:19 +0200	[thread overview]
Message-ID: <midpuwlrt6tllgk2lpcntariyyt7msp7uyv32syfwne2p662yg@ux2zb7flcam3> (raw)
In-Reply-To: <77b19486-28ca-47e1-b506-6de604f6ec0a@redhat.com>

> >      in the examples below we presume that the basic page size is 4K and
> > @@ -463,6 +463,10 @@ fields for each mapping. (Note that AnonHugePages only applies to traditional
> >   PMD-sized THP for historical reasons and should have been called
> >   AnonHugePmdMapped).
> > +The number of PMD-sized transparent huge pages currently used by
> > +filesystem data (page cache) is available by reading the FileHugePages field
> > +in ``/proc/meminfo``.
> > +
> 
> These changed look good. Do we also want to talk about FilePmdMapped?
> (PMD-sized THPs in the page cache that are mapped in to user space using a
> PMD ?)

I am a bit new to this subsystem, and it took some time to wrap around all
the different terminology used :)

But sure, I will add a new commit to talk about FilePmdMapped. I can
give it a shot with what I understand about FilePmdMapped, but please feel
free to add your input.

> 
> Do we have to distinguish it from below? (shmem also uses the page cache)
> 
> >   The number of file transparent huge pages mapped to userspace is available
> >   by reading ShmemPmdMapped and ShmemHugePages fields in ``/proc/meminfo``.
> >   To identify what applications are mapping file transparent huge pages, it
> 
> Previously here, but: this reads rather odd. "file transparent huge pages".
> "PMD-sized THPs specific to shmem are tracked separately ..." ?
> 

I totally agree. Reading "file transparent huge pages" confused me even
more. I will fold these changes as well.

Thanks, David.

--
Pankaj


      reply	other threads:[~2025-04-03 18:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 10:38 Pankaj Raghav (Samsung)
2025-04-03 10:50 ` Bagas Sanjaya
2025-04-03 13:49 ` David Hildenbrand
2025-04-03 18:21   ` Pankaj Raghav (Samsung) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=midpuwlrt6tllgk2lpcntariyyt7msp7uyv32syfwne2p662yg@ux2zb7flcam3 \
    --to=kernel@pankajraghav.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=da.gomez@kernel.org \
    --cc=david@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox