From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBA7C77B7C for ; Wed, 10 May 2023 14:04:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED5E16B0071; Wed, 10 May 2023 10:04:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E85C26B0072; Wed, 10 May 2023 10:04:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4F5E6B0074; Wed, 10 May 2023 10:04:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C210D6B0071 for ; Wed, 10 May 2023 10:04:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3971C1C6F1F for ; Wed, 10 May 2023 14:04:34 +0000 (UTC) X-FDA: 80774515668.25.32680AB Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf26.hostedemail.com (Postfix) with ESMTP id 45A77140419 for ; Wed, 10 May 2023 14:01:58 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b=xm7Lt7K+; spf=pass (imf26.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683727323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=8O+Xva6SSKUOzu8cD6VykU+fN8y+E0NtB9pirvzzQ9U=; b=gpPysBv9cWHkqZDS/3usUVCGqz0pp5FgmypQhxKJsYgHtYfDFh/Jo1NPgVxrLx+Ui2KXtA f6xCb6b67nnybdeLirfdY29X0xi/Rijx5vAW1SvI4EbHoGClvIHXwo1I+gMjhn3lp43mrU HLUj2kAoa18dXzVluamEH4DTEhCp+jw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b=xm7Lt7K+; spf=pass (imf26.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683727323; a=rsa-sha256; cv=none; b=OZ6xunxlXSD0xJkspOoD/0P+ZcC9Ws7vC54M/Kvd8bGlqv48QTGC++FYVoToJrf1rKzpmg 6hEukTUrNq4gG2QYsj2KekGYXwn10L5NO2LQ829+vpqw0BFMS/SlMnTrr7OWiKYLCOIaLh wvAKRFxduRZKQjinmtPQ1T1Nh1E1+iA= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-64115eef620so50339838b3a.1 for ; Wed, 10 May 2023 07:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1683727315; x=1686319315; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=8O+Xva6SSKUOzu8cD6VykU+fN8y+E0NtB9pirvzzQ9U=; b=xm7Lt7K+fM4a6fbPP7MIva3KYIsdEH2pn6NhTnqMZWDxfwMmfjfuC2iA7TIUgSp9X7 iapnslzabTi/3hpYysj/Y+Qpo/U+trS4YUbBrAymZCbRPQc2GdzYMvfSXRt75xnkQ7HH 9YmGcBzN1XGEnBnDnk4hqc6szvJ0vnbRYHR7DYbbDIfxitLJRxJHVDjlkZx/sb2Dalmd NMN9fv1UEU3MEvWMv2OyK363gty+uPi7R5tqnoKyXja1AZDDzs7OuMx+xXPfQOPl3EBu 5ahAyXiN9ZWDD9X3LQrrN5sPj7Sd7WcMwJ/uvJSD2iG4PimTEA2R4mrq6SpEbr7//1lB gm+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683727315; x=1686319315; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8O+Xva6SSKUOzu8cD6VykU+fN8y+E0NtB9pirvzzQ9U=; b=LgGZQLQAJbXiPbE0rszjxoMJTCbGDC67ktxbCjaU9PnHsUyrupkW7pcYzNRtPtnys0 rWvBhKIS5uPi5tEcQCE28+1vhijWPqR6OuLJGQgTjPn9ckFSd4yJWkPifTeHEk2B1y6G iL26Yf9976MBpisE/Y9kf4oT+Fh7qyRckXmES4DofH6On65qeo8WGzl2nDzmBvtIFF32 BPlROlISes1xjBaR+/FPSlMEyZG7y6PQ0LM0zMdDs6qW4bNelm6nuAjchS/nD9AlCpPg U1sbBbZzKv5bnoqZeJt7Fr2K5JtMHeADkcCdImU9zXNX3Pl5b0EuFP17e+drRO1I9uEE HJZg== X-Gm-Message-State: AC+VfDymvovCZ4zPhLCrYV0rnqTMSiJTRKSKWTYXjJ+nqTBjUnvIFUkX 9xHPd/CxEaW/+bxjsa2at1tz1A== X-Google-Smtp-Source: ACHHUZ5DO6A5G9Iwzn4Bquam+4PsWMq7WswXOCHPFyT+gtbX2VPfleyC7b8WGb0kQumaiIfRAr9lsw== X-Received: by 2002:a17:902:9a03:b0:1ad:1be7:2a76 with SMTP id v3-20020a1709029a0300b001ad1be72a76mr1572089plp.10.1683727315241; Wed, 10 May 2023 07:01:55 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id q6-20020a170902dac600b001ac55a5e5eesm3819212plx.121.2023.05.10.07.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 07:01:54 -0700 (PDT) Date: Wed, 10 May 2023 07:01:54 -0700 (PDT) X-Google-Original-Date: Wed, 10 May 2023 07:01:48 PDT (-0700) Subject: Re: [PATCH 14/23] riscv/hugetlb: pte_alloc_huge() pte_offset_huge() In-Reply-To: CC: akpm@linux-foundation.org, mike.kravetz@oracle.com, rppt@kernel.org, kirill.shutemov@linux.intel.com, willy@infradead.org, david@redhat.com, surenb@google.com, zhengqi.arch@bytedance.com, linux@armlinux.org.uk, Catalin Marinas , Will Deacon , geert@linux-m68k.org, gerg@linux-m68k.org, monstr@monstr.eu, tsbogend@alpha.franken.de, deller@gmx.de, dave.anglin@bell.net, aneesh.kumar@linux.ibm.com, mpe@ellerman.id.au, alexghiti@rivosinc.com, hca@linux.ibm.com, borntraeger@linux.ibm.com, imbrenda@linux.ibm.com, glaubitz@physik.fu-berlin.de, davem@davemloft.net, chris@zankel.net, jcmvbkbc@gmail.com, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Palmer Dabbelt To: hughd@google.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: dpjp8a1z64oabxzze6gbuwnb3tqwdiy1 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 45A77140419 X-Rspam-User: X-HE-Tag: 1683727318-842758 X-HE-Meta: U2FsdGVkX19uyscXvtwroZF0i8gn4u2uZrXCMEVFfAdo/bH5GFFH+PW7p87QJm+QfmLUQ2/8vRzFly5WQ6cgKdF788iDOk1jb9tPtejFyZ9wxKxXpYa3J5Idkc+d/StxEtzwKC6vW/ELevJZf3wBeknelg6bNizrJ9I0EW6Jq6uaPYo4M5YSSKkkx6xYIX4BNTkhc4DTtnla7htWaPAwqhBBATi5Efi8K3MxLYGhs6K4C1mWipOLQPdbWW7AVJmf5YQyRVxFKGOhGVFVvCBVvdFoREeeUkyt9W1wc7+3SVqpH06ZQzEWlsb98Stw5orz/YDulI9ZLJW7KRAV6PV1myLljyy+Z++EWzUB9rlEA9/SOEKqtdGbUH0wr/DBSswVBCFmwtQmGK5utS4eTlWCA9xtCcUDLBfNxQXCjN/Y89EXt2iW9pEqKAt0Bz5tLVcOL7ZbFLoABe7e7zulTrC63shuHyRRKHEm0HV7KSMMAzWHvwFdiXnrx6dte4nkVDptUIlublR9Khf9KYmBc6dXZDDPlPeox81Cj2iRMvOAddrqxaxtMMEEYJ7AtXUwT0oxhsD/E0FnsE3M3/9Cy5a4MqNhbbYOO4KYBffdV2p2hkzKSEUDI1bfkQPOKu2tljRsbYt9vaNB7luqSIluCmchAS/cnBd818jAckq39NlMHOprbVcVD+7vEKfgLbFvgP/jDXQfI0GRYWN4OWcb3cdi066PL7FwI2c/iq8lSNC2bnktczF6aSoOy3vTLts5azN3RqIUgdCY1hGhVus46FPpLh3nE5K+OkadlaK8VGgD98q/oD3j5l8Wy/ZBNWLaYlqcfuX4opY6i2wvipwThX2Qne1EZDJxHiNLaUbdxdOFC6MwFm38zU8lm2u+PB9nKUpjmJjPKpndgG22kni63GEBIvOu+9CeRo0+kU5e6ZY2uwWGrcKSU73eVaS0DpWS/uM/zcmSUdF4GgzZ4tMASJf KVxctT3E UNx6Nxdcjoqr+OFev3wjTpRuSLGpy3SdDMDWG6BSqaylS6VtVOeegBFyPskDddlMG8mQlXIiOO2fiA3mqs3SAV5LTfcGpwE8caFYwOyQEYdoYL5+UD1dr/+Hp4R8e4zuCsRZ0MgW++3ibncBLm+0aYOAQDQwxjRWSzsxh2+8jEbw5fHg5eAxdnmBmipKxJ9sk6RlhDsCSC2d5Gl+RXdhJEXoqNlTRzbR4svuSpnjiFNtvO8ZlQh17MYro9avALIZeN9DnYYMh4gCZUAeeCaoeIVDGSUO2XfFZHwrKD+scw+1KXqEqaZNsPUCsBMhG8nKNobq0j0bEWdFVKMkpG6EV7BMLRFDg+VodXq9eS06/KQoTOjlZM+GsOIr8R50vv+nblr3J90hS0pWzT1KJAZUFvzs/oEQsHr2cPGpj78OIArPQ1lR2xceDhbOILL7blNBJ0hzpY7wGV3ESWkqvoZx3P/bz4WEsFAmpC89+s4F90frBvwhPYVWp/58Glq8xOOV79Ifv8kX/YdMdX42POJq8vmbh36aZNRDFdNS2bc/r7rIuDAE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010229, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 09 May 2023 21:59:57 PDT (-0700), hughd@google.com wrote: > pte_alloc_map() expects to be followed by pte_unmap(), but hugetlb omits > that: to keep balance in future, use the recently added pte_alloc_huge() > instead; with pte_offset_huge() a better name for pte_offset_kernel(). > > Signed-off-by: Hugh Dickins > --- > arch/riscv/mm/hugetlbpage.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/mm/hugetlbpage.c b/arch/riscv/mm/hugetlbpage.c > index a163a3e0f0d4..80926946759f 100644 > --- a/arch/riscv/mm/hugetlbpage.c > +++ b/arch/riscv/mm/hugetlbpage.c > @@ -43,7 +43,7 @@ pte_t *huge_pte_alloc(struct mm_struct *mm, > > for_each_napot_order(order) { > if (napot_cont_size(order) == sz) { > - pte = pte_alloc_map(mm, pmd, addr & napot_cont_mask(order)); > + pte = pte_alloc_huge(mm, pmd, addr & napot_cont_mask(order)); > break; > } > } > @@ -90,7 +90,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm, > > for_each_napot_order(order) { > if (napot_cont_size(order) == sz) { > - pte = pte_offset_kernel(pmd, addr & napot_cont_mask(order)); > + pte = pte_offset_huge(pmd, addr & napot_cont_mask(order)); > break; > } > } Acked-by: Palmer Dabbelt