From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C009EB64D8 for ; Thu, 22 Jun 2023 15:05:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F1218D0002; Thu, 22 Jun 2023 11:05:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07A548D0001; Thu, 22 Jun 2023 11:05:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E84EA8D0002; Thu, 22 Jun 2023 11:05:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DABCF8D0001 for ; Thu, 22 Jun 2023 11:05:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BFB2F140BB8 for ; Thu, 22 Jun 2023 15:05:04 +0000 (UTC) X-FDA: 80930706528.12.227875D Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf02.hostedemail.com (Postfix) with ESMTP id 09AAF801FE for ; Thu, 22 Jun 2023 15:02:11 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b=mt+u4MU2; dmarc=none; spf=pass (imf02.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687446133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=faWv91VP2z/YbKZA+qDwvC+H5Ebg0LphINaB6C6XGBI=; b=X2So4kyOCQq/eIaU/pRq+6jJ+dZmzKZRQ9vhkAzX7pPBK5LMu1klg1WYRTYQcvfJz6hyED lfTQyoc4s7rj0jTx8FNzN2quVvZdxqt85fDB+AEU7n0s8fR15k/KL/n/ZgIrlmp/NR2L0O +mxmFmM1uIW7r+i4GR47XyIZrkDrpzk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b=mt+u4MU2; dmarc=none; spf=pass (imf02.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687446133; a=rsa-sha256; cv=none; b=teqUGKyQdDJ1fD+JD4J3Ku8knf4g8SvbPg+JELU2XXZxHBpKVDpxS1fAVnYufj8Z1ZjRGq KyysxdAQIEH7ex1pvVSeB8BJv9ulzsudcBIDGcRbh73QyZJr+paii4bxvD7EKsLm7o7ouP iTcWjaxU5bW1lJ3b2DQCRrU0DQmFNYQ= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1b51780bed0so56459385ad.3 for ; Thu, 22 Jun 2023 08:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1687446130; x=1690038130; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=faWv91VP2z/YbKZA+qDwvC+H5Ebg0LphINaB6C6XGBI=; b=mt+u4MU2N69BdCB48EipZPFZvxxegmfx/OHOcyc/fM4PZHcrYAkSQWkcdFUsmp5rNU a6j2G9cgP05nAPrTpXTrKstR8E5BoO42DmiP6/AZUuIG/6/BBMLFuw5aAo/SAHPeZdEg DNvDehDx9+J7nZG9sBU7G6/wpPi2vu+msKWiZ8QFox3/ruMzFIOZCnfnj843xufxdgu9 MeGUmiA7Z/dRVBK3NdT9B4ymhpM9c0qpwKNXpegEvvYhn5T1kxweIZjlNE+fattEVIvn jG1RiXKH3SvzlebwvUPYmft34NdlnUAiikYo4SRSggxh+pPF10pxJtEKozp+lS8TepIG aHrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687446130; x=1690038130; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=faWv91VP2z/YbKZA+qDwvC+H5Ebg0LphINaB6C6XGBI=; b=SR4j4AvefJcrX692lvPxWbft0iK4G+USyR5/ZMQd0OIwqczfrbH7gLJs2MMx0vNU26 iR2Zw8iVxUlgJ4HoK9Zk1KtD1HvPtaJhrF6GPqGUH/MJRcrygStF+g9Qu6jpKjsYG+NW Ku4V0ctV72v1TpI2G+hDE2MMCor9z9rpr2e2SVe4Ztuow/OAyZNET7tJHF1RiA8Wt6mO B6Q9Wk6MyEBM7NqfxDkBvfgIYgQ3cDh0AX+KK5V1tL6ATDo0j510347U+bMFxeb7ewRH 7Mxh212RqCg6TjsjS56awNuhfQe7qnIVHdgdOmmJP94VN3Lb1/f9l/UqUMg29baiHQBl Ty/g== X-Gm-Message-State: AC+VfDx7ZXEgsFDtPfIisFGG53fw/YK4kShbEQPcM6fzjQJmdk0HFUj0 MV37ZSaRCSWlekdN/tmvTlPDJw== X-Google-Smtp-Source: ACHHUZ7sxI2/l9NYWY43UXjLd7//zIrvDML1M6VqO+WFrtnEGO/KRuc42ZZ7KlADjiu835vi4h/IOA== X-Received: by 2002:a17:902:f7c6:b0:1ae:14d:8d0a with SMTP id h6-20020a170902f7c600b001ae014d8d0amr15965819plw.29.1687446130063; Thu, 22 Jun 2023 08:02:10 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id z7-20020a170902708700b001b3dada0e78sm5466709plk.258.2023.06.22.08.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 08:02:09 -0700 (PDT) Date: Thu, 22 Jun 2023 08:02:09 -0700 (PDT) X-Google-Original-Date: Thu, 22 Jun 2023 08:01:29 PDT (-0700) Subject: Re: [PATCH 11/14] init: consolidate prototypes in linux/init.h In-Reply-To: <20230517131102.934196-12-arnd@kernel.org> CC: akpm@linux-foundation.org, linux-mm@kvack.org, Arnd Bergmann , linux@armlinux.org.uk, Catalin Marinas , Will Deacon , monstr@monstr.eu, tsbogend@alpha.franken.de, deller@gmx.de, mpe@ellerman.id.au, hca@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, rafael@kernel.org, paul@paul-moore.com, eparis@redhat.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, pavel@ucw.cz, peterz@infradead.org, longman@redhat.com, boqun.feng@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, audit@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com From: Palmer Dabbelt To: arnd@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 09AAF801FE X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: nzsq3aho5rwk1suc9byqsyy8wcifok4e X-HE-Tag: 1687446131-476870 X-HE-Meta: U2FsdGVkX191K8+Y9qjCpiz2tCjYM2ALCxj2e00+VosaM9JCoi4n1u2tcIXy79c1iFqag3GriR4jjiFjhJZ5DPjAw9BVhGERFrwZJaok35Tb9ZRyDvGzbO41YV41TOzuF8lxS8oDq4hI1N0BpfZ2qXAnVmtPvGUHzz2SQmDSfobZu784U+G9FCbvoDpz9TF6bOrYPzVYxCph1RuY8+2vaqBE0QIQoP8SbGsWR8wwZ/VN0gi7Ti5x2ombm6zX3JMU0c39WZvVB9mWePQeFsk/Uk25pFr5E48y7kdSLShTmkW34XDP+xKDFZJXmjsPhkXorUz3AnJqkqnznLl31voc3yOj6o4uSxiEZOBn8zfGouPDDzkKPkbFVNukDnulAR99G7hv1X2nwGa0eG2RRjEhUJwOCgvVbJg6ZsZDi+QYoEFjeDoKMQUDHGnlGtCt8niDr0P3VC3qcfsZVDBRWpZrHClCxLyVzEX42uE9t+L5+yAcKifjeQFyN5POYVxr80BPWKhBt60H/5hRUSGHWgLd48JPtgm7v5b8AyhNmGFMMVFdcNpQ/9mz/jlscbdW1mfYFL8BHwVI1t6sZOIPkgjWe7oUGFar32wwp2cw/yvdlXG5KLI9aSsyjesqegm2wgXNlAcAv2Vgm+EJxbP5NSuohnE2epOTcLUBbxgkp2WHAZvPV6uT7tZryd7plqEH2G7ksO9OLnPp5qQ5ZvZJJCp8WN5Y/xME6hmnFiOuvwh6Z0wUBq9sZT0KBkK49uBB+3WbKw7pbtii9G85XWdgNQVtX8dswJAkLfu9l/1g/GdmNBDRmB5cqd7FvG/AeRbDuzWGSJDo6qLysc/BR39GVTnJKFVDYXDC2jgL1XMRfnbP4TT7aKS24ikTLrUVlCWNYU5HRryZiu7UXWogbl5Rn5VgW6xXTwjq1F/AEw5/k0epgG1kRZVewbZY153kj/D8wM5UbJXiomN1klhySOu1f3w GkQ/SovK uZS8MSOuzfiLLABmFWGnoztGtch+9VRdAcK3RHxSyQ8S/yng69iDEpRcG9a00RVPIJJYy5dJWAuHEHAi9N9dQ+qkvsWtFnQd9kT3B+vjEIKfyHO73EcfOTDZB1sbjVsNjVP60xyK3fONcl7ZZUmYWJ41jwfrxFeupWR7OhEo51lt3qbEWXTkeH5CONmAyv7hd3y8Bta/qAf3mQU7o5IFN1Plv/qacUq39bNGk3c4YGbghPqnG5g/hCs6i/XoZ2H+5I6EHLmOoEn25f8E0wbOo3iU8xrJUlMiKli8FQIbFIDZ0bPeyhX8ABMxCuodQ3hlFvkJMMgw25PhmsI/FCwsYMcyjU6vQCfJBI9gdWeDNRIzuGn/JdC0u1sbJ2vGwOkxpR03T9gj6zam8AqElPkT9WSXUBnGctbTvf0LFiOtzifyuTZSstdXZQ8dqrlYxnPkjRVBj4DLoZdXDMIye5atJPhJldj9UT/8/R9Tmd6lBBjOh1GSnXXIrG12DDhwlxFFslOUxbyujOskxwnmB2MgN3hqUxXlj45H6EEDg3VhKe7uHbGJkJGHJnZbHrtjlZlX/0wkOt/mdExw4mOFm+BhcJ2LUZpCwiOsRmI5NW1rpsUrTlZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 17 May 2023 06:10:59 PDT (-0700), arnd@kernel.org wrote: > From: Arnd Bergmann > > The init/main.c file contains some extern declarations for functions > defined in architecture code, and it defines some other functions that > are called from architecture code with a custom prototype. Both of those > result in warnings with 'make W=1': > > init/calibrate.c:261:37: error: no previous prototype for 'calibrate_delay_is_known' [-Werror=missing-prototypes] > init/main.c:790:20: error: no previous prototype for 'mem_encrypt_init' [-Werror=missing-prototypes] > init/main.c:792:20: error: no previous prototype for 'poking_init' [-Werror=missing-prototypes] > arch/arm64/kernel/irq.c:122:13: error: no previous prototype for 'init_IRQ' [-Werror=missing-prototypes] > arch/arm64/kernel/time.c:55:13: error: no previous prototype for 'time_init' [-Werror=missing-prototypes] > arch/x86/kernel/process.c:935:13: error: no previous prototype for 'arch_post_acpi_subsys_init' [-Werror=missing-prototypes] > init/calibrate.c:261:37: error: no previous prototype for 'calibrate_delay_is_known' [-Werror=missing-prototypes] > kernel/fork.c:991:20: error: no previous prototype for 'arch_task_cache_init' [-Werror=missing-prototypes] > > Add prototypes for all of these in include/linux/init.h or another > appropriate header, and remove the duplicate declarations from > architecture specific code. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/include/asm/irq.h | 1 - > arch/microblaze/include/asm/setup.h | 2 -- > arch/mips/include/asm/irq.h | 1 - > arch/parisc/kernel/smp.c | 1 - > arch/powerpc/include/asm/irq.h | 1 - > arch/riscv/include/asm/irq.h | 2 -- > arch/riscv/include/asm/timex.h | 2 -- > arch/s390/kernel/entry.h | 2 -- > arch/sh/include/asm/irq.h | 1 - > arch/sh/include/asm/rtc.h | 2 -- > arch/sparc/include/asm/irq_32.h | 1 - > arch/sparc/include/asm/irq_64.h | 1 - > arch/sparc/include/asm/timer_64.h | 1 - > arch/sparc/kernel/kernel.h | 4 ---- > arch/x86/include/asm/irq.h | 2 -- > arch/x86/include/asm/mem_encrypt.h | 3 --- > arch/x86/include/asm/time.h | 1 - > arch/x86/include/asm/tsc.h | 1 - > include/linux/acpi.h | 3 ++- > include/linux/delay.h | 1 + > include/linux/init.h | 20 ++++++++++++++++++++ > init/main.c | 18 ------------------ > 22 files changed, 23 insertions(+), 48 deletions(-) ... > diff --git a/arch/riscv/include/asm/irq.h b/arch/riscv/include/asm/irq.h > index 43b9ebfbd943..8e10a94430a2 100644 > --- a/arch/riscv/include/asm/irq.h > +++ b/arch/riscv/include/asm/irq.h > @@ -16,6 +16,4 @@ void riscv_set_intc_hwnode_fn(struct fwnode_handle *(*fn)(void)); > > struct fwnode_handle *riscv_get_intc_hwnode(void); > > -extern void __init init_IRQ(void); > - > #endif /* _ASM_RISCV_IRQ_H */ > diff --git a/arch/riscv/include/asm/timex.h b/arch/riscv/include/asm/timex.h > index d6a7428f6248..a06697846e69 100644 > --- a/arch/riscv/include/asm/timex.h > +++ b/arch/riscv/include/asm/timex.h > @@ -88,6 +88,4 @@ static inline int read_current_timer(unsigned long *timer_val) > return 0; > } > > -extern void time_init(void); > - > #endif /* _ASM_RISCV_TIMEX_H */ Reviewed-by: Palmer Dabbelt # RISC-V Acked-by: Palmer Dabbelt # RISC-V Thanks!