From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F090CC6FD1D for ; Wed, 15 Mar 2023 05:09:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63F7F8E0001; Wed, 15 Mar 2023 01:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EFAF6B0074; Wed, 15 Mar 2023 01:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B7238E0001; Wed, 15 Mar 2023 01:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3CA1B6B0072 for ; Wed, 15 Mar 2023 01:09:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B0A0A10A2 for ; Wed, 15 Mar 2023 05:09:10 +0000 (UTC) X-FDA: 80569953660.11.F7C7222 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 233BB4000C for ; Wed, 15 Mar 2023 05:09:07 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b="fGqFohi/"; spf=pass (imf11.hostedemail.com: domain of palmer@rivosinc.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=palmer@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678856948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=cDhp6I3SlNxGtr/O2yKbwiije8DSntjdlAK0nvSsNNE=; b=Sh+W1TkiBdICoBdMq1C4jvvqUS0oDa/ZAM2VruAKu6JUoYnnh84mLMbBiBBmlA7P36LFcQ VHqeC0TpngIyPJnX27sFRz4CukC3kTPrhE6bVmlO+QRG0BdkBdsDtjAmBIloiPtkcQ3Sj8 JHlCdqOpXvWT+Nia/vDG7bhuAyZxlZE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b="fGqFohi/"; spf=pass (imf11.hostedemail.com: domain of palmer@rivosinc.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=palmer@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678856948; a=rsa-sha256; cv=none; b=F96k6TqIBCooJZQEOyNuK2p0OENiYoXpWDaljIRNH9R4sDOIx5WwjR96On1Iv9PUBLavxx nx7JJuDlXkA+sOBQ6t8DQmib5+OZXlLR4IpuT6GTt4g3LQT963Nm5WG5F5Wl8HypmY9jI5 vAsKKlaIJn7K12t9MFRXlBFIEtpXV54= Received: by mail-pl1-f172.google.com with SMTP id x11so18816649pln.12 for ; Tue, 14 Mar 2023 22:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; t=1678856947; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=cDhp6I3SlNxGtr/O2yKbwiije8DSntjdlAK0nvSsNNE=; b=fGqFohi/U0BaTxNiwoIwD6MODRfd07bt2ES8n34/VYOh/f4HlZWFxnzVvt4O3h+BRC /hAb0APS4PAYxvTzi2Wvcd3eeDXlio7s+9p4lZjr4x/yQzLq47Qr+hPKSTiT+7hYxBGs i3CDZA9bQAiO4CFCL1K6uKFdUBa8BMNqmI8DeAuDdPC7CW1PBcSNVA8fzPdMqp1iGZKd MYtTLzfNUmesH/WxmH5wiwAYCcRbvl3QewEWJlqd/12S9r1FfC8WwmpkbTiZH629IJDp o7GcnJZZQyUv4B7T5OsfTiVlLXHGXe1c9tlVmlHIevWqwcF/P2S3qs6EzumHpyHrdo2G DhiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678856947; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cDhp6I3SlNxGtr/O2yKbwiije8DSntjdlAK0nvSsNNE=; b=ga26YQSJlPUMywXSGI8e7qAmdIC6HnEnpgFNyu9bWxZLCOxPNMH0rlxw8SvtdMVP1X pAE9TxYf3LYgbyUucGPuF0mazNmlalDtCyCoNJc23yHk79I/XAcUNiTkmUzjrN/TVSPV wHr8JbFOpWVNx3eOe0kiYQ0j9VcPp4c2lt/iCt6uIaSJqFGx6kboPszgm9N1Y9zCvVxd jszDX6GxDF1rLgCQzrfNwqfOcLjO4pp2jWzpDZYNYRuvrVdzo5zrTxCKYQTYy0hl+MTV IBWyLBPNO3+1FJWcPw3DTkcpC8278TrAsmMzLiMOHbgJSHH7px7JOj6UEmQWi4G/ooFi Wccw== X-Gm-Message-State: AO0yUKW8vk/5q5voVhRXHHXbSPVbvJcN2hWQlycXetX0gnJ25UL+OGFS 4ETJ2Vn2r8dDbS65Iy8dMrb7FQ== X-Google-Smtp-Source: AK7set8juefow6279l5hDaRc9EcSMejPwOhhh67Wy+KVPRNO0G7i+DJ7i60mGKb+GVMj9wBlxJ/qVg== X-Received: by 2002:a17:903:1c1:b0:1a1:7b8d:670a with SMTP id e1-20020a17090301c100b001a17b8d670amr370816plh.21.1678856946844; Tue, 14 Mar 2023 22:09:06 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id gt22-20020a17090af2d600b0023530b1e4a0sm391684pjb.2.2023.03.14.22.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 22:09:06 -0700 (PDT) Date: Tue, 14 Mar 2023 22:09:06 -0700 (PDT) X-Google-Original-Date: Tue, 14 Mar 2023 22:08:14 PDT (-0700) Subject: Re: [PATCH v2 1/6] riscv/mm/fault: simplify code for do_page_fault() In-Reply-To: CC: akpm@linux-foundation.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tongtiangen@huawei.com From: Palmer Dabbelt To: willy@infradead.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 233BB4000C X-Rspam-User: X-Stat-Signature: h9d5m4zd6qj9pfaxkitwdscjnz9f7ps9 X-HE-Tag: 1678856947-690079 X-HE-Meta: U2FsdGVkX186oOnCqz3C64DRUe8ELPw4GmDYWsZ/vBKVkOCjUmt2eo7B5VWlxv3cT56QZMBAe9yhDhkUYk4wUiWISTb+2u7KTp271qVfQjSn5jVFXACjNbpwzzbsCpvqHFdxzvKiOsb3qRr0l4ub1F+wc55lopnJZ0dLi3imRkqwVT0GKT+S/8wbrNY1g2TFaqo8ijTEsrW0k2hUuwyys3VN1oqXrWvvM/qPaqmsP2BJisGmZT26hTnVDl0abCngAYkopEyaDMpxYiyN4dOByZVDzdV2Gi6jAuGl25jo5AKyD6fMc5LLkwzW2NF572fdlM52Vkeu1F1AI2HTKYUQj+f9wF+7ezU1MigiRRCcy26zTmAg7HWuOoNiBIaa8kN2dxuQURd2JhBmI1w9ygWwB7TDS2P5XKOl0k3WcrqhdDfuuid6QFBCYsOcS5+4zqOAsM1znV4OhEI9GSpsD45on9oe8DcSQ8ifoP3S6sYUn6IlkfML4mwGqYCMfRtSCgip58hbSHJlOdKyAYGz346wJpLKkEFLkrNHDZjRyKjWHsL2jYRkt0gEiMtg4HF5qBiODMK/g6MMcSTZBx/5tEprNBW6xhJLzIPnLyeD/ucCyOZOO/SrcIkDZ7z9Nx7T9HhEd6GO026zMRZXlbi6Y5xrDIb3NrYdRnhu/JVkzG3JEbJ4A4IF8ObQau2CmYeb3t8a6X2qjfedvsEEihUmFwy+18v+okzquRP87e6eayvQ384SyjQcRw1wY/8XqlVUlT33hvM13UICwIyaBG2DPQecOjDkr56ExoJnu1GMsf44TQ2QthlDLTK9k5EQKHx6H+4FMPeZkNo5YeKu3IKkiK6T6HL8mitEForlHBfP8JPu/vQ3pDOAJon6oF+Dqb0LUWykwaG31h1QHtLoDgaqSjRxhpEp/gwavrwZv6qd/8K7Y/CimG0wXq2nbXw4xDeGP0yy8GvVOcPlLV/9TXNOHCG euUqY4bb BLb9cj9s2C6+4JFYd4lDa2Vp0OjUjavxYw3kW8HmFrzo8gZqj3G8+AkWXmvAVwwqKQ1yLEBBUQHLQTe9ZvSCmBBRw3ilQ5yQB1eQaiOQWoQhs9S4Q1HQlK5Sopbw8OtFe1ak9vK6ut26/OgAkQIXHD4NsKNrvErFfp8fgDndhPp+e+FDVZeAjorn3Rr3j0PBlAKgbVIqNypVxlLppF6Ct3lK3TGM2fv5st0YVW3+sy0Lj0anItlwIa9sbAGwn/Kza7cM55dcJT69FRnGgh2lemtLP4dgjSF66BEFr324y4iyz6I89dCaaRAGvMoyVyzwbELCeiLtRKZy0KK6tUowS44Sv1DTsY/juZkM15CjrvSgxWgk0XRqIfFQsk9K71Kg3QNCNlLHWWGeZMBaUtRHuhcBKXRPra9k1AOwzmisR/mVBrMpzDf/+RFOmgO2k9Sqi+jcUKEhBvm/VHOh7kKlq6b028DJRMqlFFboc8vNoxaiOCWHv5lL1aCoGxhqkGVNLplsCTqKLQyDhYebRhcPT25pQ23j4UpCMkqgi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Mar 2023 22:02:37 PDT (-0700), willy@infradead.org wrote: > On Tue, Mar 14, 2023 at 08:03:54PM -0700, Palmer Dabbelt wrote: >> To make the code more hierarchical and readable, we fold vma related >> judgments into __do_page_fault(). And to simplify the code, move the >> tsk->thread.bad_cause's setting into bad_area(). No functional change >> intended. > > I think this is exaactly the wrong thing to be doing. Please _stop_ > using custom internal VM_FAULT flags, not adding new uses! I'm fine with that. The rest of the patch set was to chunk out a few to avoid them stepping on generic stuff, but we don't really need that in RISC-V land (aside from this, which is sort of a mixed bag WRT whether this is simpler or not). That's sort of why I held off on merging this in the first place. That said, the follow-on patches do clean up some mixing between generic and arch codes for other ports. I'm not sure if those can manifest as a real bug or not.