From: Palmer Dabbelt <palmer@rivosinc.com>
To: willy@infradead.org
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tongtiangen@huawei.com
Subject: Re: [PATCH v2 1/6] riscv/mm/fault: simplify code for do_page_fault()
Date: Tue, 14 Mar 2023 22:09:06 -0700 (PDT) [thread overview]
Message-ID: <mhng-dc587968-81c2-4f28-8d27-f739230b25cb@palmer-ri-x1c9a> (raw)
In-Reply-To: <ZBFRbVJDK8p5nelT@casper.infradead.org>
On Tue, 14 Mar 2023 22:02:37 PDT (-0700), willy@infradead.org wrote:
> On Tue, Mar 14, 2023 at 08:03:54PM -0700, Palmer Dabbelt wrote:
>> To make the code more hierarchical and readable, we fold vma related
>> judgments into __do_page_fault(). And to simplify the code, move the
>> tsk->thread.bad_cause's setting into bad_area(). No functional change
>> intended.
>
> I think this is exaactly the wrong thing to be doing. Please _stop_
> using custom internal VM_FAULT flags, not adding new uses!
I'm fine with that. The rest of the patch set was to chunk out a few to
avoid them stepping on generic stuff, but we don't really need that in
RISC-V land (aside from this, which is sort of a mixed bag WRT whether
this is simpler or not). That's sort of why I held off on merging this
in the first place.
That said, the follow-on patches do clean up some mixing between generic
and arch codes for other ports. I'm not sure if those can manifest as a
real bug or not.
next prev parent reply other threads:[~2023-03-15 5:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 3:03 [PATCH v2 0/6] mm: Stop alaising VM_FAULT_HINDEX_MASK in arch code Palmer Dabbelt
2023-03-15 3:03 ` [PATCH v2 1/6] riscv/mm/fault: simplify code for do_page_fault() Palmer Dabbelt
2023-03-15 5:02 ` Matthew Wilcox
2023-03-15 5:09 ` Palmer Dabbelt [this message]
2023-03-15 3:03 ` [PATCH v2 2/6] mm: Add a leading 0 to the VM_FAULT_* types Palmer Dabbelt
2023-03-15 3:03 ` [PATCH v2 3/6] mm: Add VM_FAULT_ARCH_* codes Palmer Dabbelt
2023-03-16 9:32 ` kernel test robot
2023-03-15 3:03 ` [PATCH v2 4/6] RISC-V: fault: Convert to " Palmer Dabbelt
2023-03-15 3:03 ` [PATCH v2 5/6] arm: " Palmer Dabbelt
2023-03-15 3:03 ` [PATCH v2 6/6] s390: " Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-dc587968-81c2-4f28-8d27-f739230b25cb@palmer-ri-x1c9a \
--to=palmer@rivosinc.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=tongtiangen@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox